Ack series
On Thu, 2016-06-30 at 11:17 +0200, Pavel Grunt wrote:
> setup_dummy_signal_handler was used before declared
> ---
> server/dispatcher.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/server/dispatcher.c b/server/dispatcher.c
> index 8c55881..44624cc 100644
> --- a/server/d
On Thu, Jun 30, 2016 at 04:54:53PM +0200, Hans de Goede wrote:
> Hi,
>
> The entire series looks good to me now, one remark wrt this patch,
> with that fixed this series is:
>
> Reviewed-by: Hans de Goede
>
>
> On 30-06-16 15:40, Christophe Fergeau wrote:
> > This is a follow-up of the previou
Hi,
The entire series looks good to me now, one remark wrt this patch,
with that fixed this series is:
Reviewed-by: Hans de Goede
On 30-06-16 15:40, Christophe Fergeau wrote:
This is a follow-up of the previous commit ('usb-channel: Really stop
listening for USB events on disconnection').
S
Hi
- Original Message -
> > Do you know which one? At the beginning I was worried this was true
> > even for QXL but is not. Looks like it only happens for Virgl.
> >
>
> See some commits here: https://github.com/elmarco/qemu/commits/virgl
>
> In particular
> https://github.com/elmarco
Hi
- Original Message -
>
> > Hi
> >
> > - Original Message -
> > >
> > > > Hi,
> > > >
> > > > > Yes you want to use EGL here, I think we could probably put more code
> > > > > in
> > > > > qemu
> > > > > to help with this case.
> > > >
> > > > Sure, if anything is needed we'
> Hi
>
> - Original Message -
> >
> > > Hi,
> > >
> > > > Yes you want to use EGL here, I think we could probably put more code
> > > > in
> > > > qemu
> > > > to help with this case.
> > >
> > > Sure, if anything is needed we'll get that sorted ;)
> > >
> > > I suspect spice-server n
On Thu, Jun 30, 2016 at 01:49:57PM +0200, Hans de Goede wrote:
> Hi,
> Thinking about this more, the easiest fix is probably for
> channel-usbredir.c to take a ref on the usb_device_manager when it calls
> spice_usb_device_manager_start_event_listening(), and use that ref when
> it wants to call sp
On Thu, Jun 30, 2016 at 01:08:10PM +0200, Hans de Goede wrote:
> 2) spice_usbredir_channel_disconnect_device now running in a thread, rather
> then being a synchronous part of the tear-down sequence, this can either be
> due to someone calling spice_usbredir_channel_disconnect_device_async() or
> s
It's still true after the switch to GTask.
---
src/channel-usbredir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index b22cec5..df18be2 100644
--- a/src/channel-usbredir.c
+++ b/src/channel-usbredir.c
@@ -205,7 +205,7 @@ stat
This is a follow-up of the previous commit ('usb-channel: Really stop
listening for USB events on disconnection').
Since the USB event thread has to be stopped when we destroy the
associated SpiceUsbDeviceManager, spice_usb_device_manager_dispose()
should force event_thread_run to FALSE even if
sp
When using USB redirection, it's fairly easy to leak the thread handling
USB events, which will eventually cause problems in long lived apps.
In particular, in virt-manager, one can:
- start a VM
- connect to it with SPICE
- open the USB redirection window
- redirect a device
- close the SPICE wind
This variable is accessed from 2 different threads (main thread and USB
event thread), so some care must be taken to read/write it.
---
Unchanged since v2, I can drop it if you strongly feel it's unneeded.
src/usb-device-manager.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Hello Dear Developer Team;
we have a big issue related to using spice protocol on Centos. we are trying to
find out an alternative way to windows RDP protocol.
however, we saw that spice protocol is consunimg 2 times much bandwith than
windows RDP.
will you please tell us how we can configure sp
Hi
- Original Message -
>
> > Hi,
> >
> > > Yes you want to use EGL here, I think we could probably put more code in
> > > qemu
> > > to help with this case.
> >
> > Sure, if anything is needed we'll get that sorted ;)
> >
> > I suspect spice-server needs access to the gl context helpe
> Hi,
>
> > Yes you want to use EGL here, I think we could probably put more code in
> > qemu
> > to help with this case.
>
> Sure, if anything is needed we'll get that sorted ;)
>
> I suspect spice-server needs access to the gl context helpers
> (dpy_gl_ctx_*) if it wants use opengl.
>
I wou
Hi,
On 30-06-16 13:08, Hans de Goede wrote:
Hi,
On 30-06-16 09:08, Christophe Fergeau wrote:
On Wed, Jun 29, 2016 at 07:29:18PM +0200, Hans de Goede wrote:
Erm no, it is the caller's responsibility to make sure that all
spice_usbredir_channel's are properly torn down before the
usbdevicemanag
Hi,
On 30-06-16 09:08, Christophe Fergeau wrote:
On Wed, Jun 29, 2016 at 07:29:18PM +0200, Hans de Goede wrote:
Erm no, it is the caller's responsibility to make sure that all
spice_usbredir_channel's are properly torn down before the
usbdevicemanager gets torn down.
Otherwise you're not just
Hi,
On 30-06-16 09:13, Christophe Fergeau wrote:
On Wed, Jun 29, 2016 at 07:20:16PM +0200, Hans de Goede wrote:
Hi,
On 29-06-16 17:42, Christophe Fergeau wrote:
This variable is accessed from 2 different threads (main thread and USB
event thread), so some care must be taken to read/write it.
---
server/glz-encode.tmpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/glz-encode.tmpl.c b/server/glz-encode.tmpl.c
index d699499..4874a94 100644
--- a/server/glz-encode.tmpl.c
+++ b/server/glz-encode.tmpl.c
@@ -365,7 +365,7 @@ static void FNAME(compress_seg)(Encod
setup_dummy_signal_handler was used before declared
---
server/dispatcher.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index 8c55881..44624cc 100644
--- a/server/dispatcher.c
+++ b/server/dispatcher.c
@@ -36,6 +36,8 @@
#ifdef DEBUG_DISPATCHER
Let user to define STREAM_STATS to enable them
---
server/stream.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/stream.h b/server/stream.h
index 9dcb8f7..b4fe540 100644
--- a/server/stream.h
+++ b/server/stream.h
@@ -52,7 +52,6 @@ typedef struct RedStreamActivateReportItem {
uint
On Tue, Jun 28, 2016 at 03:45:57PM +0200, Sergio L. Pascual wrote:
> On Mon, 2016-06-27 at 17:18 +0200, Christophe Fergeau wrote:
> > On Mon, Jun 27, 2016 at 09:30:39AM +0200, Sergio L. Pascual wrote:
> > > As for the repo, if you're interested in taking a look, we can
> > > upload
> > > our 0.28 f
On Wed, 2016-06-29 at 11:42 -0400, Frediano Ziglio wrote:
> >
> >
> > Hi Frediano,
> >
> > On Wed, 2016-06-22 at 16:19 +0100, Frediano Ziglio wrote:
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > server/image-encoders.c | 29 -
> > > 1 file changed, 28
On Wed, Jun 29, 2016 at 11:58:21AM -0400, Marc-André Lureau wrote:
> ack
I've pushed this one, and sent v2 for the 2 remaining patches.
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
On Wed, Jun 29, 2016 at 12:07:48PM -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > This variable is accessed from 2 different threads (main thread and USB
> > event thread), so some care must be taken to read/write it.
> > ---
>
> event_thread_run is a bool, you should m
This variable is accessed from 2 different threads (main thread and USB
event thread), so some care must be taken to read/write it.
---
Changes since v1:
- make event_thread_run a gint
- remove one direct use of event_thread_run I missed
src/usb-device-manager.c | 10 +-
1 file change
When using USB redirection, it's fairly easy to leak the thread handling
USB events, which will eventually cause problems in long lived apps.
In particular, in virt-manager, one can:
- start a VM
- connect to it with SPICE
- open the USB redirection window
- redirect a device
- close the SPICE wind
On Wed, Jun 29, 2016 at 07:20:16PM +0200, Hans de Goede wrote:
> Hi,
>
> On 29-06-16 17:42, Christophe Fergeau wrote:
> > This variable is accessed from 2 different threads (main thread and USB
> > event thread), so some care must be taken to read/write it.
>
> The event-thread only reads it, so
On Wed, Jun 29, 2016 at 07:29:18PM +0200, Hans de Goede wrote:
> Erm no, it is the caller's responsibility to make sure that all
> spice_usbredir_channel's are properly torn down before the
> usbdevicemanager gets torn down.
>
> Otherwise you're not just having the problem of the thread continuing
29 matches
Mail list logo
