Re: [Spice-devel] [PATCH v2] Remove core_public and core_interface_adapter globals usage

2016-06-28 Thread Jonathon Jongsma
On Fri, 2016-06-24 at 09:14 +0100, Frediano Ziglio wrote: > Avoid not constant globals. > > Signed-off-by: Frediano Ziglio > --- >  server/event-loop.c | 23 ++- >  server/red-channel.c| 59 +++ >  server/red-common.h | 17

Re: [Spice-devel] [PATCH v2] Constify spice_server_char_device_recognized_subtypes

2016-06-28 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Fri, 2016-06-24 at 07:41 +0100, Frediano Ziglio wrote: > Users should not change the list of supported subtypes. > > Signed-off-by: Frediano Ziglio > --- >  configure.ac| 1 + >  server/reds.c   | 4 ++-- >  server/spice-char.h | 1 + >  3 files changed,

Re: [Spice-devel] [PATCH v2] Constify event_loop_core

2016-06-28 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Fri, 2016-06-24 at 08:54 +0100, Frediano Ziglio wrote: > Was used as write variable only for testing. > Avoid usage of not constant globals. > Making globals constants avoid future race condition > usages. > > Signed-off-by: Frediano Ziglio > --- >  server/event-l

Re: [Spice-devel] [spice-gtk v4 24/24] tests: file-transfer agent cancel

2016-06-28 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > Agent only can only send error or cancel from a transfer operation > after it was initialized. From SpiceFileTransferTask point of view, > error and cancellation is an GError with different code so testing > only

Re: [Spice-devel] [spice-gtk v4 23/24] tests: file-transfer cancel on read async

2016-06-28 Thread Jonathon Jongsma
On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > --- >  tests/file-transfer.c | 64 > +++ >  1 file changed, 64 insertions(+) > > diff --git a/tests/file-transfer.c b/tests/file-transfer.c > index 61d0dcc..018d6ad 100644 > --- a/tests/file-tran

Re: [Spice-devel] [spice-gtk v4 22/24] tests: file-transfer cancel on task init

2016-06-28 Thread Jonathon Jongsma
On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > --- >  tests/file-transfer.c | 43 +++ >  1 file changed, 43 insertions(+) > > diff --git a/tests/file-transfer.c b/tests/file-transfer.c > index 6ef178b..61d0dcc 100644 > --- a/tests/file-transfer.c > +

Re: [Spice-devel] [spice-gtk v4 21/24] tests: file-transfer include simple tests

2016-06-28 Thread Jonathon Jongsma
On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > This only includes a simple test for file-transfer with a small > summary of the possible situations of the test. > > As the test is specifically for SpiceFileTransferTask, we don't create > a SpiceMainChannel. That could cause a simple crash

[Spice-devel] [PATCH RFC EXP] remote Virgl support

2016-06-28 Thread Frediano Ziglio
This patch is really hacky and mainly intended to try to use the current spice-protocol to make Virgl remote. It does in a fast (as code lines) way: - extract the images from scanouts; - fed these images to normal flow (using display_channel_process_draw) so making possible to check streaming flo

[Spice-devel] [spice v3 resend] Add support for clients connecting with the WebSocket protocol.

2016-06-28 Thread Jeremy White
We do this by auto detecting the inbound http(s) 'GET' and probing for a well formulated WebSocket binary connection, such as used by the spice-html5 client. If detected, we implement a set of cover functions that abstract the read/write/writev functions, in a fashion similar to the SASL implement

Re: [Spice-devel] [spice-gtk v4 12/24] file-xfer: a FileTransferOperation per transfer call

2016-06-28 Thread Victor Toso
Hi, On Fri, Jun 24, 2016 at 04:45:51PM -0500, Jonathon Jongsma wrote: > On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > > Each call to spice_main_file_copy_async will now create a > > FileTransferOperation which groups all SpiceFileTransferTasks of the > > copy operation in a GHashTable. >

Re: [Spice-devel] Cross-platform mobile (iOS and Android) client

2016-06-28 Thread Sergio L. Pascual
On Mon, 2016-06-27 at 17:18 +0200, Christophe Fergeau wrote: > On Mon, Jun 27, 2016 at 09:30:39AM +0200, Sergio L. Pascual wrote: > > As for the repo, if you're interested in taking a look, we can > > upload > > our 0.28 fork somewhere. > Yes, a git repository, even if it's based on 0.28, would be

Re: [Spice-devel] [spice-gtk v4 10/24] file-xfer: improve helper function to queue agent message

2016-06-28 Thread Victor Toso
Hi, On Fri, Jun 24, 2016 at 03:04:03PM -0500, Jonathon Jongsma wrote: > On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > > file_xfer_queue() function belongs to channel-main so it should not > > access SpiceFileTransferTask private struct (self->buffer). > > > > This patch changes: > > * r

Re: [Spice-devel] [spice-gtk v4 09/24] main: do not check for xfer-task errors

2016-06-28 Thread Victor Toso
Hi, On Fri, Jun 24, 2016 at 02:30:09PM -0500, Jonathon Jongsma wrote: > On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > > file_xfer_flush_finish and file_xfer_data_flushed_cb are channel-main > > function and should not check for SpiceFileTransferTask internal > > errors. > > OK, but I'd l

Re: [Spice-devel] [spice-gtk v4 20/24] file-xfer: move to spice-file-transfer-task.c

2016-06-28 Thread Victor Toso
Hi, On Mon, Jun 27, 2016 at 03:57:10PM -0500, Jonathon Jongsma wrote: > On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > > This patch moves: > > * GObject boilerplate > > * External API related to SpiceFileTransferTask > > * Internal API needed by channel-main > > * Helpers that belong to t

Re: [Spice-devel] [spice-gtk v4 18/24] file-xfer: use helper function for debug xfer-task

2016-06-28 Thread Victor Toso
Hi, On Mon, Jun 27, 2016 at 03:53:03PM -0500, Jonathon Jongsma wrote: > On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > > --- > >  src/channel-main.c | 29 + > >  1 file changed, 17 insertions(+), 12 deletions(-) > > > > diff --git a/src/channel-main.c b/src/cha

Re: [Spice-devel] [spice-gtk v4 15/24] file-xfer: call user callback once per operation

2016-06-28 Thread Victor Toso
Hi, On Mon, Jun 27, 2016 at 11:50:01AM -0500, Jonathon Jongsma wrote: > On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > > SpiceFileTransferTask has a callback to be called when operation > > ended. Til this patch, we were setting the user callback which means > > that in multiple file-tran

Re: [Spice-devel] [spice-gtk v4 14/24] file-xfer: call progress_callback per FileTransferOperation

2016-06-28 Thread Victor Toso
Hi, On Mon, Jun 27, 2016 at 11:27:38AM -0500, Jonathon Jongsma wrote: > On Thu, 2016-06-23 at 19:37 +0200, Victor Toso wrote: > > Before this patch, the progress_callback is being called from > > SpiceFileTransferTask each time that some data is flushed to the agent > > of this given xfer-task. Th

Re: [Spice-devel] Help :Build error of "You must run autogen.sh or configure --enable vala"

2016-06-28 Thread 小泉
Thanks a lot for your reply. I will try "dnf builddep mingw-spice-gtk" Koizumi On 2016/06/28 16:31, Christophe Fergeau wrote: Hey, On Tue, Jun 28, 2016 at 11:04:03AM +0900, 小泉 wrote: Hi Thanks a lot for your reply.

Re: [Spice-devel] Help :Build error of "You must run autogen.sh or configure --enable vala"

2016-06-28 Thread Christophe Fergeau
Hey, On Tue, Jun 28, 2016 at 11:04:03AM +0900, 小泉 wrote: >Hi >Thanks a lot for your reply. >I tried "NOCONFIGURE=1 ./autogen.sh && mingw32-configure >--enable-vala". >But I see "configure: error: Cannot find the "vapigen" binary in your >PATH" error although vapigen is in m