Re: [Spice-devel] Help :Build error of "configure: error: Package requirements (libxml-2.0 >= 2.6.0) were not met:"

2016-06-22 Thread Fabiano Fidêncio
On Thu, Jun 23, 2016 at 7:14 AM, 小泉 wrote: > Hi all > > I build virt-viewer for Windows on my fedora based on following instruction. > > Building Instructions/Client > http://www.spice-space.org/page/Building_Instructions/Client > > I see "configure: error: Package requirements (libxml-2.

[Spice-devel] Help :Build error of "configure: error: Package requirements (libxml-2.0 >= 2.6.0) were not met:"

2016-06-22 Thread 小泉
Hi all I build virt-viewer for Windows on my fedora based on following instruction. Building Instructions/Client http://www.spice-space.org/page/Building_Instructions/Client I see "configure: error: Package requirements (libxml-2.0 >= 2.6.0) were not met:" error message when I run "mingw3

Re: [Spice-devel] gitlab

2016-06-22 Thread Marc-André Lureau
Hi On Wed, Jun 22, 2016 at 5:31 PM, Christophe Fergeau wrote: > On Wed, Jun 22, 2016 at 11:05:11AM -0400, Marc-André Lureau wrote: >> Hi >> >> - Original Message - >> > Hi all, >> > >> > I created a spice group in gitlab [0] mirroring the repository from >> > freedesktop which should be u

Re: [Spice-devel] [NSIS 1/5] packaging: bump version to 4.1

2016-06-22 Thread Christophe Fergeau
On Tue, Jun 21, 2016 at 10:44:10PM +0300, Yedidyah Bar David wrote: > On Tue, Jun 21, 2016 at 10:24 PM, Yedidyah Bar David wrote: > > On Tue, Jun 21, 2016 at 6:05 PM, Christophe Fergeau > > wrote: > >> Were there any changes? > > > > No. > > > >> If yes, a "Changes since v2" would be useful, if

Re: [Spice-devel] gitlab

2016-06-22 Thread Victor Toso
Hi, On Wed, Jun 22, 2016 at 11:05:11AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi all, > > > > I created a spice group in gitlab [0] mirroring the repository from > > freedesktop which should be updated every hour. > > > > [0] https://gitlab.com/groups/spice > > >

Re: [Spice-devel] [PATCH 8/8] Protect globals servers variable with a mutex

2016-06-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Mon, 2016-06-20 at 10:15 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/reds.c | 7 +++ >  1 file changed, 7 insertions(+) > > diff --git a/server/reds.c b/server/reds.c > index c139d8d..f571379 100644 > --- a/server/reds.c > +++

Re: [Spice-devel] gitlab

2016-06-22 Thread Christophe Fergeau
On Wed, Jun 22, 2016 at 11:05:11AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi all, > > > > I created a spice group in gitlab [0] mirroring the repository from > > freedesktop which should be updated every hour. > > > > [0] https://gitlab.com/groups/spice > > >

Re: [Spice-devel] [PATCH 5/8] Remove code_public and core_interface_adapter globals usage

2016-06-22 Thread Jonathon Jongsma
subject: code_public -> core_public On Mon, 2016-06-20 at 10:15 +0100, Frediano Ziglio wrote: > Avoid not constant globals. > > Signed-off-by: Frediano Ziglio > --- >  server/event-loop.c | 23 +--- >  server/red-channel.c| 59 --

Re: [Spice-devel] [PATCH 3/8] Constify spice_server_char_device_recognized_subtypes

2016-06-22 Thread Jonathon Jongsma
On Wed, 2016-06-22 at 02:57 -0400, Frediano Ziglio wrote: > > > > > > There aren't many users of spice-server, and the required fix is pretty > > small > > here, but I don't think we should break API for this unless there's a really > > good reason coming in the following patches... > > > > Revi

[Spice-devel] [PATCH v2 1/2] Refactory Glz RedDrawable retention code

2016-06-22 Thread Frediano Ziglio
The code was quite complicated. - a GlzEncDictImageContext was bound to a GlzDrawableInstanceItem (1-1 relation); - multiple GlzDrawableInstanceItem were attached to RedGlzDrawable; - multiple RedGlzDrawable (one for RedClient) were attached to Drawable using GlzImageRetention; - OOM code requi

[Spice-devel] [PATCH v2 2/2] Add some debugging for GlzDictItem structure

2016-06-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/image-encoders.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/server/image-encoders.c b/server/image-encoders.c index 0ade8c8..c2d7648 100644 --- a/server/image-encoders.c +++ b/server/image-encoders.c

[Spice-devel] [PATCH v2 0/2] Rewrite Glz image retention code

2016-06-22 Thread Frediano Ziglio
Cahnges from v1 (inside "Some image encoding updates" series): - more comments, updated outdated ones; - renamed GlzContext to GlzDictItem (and descending fields and variables); - invert red_drawable_unref return value; - renamed glz_retention_free to glz_retention_destroy. Frediano Ziglio (2):

Re: [Spice-devel] gitlab

2016-06-22 Thread Christophe Fergeau
Hey, On Wed, Jun 22, 2016 at 04:48:39PM +0200, Victor Toso wrote: > Hi all, > > I created a spice group in gitlab [0] mirroring the repository from > freedesktop which should be updated every hour. > > [0] https://gitlab.com/groups/spice > > But I would like to discuss the transition to use git

Re: [Spice-devel] gitlab

2016-06-22 Thread Marc-André Lureau
Hi - Original Message - > Hi all, > > I created a spice group in gitlab [0] mirroring the repository from > freedesktop which should be updated every hour. > > [0] https://gitlab.com/groups/spice > > But I would like to discuss the transition to use gitlab for source code > at some time

Re: [Spice-devel] [NSIS] Correct path to QEMU GA MSI files

2016-06-22 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Wed, Jun 22, 2016 at 02:53:44PM +0200, Vinzenz 'evilissimo' Feenstra wrote: > From: Vinzenz Feenstra > > Previously the path to the qemu-ga-x{86,64}.msi files was incorrect. > The files are installed into the drivers sub-directory. > > Change-Id: I697dccf37fb86

Re: [Spice-devel] [NSIS v2 1/4] OVirtGuestService.exe is a File not a Directory to remove

2016-06-22 Thread Christophe Fergeau
For the series: Acked-by: Christophe Fergeau On Wed, Jun 22, 2016 at 12:12:40PM +0200, Vinzenz 'evilissimo' Feenstra wrote: > From: Vinzenz Feenstra > > Change-Id: Ie71a0164c33d41aa1945f6dfe6feb6e54d1806e1 > Signed-off-by: Vinzenz Feenstra > --- > win-guest-tools.nsis | 2 +- > 1 file changed

[Spice-devel] gitlab

2016-06-22 Thread Victor Toso
Hi all, I created a spice group in gitlab [0] mirroring the repository from freedesktop which should be updated every hour. [0] https://gitlab.com/groups/spice But I would like to discuss the transition to use gitlab for source code at some time soon. One of the main reasons is the management fo

Re: [Spice-devel] [PATCH 4/5] Refactory Glz RedDrawable retention code

2016-06-22 Thread Frediano Ziglio
> > On Fri, 2016-06-17 at 14:58 +0100, Frediano Ziglio wrote: > > The code was quite complicated. > > - a GlzEncDictImageContext was bound to a GlzDrawableInstanceItem > > (1-1 relation); > > - multiple GlzDrawableInstanceItem were attached to RedGlzDrawable; > > - multiple RedGlzDrawable (one f

Re: [Spice-devel] missing dll

2016-06-22 Thread Victor Toso
Hi, On Wed, Jun 22, 2016 at 02:37:27PM +0200, Iker Ibarguren Berasaluze wrote: > Hi, > > I tried to install virt-viewer on my windows xp machine but when I > launch it says that dwmapi.dll is missing From where have you downloaded it? > > -- > Iker Ibarguren Berasaluze > Informatikako Errefort

[Spice-devel] missing dll

2016-06-22 Thread Iker Ibarguren Berasaluze
Hi, I tried to install virt-viewer on my windows xp machine but when I launch it says that dwmapi.dll is missing -- Iker Ibarguren Berasaluze Informatikako Errefortzua PASAIAKO UDALA Donibane kalea 19, 20110 PASAIA 943 345366 Ezinbestekoa ez bada, ez inprimatu mezu hau, ingurumena gure

[Spice-devel] [NSIS] Correct path to QEMU GA MSI files

2016-06-22 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Previously the path to the qemu-ga-x{86,64}.msi files was incorrect. The files are installed into the drivers sub-directory. Change-Id: I697dccf37fb868c335b0113c6c09f628d2fcbe27 Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 8 1 file changed, 4 inse

[Spice-devel] [PATCH 2/3] qxl: store memory region and offset instead of pointer for guest slots

2016-06-22 Thread Gerd Hoffmann
Store MemoryRegion and offset instead of a pointer for each qxl memory slot, so we can easily figure in which memory region an qxl object stored. Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 15 +++ hw/display/qxl.h | 3 ++- 2 files changed, 13 insertions(+), 5 deletions(-)

[Spice-devel] [PATCH 3/3] qxl: fix surface migration

2016-06-22 Thread Gerd Hoffmann
Create a helper function qxl_dirty_one_surface() to mark a single qxl surface as dirty. Use the new qxl_get_check_slot_offset function and lookup the memory region from the slot instead of assuming the surface is stored in vram. Use the new helper function in qxl_dirty_surfaces, for both primary

[Spice-devel] [PATCH 1/3] qxl: factor out qxl_get_check_slot_offset

2016-06-22 Thread Gerd Hoffmann
New helper function which translates a qxl physical address into memory slot and offset. Also applies sanity checks. Factored out from qxl_phys2virt. No functional change. Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 59 1 file c

[Spice-devel] Windows guest and virtio serial port

2016-06-22 Thread Tadas
I'm not sure, if it's correct mailing list to post this problem to. For that I apologize. I'm having problems with Windows guest and virtio serial port. According to this manual: http://www.spice-space.org/page/Whiteboard/AgentProtocol I should get a named pipe on my guest VM after I create VirtI

[Spice-devel] [NSIS v2 3/4] ovirt: Add service removal

2016-06-22 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Previously the service registration has not been removed during the uninstallation. This patch adds the removal code. Change-Id: I9e2f89b01468ea51fe64afb68a75c50eb21888c1 Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 23 +++ 1 file change

[Spice-devel] [NSIS v2 1/4] OVirtGuestService.exe is a File not a Directory to remove

2016-06-22 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Change-Id: Ie71a0164c33d41aa1945f6dfe6feb6e54d1806e1 Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index e4cd33d..17f1103 100644 --- a/win-guest-tool

[Spice-devel] [NSIS v2 2/4] ovirt: Remove all files install by the ovirt-guest-agent

2016-06-22 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Previously we left behind: - default.ini - default-logger.ini - ovirt-guest-agent.ini - vcredist_x86.exe Change-Id: If625ea358d0808bbee70bff9124d4f4e083157dc Signed-off-by: Vinzenz Feenstra --- win-guest-tools.nsis | 5 + 1 file changed, 5 insertions(+) diff --git a

[Spice-devel] [NSIS v2 4/4] ovirt: Add missing removal of hooks base directory

2016-06-22 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra When the directories for the hooks have been introduced, the base folder has been left over during the uninstallation. This patch adds the removal of the hooks base directory. Change-Id: Ib48d2538c92e5e761ce4803c99a85ca0de2a47a4 Signed-off-by: Vinzenz Feenstra --- win-gu

Re: [Spice-devel] [NSIS 5/5] ovirt: Add ovirt-guest-agent service removal

2016-06-22 Thread Vinzenz Feenstra
> On Jun 22, 2016, at 10:54 AM, Christophe Fergeau wrote: > > On Tue, Jun 21, 2016 at 07:35:14PM +0200, Vinzenz Feenstra wrote: >> >>> On Jun 21, 2016, at 5:11 PM, Christophe Fergeau wrote: >>> >>> >>> On Tue, Jun 21, 2016 at 05:26:33PM +0300, Yedidyah Bar David wrote: From: Vinzenz Fee

Re: [Spice-devel] [NSIS 5/5] ovirt: Add ovirt-guest-agent service removal

2016-06-22 Thread Christophe Fergeau
On Tue, Jun 21, 2016 at 07:35:14PM +0200, Vinzenz Feenstra wrote: > > > On Jun 21, 2016, at 5:11 PM, Christophe Fergeau wrote: > > > > > > On Tue, Jun 21, 2016 at 05:26:33PM +0300, Yedidyah Bar David wrote: > >> From: Vinzenz Feenstra > >> > >> Previously the ovirt guest agent service registr

Re: [Spice-devel] [PATCH 7/8] Initialise OpenSSL just once

2016-06-22 Thread Pavel Grunt
On Wed, 2016-06-22 at 03:01 -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > On Mon, 2016-06-20 at 10:15 +0100, Frediano Ziglio wrote: > > > Avoid multiple initializations of this library. > > imo would be nice to mention that it is about threads > > > > > What about > > > Avoid multipl

[Spice-devel] [NSIS] ovirt: Add missing removal of hooks base directory

2016-06-22 Thread Yedidyah Bar David
From: Vinzenz Feenstra When the directories for the hooks have been introduced, the base folder has been left over during the uninstallation. This patch adds the removal of the hooks base directory. Change-Id: Ib48d2538c92e5e761ce4803c99a85ca0de2a47a4 Signed-off-by: Vinzenz Feenstra --- win-gu

Re: [Spice-devel] [PATCH 7/8] Initialise OpenSSL just once

2016-06-22 Thread Frediano Ziglio
> > Hi, > > On Mon, 2016-06-20 at 10:15 +0100, Frediano Ziglio wrote: > > Avoid multiple initializations of this library. > imo would be nice to mention that it is about threads > > What about Avoid multiple initializations of this library. Also initialize using thread safe code to avoid possi