Re: [Spice-devel] [PATCH] configure: Better wording hasn't -> has not

On 06/15/2016 06:08 PM, Jonathon Jongsma wrote: > On Wed, 2016-06-15 at 15:12 -0300, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> >> N.B.: The REAL reason for this one is because it was breaking vim syntax >> highlighting. > > hehe, sure. why not? > Pushed, t

Re: [Spice-devel] [PATCH] configure: Better wording hasn't -> has not

On Wed, 2016-06-15 at 15:12 -0300, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > > N.B.: The REAL reason for this one is because it was breaking vim syntax > highlighting. hehe, sure. why not? Acked-by: Jonathon Jongsma > > -- > >  configure.ac | 2 +- >  1 f

Re: [Spice-devel] [PATCH v5 9/9] Remove message_buf from EncoderData

On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > This buffer was just written and then used, no reason to store into > a more persistent structure. > > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 34 ++ >  server/dcc-encoders.h |  1 -

Re: [Spice-devel] [PATCH v5 3/9] Better encapsulation for image_encoders_compress_glz call

On Wed, 2016-06-15 at 16:23 +0200, Pavel Grunt wrote: > Hi, > > On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > > Do not access too much encoders data. > > Slightly different as now if glz is frozen lz compression is used. > > What about documenting the compression rules as a comment

Re: [Spice-devel] [PATCH v5 8/9] Reduce header dependency

Acked-by: Jonathon Jongsma On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > Avoid dependencies from RedChannel stuff. > > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.h | 6 -- >  1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/server/dcc-encoders

Re: [Spice-devel] [PATCH v5 7/9] Remove dependency from dcc-encoders to Drawable

On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > Encoding image requires a RedDrawable (where the data is stored) and > a Ring where to store information to free Glz structures. > > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 17 ++--- >  server/dcc-encod

[Spice-devel] [PATCH v2 2/2] Fix set but not used variable warning

Introduced by commit 903c91cd3013c763abd3f2292f8fbd911a0c83f0, this variable is used only for LZ4 code. Move the declaration to the proper block of code. Build log: spicevmc.c: In function 'handle_compressed_msg': spicevmc.c:346:14: error: variable 'decompressed' set but not used [-Werror=unused

Re: [Spice-devel] [PATCH 2/2] Fix set but not used variable warning

On 06/15/2016 02:45 PM, Eduardo Lima (Etrunko) wrote: > Introduced by commit 903c91cd3013c763abd3f2292f8fbd911a0c83f0, this > variable is used only for LZ4 code. Move the declaration to the proper > block of code. > > Build log: > > spicevmc.c: In function 'handle_compressed_msg': > spicevmc.c:34

[Spice-devel] [PATCH 2/2 spice-server] Move lz4-encoder.[ch] to conditional block in Makefile.am

Let's follow the 'standard' for optional components. This commit also drops (now) unecessary #ifdef USE_LZ4 from lz4-encode.c, as the decision to build this file is now made in Makefile. Signed-off-by: Eduardo Lima (Etrunko) --- server/Makefile.am | 9 +++-- server/lz4-encoder.c | 4

[Spice-devel] [PATCH spice-common] Make LZ4 dependency check more robust

Add a new 'have_lz4' variable to really tell if we have the dependency installed on the system. It will later be used in Makefile to decide whether or not the specific files related to LZ4 should be built. Signed-off-by: Eduardo Lima (Etrunko) --- m4/spice-deps.m4 | 12 1 file chang

[Spice-devel] [PATCH 1/2 spice-server] Use correct variable to print if LZ4 support is to be built.

Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 79a15dc..a3289ac 100644 --- a/configure.ac +++ b/configure.ac @@ -270,7 +270,7 @@ AC_MSG_NOTICE([ prefix: ${prefi

[Spice-devel] [PATCH spice-gtk] Use correct variable to print if LZ4 support is to be built.

Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6e65188..0ca333f 100644 --- a/configure.ac +++ b/configure.ac @@ -640,7 +640,7 @@ AC_MSG_NOTICE([ USB redirection support: ${have_

[Spice-devel] [PATCH] configure: Better wording hasn't -> has not

Signed-off-by: Eduardo Lima (Etrunko) --- N.B.: The REAL reason for this one is because it was breaking vim syntax highlighting. -- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ce3cc7b..79a15dc 100644 --- a/configure.ac +++

Re: [Spice-devel] [PATCH 1/2] Fix build for systems without LZ4 dependency installed

On 06/15/2016 02:45 PM, Eduardo Lima (Etrunko) wrote: > This was introduced by commit 903c91cd3013c763abd3f2292f8fbd911a0c83f0. > To fix it, we simply protect the try_compress_lz4 function with proper > The commit message should read "... with proper #ifdef guards." , but it was ignored because I

[Spice-devel] [PATCH 0/2] Build fixes for systems without LZ4

Simple series fixing the build after commit 903c91cd3013c763abd3f2292f8fbd911a0c83f0. This was detected by Smoketest. spicevmc.c: In function 'try_compress_lz4': spicevmc.c:143:5: error: implicit declaration of function 'LZ4_compress_default' [-Werror=implicit-function-declaration] compress

[Spice-devel] [PATCH 1/2] Fix build for systems without LZ4 dependency installed

This was introduced by commit 903c91cd3013c763abd3f2292f8fbd911a0c83f0. To fix it, we simply protect the try_compress_lz4 function with proper Build log: spicevmc.c: In function 'try_compress_lz4': spicevmc.c:143:5: error: implicit declaration of function 'LZ4_compress_default' [-Werror=implicit

[Spice-devel] [PATCH 2/2] Fix set but not used variable warning

Introduced by commit 903c91cd3013c763abd3f2292f8fbd911a0c83f0, this variable is used only for LZ4 code. Move the declaration to the proper block of code. Build log: spicevmc.c: In function 'handle_compressed_msg': spicevmc.c:346:14: error: variable 'decompressed' set but not used [-Werror=unused

Re: [Spice-devel] [Spice-commits] configure.ac server/spicevmc.c spice-common

This commit broke the build on systems where lz4-devel is not present. The LZ4 detection is broken in spice-deps.m4 and in some places in server code. Patches coming soon. On 06/13/2016 07:13 PM, Frediano Ziglio wrote: > configure.ac |2 > server/spicevmc.c | 140 > ++

Re: [Spice-devel] [PATCH v5 6/9] Make GlzSharedDictionary structure private in dcc-encoders.c

Acked-by: Jonathon Jongsma On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 10 ++ >  server/dcc-encoders.h | 11 +-- >  2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/server/dcc-encod

Re: [Spice-devel] [PATCH v5 5/9] Do not access ImageEncoders internal to lock/unlock glz encoding

On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c| 14 ++ >  server/dcc-encoders.h|  2 ++ >  server/display-channel.c | 18 +- >  3 files changed, 21 insertions(+), 13 deletions(-) > > diff -

Re: [Spice-devel] [PATCH v5 4/9] Use Ring instead of accessing Drawable internals

On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > Remove some coupling, we mainly need to store a list of RedGlzDrawables. > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c| 8 >  server/dcc-encoders.h| 4 ++-- >  server/display-channel.c | 4 ++-- >  3 files

Re: [Spice-devel] [PATCH] Make video-encoder.h self independent

On Wed, Jun 15, 2016 at 04:09:08PM +0100, Frediano Ziglio wrote: > gpointer definition was not included causing the header to fails to > compile if included first. > > Signed-off-by: Frediano Ziglio > --- > server/video-encoder.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

[Spice-devel] [PATCH] Make video-encoder.h self independent

gpointer definition was not included causing the header to fails to compile if included first. Signed-off-by: Frediano Ziglio --- server/video-encoder.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/video-encoder.h b/server/video-encoder.h index 5522818..1b1e16

Re: [Spice-devel] [PATCH v5 3/9] Better encapsulation for image_encoders_compress_glz call

Hi, On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > Do not access too much encoders data. > Slightly different as now if glz is frozen lz compression is used. What about documenting the compression rules as a comment for 'dcc_compress_image()' ? Pavel > > Signed-off-by: Frediano Zig

Re: [Spice-devel] [PATCH v5 1/9] Encapsulate some data in dcc-encoders

Acked-by: Jonathon Jongsma On Wed, 2016-06-15 at 10:37 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c| 59 ++- > - >  server/dcc-encoders.h| 33 ++- >  server/display-channel

Re: [Spice-devel] [PATCH spice 1/2] Remove unused reds_expects_link_id

> > Not needed since f683815ad53cc39f485ddac9770e23282ca5c340 > > Signed-off-by: Pavel Grunt > --- > server/reds.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 10b943a..28ab90a 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -1657,

[Spice-devel] [PATCH spice 1/2] Remove unused reds_expects_link_id

Not needed since f683815ad53cc39f485ddac9770e23282ca5c340 Signed-off-by: Pavel Grunt --- server/reds.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/server/reds.c b/server/reds.c index 10b943a..28ab90a 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1657,12 +1657,6 @@ static void r

[Spice-devel] [PATCH spice 2/2] Fix missing prototypes

Signed-off-by: Pavel Grunt Signed-off-by: Frediano Ziglio --- m4/spice-compile-warnings.m4 | 1 - server/red-channel.c | 4 ++-- server/red-worker.c | 2 +- server/stream.c | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/m4/spice-compile-war

Re: [Spice-devel] [PATCH] Remove goto within switch statement

On Wed, 2016-06-15 at 08:18 +0200, Pavel Grunt wrote: > Hi Jonathon, > > On Tue, 2016-06-14 at 16:04 -0500, Jonathon Jongsma wrote: > > > > Having a goto label in the middle of a switch/case statement is a bit > > confusing. But the same behavior can be achieved  > it changes the behavior - if LZ

[Spice-devel] [PATCH] Make some functions static

Signed-off-by: Frediano Ziglio --- server/red-worker.c | 2 +- server/stream.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/red-worker.c b/server/red-worker.c index b38d7c7..f8b1913 100644 --- a/server/red-worker.c +++ b/server/red-worker.c @@ -1059,7 +1059,

Re: [Spice-devel] [spice-gtk] widget: Disable IME context on display widget

> > Hi Frediano, > > On Wed, 2016-06-15 at 11:54 +0100, Frediano Ziglio wrote: > > This prevent Windows to handle IME on the widget which cause the > > application to not receive keyboard events. > > > > Signed-off-by: Frediano Ziglio > > --- > >  src/spice-widget.c | 9 + > >  1 file ch

Re: [Spice-devel] [spice-gtk] widget: Disable IME context on display widget

Hi Frediano, On Wed, 2016-06-15 at 11:54 +0100, Frediano Ziglio wrote: > This prevent Windows to handle IME on the widget which cause the > application to not receive keyboard events. > > Signed-off-by: Frediano Ziglio > --- >  src/spice-widget.c | 9 + >  1 file changed, 9 insertions(+)

[Spice-devel] [spice-gtk] widget: Disable IME context on display widget

This prevent Windows to handle IME on the widget which cause the application to not receive keyboard events. Signed-off-by: Frediano Ziglio --- src/spice-widget.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/spice-widget.c b/src/spice-widget.c index c528614..595c8f5 100644 --

Re: [Spice-devel] [spice-gtk] widget: Disable IME context on main widget

> > Hey, > > On Mon, Jun 13, 2016 at 06:07:53AM -0400, Frediano Ziglio wrote: > > > > > > On Fri, Jun 10, 2016 at 08:45:56AM -0400, Frediano Ziglio wrote: > > > > > > > > This seems quite strong! I think this will remove the IME context > > > > even from the Windows desktop :) > > > > > > Oh?

Re: [Spice-devel] [PATCH v4 07/19] Encapsulate some data in dcc-encoders

> > On Tue, 2016-06-14 at 10:32 +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > >  server/dcc-encoders.c| 60 > >  ++- > > - > >  server/dcc-encoders.h| 33 ++ > >  server/display-channel.c | 13 +

[Spice-devel] [PATCH v5 8/9] Reduce header dependency

Avoid dependencies from RedChannel stuff. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server/dcc-encoders.h b/server/dcc-encoders.h index 03230bb..efe861f 100644 --- a/server/dcc-encoders.h +++ b/server/dcc-en

[Spice-devel] [PATCH v5 7/9] Remove dependency from dcc-encoders to Drawable

Encoding image requires a RedDrawable (where the data is stored) and a Ring where to store information to free Glz structures. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 17 ++--- server/dcc-encoders.h | 3 ++- server/dcc.c | 4 +++- 3 files changed, 15 ins

[Spice-devel] [PATCH v5 4/9] Use Ring instead of accessing Drawable internals

Remove some coupling, we mainly need to store a list of RedGlzDrawables. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c| 8 server/dcc-encoders.h| 4 ++-- server/display-channel.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/server/dcc-encod

[Spice-devel] [PATCH v5 3/9] Better encapsulation for image_encoders_compress_glz call

Do not access too much encoders data. Slightly different as now if glz is frozen lz compression is used. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 15 +++ server/dcc.c | 17 - 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/s

[Spice-devel] [PATCH v5 9/9] Remove message_buf from EncoderData

This buffer was just written and then used, no reason to store into a more persistent structure. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 34 ++ server/dcc-encoders.h | 1 - 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/server

[Spice-devel] [PATCH v5 6/9] Make GlzSharedDictionary structure private in dcc-encoders.c

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 10 ++ server/dcc-encoders.h | 11 +-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index a5bc328..c690746 100644 --- a/server/dcc-encoders.c +++ b/server/d

[Spice-devel] [PATCH v5 5/9] Do not access ImageEncoders internal to lock/unlock glz encoding

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c| 14 ++ server/dcc-encoders.h| 2 ++ server/display-channel.c | 18 +- 3 files changed, 21 insertions(+), 13 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index 6fccb17..a5bc32

[Spice-devel] [PATCH v5 2/9] Make red_glz_drawable_free() static

Signed-off-by: Frediano Ziglio Acked-by: Jonathon Jongsma --- server/dcc-encoders.c | 2 +- server/dcc-encoders.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index 2fa5f1b..098a397 100644 --- a/server/dcc-encoders.c +++ b/ser

[Spice-devel] [PATCH v5 1/9] Encapsulate some data in dcc-encoders

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c| 59 ++-- server/dcc-encoders.h| 33 ++- server/display-channel.c | 13 +++ server/display-channel.h | 5 4 files changed, 62 insertions(+), 48 deleti

[Spice-devel] [PATCH v5 0/9] Better encapsulation of image encoding stuff

Hi, after the discussion and tests to reduce typedef mess I realized the code lack some proper encapsulation. In DisplayChannel there are multiple files to handle different stuff but all code needs to know all structures and basically include all stuff. Looking at code one stuff that could/should

Re: [Spice-devel] [PATCH 0/2] RFC: cleanup glz drawable stuff

> > These patches should apply on top of Frediano's "Better encapsulation of > image > encoding stuff" patch series. > > Jonathon Jongsma (2): > Rename image_encoders_free_glz_drawable_instance() > Rename image_encoders_free_glz_drawable() > > server/dcc-encoders.c | 32 +++-