Re: [Spice-devel] [spice v13 10/29] server: Handle and recover from GStreamer encoding errors

2016-06-06 Thread Francois Gouget
On Fri, 3 Jun 2016, Christophe Fergeau wrote: [...] > For what it's worth, I tried asking GStreamer people if they had > suggestions how we could handle what is being done in this patch, but > they did not have a silver bullet :) I'm not surprised. The GStreamer doc says you're not supposed to exp

[Spice-devel] [spice-gtk v2] sasl: fix SASL GSSAPI by allowing NULL username

2016-06-06 Thread Fabiano Fidêncio
From: Alexander Bokovoy SASL GSSAPI module will try to negotiate authentication based on the credentials in the default credentials cache. It does not matter if SPICE knows username or not as SASL negotiation will pass through the discovered name from the GSSAPI module. Signed-off-by: Alexander

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

2016-06-06 Thread Fabiano Fidêncio
On Mon, Jun 6, 2016 at 4:07 PM, Alexander Bokovoy wrote: > On Mon, 06 Jun 2016, Daniel P. Berrange wrote: >> >> On Mon, Jun 06, 2016 at 04:34:09PM +0300, Alexander Bokovoy wrote: >>> >>> On Mon, 06 Jun 2016, Daniel P. Berrange wrote: >>> > On Mon, Jun 06, 2016 at 09:01:10AM -0400, Marc-André Lurea

Re: [Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-06 Thread Frediano Ziglio
> > If Windows layout does not support a given key the resulting virtual code > is set to 0xFF. To avoid losing this raw key (causing the key not been > sent to remote machine) detect this condition and handle the key. > The check for raw scancode is there to understand if we can handle > correctl

[Spice-devel] [spice-gtk v2] widget: Do not ignore unsupported keys from keyboard

2016-06-06 Thread Frediano Ziglio
If Windows layout does not support a given key the resulting virtual code is set to 0xFF. To avoid losing this raw key (causing the key not been sent to remote machine) detect this condition and handle the key. The check for raw scancode is there to understand if we can handle correctly the key in

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

2016-06-06 Thread Daniel P. Berrange
On Mon, Jun 06, 2016 at 04:34:09PM +0300, Alexander Bokovoy wrote: > On Mon, 06 Jun 2016, Daniel P. Berrange wrote: > > On Mon, Jun 06, 2016 at 09:01:10AM -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > I'm sending Alexander Bokovoy's patch as it is, also

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

2016-06-06 Thread Daniel P. Berrange
On Mon, Jun 06, 2016 at 09:01:10AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > I'm sending Alexander Bokovoy's patch as it is, also here is some notes from > > him: > > > > "I'd really like to find a way to do it with pure SASL properties so that > > the > > code wo

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

2016-06-06 Thread Fabiano Fidêncio
On Mon, Jun 6, 2016 at 3:01 PM, Marc-André Lureau wrote: > Hi > > - Original Message - >> I'm sending Alexander Bokovoy's patch as it is, also here is some notes from >> him: >> >> "I'd really like to find a way to do it with pure SASL properties so that the >> code would work for both SPN

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

2016-06-06 Thread Marc-André Lureau
Hi - Original Message - > I'm sending Alexander Bokovoy's patch as it is, also here is some notes from > him: > > "I'd really like to find a way to do it with pure SASL properties so that the > code would work for both SPNEGO and Kerberos. SPNEGO NTLMSSP would make it > working for enviro

Re: [Spice-devel] [spice-gtk] Support SASL GSSAPI

2016-06-06 Thread Fabiano Fidêncio
On Mon, Jun 6, 2016 at 2:51 PM, Fabiano Fidêncio wrote: > I'm sending Alexander Bokovoy's patch as it is, also here is some notes from > him: > > "I'd really like to find a way to do it with pure SASL properties so that the > code would work for both SPNEGO and Kerberos. SPNEGO NTLMSSP would make

[Spice-devel] [spice-gtk] spice-channel: support SASL GSSAPI

2016-06-06 Thread Fabiano Fidêncio
From: Alexander Bokovoy Support SASL GSSAPI Kerberos by discovering default credential from default Kerberos credentials cache. If default Kerberos credential is missing, fallback to standard method with password and username. Signed-of-by: Alexander Bokovoy --- src/spice-channel.c | 61 +

[Spice-devel] [spice-gtk] Support SASL GSSAPI

2016-06-06 Thread Fabiano Fidêncio
I'm sending Alexander Bokovoy's patch as it is, also here is some notes from him: "I'd really like to find a way to do it with pure SASL properties so that the code would work for both SPNEGO and Kerberos. SPNEGO NTLMSSP would make it working for environments where you don't have Kerberos but what

[Spice-devel] [spice-gtk] widget: Do not ignore unsupported keys from keyboard

2016-06-06 Thread Frediano Ziglio
If Windows layout does not support a given key the resulting virtual code is set to 0xFF. To avoid losing this raw key (causing the key not been sent to remote machine) detect this condition and handle the key. The check for raw scancode is there to understand if we can handle correctly the key in

[Spice-devel] [spice-server v1] char-device: fix mismatch of client tokens

2016-06-06 Thread Victor Toso
As the tokens counter were not being reset you could enter in a situation where client thinks it has more tokens then server which would eventually lead to client's disconnection from 0c5eca97f16ec6 onwards (before it was crashing). It is easy to check the above situation if you track the amount o

[Spice-devel] [PATCH] replay: Handle errors in record file

2016-06-06 Thread Frediano Ziglio
Detect errors in record file. This can happen from a wrong version or corruption of files. Allocations are kept into a GList to be able to free in case some errors happened. Some macros are used to return error condition without many if. replay_t was converted to a pointer and REPLAY_EOF is NULL to

Re: [Spice-devel] [PATCH spice-gtk] mingw: Fix -Werror format & missing-prototypes

2016-06-06 Thread Marc-André Lureau
ack - Original Message - > --- > src/spice-widget.c | 2 +- > src/usb-device-manager.c | 6 +++--- > src/win-usb-clerk.h | 4 ++-- > src/win-usb-driver-install.c | 3 ++- > 4 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/src/spice-widget.c b/src/s

[Spice-devel] [PATCH spice-gtk] mingw: Fix -Werror format & missing-prototypes

2016-06-06 Thread Pavel Grunt
--- src/spice-widget.c | 2 +- src/usb-device-manager.c | 6 +++--- src/win-usb-clerk.h | 4 ++-- src/win-usb-driver-install.c | 3 ++- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 0c70ce4..51a2055 100644 --- a/

Re: [Spice-devel] [PATCH 4/4] replay: Handle cursor commands

2016-06-06 Thread Frediano Ziglio
> > On Fri, 2016-06-03 at 10:59 +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > >  server/tests/replay.c | 50 > >  -- > >  1 file changed, 32 insertions(+), 18 deletions(-) > > > > diff --git a/server/tests/replay.c b/ser

[Spice-devel] [PATCH 2/2] record: Make red_record_cursor_cmd static

2016-06-06 Thread Frediano Ziglio
This function is never used outside this compile unit. Signed-off-by: Frediano Ziglio --- server/red-record-qxl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c index 5673f7d..9b7d2af 100644 --- a/server/red-record-qxl.c

[Spice-devel] [PATCH 1/2 v2] replay: Handle cursor commands

2016-06-06 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/tests/replay.c | 50 +++--- 1 file changed, 35 insertions(+), 15 deletions(-) Changes from v1: - renamed cmd_queue to display_queue to make clear which queue is; - check just for a single queue in get_command_f

Re: [Spice-devel] [PATCH 3/4] replay: Load cursor commands

2016-06-06 Thread Frediano Ziglio
> > On Fri, 2016-06-03 at 10:59 +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > >  server/red-replay-qxl.c | 70 > > + > >  1 file changed, 70 insertions(+) > > > > diff --git a/server/red-replay-qxl.c b/server/red-replay-

Re: [Spice-devel] [PATCH 2/4] worker: Record cursor commands

2016-06-06 Thread Frediano Ziglio
> > On Fri, 2016-06-03 at 10:59 +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > >  server/red-worker.c | 5 + > >  1 file changed, 5 insertions(+) > > > > diff --git a/server/red-worker.c b/server/red-worker.c > > index a14f55d..e754bd2 100644 > > --- a/server/red-w

Re: [Spice-devel] [spice-gtk v3 05/16] file-xfer: inform agent of errors only when task finished

2016-06-06 Thread Pavel Grunt
Hi Jonathon, On Fri, 2016-06-03 at 10:17 -0500, Jonathon Jongsma wrote: > Related to my comments to the last patch, this change makes the > SpiceFileTransferTask class less "self-contained". In other words, if the user > does not connect to the 'finished' signal and send the appropriate agent > XF

Re: [Spice-devel] [PATCH v3] streaming: Use the frame dimensions reported by the video decoder

2016-06-06 Thread Pavel Grunt
On Fri, 2016-06-03 at 15:02 +0200, Francois Gouget wrote: > The dimensions sent by the remote end are redundant and should not be > trusted. > > Signed-off-by: Francois Gouget Acked-by: Pavel Grunt Thanks, Pavel > --- >  src/channel-display-gst.c   | 41 +