Hi,
On Fri, Jun 03, 2016 at 11:52:17AM -0400, Frediano Ziglio wrote:
> >
> > ---
> > server/char-device.c | 6 ++
> > server/reds.c| 8 ++--
> > 2 files changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/server/char-device.c b/server/char-device.c
> > index cb35aa2..8
Hi,
On Fri, Jun 03, 2016 at 12:22:09PM -0500, Jonathon Jongsma wrote:
> On Mon, 2016-05-30 at 11:55 +0200, Victor Toso wrote:
> > Application can start multiple file-transfers in one operation and
> > cancel a few of them while the operation is ongoing. In that case, we
> > should remove the file-
Hi,
On Fri, Jun 03, 2016 at 12:12:14PM -0500, Jonathon Jongsma wrote:
> On Mon, 2016-05-30 at 11:55 +0200, Victor Toso wrote:
> > SpiceFileTransferTask has a callback to be called when operation
> > ended. Til this patch, we were setting the user callback which means
> > that in multiple file-tran
On Fri, Jun 03, 2016 at 11:42:13AM -0500, Jonathon Jongsma wrote:
> On Mon, 2016-05-30 at 11:55 +0200, Victor Toso wrote:
> > Each call to spice_main_file_copy_async will now create a
> > FileTransferOperation which groups all SpiceFileTransferTasks of the
> > copy operation and also the progress_c
Hi,
On Fri, Jun 03, 2016 at 10:17:05AM -0500, Jonathon Jongsma wrote:
> Related to my comments to the last patch, this change makes the
> SpiceFileTransferTask class less "self-contained". In other words, if
> the user does not connect to the 'finished' signal and send the
> appropriate agent XFER
Hi,
On Thu, Jun 02, 2016 at 05:14:57PM -0500, Jonathon Jongsma wrote:
> On Mon, 2016-05-30 at 11:55 +0200, Victor Toso wrote:
> > In order to avoid sending the agent message on
> > file_xfer_info_async_cb, we can provide the "file-info" signal to
> > SpiceFileTransferTask.
> >
> > In order to thi
Hi,
On Thu, Jun 02, 2016 at 11:44:42AM -0500, Jonathon Jongsma wrote:
> On Mon, 2016-05-30 at 11:54 +0200, Victor Toso wrote:
> > By splitting file_xfer_send_start_msg_async we can separate in three
> > different steps the spice_main_file_copy_async function:
> >
> > 1-) Creating tasks with spice
On Fri, Jun 3, 2016 at 2:03 PM, Frediano Ziglio wrote:
> The segment_size computation on 32 bit can lead to big numbers which
> can lead to negative offset. As we test we don't overrun the buffer
> avoid to underrun it as we don't have a check for this.
The last sentence in the commit message is
On Fri, Jun 3, 2016 at 2:03 PM, Frediano Ziglio wrote:
> Use 64 bit arithmetic to avoid overflows.
> The multiplication between count and a constant can overflow.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-parse-qxl.c | 13 -
> 1 file changed, 4 insertions(+), 9 deletions(
