Hi Francois,
On Thu, 2016-05-26 at 01:26 +0200, Francois Gouget wrote:
> On Wed, 25 May 2016, Pavel Grunt wrote:
> [...]
> > > +do {
> > it is preferred to declare variables at the beginning of the block.
>
> That does not seem to be mentionned in the Spice coding style and
> conventions:
>
On Wed, 25 May 2016, Pavel Grunt wrote:
[...]
> > +do {
> it is preferred to declare variables at the beginning of the block.
That does not seem to be mentionned in the Spice coding style and
conventions:
http://www.spice-space.org/static/docs/spice_style.pdf
There's also quite a few cases a
On Wed, 2016-05-25 at 16:35 +0100, Frediano Ziglio wrote:
> This allows compressions using external programs or any type
compressions -> compression
> of filters.
>
> To use it set SPICE_WORKER_RECORD_FILTER environment to the
> filter command you want to use. The command is executed with
> g_sp
Hi,
On Wed, May 25, 2016 at 05:33:02PM +0200, Marc-André Lureau wrote:
> The struct is already private
>
> Signed-off-by: Marc-André Lureau
Let's have this sooner. I can rebase the other series later.
Both patches are good.
Acked-by: Victor Toso
> ---
> src/channel-main.c | 227
Hi,
On Wed, May 25, 2016 at 11:01:47PM +0200, Victor Toso wrote:
> Hi,
>
> On Wed, May 25, 2016 at 05:42:48PM +0200, Pavel Grunt wrote:
> > Of course it is correct, but I would wait with it after applying:
> > https://lists.freedesktop.org/archives/spice-devel/2016-May/029359.html
> > or if Victo
Hi,
On Wed, May 25, 2016 at 05:42:48PM +0200, Pavel Grunt wrote:
> Of course it is correct, but I would wait with it after applying:
> https://lists.freedesktop.org/archives/spice-devel/2016-May/029359.html
> or if Victor is ok with it?
No problem Besides the typo in the commit log /o\ :D
>
Hi,
On Mon, May 23, 2016 at 01:50:37PM +0200, Victor Toso wrote:
> The idea is mainly to have a design improvement over the current file-transfer
> logic by trying to detach it from channel-main and the agent logic plus a few
> simple tests.
>
> One interesting change is about creating a FileTrans
On Wed, 2016-05-25 at 16:35 +0100, Frediano Ziglio wrote:
> Remove global/static from red_record_qxl.c.
> Defined a structure and use it to hold record state.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-record-qxl.c | 53 ++--
> -
> server/re
On Fri, 2016-05-13 at 10:16 +0100, Frediano Ziglio wrote:
> Explain usage of the class.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.h | 30 +-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/server/cursor-channel.h b/server/cur
On Fri, 2016-05-13 at 10:16 +0100, Frediano Ziglio wrote:
> The existence of this class can be hidden to user of CursorChannel class
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.c | 15 +++
> server/cursor-channel.h | 7 ++-
> server/red-worker.c | 4 ++-
Acked-by: Jonathon Jongsma
On Fri, 2016-05-13 at 10:16 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.c | 10 ++
> server/cursor-channel.h | 5 -
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/server/cursor-channel
Looks like an improvment
Acked-by: Jonathon Jongsma
On Fri, 2016-05-13 at 10:16 +0100, Frediano Ziglio wrote:
> This function was handling mainly CursorChannel state
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.c | 23 +++
> server/cursor-channel.h |
On Wed, May 25, 2016 at 12:31:09PM -0400, Marc-André Lureau wrote:
> >
> > When this happens, we inform the server that only one monitor is active,
> > then the server sends a MonitorsConfig message with 2 monitors (first
> > request we sent), and then with just 1 monitor (second request we sent).
Hi
- Original Message -
> When using remote-viewer --full-screen with a VM/client with multiple
> monitors, a race can be observed during auto-configuration. First, the
> client monitors config is sent to the guest:
> (remote-viewer:19480): GSpice-DEBUG: channel-main.c:1166 main-1:0: sendi
When using remote-viewer --full-screen with a VM/client with multiple
monitors, a race can be observed during auto-configuration. First, the
client monitors config is sent to the guest:
(remote-viewer:19480): GSpice-DEBUG: channel-main.c:1166 main-1:0: sending new
monitors config to guest
(remote-
Of course it is correct, but I would wait with it after applying:
https://lists.freedesktop.org/archives/spice-devel/2016-May/029359.html
or if Victor is ok with it?
Pavel
On Wed, 2016-05-25 at 17:33 +0200, Marc-André Lureau wrote:
> The struct is already private
>
> Signed-off-by: Marc-André L
Hi
On Wed, May 25, 2016 at 7:30 AM, Pavel Grunt wrote:
> ---
> doc/reference/spice-gtk-sections.txt | 4 ++--
> src/channel-main.c | 24
> src/spice-file-transfer-task.h | 23 ---
> 3 files changed, 26 insertions(+), 25 deleti
Remove global/static from red_record_qxl.c.
Defined a structure and use it to hold record state.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c | 53 ++---
server/red-record-qxl.h | 15 ++
server/red-worker.c | 25 ++
This allows compressions using external programs or any type
of filters.
To use it set SPICE_WORKER_RECORD_FILTER environment to the
filter command you want to use. The command is executed with
g_spawn_async_with_pipes (which uses execve) so is not a shell
command although the command is parsed us
They are no longer in the doc, and not really useful anyway
Signed-off-by: Marc-André Lureau
---
src/channel-main.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index c9bc668..92e01ce 100644
--- a/src/channel-main.c
+++ b/src/channel-mai
The struct is already private
Signed-off-by: Marc-André Lureau
---
src/channel-main.c | 227 +++--
src/spice-file-transfer-task.h | 1 -
2 files changed, 107 insertions(+), 121 deletions(-)
diff --git a/src/channel-main.c b/src/channel-main.c
in
>
> I vaguely remembered reviewing something like this earlier and found an
> earlier
> thread where we were discussing some changes to this patch:
> https://lists.freedesktop.org/archives/spice-devel/2016-January/026206.html
>
> It doesn't look like those changes were incorporated. Did you decid
Hi Francois,
On Tue, 2016-05-24 at 11:46 +0200, Francois Gouget wrote:
> The dimensions sent by the remote end are redundant and should not be
> trusted.
>
> Signed-off-by: Francois Gouget
> ---
> src/channel-display-gst.c | 40 +++-
> src/channel-display-m
I vaguely remembered reviewing something like this earlier and found an earlier
thread where we were discussing some changes to this patch:
https://lists.freedesktop.org/archives/spice-devel/2016-January/026206.html
It doesn't look like those changes were incorporated. Did you decide against
them
>
> On Wed, 2016-05-25 at 10:21 +0200, Pavel Grunt wrote:
> > Hi,
> >
> > On Fri, 2016-05-20 at 06:44 -0400, Frediano Ziglio wrote:
> > > Hi,
> > > I'd like to have some standard on the internal documentation of spice-
> > > server.
> > >
> > Yes, that would be nice.
> >
> > > The current sit
On Wed, 2016-05-25 at 16:12 +0200, Victor Toso wrote:
> Hi!
>
> On Wed, May 25, 2016 at 08:31:45AM -0400, Frediano Ziglio wrote:
> > I personally find that vertical indentation tend to cause long lines and
> > it's hard to maintain when new declarations are added (like requiring
> > new indentati
On Wed, 2016-05-25 at 08:31 -0400, Frediano Ziglio wrote:
> Hi,
> I was reading the style document and I found some different styles in the
> code
>
> The structures for GObject differs from the rest of the code, they are
>
> struct DispatcherClass
> {
> GObjectClass parent_class;
> };
>
>
On Wed, 2016-05-25 at 10:21 +0200, Pavel Grunt wrote:
> Hi,
>
> On Fri, 2016-05-20 at 06:44 -0400, Frediano Ziglio wrote:
> > Hi,
> > I'd like to have some standard on the internal documentation of spice-
> > server.
> >
> Yes, that would be nice.
>
> > The current situation is quite messy hav
Acked-by: Jonathon Jongsma
On Wed, 2016-05-25 at 11:35 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc-encoders.c| 7 +--
> server/dcc-encoders.h| 2 --
> server/display-channel.c | 2 +-
> server/display-channel.h | 2 --
> server/image-cache.
Hi,
more than a patch review I'd like to start (another?)
discussion about some changes in the code.
This patch add some code to make valgrind work better.
The main issue is that we don't want code like this in
production. It simply does make no sense.
These kind of stuff are usually called co
On Wed, 2016-05-25 at 13:02 +0200, Christophe Fergeau wrote:
> On Wed, May 25, 2016 at 11:31:13AM +0100, Frediano Ziglio wrote:
> > If you are testing for NULL data this means that variable could be
> > NULL so avoid to access before the check to make sure the check is hit.
> >
> > Signed-off-by:
On Tue, 2016-05-24 at 11:44 +0200, Francois Gouget wrote:
> They are only supposed to be changed when receiving the relevant server
> message.
>
> Signed-off-by: Francois Gouget
Acked-by: Pavel Grunt
> ---
> src/channel-display-priv.h | 2 +-
> src/channel-display.c | 4 ++--
> 2 files cha
Not terrible, but I think if we did use this approach there should be a
prominent comment in red-types.h explaining why this seemingly-arbitrary set of
types are defined there.
On Wed, 2016-05-25 at 11:43 +0200, Christophe Fergeau wrote:
> This fixes compilation on el6. This is achieved by moving
Hi!
On Wed, May 25, 2016 at 08:31:45AM -0400, Frediano Ziglio wrote:
> Hi,
> I was reading the style document and I found some different styles in the
> code
>
> The structures for GObject differs from the rest of the code, they are
>
> struct DispatcherClass
> {
> GObjectClass parent_class
On Wed, May 25, 2016 at 03:52:11PM +0200, Christophe Fergeau wrote:
> On Thu, May 19, 2016 at 06:56:05PM +0200, Sergio L. Pascual wrote:
> > We still apply some minor changes to the spice-gtk package (https://git
> > hub.com/flexVDI/cerbero/tree/master/recipes/spice-gtk), mostly to fix
> > some ali
On Thu, May 19, 2016 at 06:56:05PM +0200, Sergio L. Pascual wrote:
> We still apply some minor changes to the spice-gtk package (https://git
> hub.com/flexVDI/cerbero/tree/master/recipes/spice-gtk), mostly to fix
> some alignment issues on ARMv7.
>
> Probably, it would be nice to apply those chang
From: Lukas Venhoda
Check whether Spice Folder is already mapped.
If yes, don't try to map another one.
---
Changes since v6:
- Removed empty line
Changes since v5:
- fixed indentation
- fixed * indentaion
Changes since v4:
- Moved some variables around
- Better debug message
- Fixed bug,
From: Lukas Venhoda
When stopping the service, automatically disconnect shared folder on
windows. Not dismounting could lead to multiple shared folders.
---
Changes since v6:
- Changed gchar* to ServiceData*
- Added mutex for ServiceData multithread handeling
- Moved ServiceData from windows s
From: Lukas Venhoda
Try to connect to shared folder automatically on Windows.
On each loop of run_service(), run a GTask, that waits for half a second.
If read_thread() returns, it means, that sharing is not yet connected,
and the map_drive task is cancelled.
If the map_drive task is NOT cancel
Hi Lorenzo,
On 05/25/2016 07:35 AM, Lorenzo Garcia wrote:
> Hello,
>
> First of all, thanks for your help. The biggest change was that we
> changed the physical server, but i have used the same debs for the
> installation and used the same ubuntu. The spice-html5 client was
> upgraded, but with t
>
> Acked-by: Christophe Fergeau
>
> (and as a side-note, we should actively fight against using these
> abbreviations)
>
> Christophe
>
Currently they are mostly used for variable like the standard
"int i" in C. There are some exceptions like dcc but really, it
became very long.
IMO as used
Reluctant
Acked-by: Christophe Fergeau
as imo the solution is not to document them, but to get rid of them.
This will do for now :)
Christophe
On Wed, May 25, 2016 at 12:51:37PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> docs/spice_style.txt | 4
> 1 file cha
Acked-by: Christophe Fergeau
(and as a side-note, we should actively fight against using these
abbreviations)
Christophe
On Wed, May 25, 2016 at 12:51:36PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> docs/spice_style.txt | 8
> 1 file changed, 4 insertions
Hey,
On Wed, May 25, 2016 at 12:58:48PM +0100, Frediano Ziglio wrote:
> ---
> server/inputs-channel-client.c | 2 --
> server/inputs-channel.c| 7 +--
> server/inputs-channel.h| 1 -
> 3 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/server/inputs-channel-clie
Acked-by: Christophe Fergeau
On Wed, May 25, 2016 at 01:06:36PM +0100, Frediano Ziglio wrote:
> ---
> server/glz-encode.tmpl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/glz-encode.tmpl.c b/server/glz-encode.tmpl.c
> index 033a810..d699499 100644
> --- a/server/glz-encode.t
On Wed, May 25, 2016 at 08:31:45AM -0400, Frediano Ziglio wrote:
> Hi,
> I was reading the style document and I found some different styles in the
> code
>
> The structures for GObject differs from the rest of the code, they are
>
> struct DispatcherClass
> {
> GObjectClass parent_class;
>
Remove global/static from red_record_qxl.c.
Defined a structure and use it to hold record state.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c | 58 +++--
server/red-record-qxl.h | 12 +++---
server/red-worker.c | 30 --
Hi,
was a while I didn't post this set of patches.
Changes:
- rebased;
- adapt to name prefix decisions.
One of the pending issue was about using Red or Spice
prefix for structures. It was (recently?) decided to
use Red for internal and Spice for external so as
these structure are internal now ar
This allows compressions using external programs or any type
of filters.
To use it set SPICE_WORKER_RECORD_FILTER environment to the
filter command you want to use. The command is executed with
g_spawn_async_with_pipes (which uses execve) so is not a shell
command although the command is parsed us
Hello,
First of all, thanks for your help. The biggest change was that we
changed the physical server, but i have used the same debs for the
installation and used the same ubuntu. The spice-html5 client was
upgraded, but with the old version it behaves the same.
For now I can't use the old ser
Hi,
I was reading the style document and I found some different styles in the code
The structures for GObject differs from the rest of the code, they are
struct DispatcherClass
{
GObjectClass parent_class;
};
instead of
struct DispatcherClass {
GObjectClass parent_class;
};
(all othe
---
server/glz-encode.tmpl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/glz-encode.tmpl.c b/server/glz-encode.tmpl.c
index 033a810..d699499 100644
--- a/server/glz-encode.tmpl.c
+++ b/server/glz-encode.tmpl.c
@@ -538,7 +538,6 @@ static void FNAME(compress)(Encoder *encoder)
#undef
---
server/inputs-channel-client.c | 2 --
server/inputs-channel.c| 7 +--
server/inputs-channel.h| 1 -
3 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/server/inputs-channel-client.c b/server/inputs-channel-client.c
index f9dd6b2..2f8acec 100644
--- a/server/inpu
Signed-off-by: Frediano Ziglio
---
docs/spice_style.txt | 4
1 file changed, 4 insertions(+)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index d7a879d..e2d7a3e 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -138,6 +138,10 @@ As a basic rule `Spice` refers to ty
Signed-off-by: Frediano Ziglio
---
docs/spice_style.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index b024b6b..d7a879d 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -138,15 +138,15 @@ As a basic rule
Signed-off-by: Frediano Ziglio
---
server/red-channel.c | 40 ++--
1 file changed, 18 insertions(+), 22 deletions(-)
Changes since v1:
- fix a typo in subject;
- use a single macro that is safe instead of two.
diff --git a/server/red-channel.c b/server/red-ch
On Wed, May 25, 2016 at 11:31:13AM +0100, Frediano Ziglio wrote:
> If you are testing for NULL data this means that variable could be
> NULL so avoid to access before the check to make sure the check is hit.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.c | 5 +++--
> server
>
> On Wed, May 25, 2016 at 06:42:56AM -0400, Frediano Ziglio wrote:
> > >
> > > On Wed, May 25, 2016 at 11:44:14AM +0200, Christophe Fergeau wrote:
> > > > and verify() causing compile failures
> > >
> > > Actually this one is just a warning + -Werror:
> > >
> > > image-cache.c:82: warning: ne
On Wed, May 25, 2016 at 06:42:56AM -0400, Frediano Ziglio wrote:
> >
> > On Wed, May 25, 2016 at 11:44:14AM +0200, Christophe Fergeau wrote:
> > > and verify() causing compile failures
> >
> > Actually this one is just a warning + -Werror:
> >
> > image-cache.c:82: warning: nested extern declara
>
> On Wed, May 25, 2016 at 11:44:14AM +0200, Christophe Fergeau wrote:
> > and verify() causing compile failures
>
> Actually this one is just a warning + -Werror:
>
> image-cache.c:82: warning: nested extern declaration of
> '_gl_verify_function6' [-Wnested-externs]
>
> Christophe
>
Can you
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c| 7 +--
server/dcc-encoders.h| 2 --
server/display-channel.c | 2 +-
server/display-channel.h | 2 --
server/image-cache.c | 2 +-
server/image-cache.h | 1 -
server/inputs-channel.c | 10 +++---
server/input
On Wed, 2016-05-25 at 12:20 +0200, Marc-André Lureau wrote:
> spice_cairo_draw_event() can deal with d->canvas.surface == NULL.
>
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> src/spice-widget.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/spice-widget.c b/src
On Wed, 2016-05-25 at 12:20 +0200, Marc-André Lureau wrote:
> When the display is not yet realized, spice_display_widget_gl_scanout()
> will fail because the egl context is not ready. The display is never
> marked ready because the egl.image (and egl.scanout) is not set, and
> some clients, such as
On Wed, 2016-05-25 at 12:20 +0200, Marc-André Lureau wrote:
> Group canvas related data to a sub-structure.
>
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> src/spice-widget-cairo.c | 38 +++--
> src/spice-widget-priv.h | 17 +++--
> src/spice-
If you are testing for NULL data this means that variable could be
NULL so avoid to access before the check to make sure the check is hit.
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 5 +++--
server/dcc-send.c| 6 --
server/dcc.c | 2 +-
server/displa
On Wed, May 25, 2016 at 11:44:14AM +0200, Christophe Fergeau wrote:
> and verify() causing compile failures
Actually this one is just a warning + -Werror:
image-cache.c:82: warning: nested extern declaration of '_gl_verify_function6'
[-Wnested-externs]
Christophe
signature.asc
Description: PG
spice_cairo_draw_event() can deal with d->canvas.surface == NULL.
Signed-off-by: Marc-André Lureau
---
src/spice-widget.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index a37faad..f13a066 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@
When the display is not yet realized, spice_display_widget_gl_scanout()
will fail because the egl context is not ready. The display is never
marked ready because the egl.image (and egl.scanout) is not set, and
some clients, such as virt-viewer will not realize the widget until the
display is ready.
spice-gtk used to have x11/shm backend, now it's only cairo
Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
---
src/spice-widget-cairo.c | 8
src/spice-widget-priv.h | 8
src/spice-widget.c | 27 +--
3 files changed, 21 insertions(+), 22
Group canvas related data to a sub-structure.
Signed-off-by: Marc-André Lureau
---
src/spice-widget-cairo.c | 38 +++--
src/spice-widget-priv.h | 17 +++--
src/spice-widget.c | 62
3 files changed, 59 inserti
Hi
On Wed, May 25, 2016 at 8:42 AM, Pavel Grunt wrote:
> On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote:
>> When the display is not yet realized, spice_display_widget_gl_scanout()
>> will fail because the egl context is not ready. The display is never
>> marked ready because the egl.i
Hi
- Original Message -
> Hi,
>
> On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote:
> > Group canvas related data to a sub-structure.
> I am ok with groupping part of the patch, but there are some changes which
> should be documented & go in a separate patch.
> >
> > Signed-off
On Wed, 25 May 2016, Francois Gouget wrote:
> On Tue, 24 May 2016, Francois Gouget wrote:
> [...]
> > Now if the content of SpiceCopy cannot be trusted, the GStreamer encoder
> > is the wrong place to check for issues : there are at least three places
> > where the SpiceCopy bitmap can be used:
Hi,
On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote:
> Group canvas related data to a sub-structure.
I am ok with groupping part of the patch, but there are some changes which
should be documented & go in a separate patch.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-widget
On Wed, May 25, 2016 at 04:42:00AM -0400, Frediano Ziglio wrote:
> Could we use a backported gcc on rhel6 ?
> I remember for rhel5 there was an official gcc44 package you
> could install to get a newer compiler, maybe we can use it
> to support multiple typedefs on rhel6.
There is
https://access.r
This fixes compilation on el6. This is achieved by moving the most problematic
typedef to a red-types.h header. Ideally, it will go away once we have put some
order in the header content/API/... For example, StreamAgent would be better as
an opaque type.
---
Here is my take on this.
Christophe
On Wed, 2016-05-25 at 11:13 +0200, Marc-André Lureau wrote:
> Hi
>
> On Wed, May 25, 2016 at 9:00 AM, Pavel Grunt wrote:
> >
> > What about binding the texture in gl_make_current ?
>
> There are 2 textures, one for the display and one for the cursor.
ah, right, I did not relealize
>
> > More i
Hi
On Wed, May 25, 2016 at 9:00 AM, Pavel Grunt wrote:
>
> What about binding the texture in gl_make_current ?
There are 2 textures, one for the display and one for the cursor.
> More info about the regression in the commit log would be nice.
What about:
glEGLImageTargetTexture2DOES() changes
>
> On 05/24/2016 12:19 AM, Jonathon Jongsma wrote:
> > On Mon, 2016-05-23 at 15:17 -0500, Jonathon Jongsma wrote:
> >> On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:
> >>
> /* FIXME: move back to display-channel.h (once structs are private) */
> typedef struct Drawable Draw
>
> Since recent version of GCC allow multiple typedefs of the same name as
> long as it refers to the same type, we can avoid some of the
> typedef/header issues if we just decide to require a version of gcc that
> allows this behavior. This is also valid according ot the C11 standard.
> I don't
With some simple steps I simplified the internal loop of this
function
* convert to infinite loop
while (link) {
dcc = link->data;
dpi = SPICE_UPCAST(RedDrawablePipeItem, dpi_ring_item);
-while (link && (!dpi || dcc != dpi->dcc)) {
+for (;;) {
+i
Hi,
On Fri, 2016-05-20 at 06:44 -0400, Frediano Ziglio wrote:
> Hi,
> I'd like to have some standard on the internal documentation of spice-
> server.
>
Yes, that would be nice.
> The current situation is quite messy having different styles.
> I think the worst think is not having any document
On Tue, 24 May 2016, Francois Gouget wrote:
[...]
> Now if the content of SpiceCopy cannot be trusted, the GStreamer encoder
> is the wrong place to check for issues : there are at least three places
> where the SpiceCopy bitmap can be used: the MJPEG encoder, the GStreamer
> encoder and the reg
Hi,
On Wed, May 25, 2016 at 09:54:07AM +0200, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
This should be fixed by
https://cgit.freedesktop.org/spice/spice/commit/?id=7a51188891885d2950bd20dc129d58f9360a2408
> ---
>
> Otherwise you get compiler warnings...
>
> server/display-chann
Signed-off-by: Francois Gouget
---
Otherwise you get compiler warnings...
server/display-channel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index b970c9b..b0875e8 100644
--- a/server/display-channel.c
+++ b/serve
Hi,
On Tue, May 24, 2016 at 01:58:57PM -0500, Jonathon Jongsma wrote:
> since display_channel_print_stats is now static, the compiler complains
> when RED_WORKER_STAT is undefined since this function is not used:
>
> ../../server/display-channel.c:853:13: error:
> 'display_channel_print_stats
Hi,
What about binding the texture in gl_make_current ?
More info about the regression in the commit log would be nice.
Pavel
On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote:
> Fix regression from commit 3539ac6212d506128bd38aad032e0363e78cb4f6.
>
> Signed-off-by: Marc-André Lureau
87 matches
Mail list logo
