Re: [Spice-devel] [PATCH spice-gtk 1/4] tests: Add test for SpiceUri

Hi, On Mon, May 16, 2016 at 03:00:14PM +0200, Pavel Grunt wrote: > Related: rhbz#1335239 > --- > tests/Makefile.am | 2 ++ > tests/test-spice-uri.c | 64 > ++ > 2 files changed, 66 insertions(+) > create mode 100644 tests/test-spice-uri.c >

Re: [Spice-devel] [PATCH v3] stats: simplify printing statistics

On Mon, 2016-05-16 at 10:55 +0100, Frediano Ziglio wrote: > Use some utility function to show and compute statistics. > > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- >  server/display-channel.c | 131 ++-- > --- >  1 file changed, 49 insertio

[Spice-devel] [PATCH 14/15] dc: inline dpi computation

Actually not exactly the same as this fix a bug if base is not the first element (in this case if dpi_ring_item is NULL dpi is not) Signed-off-by: Frediano Ziglio --- server/display-channel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/server/display-channel.c b/server

[Spice-devel] [PATCH 15/15] dc: use RING_FOREACH macro for loop

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 608d176..65ca110 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -504,10 +504,9 @@

[Spice-devel] [PATCH 11/15] dc: convert break to continue

Both jump to check worker_ring_item (internal or external loops) Signed-off-by: Frediano Ziglio --- server/display-channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/display-channel.c b/server/display-channel.c index 58c1fd6..40e6608 100644 --- a/server/display-

[Spice-devel] [PATCH 13/15] dc: join the two loop

They tested the same condition, no break in inside loop (which would exit all loops) Signed-off-by: Frediano Ziglio --- server/display-channel.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index a54

[Spice-devel] [PATCH 07/15] dc: dpi is always a value computed from dpi_ring_item

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/display-channel.c b/server/display-channel.c index 27d8e83..d618ba5 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -509,13 +509,13 @@ sta

[Spice-devel] [PATCH 06/15] dc: move code inside if

these lines are only executed then the condition are satisfied Signed-off-by: Frediano Ziglio --- server/display-channel.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index c5768de..27d8e83 100644 --- a/serve

[Spice-devel] [PATCH 12/15] dc: reuse code inside loop

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 40e6608..a54f561 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -515,11 +515,9 @

[Spice-devel] [PATCH 01/15] dc: convert to infinite loop

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/display-channel.c b/server/display-channel.c index 1f4d66f..171dfce 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -512,7 +512,10 @@

[Spice-devel] [PATCH 02/15] dc: split if

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/display-channel.c b/server/display-channel.c index 171dfce..f19d3db 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -513,7 +513,10 @@

[Spice-devel] [PATCH 03/15] dc: the worker_ring_item condition make this case terminate loop

dpi_ring_item is changed but ignored Signed-off-by: Frediano Ziglio --- server/display-channel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/display-channel.c b/server/display-channel.c index f19d3db..fc232fb 100644 --- a/server/display-channel.c +++ b/server/dis

[Spice-devel] [PATCH 04/15] dc: worker_ring_item is never null here

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index fc232fb..31ec5d0 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -529,10 +529,8 @

[Spice-devel] [PATCH 08/15] dc: if dpi is not NULL even dpi_ring_item is not NULL

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index d618ba5..cb60637 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -517,9 +517,7 @@ st

[Spice-devel] [PATCH 10/15] dc: use while again

Convert from for(;;) { if () break; ... } to while Signed-off-by: Frediano Ziglio --- server/display-channel.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 312d971..58c1fd6 100644 --- a/server/display-channel.c

[Spice-devel] [PATCH 05/15] dc: dcc used is always a value from current worker_ring_item

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 31ec5d0..c5768de 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -509,21 +509,19

[Spice-devel] [PATCH 09/15] dc: if worker_ring_item is NULL jumping outside loop will check variable and exit

The outer loop will exit too. Signed-off-by: Frediano Ziglio --- server/display-channel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index cb60637..312d971 100644 --- a/server/display-channel.c +++ b/server/display-ch

[Spice-devel] [PATCH 00/15] Simplify current_add_equal function loop

These patches should be probably squashed together. I still don't get that much what the loop is supposed to achieve but surely now is much neat. Also I removed a code assumption (it all started from there). Can somebody explain what the code is supposed to do? Frediano Ziglio (15): dc: convert

[Spice-devel] [PATCH] make spice-server-replay utility smaller

spice-server-replay is built inside tests. However tests are built linking to a convenience library causing all spice-server code to be linked inside of the executable. This is not a big problem however do not allow to easily use this utility to test different binary version libraries. Linking to j

[Spice-devel] [PATCH] remove only written num_mig_target_clients field in RedsState

Signed-off-by: Frediano Ziglio --- server/reds-private.h | 1 - server/reds.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/server/reds-private.h b/server/reds-private.h index 97ea0ba..5724f16 100644 --- a/server/reds-private.h +++ b/server/reds-private.h @@ -118,7 +118,6 @@ struc

[Spice-devel] [PATCH] remove only written peer_minor_version field in RedsState

Signed-off-by: Frediano Ziglio --- server/reds-private.h | 1 - server/reds.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/server/reds-private.h b/server/reds-private.h index 74a251b..97ea0ba 100644 --- a/server/reds-private.h +++ b/server/reds-private.h @@ -140,7 +140,6 @@ stru

[Spice-devel] [PATCH] use more portable SPICE_OFFSETOF instead of offsetof

Signed-off-by: Frediano Ziglio --- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index 9898fe5..1909e6e 100644 --- a/server/reds.c +++ b/server/reds.c @@ -442,7 +442,7 @@ uint64_t *stat_add_counter(RedsState *reds, StatNodeRef par

[Spice-devel] [PATCH] remove a warning building a test

Signed-off-by: Frediano Ziglio --- server/tests/stream-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/tests/stream-test.c b/server/tests/stream-test.c index 6317796..8fd1449 100644 --- a/server/tests/stream-test.c +++ b/server/tests/stream-test.c @@ -35,6 +35

[Spice-devel] [PATCH 0/5] Proposed LZ4 extensions and some type changes

Starting changing LZ4 new protocol message I found some issues with types. Frediano Ziglio (4): improve lz4 protocol fix wrong assert check add a check for negate cases on enumerations extend a comment for type attributes Snir Sheriber (1): Add LZ4 data compression and used it in spicev

[Spice-devel] [PATCH 2/4] fix wrong assert check

The assert were never triggered as always True Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 753d363..74f3e55 100644 --- a/python_modules/ptypes.py +++ b/py

[Spice-devel] [PATCH 5/5] extend a comment for type attributes

Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 1f4e068..f4a09f7 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@ -63,7 +63,7 @@ class F

[Spice-devel] [PATCH 4/5] add a check for negate cases on enumerations

Not supported by code so trigger an error to avoid invalid uses Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 74f3e55..1f4e068 100644 --- a/python_modules/ptypes.py +++ b/p

[Spice-devel] [PATCH 2/5] improve lz4 protocol

Reduce size if not compressed and compute compressed size using message length This should be merged in previous patch --- common/messages.h | 2 +- spice.proto | 17 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/common/messages.h b/common/messages.h ind

[Spice-devel] [PATCH 4/4] extend a comment for type attributes

Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 1f4e068..f4a09f7 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@ -63,7 +63,7 @@ class F

[Spice-devel] [PATCH 1/4] improve lz4 protocol

Reduce size if not compressed and compute compressed size using message length This should be merged in previous patch --- common/messages.h | 2 +- spice.proto | 17 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/common/messages.h b/common/messages.h ind

[Spice-devel] [PATCH 3/5] fix wrong assert check

The assert were never triggered as always True Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 753d363..74f3e55 100644 --- a/python_modules/ptypes.py +++ b/py

[Spice-devel] [PATCH 3/4] add a check for negate cases on enumerations

Not supported by code so trigger an error to avoid invalid uses Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 74f3e55..1f4e068 100644 --- a/python_modules/ptypes.py +++ b/p

[Spice-devel] [PATCH 1/5] Add LZ4 data compression and used it in spicevmc channel

From: Snir Sheriber Compressed message type is CompressedData which contains compression type (1 byte) followed by the uncompressed data size (4 bytes) followed by the compressed data size (4 bytes) followed by the compressed data --- common/client_marshallers.h | 1 + common/messages.h

Re: [Spice-devel] [PATCH spice-gtk 1/4] tests: Add test for SpiceUri

On Po, 2016-05-16 at 10:10 -0400, Frediano Ziglio wrote: > > > > Related: rhbz#1335239 > > --- > > tests/Makefile.am | 2 ++ > > tests/test-spice-uri.c | 64 > > ++ > > 2 files changed, 66 insertions(+) > > create mode 100644 tests/test-spic

Re: [Spice-devel] [PATCH spice-gtk 4/4] spice-uri: Add ipv6 support

On Mon, 2016-05-16 at 10:35 -0400, Frediano Ziglio wrote: > > > > > > Resolves: rhbz#1335239 > > --- > >  src/spice-uri.c| 25 +++-- > >  tests/test-spice-uri.c | 43 +++ > >  2 files changed, 62 insertions(+), 6 deletions(-) > >

Re: [Spice-devel] [PATCH spice-gtk 4/4] spice-uri: Add ipv6 support

> > Resolves: rhbz#1335239 > --- > src/spice-uri.c| 25 +++-- > tests/test-spice-uri.c | 43 +++ > 2 files changed, 62 insertions(+), 6 deletions(-) > > diff --git a/src/spice-uri.c b/src/spice-uri.c > index 35d773e..36e75bb 100

Re: [Spice-devel] [PATCH spice-gtk 4/4] spice-uri: Add ipv6 support

> > Resolves: rhbz#1335239 > --- > src/spice-uri.c| 25 +++-- > tests/test-spice-uri.c | 43 +++ > 2 files changed, 62 insertions(+), 6 deletions(-) > > diff --git a/src/spice-uri.c b/src/spice-uri.c > index 35d773e..36e75bb 100

Re: [Spice-devel] [PATCH spice-gtk 1/4] tests: Add test for SpiceUri

> > Related: rhbz#1335239 > --- > tests/Makefile.am | 2 ++ > tests/test-spice-uri.c | 64 > ++ > 2 files changed, 66 insertions(+) > create mode 100644 tests/test-spice-uri.c > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index c

[Spice-devel] [PATCH 19/23] remove release_item callback

Just a call to red_pipe_item_unref. Signed-off-by: Frediano Ziglio --- server/red-channel.c | 19 +-- server/red-channel.h | 3 --- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 0d35fc0..4d7c1b1 100644 --- a/serv

[Spice-devel] [PATCH 16/23] use a default release_item implementation in RedChannel

Avoid having to provide a lot of empty implementations Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 6 -- server/display-channel.c | 6 -- server/inputs-channel.c | 7 --- server/red-channel.c | 10 +- server/smartcard.c | 7 --- server/spi

[Spice-devel] [PATCH 22/23] reuse red_channel_client_release_sent_item function

Signed-off-by: Frediano Ziglio --- server/red-channel.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 77eb4be..803570c 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@ -1757,10 +1757,7 @@ int red_channel_is

[Spice-devel] [PATCH 00/23] Using more reference counting on RedPipeItem

This is the continuation of Christophe patches using reference counting for RedPipeItem. Extend it's usage. This for instance lead to the removal of release_item callback. Some patches could probably be merged but it's easier to review them. I did some tests even adding some debugging to see how ma

[Spice-devel] [PATCH 17/23] simplify main_channel_release_pipe_item

Reuse RedPipeItem facilities. Signed-off-by: Frediano Ziglio --- server/main-channel.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/server/main-channel.c b/server/main-channel.c index 98ce660..433b46c 100644 --- a/server/main-channel.c

[Spice-devel] [PATCH 18/23] inline main_channel_release_pipe_item

Signed-off-by: Frediano Ziglio --- server/main-channel.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/server/main-channel.c b/server/main-channel.c index 433b46c..d540796 100644 --- a/server/main-channel.c +++ b/server/main-channel.c @@ -165,9 +165,6 @@ enum Ne

[Spice-devel] [PATCH 21/23] make red_channel_client_clear_sent_item static

Signed-off-by: Frediano Ziglio --- server/red-channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-channel.c b/server/red-channel.c index b7ec11e..77eb4be 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@ -1755,7 +1755,7 @@ int red_channel_is_conn

[Spice-devel] [PATCH 20/23] inline red_channel_client_release_item

Signed-off-by: Frediano Ziglio --- server/red-channel.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 4d7c1b1..b7ec11e 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@ -581,16 +581,10 @@ sta

[Spice-devel] [PATCH 23/23] use reference counting for RedPipeItem

Signed-off-by: Frediano Ziglio --- server/red-channel.c | 2 +- server/spicevmc.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 803570c..9aef363 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@ -578,7 +57

[Spice-devel] [PATCH 03/23] simplify RED_PIPE_ITEM_TYPE_DRAW item release

Move ring_remove to the function to release this type of item. Signed-off-by: Frediano Ziglio --- server/dcc.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index db77cc7..0953efd 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -288,7

[Spice-devel] [PATCH 01/23] remove unused refs field

Signed-off-by: Frediano Ziglio --- server/dcc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/server/dcc.h b/server/dcc.h index 1dd53bd..89934bc 100644 --- a/server/dcc.h +++ b/server/dcc.h @@ -154,7 +154,6 @@ typedef struct RedDrawablePipeItem { RedPipeItem dpi_pipe_item; /* link for t

[Spice-devel] [PATCH 07/23] handle STREAM_CREATE and STREAM_DESTROY pipe items more coherently

The items of these pipe items were allocated staticaly inside the StreamAgent structure. All others RedPipeItem are allocated dynamically. This could solve possible future maintenance as the life of these item is more easier to understand. It's more easier to understand why reference where incremen

[Spice-devel] [PATCH 11/23] simplify spicevmc_red_channel_release_pipe_item

Signed-off-by: Frediano Ziglio --- server/spicevmc.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index bdaa3c3..5724023 100644 --- a/server/spicevmc.c +++ b/server/spicevmc.c @@ -441,11 +441,7 @@ static void spicevmc_red_channel_

[Spice-devel] [PATCH 02/23] remove useless assignment

type was already initialized calling red_pipe_item_init Signed-off-by: Frediano Ziglio --- server/smartcard.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/smartcard.c b/server/smartcard.c index e483eec..b2fb766 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -541,7 +541,

[Spice-devel] [PATCH 15/23] inline dcc_release_item

Signed-off-by: Frediano Ziglio --- server/dcc-send.c| 2 +- server/dcc.c | 5 - server/dcc.h | 3 --- server/display-channel.c | 5 + 4 files changed, 2 insertions(+), 13 deletions(-) diff --git a/server/dcc-send.c b/server/dcc-send.c index 0f645a9..f0f2e1

[Spice-devel] [PATCH 14/23] simplify pipe items release in CursorChannel

All RedPipeItems can be freed with red_pipe_item_unref. Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 46 ++ 1 file changed, 2 insertions(+), 44 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index 2d57c59..

[Spice-devel] [PATCH 04/23] call red_pipe_item_unref instead of free

This is the standard way to release a RedPipeItem Signed-off-by: Frediano Ziglio --- server/dcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/dcc.c b/server/dcc.c index 0953efd..6f08cd9 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -1676,7 +1676,7 @@ static void

[Spice-devel] [PATCH 08/23] simplify release_item_after_push

Signed-off-by: Frediano Ziglio --- server/dcc.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 286514c..20ba6ee 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -1610,22 +1610,7 @@ int dcc_handle_migrate_data(DisplayChannelCl

[Spice-devel] [PATCH 09/23] simplify dcc_release_item

Signed-off-by: Frediano Ziglio --- server/dcc.c | 41 + 1 file changed, 1 insertion(+), 40 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 20ba6ee..7d9d366 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -1608,46 +1608,7 @@ int dcc_handle_migra

[Spice-devel] [PATCH 12/23] remove unused parameter from put_cursor_pipe_item

Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index 444d89b..4df5c66 100644 --- a/server/cursor-channel.c +++ b/server/cursor-channel.c @@ -203,8 +203,7 @@ voi

[Spice-devel] [PATCH 06/23] simplify release of STREAM_CREATE and STREAM_DESTROY pipe items

Signed-off-by: Frediano Ziglio --- server/dcc.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index a6d4fc4..75f5120 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -335,6 +335,28 @@ void dcc_add_drawab

[Spice-devel] [PATCH 10/23] simplify smartcard_channel_release_pipe_item

Signed-off-by: Frediano Ziglio --- server/smartcard.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index b2fb766..c8e9eb0 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -507,11 +507,7 @@ static void smartcard_channel

[Spice-devel] [PATCH 13/23] reuse RedPipeItem facilities for RedCursorPipeItem

Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index 4df5c66..2d57c59 100644 --- a/server/cursor-channel.c +++ b/server/cursor-channel.

[Spice-devel] [PATCH 05/23] simplify release of CREATE_SURFACE and DESTROY_SURFACE pipe items

Putting base as first item the default free function is fine. Signed-off-by: Frediano Ziglio --- server/dcc.c | 16 ++-- server/dcc.h | 2 +- server/display-channel.h | 2 +- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/server/dcc.c b/serv

[Spice-devel] [PATCH spice-gtk 4/4] spice-uri: Add ipv6 support

Resolves: rhbz#1335239 --- src/spice-uri.c| 25 +++-- tests/test-spice-uri.c | 43 +++ 2 files changed, 62 insertions(+), 6 deletions(-) diff --git a/src/spice-uri.c b/src/spice-uri.c index 35d773e..36e75bb 100644 --- a/src/spice

[Spice-devel] [PATCH spice-gtk 3/4] spice-uri: Set user & password to NULL when not specified

Avoid using old values after parsing a new uri. Related: rhbz#1335239 --- src/spice-uri.c| 3 +++ tests/test-spice-uri.c | 8 2 files changed, 11 insertions(+) diff --git a/src/spice-uri.c b/src/spice-uri.c index 0cc2195..35d773e 100644 --- a/src/spice-uri.c +++ b/src/spice-uri.

[Spice-devel] [PATCH spice-gtk 2/4] spice-uri: Add missing include

Related: rhbz#1335239 --- src/spice-uri.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/spice-uri.c b/src/spice-uri.c index e1317bd..0cc2195 100644 --- a/src/spice-uri.c +++ b/src/spice-uri.c @@ -22,6 +22,7 @@ #include "spice-client.h" #include "spice-uri.h" +#include "spice-uri-priv

[Spice-devel] [PATCH spice-gtk 1/4] tests: Add test for SpiceUri

Related: rhbz#1335239 --- tests/Makefile.am | 2 ++ tests/test-spice-uri.c | 64 ++ 2 files changed, 66 insertions(+) create mode 100644 tests/test-spice-uri.c diff --git a/tests/Makefile.am b/tests/Makefile.am index c1d95c1..fb97138 100644 -

[Spice-devel] [PATCH spice-gtk 0/4] Allow ipv6 proxy url

Hi, these patches add ipv6 support to SpiceUri, so it can be used in SPICE_PROXY. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335239 Pavel Grunt (4): tests: Add test for SpiceUri spice-uri: Add missing include spice-uri: Set user & password to NULL when not specified spice-uri

Re: [Spice-devel] [spice-protocol PATCH v4] LZ4 compression is now available at the Spicevmc channel

> > -New message type for compressed messages has been added to the protocol > -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added > --- > spice/enums.h| 10 ++ > spice/protocol.h | 4 > 2 files changed, 14 insertions(+) > > diff --git a/spice/enums.h b/spice/enums.

Re: [Spice-devel] [spice-gtk v3] Spice-widget: Use new gdk_event_get_scancode if available

Hi, sorry, ack. Pavel On Mon, 2016-05-16 at 06:06 -0400, Frediano Ziglio wrote: > ping... again! > > - Original Message - > > From: "Frediano Ziglio" > > To: spice-devel@lists.freedesktop.org > > Sent: Monday, May 9, 2016 12:15:15 PM > > Subject: Re: [Spice-devel] [spice-gtk v3] Spice-

Re: [Spice-devel] [spice-gtk v3] Spice-widget: Use new gdk_event_get_scancode if available

ping... again! - Original Message - > From: "Frediano Ziglio" > To: spice-devel@lists.freedesktop.org > Sent: Monday, May 9, 2016 12:15:15 PM > Subject: Re: [Spice-devel] [spice-gtk v3] Spice-widget: Use new > gdk_event_get_scancode if available > > ping > > - Original Message

[Spice-devel] [PATCH v3] stats: simplify printing statistics

Use some utility function to show and compute statistics. Signed-off-by: Frediano Ziglio --- server/display-channel.c | 131 ++- 1 file changed, 49 insertions(+), 82 deletions(-) Changes from v2: - make total computation same as initial patch. I'm not

Re: [Spice-devel] [spice-gtk v3] file-xfer: fix segfault on agent disconnection

Hi, On Mon, May 16, 2016 at 09:02:16AM +0200, Fabiano Fidêncio wrote: > On Mon, May 16, 2016 at 8:50 AM, Victor Toso wrote: > > We are checking self->priv->error but accessing the argument GError * > > which is NULL and leads to a segfault. > > > > Program received signal SIGSEGV, Segmentation fa

Re: [Spice-devel] [spice-gtk v3] file-xfer: fix segfault on agent disconnection

On Mon, May 16, 2016 at 8:50 AM, Victor Toso wrote: > We are checking self->priv->error but accessing the argument GError * > which is NULL and leads to a segfault. > > Program received signal SIGSEGV, Segmentation fault. > spice_file_transfer_task_completed (self=self@entry=0x7fffd0006f00, > err