On Mon, May 09, 2016 at 03:02:44PM +0200, Marc-André Lureau wrote:
> Hi,
>
> This is a resent of a previous series, see description in the first
> patch. Thanks!
Tested spicy on Windows XP and Fedora 23 guests.
Acked-by: Victor Toso
>
> Marc-André Lureau (3):
> gtk: add spice_main_request_mou
Hey,
On Mon, May 09, 2016 at 11:09:40AM -0400, Frediano Ziglio wrote:
> I think it's time to update this document
>
> >
> > 1. C and C++ style
> >
> > All of the following are applicable for both c and c++, except for section
> > 25
> > which is c++ extension.
> >
>
> This file is in spice
>
> Hey,
>
> On Mon, May 09, 2016 at 10:03:03AM +0100, Frediano Ziglio wrote:
> > Removing an interface cause SpiceBaseInstance->st to be set to NULL.
> > This pointer was then deferenced in agent code.
> > As SpiceBaseInstance should not be used after this call make sure
> > we don't keep pointe
I think it's time to update this document
>
> 1. C and C++ style
>
> All of the following are applicable for both c and c++, except for section 25
> which is c++ extension.
>
This file is in spice-server which is not much C++ but this paragraph is
not going to hurt.
> 2. Source Files
>
>
This code make easier to be sure we don't have dangling pointers
resetting in the function which free the structure.
Signed-off-by: Frediano Ziglio
---
server/char-device.c | 21 ++---
server/char-device.h | 2 +-
server/reds.c| 3 ++-
server/smartcard.c | 3 +--
ser
For the 2 patches:
Acked-by: Christophe Fergeau
On Mon, May 09, 2016 at 01:55:54PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.h | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/server/reds.h b/server/reds.h
> index f0f28da9e..efb46a0 10064
On Mon, 2016-05-09 at 10:36 +0100, Daniel P. Berrange wrote:
> On Wed, May 04, 2016 at 04:30:35AM -0400, Frediano Ziglio wrote:
> > A patch of this size cannot be accepted, no matter how good it is.
> > We need to find a way to split it.
> >
> > Any proposal would be good.
>
> There's some simple
Hi,
This is a resent of a previous series, see description in the first
patch. Thanks!
Marc-André Lureau (3):
gtk: add spice_main_request_mouse_mode()
main: do not always request client mouse mode
spicy: add toggle mouse mode menu
doc/reference/spice-gtk-sections.txt | 1 +
src/channel-m
From: Marc-André Lureau
This is just for testing, the UI could be different in better clients.
Signed-off-by: Marc-André Lureau
---
src/spicy.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/spicy.c b/src/spicy.c
index 0475530..2865678 100644
--- a/src/spicy.c
From: Marc-André Lureau
Whenever the mouse mode changed on the server, spice-gtk was requesting
client mode. Instead keep the last requested mode and request it
whenever it's possible.
Signed-off-by: Marc-André Lureau
Reviewed-by: Victor Toso
---
src/channel-main.c | 21 +
From: Marc-André Lureau
Send a SpiceMsgcMainMouseModeRequest message to request a mouse mode.
This allows to switch between client/absolute and server/relative mouse
modes.
This is necessary for some applications that require pointer
re-positioning, which we can't provide through a remote proto
On 05/09/2016 06:03 AM, Frediano Ziglio wrote:
> Removing an interface cause SpiceBaseInstance->st to be set to NULL.
> This pointer was then deferenced in agent code.
> As SpiceBaseInstance should not be used after this call make sure
> we don't keep pointers to it.
>
> Signed-off-by: Frediano Zi
- fix typo;
- simplify sentence.
Signed-off-by: Frediano Ziglio
---
server/char-device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/char-device.h b/server/char-device.h
index d05b1fd..3ac28fd 100644
--- a/server/char-device.h
+++ b/server/char-device.h
@@ -71,7 +7
Signed-off-by: Frediano Ziglio
---
server/reds.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/server/reds.h b/server/reds.h
index f0f28da9e..efb46a0 100644
--- a/server/reds.h
+++ b/server/reds.h
@@ -37,11 +37,6 @@ static inline QXLInterface * qxl_get_interface(QXLInstance
*qxl)
>
> Hi Frediano,
>
> On Mon, 2016-05-09 at 11:51 +0100, Frediano Ziglio wrote:
> > Different headers changes:
> > - order headers:
> > - system/no-spice library includes;
> > - spice-common/spice-protocol;
> maybe protocol before common (just to keep one style in all the files)?
quite strict
Hey,
On Mon, May 09, 2016 at 10:03:03AM +0100, Frediano Ziglio wrote:
> Removing an interface cause SpiceBaseInstance->st to be set to NULL.
> This pointer was then deferenced in agent code.
> As SpiceBaseInstance should not be used after this call make sure
> we don't keep pointers to it.
I gues
Hi,
On Mon, May 09, 2016 at 02:05:33PM +0200, Christophe Fergeau wrote:
> On Mon, May 09, 2016 at 02:01:05PM +0200, Victor Toso wrote:
> > Hi,
> >
> > This should be a harmless one :P
>
> Or stick with the stable 3.20 for now? Is this causing problems?
>
> Christophe
To be honest, I don't recall
On Mon, May 09, 2016 at 02:01:05PM +0200, Victor Toso wrote:
> Hi,
>
> This should be a harmless one :P
Or stick with the stable 3.20 for now? Is this causing problems?
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Hi,
This should be a harmless one :P
On Sat, Apr 30, 2016 at 09:52:05AM +0200, Victor Toso wrote:
> ---
> modulesets/spice.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modulesets/spice.xml b/modulesets/spice.xml
> index 48d3795..64df52c 100644
> --- a/modulesets/
Hi Frediano,
On Mon, 2016-05-09 at 11:51 +0100, Frediano Ziglio wrote:
> Different headers changes:
> - order headers:
> - system/no-spice library includes;
> - spice-common/spice-protocol;
maybe protocol before common (just to keep one style in all the files)?
> - spice-server;
> - every he
On Mon, 2016-05-09 at 11:51 +0100, Frediano Ziglio wrote:
> This include was just including another file
>
The same thing can be done for spice-gtk
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/Makefile.am | 1 -
> server/display-channel.h | 3 ++-
> server/red-
On Mon, 2016-05-09 at 11:51 +0100, Frediano Ziglio wrote:
> The include directory is specified with the -I which is the directory
> used directly by #include<>.
ok,
>
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/cache-item.h | 2 +-
> server/cursor-channel
ping
- Original Message -
> From: "Frediano Ziglio"
> To: spice-devel@lists.freedesktop.org
> Cc: "Frediano Ziglio"
> Sent: Monday, April 25, 2016 4:36:45 PM
> Subject: [spice-gtk v3] Spice-widget: Use new gdk_event_get_scancode if
> available
>
> This new Gdk API allows in Windows to
Hi,
On Mon, May 09, 2016 at 10:38:11AM +0200, Pavel Grunt wrote:
> On Mon, 2016-05-09 at 10:31 +0200, Victor Toso wrote:
> > Hi,
> >
> > On Fri, May 06, 2016 at 01:50:31PM +0200, Victor Toso wrote:
> > > From WTSRegisterSessionNotification() we are aware of session changes
> > > (WM_WTSSESSION_CH
On Mon, 2016-05-09 at 11:09 +0200, Christophe Fergeau wrote:
> On Fri, May 06, 2016 at 05:14:50PM +0200, Pavel Grunt wrote:
> > It is not needed since spice-server commit
> > c5c176a5c7718177f23b07981556b5d460627498
>
> I assume this has 0 impact on spice-gtk either?
>
Yes, I think it has not bee
On Mon, 2016-05-09 at 06:05 -0400, Frediano Ziglio wrote:
> >
> >
> > On Sat, May 07, 2016 at 09:38:07AM -0400, Frediano Ziglio wrote:
> > > >
> > > > Silence compile-time warning with clang:
> > > > comparison of constant 16 with expression of type 'SpiceROP' is always
> > > > true [-Wtautolo
Different headers changes:
- order headers:
- system/no-spice library includes;
- spice-common/spice-protocol;
- spice-server;
- every header must be auto sufficient;
- use definition include only if necessary.
Signed-off-by: Frediano Ziglio
---
server/agent-msg-filter.h | 9 ++-
The include directory is specified with the -I which is the directory
used directly by #include<>.
Signed-off-by: Frediano Ziglio
---
server/cache-item.h | 2 +-
server/cursor-channel.c | 2 +-
server/dcc-encoders.h | 4 ++--
server/dcc-send.c | 4
This include was just including another file
Signed-off-by: Frediano Ziglio
---
server/Makefile.am | 1 -
server/display-channel.h | 3 ++-
server/red-qxl.c | 2 +-
server/sw-canvas.c | 2 +-
server/sw-canvas.h | 22 --
5 files changed, 4 inserti
Various patches doing some cleanup with headers.
First two are quite easy and small.
Last one is the main one trying to reduce the hell of
dependencies. It's not complete but it's quite ready for
discussions.
Frediano Ziglio (3):
use #include<> style for spice-common header inclusions.
remove
>
> On Sat, May 07, 2016 at 09:38:07AM -0400, Frediano Ziglio wrote:
> > >
> > > Silence compile-time warning with clang:
> > > comparison of constant 16 with expression of type 'SpiceROP' is always
> > > true [-Wtautological-constant-out-of-range-compare]
> > > ---
> > > common/pixman_utils.c
Hello,
this list is for Spice the VDI protocol, not Spice the Circuit
simulator. What you're probably looking for is some of ngspice project
mailing lists: http://ngspice.sourceforge.net/mlarch.html
David
On Ne, 2016-05-08 at 19:31 +0800, jakkula bhoolaxmi wrote:
> Dear Sir/Madam,
>
>
> I have
Hey,
I believe you are confusing us (
https://en.wikipedia.org/wiki/SPICE_%28protocol%29 )
with https://en.wikipedia.org/wiki/SPICE
This mailing list has nothing to do with electronic circuits
modeling/simulation, but is about remote access to virtual machines.
Christophe
On Sun, May 08, 2016 at
On Wed, May 04, 2016 at 04:30:35AM -0400, Frediano Ziglio wrote:
> A patch of this size cannot be accepted, no matter how good it is.
> We need to find a way to split it.
>
> Any proposal would be good.
There's some simple things which could be done ahead of the main conversion
to GObject.
- AP
Right now, `spice_auto.html` reads the path from query string .. and
never actually does anything with it. This should make
`spice_auth.html` respect a path parametr when given.
---
spice_auto.html | 4
1 file changed, 4 insertions(+)
diff --git a/spice_auto.html b/spice_auto.html
index 571
Hi,
On Sat, May 07, 2016 at 09:59:09AM -0400, Frediano Ziglio wrote:
> A bit OT but on the same page.
>
> I used the drag&drop feature and it's quite useful.
> It's not however perfectly integrated. Would be really good if user could for
> instance
> drop from the client to a specific explorer wi
On Fri, May 06, 2016 at 05:14:50PM +0200, Pavel Grunt wrote:
> It is not needed since spice-server commit
> c5c176a5c7718177f23b07981556b5d460627498
I assume this has 0 impact on spice-gtk either?
Christophe
signature.asc
Description: PGP signature
__
On Sat, May 07, 2016 at 09:38:07AM -0400, Frediano Ziglio wrote:
> >
> > Silence compile-time warning with clang:
> > comparison of constant 16 with expression of type 'SpiceROP' is always
> > true [-Wtautological-constant-out-of-range-compare]
> > ---
> > common/pixman_utils.c | 4 ++--
> > co
Removing an interface cause SpiceBaseInstance->st to be set to NULL.
This pointer was then deferenced in agent code.
As SpiceBaseInstance should not be used after this call make sure
we don't keep pointers to it.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 1 +
1 file changed, 1 insertion
On Mon, 2016-05-09 at 10:31 +0200, Victor Toso wrote:
> Hi,
>
> On Fri, May 06, 2016 at 01:50:31PM +0200, Victor Toso wrote:
> > From WTSRegisterSessionNotification() we are aware of session changes
> > (WM_WTSSESSION_CHANGE) such as Lock/Unlock events.
> >
> > We can use that to disable features
Hi,
On Fri, May 06, 2016 at 01:50:31PM +0200, Victor Toso wrote:
> From WTSRegisterSessionNotification() we are aware of session changes
> (WM_WTSSESSION_CHANGE) such as Lock/Unlock events.
>
> We can use that to disable features such as drag-and-drop.
> Resolves: https://bugzilla.redhat.com/show_
Hi Frediano,
It looks good to me. I would prefer to keep the patches separated.
Pavel
On Sat, 2016-05-07 at 14:49 +0100, Frediano Ziglio wrote:
> This is a kind of replacement to the "Move CommonGraphicsChannelClient
> to a separate file" refactory patch. The idea came after looking at
> the pat
42 matches
Mail list logo
