Re: [Spice-devel] [vdagent-windows v1] vdagent-win: check for locked session

2016-05-06 Thread Victor Toso
Hi, On Fri, May 06, 2016 at 05:49:03PM +0200, Fabiano Fidêncio wrote: > On Fri, May 6, 2016 at 5:35 PM, Victor Toso wrote: > > Hi, > > > > On Fri, May 06, 2016 at 05:21:40PM +0200, Pavel Grunt wrote: > >> Hey, it looks good. But according to docs, it will not work on WinXP > >> > >> https://msdn.

Re: [Spice-devel] [vdagent-windows v1] vdagent-win: check for locked session

2016-05-06 Thread Fabiano Fidêncio
On Fri, May 6, 2016 at 5:35 PM, Victor Toso wrote: > Hi, > > On Fri, May 06, 2016 at 05:21:40PM +0200, Pavel Grunt wrote: >> Hey, it looks good. But according to docs, it will not work on WinXP >> >> https://msdn.microsoft.com/en-us/library/windows/desktop/aa383828%28v=vs.85%29.a >> spx >> Okay.

Re: [Spice-devel] [vdagent-windows v1] vdagent-win: check for locked session

2016-05-06 Thread Victor Toso
Hi, On Fri, May 06, 2016 at 05:21:40PM +0200, Pavel Grunt wrote: > Hey, it looks good. But according to docs, it will not work on WinXP > > https://msdn.microsoft.com/en-us/library/windows/desktop/aa383828%28v=vs.85%29.a > spx > > Pavel Interesting, I did not see that. Thanks! I would still keep

Re: [Spice-devel] [vdagent-windows v1] vdagent-win: check for locked session

2016-05-06 Thread Pavel Grunt
Hey, it looks good. But according to docs, it will not work on WinXP https://msdn.microsoft.com/en-us/library/windows/desktop/aa383828%28v=vs.85%29.a spx Pavel On Fri, 2016-05-06 at 13:50 +0200, Victor Toso wrote: > From WTSRegisterSessionNotification() we are aware of session changes > (WM_WTSS

[Spice-devel] [PATCH spice-common 3/3] SpiceROP: Do not compare to constant

2016-05-06 Thread Pavel Grunt
Silence compile-time warning with clang: comparison of constant 16 with expression of type 'SpiceROP' is always true [-Wtautological-constant-out-of-range-compare] --- common/pixman_utils.c | 4 ++-- common/pixman_utils.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/co

[Spice-devel] [PATCH spice-common 2/3] test-logging: Include stdlib.h for _Exit()

2016-05-06 Thread Pavel Grunt
--- tests/test-logging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-logging.c b/tests/test-logging.c index b7ca616..1ae4e00 100644 --- a/tests/test-logging.c +++ b/tests/test-logging.c @@ -22,6 +22,7 @@ #define SPICE_LOG_DOMAIN G_LOG_DOMAIN #include +#include #include

[Spice-devel] [PATCH spice-common 1/3] Remove GL support

2016-05-06 Thread Pavel Grunt
It is not needed since spice-server commit c5c176a5c7718177f23b07981556b5d460627498 --- common/Makefile.am | 12 - common/gl_canvas.c | 911 --- common/gl_canvas.h | 45 -- common/gl_utils.h | 59 -- common/glc.c | 1510

Re: [Spice-devel] [PATCH 2/2] Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"

2016-05-06 Thread Eduardo Lima (Etrunko)
On 05/06/2016 08:19 AM, Frediano Ziglio wrote: >> >> Hi, >> >> On Fri, May 06, 2016 at 12:11:46PM +0200, Victor Toso wrote: >>> Hi, >>> >>> On Thu, May 05, 2016 at 01:33:05PM +0100, Frediano Ziglio wrote: This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b. This patch causes bug

[Spice-devel] [vdagent-windows v1] vdagent-win: check for locked session

2016-05-06 Thread Victor Toso
From WTSRegisterSessionNotification() we are aware of session changes (WM_WTSSESSION_CHANGE) such as Lock/Unlock events. We can use that to disable features such as drag-and-drop. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1323628 --- vdagent/vdagent.cpp | 20 +++- 1 fi

Re: [Spice-devel] [PATCH 2/2] Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"

2016-05-06 Thread Frediano Ziglio
> > Hi, > > On Fri, May 06, 2016 at 12:11:46PM +0200, Victor Toso wrote: > > Hi, > > > > On Thu, May 05, 2016 at 01:33:05PM +0100, Frediano Ziglio wrote: > > > This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b. > > > This patch causes bug as sin->st can be NULL in some cases. > > > op

Re: [Spice-devel] [PATCH 2/2] Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"

2016-05-06 Thread Victor Toso
Hi, On Fri, May 06, 2016 at 12:11:46PM +0200, Victor Toso wrote: > Hi, > > On Thu, May 05, 2016 at 01:33:05PM +0100, Frediano Ziglio wrote: > > This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b. > > This patch causes bug as sin->st can be NULL in some cases. > > opaque is always referr

Re: [Spice-devel] [PATCH 2/2] Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"

2016-05-06 Thread Victor Toso
Hi, On Thu, May 05, 2016 at 01:33:05PM +0100, Frediano Ziglio wrote: > This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b. > This patch causes bug as sin->st can be NULL in some cases. > opaque is always referring to RedsState. > This patch fixes (avoids?) crash that happens when I rebo

Re: [Spice-devel] [PATCH 1/2 v3] remove dangling pointer for RedCharDeviceVDIPort

2016-05-06 Thread Victor Toso
Hi, On Fri, May 06, 2016 at 05:58:19AM -0400, Frediano Ziglio wrote: > > > > Hey, > > > > On Thu, May 05, 2016 at 05:03:58PM +0100, Frediano Ziglio wrote: > > > When a client disconnects remove it from the list of clients connected > > > to the spice char-device. > > > > > > This was caused by c

Re: [Spice-devel] [PATCH 1/2 v3] remove dangling pointer for RedCharDeviceVDIPort

2016-05-06 Thread Frediano Ziglio
> > Hey, > > On Thu, May 05, 2016 at 05:03:58PM +0100, Frediano Ziglio wrote: > > When a client disconnects remove it from the list of clients connected > > to the spice char-device. > > > > This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb > > ("reds: Make VDIPortState a GObject

Re: [Spice-devel] [client v14 24/29] spice-gtk: Rename num_drops_on_receive to arrive_late_count

2016-05-06 Thread Pavel Grunt
On Wed, 2016-05-04 at 11:44 +0200, Francois Gouget wrote: > The frame may not get dropped once that's left up to video decoders. > Also the debug message should be adjusted to the change. > Signed-off-by: Francois Gouget Acked-by: Pavel Grunt > --- >  src/channel-display-priv.h | 2 +- >  src/c

Re: [Spice-devel] [PATCH 1/2 v3] remove dangling pointer for RedCharDeviceVDIPort

2016-05-06 Thread Victor Toso
Hey, On Thu, May 05, 2016 at 05:03:58PM +0100, Frediano Ziglio wrote: > When a client disconnects remove it from the list of clients connected > to the spice char-device. > > This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb > ("reds: Make VDIPortState a GObject") as the lifespan

Re: [Spice-devel] [client v14 23/29] spice-gtk: Optimize handling of the decoded frame buffer

2016-05-06 Thread Pavel Grunt
On Wed, 2016-05-04 at 11:44 +0200, Francois Gouget wrote: > The MJPEG decoder does not need a zero-filled buffer. > > Signed-off-by: Francois Gouget Acked-by: Pavel Grunt > --- >  src/channel-display-mjpeg.c | 9 +++-- >  1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/c

Re: [Spice-devel] [client v14 22/29] spice-gtk: Enable adding alternative video decoders

2016-05-06 Thread Pavel Grunt
Hi, On Wed, 2016-05-04 at 11:44 +0200, Francois Gouget wrote: > This replaces the original channel-display-mjpeg API with a VideoDecoder > base class which can be reimplemented by other decoders. > Furthermore this moves the MJPEG-specific state information from the > display_stream struct to a de

[Spice-devel] [PATCH 1/6] Move MainChannelClient to separate file

2016-05-06 Thread Frediano Ziglio
From: Jonathon Jongsma Preparation for converting to GObject --- server/Makefile.am | 2 + server/inputs-channel.c | 2 +- server/main-channel-client.c | 552 ++ server/main-channel-client.h | 163 server/main-channel.c|

[Spice-devel] [PATCH 3/6] move main_channel_release_pipe_item and main_channel_send_item to client

2016-05-06 Thread Frediano Ziglio
These functions deals with client, not with entire channel. This avoid some poking some internals of MainChannelClient. Signed-off-by: Frediano Ziglio --- server/main-channel-client.c | 375 +-- server/main-channel-client.h | 51 +- server/main-channe

[Spice-devel] [PATCH 5/6] move all item creation in main-channel-client.c

2016-05-06 Thread Frediano Ziglio
Move all core to create and destroy MainChannel pipe items in a single place. Signed-off-by: Frediano Ziglio --- server/main-channel-client.c | 34 ++ server/main-channel-client.h | 15 +-- server/main-channel.c| 29 +---

[Spice-devel] [PATCH 0/6] Improve "Move MainChannelClient to separate file" patch

2016-05-06 Thread Frediano Ziglio
These patches contains changes to the original patch. Patches could be squashed to the original one. Decided to send as a series to make easier discussion and possible changes. Frediano Ziglio (5): some minor cleanup on previous patch move main_channel_release_pipe_item and main_channel_send_i

[Spice-devel] [PATCH 6/6] change main_channel_marshall_mouse_mode call style

2016-05-06 Thread Frediano Ziglio
Make the call more similar to other marshall function calls in the same function. Signed-off-by: Frediano Ziglio --- server/main-channel-client.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/server/main-channel-client.c b/server/main-channel-client.c index 5a24323

[Spice-devel] [PATCH 2/6] some minor cleanup on previous patch

2016-05-06 Thread Frediano Ziglio
This patch should be squashed in the previous. - make some function static; - remove unused functions and structures; - remove not necessary includes; - indentation fixes. Signed-off-by: Frediano Ziglio --- server/main-channel-client.c | 11 --- server/main-channel-client.h | 16 +++-

[Spice-devel] [PATCH 4/6] let compiler manage the copy in a more typesafe way

2016-05-06 Thread Frediano Ziglio
Do not use memcpy but just copy the data Signed-off-by: Frediano Ziglio --- server/red-channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-channel.c b/server/red-channel.c index c1e3dad..4be815d 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@