When a client disconnects remove it from the list of clients connected
to the spice char-device.
This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb
("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice
was changed.
This could be reproduced with:
- start rhel7 mach
On 05/05/2016 03:54 PM, Eduardo Lima (Etrunko) wrote:
On 05/05/2016 09:33 AM, Frediano Ziglio wrote:
Frediano Ziglio (2):
remove dangling pointer for RedCharDeviceVDIPort
Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"
server/reds.c | 16 ++--
1 file change
On 05/04/2016 11:51 AM, Frediano Ziglio wrote:
On 05/03/2016 01:53 PM, Frediano Ziglio wrote:
On 05/02/2016 11:25 AM, Frediano Ziglio wrote:
This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb
("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice
was changed.
>
> >
> > This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b.
> > This patch causes bug as sin->st can be NULL in some cases.
> > opaque is always referring to RedsState.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
>
> It could be weird but I'm not sure this is the right fix to do
On 05/05/2016 10:05 AM, Frediano Ziglio wrote:
>>
>> This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b.
>> This patch causes bug as sin->st can be NULL in some cases.
>> opaque is always referring to RedsState.
>>
>> Signed-off-by: Frediano Ziglio
>> ---
>
> It could be weird but I'm n
>
> This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b.
> This patch causes bug as sin->st can be NULL in some cases.
> opaque is always referring to RedsState.
>
> Signed-off-by: Frediano Ziglio
> ---
It could be weird but I'm not sure this is the right fix to do.
Why sin->st is rese
On 05/05/2016 09:33 AM, Frediano Ziglio wrote:
> Frediano Ziglio (2):
> remove dangling pointer for RedCharDeviceVDIPort
> Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"
>
> server/reds.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
Teste
This reverts commit 0f947b425cc2219f3c5a8705f4214c2deb607a5b.
This patch causes bug as sin->st can be NULL in some cases.
opaque is always referring to RedsState.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/red
Frediano Ziglio (2):
remove dangling pointer for RedCharDeviceVDIPort
Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"
server/reds.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
--
2.5.5
___
Spice-de
This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb
("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice
was changed.
This could be reproduced with:
- start rhel7 machine
- connect remote viewer (RV)
- RV: login
- connect ssh
- SSH: stop agent
- disconnect RV
- SSH
Hi Jonathon,
there are some unrelated changes which should go in separate patch.
On Tue, 2016-05-03 at 15:00 -0500, Jonathon Jongsma wrote:
> Add a few more methods and accessors so that other files don't need to
> manipulate the struct members directly. Move the struct definition to a
> private
>
> On Tue, 2016-05-03 at 15:00 -0500, Jonathon Jongsma wrote:
> > This doesn't cause problems at the moment, because the files that
> > include this file also include the other files that are needed, but just
> > for completeness...
> For me the shortlog itself is enough. From this ^ paragraph I
>
> Preparation for converting to GObject
> ---
> server/Makefile.am | 2 +
> server/inputs-channel.c | 2 +-
> server/main-channel-client.c | 552 ++
> server/main-channel-client.h | 163
> server/main-channel.c| 616
>
On Tue, 2016-05-03 at 15:00 -0500, Jonathon Jongsma wrote:
> This doesn't cause problems at the moment, because the files that
> include this file also include the other files that are needed, but just
> for completeness...
For me the shortlog itself is enough. From this ^ paragraph I get a feeling
Compressed message type is CompressedData which contains compression
type (1 byte) followed by the uncompressed data size (4 bytes) followed
by the compressed data size (4 bytes) followed by the compressed data
---
common/client_marshallers.h | 1 +
common/messages.h | 7 +++
spice
-New message type for compressed messages has been added to the protocol
-SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added
---
spice/enums.h| 10 ++
spice/protocol.h | 4
2 files changed, 14 insertions(+)
diff --git a/spice/enums.h b/spice/enums.h
index c6e9840..cf
Compressed message type is CompressedData which contains compression
type (1 byte) followed by the uncompressed data size (4 bytes) followed
by the compressed data size (4 bytes) followed by the compressed data
If SPICE_USBREDIR_CAP_DATA_COMPRESS_LZ4 capability is available &&
data_size > COMPRESS
Compressed message type is CompressedData which contains compression
type (1 byte) followed by the uncompressed data size (4 bytes) followed
by the compressed data size (4 bytes) followed by the compressed data
If SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability is available &&
data_size > COMPRESS
On Tue, 2016-05-03 at 15:00 -0500, Jonathon Jongsma wrote:
> Allows us to not expose the client_link in RedChannelClient.
Acked-by: Pavel Grunt
> ---
> server/red-channel.c | 51 ---
> server/red-channel.h | 5 +
> 2 files changed, 29 insertio
Hi,
there is more functions using peer in name, but rcc as a parameter. Would you
mind changing all of them for consitency.
Pavel
On Tue, 2016-05-03 at 15:00 -0500, Jonathon Jongsma wrote:
> Use consistent naming
> ---
> server/red-channel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deleti
On Mon, Nov 09, 2015 at 03:02:08PM +0100, Marc-André Lureau wrote:
> Whenever the mouse mode changed on the server, spice-gtk was requesting
> client mode. Instead keep the last requested mode and request it
> whenever it's possible.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/channel-main.
On Tue, Nov 10, 2015 at 11:05:09AM +0100, Victor Toso wrote:
> Hi,
>
> On Mon, Nov 09, 2015 at 03:02:07PM +0100, Marc-André Lureau wrote:
> > Send a SpiceMsgcMainMouseModeRequest message to request a mouse mode.
> >
> > This allows to switch between client/absolute and server/relative mouse
> > mo
On Wed, May 04, 2016 at 01:01:47PM +0200, Marc-André Lureau wrote:
> Hi
>
> On Mon, Nov 16, 2015 at 4:34 PM, Victor Toso wrote:
> > Hm.. I would either prefer that mouse mode did not change if it can't
> > because the function and its documentation suggested that it will only
> > try to change th
23 matches
Mail list logo
