On Wed, May 4, 2016 at 6:41 PM, Visarion-Mingopol Alexandru-Viorel
wrote:
> Sure :)
Pushed!
>
> On Wed, May 4, 2016 at 7:33 PM, Fabiano Fidêncio
> wrote:
>>
>> Visarion,
>>
>> On Wed, May 4, 2016 at 5:19 PM, Alexandru Visarion
>> wrote:
>> > From: Visarion-Mingopol Alexandru
>> >
>> > There i
On 05/04/2016 05:51 AM, Frediano Ziglio wrote:
>>
>>>
>>> Honestly more I look at the patch and this fix and more I think it's all
>>> a big bug...
>>> What I know for sure is that this patch fix a dandling pointer.
>>
>> That's true.
>> But I think we should have a better fix that does not ignore
Visarion,
On Wed, May 4, 2016 at 5:19 PM, Alexandru Visarion
wrote:
> From: Visarion-Mingopol Alexandru
>
> There is no reason to not include the spice_get_option_group
> method in the generated bindings, as it can be useful.
>
> It was removed in the commit 2db9b8dd037e22d2b04e8e2aeecfd685524b7
On 05/04/2016 07:57 AM, Pavel Grunt wrote:
> Spotted by coverity
Tested, acked, and pushed.
Thanks,
Jeremy
> ---
> filexfer.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/filexfer.js b/filexfer.js
> index beabfd8..d850db2 100644
> --- a/filexfer.js
> +++ b/filexfe
From: Visarion-Mingopol Alexandru
There is no reason to not include the spice_get_option_group
method in the generated bindings, as it can be useful.
It was removed in the commit 2db9b8dd037e22d2b04e8e2aeecfd685524b7fef,
for the reason of causing warnings, but no warnings show up now.
---
src/s
Both patches look fine to me.
On Wed, 2016-05-04 at 14:57 +0200, Pavel Grunt wrote:
> Spotted by coverity
> ---
> filexfer.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/filexfer.js b/filexfer.js
> index beabfd8..d850db2 100644
> --- a/filexfer.js
> +++ b/filexfer.j
On Wed, 2016-05-04 at 04:30 -0400, Frediano Ziglio wrote:
> A patch of this size cannot be accepted, no matter how good it is.
> We need to find a way to split it.
>
> Any proposal would be good.
>
> Frediano
Yeah, I will attempt a split. Fortunately, the large patches are at the end of
the ser
Acked-by: Frediano Ziglio
> ---
> server/agent-msg-filter.c | 1 +
> server/agent-msg-filter.h | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c
> index 498864c..25edfd9 100644
> --- a/server/agent-msg-filter.c
> ++
On Wed, May 04, 2016 at 09:09:41AM -0300, Eduardo Lima (Etrunko) wrote:
> The thing to notice here is that we are talking about two different
> events, one is configure and the other one is make. Make depends on the
> results of configure, but there is no way to know, at configure time,
> which arg
Spotted by coverity
---
quic.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/quic.js b/quic.js
index 9bb9f47..22ea3c7 100644
--- a/quic.js
+++ b/quic.js
@@ -280,6 +280,7 @@ function QuicModel(bpc)
case 2:
case 4:
console.log("quic: findmodelparams(): evol valu
Spotted by coverity
---
filexfer.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/filexfer.js b/filexfer.js
index beabfd8..d850db2 100644
--- a/filexfer.js
+++ b/filexfer.js
@@ -81,7 +81,7 @@ function handle_file_drop(e)
e.preventDefault();
for (var i = files.length
On Wed, May 4, 2016 at 8:45 AM, Alexandru Visarion
wrote:
> From: Visarion-Mingopol Alexandru
>
> There is no reason to not include the spice_get_option_group
> method in the generated bindings, as it can be useful.
Seems the skip added on commit
2db9b8dd037e22d2b04e8e2aeecfd685524b7fef when fix
On 05/04/2016 06:23 AM, Uri Lublin wrote:
> On 05/03/2016 06:36 PM, Frediano Ziglio wrote:
>>>
>>> On 05/02/2016 07:39 AM, Uri Lublin wrote:
On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote:
> The problem happens when you run 'make dist' in a system without
> asciidoc installed. Ev
---
server/agent-msg-filter.c | 1 +
server/agent-msg-filter.h | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c
index 498864c..25edfd9 100644
--- a/server/agent-msg-filter.c
+++ b/server/agent-msg-filter.c
@@ -22,6 +22,7 @@
On Wed, 2016-05-04 at 12:04 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/char-device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/char-device.h b/server/char-device.h
> index d05b1fd..25fa6ff 100644
> --- a/server/char-device.
On Wed, 2016-05-04 at 12:04 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
> ---
> server/char-device.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/char-device.c b/server/char-device.c
> index 6e612ba..055b232 100644
> --- a/server/char-
On Wed, May 04, 2016 at 12:03:57PM +0200, Christophe Fergeau wrote:
> Ugh that's bad :( Using gst_message_new_request_state() might avoid
> this, but while the GstAppSink element is blocked waiting for data, I
> don't know if state changes are going to be handled (ie I'm not sure
> about GStreamer
Signed-off-by: Frediano Ziglio
---
server/char-device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/char-device.h b/server/char-device.h
index d05b1fd..25fa6ff 100644
--- a/server/char-device.h
+++ b/server/char-device.h
@@ -71,7 +71,7 @@ struct RedCharDeviceClass
Signed-off-by: Frediano Ziglio
---
server/char-device.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/char-device.c b/server/char-device.c
index 6e612ba..055b232 100644
--- a/server/char-device.c
+++ b/server/char-device.c
@@ -49,7 +49,6 @@ struct RedCharDevicePrivate {
int runni
Hi
On Mon, Nov 16, 2015 at 4:34 PM, Victor Toso wrote:
> Hm.. I would either prefer that mouse mode did not change if it can't
> because the function and its documentation suggested that it will only
> try to change the mouse mode.
I am testing this series again, and trying to understand your is
On Wed, May 04, 2016 at 11:21:13AM +0200, Francois Gouget wrote:
> On Tue, 3 May 2016, Christophe Fergeau wrote:
> [...]
> > And GStreamer GstBus/GstAppSink API tends to be async, while we need
> > encode_frame() to be sync, so there is indeed several useful APIs that
> > we cannot use without addi
>
> This replaces the original mjpeg_encoder API with a VideoEncoder base
> class which can be reimplemented by other encoders.
> This also renames the members and enums from mjpeg_* to video_*.
>
> Signed-off-by: Francois Gouget
Merged
Frediano
> ---
> server/Makefile.am | 2 +-
> se
>
> We may get stream reports after the stream has been closed, and even, in
> extreme cases, after a new stream has started reusing the same stream
> id. Neither case should cause the server to crash.
> So restore dcc_handle_stream_report() to how it was before being moved
> to dcc.c.
>
> Signed
>
> Using spicevmc_red_channel_client_get_state(rcc) (which already
> exists) instead of SPICE_CONTAINEROF(rcc->channel, SpiceVmcState,
> channel).
> ---
> server/spicevmc.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/server/spicevmc.c b/server
This makes it possible to test the GStreamer video decoder with MJPEG
streams.
Signed-off-by: Francois Gouget
---
configure.ac | 11 +++
src/Makefile.am| 7 ++-
src/channel-display-priv.h | 2 ++
src/channel-display.c | 5 +
4 files changed, 24 i
This means future video codecs may be supported automatically.
One can also force usage of decodebin by setting $SPICE_GSTVIDEO_AUTO.
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/channel-dis
Signed-off-by: Francois Gouget
---
src/channel-display-gst.c | 17 +++--
src/channel-display-priv.h | 4 ++--
src/channel-display.c | 21 +
3 files changed, 34 insertions(+), 8 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
The frame may not get dropped once that's left up to video decoders.
Signed-off-by: Francois Gouget
---
src/channel-display-priv.h | 2 +-
src/channel-display.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/channel-display-priv.h b/src/channel-display-priv
configure will use GStreamer 1.0 if present and fall back to
GStreamer 0.10 otherwise.
ffenc_mjpeg takes its bitrate as a long so extend set_gstenc_bitrate().
Signed-off-by: Francois Gouget
---
configure.ac | 36 ++---
server/Makefile.am | 8 +++
server/gstreamer
Signed-off-by: Francois Gouget
---
src/channel-display-mjpeg.c | 142 ---
src/channel-display-priv.h | 10 ++-
src/channel-display.c | 201 +++-
3 files changed, 189 insertions(+), 164 deletions(-)
diff --git a/src/chann
The MJPEG decoder does not need a zero-filled buffer.
Signed-off-by: Francois Gouget
---
src/channel-display-mjpeg.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/channel-display-mjpeg.c b/src/channel-display-mjpeg.c
index c7e1c6f..927827b 100644
--- a/src/chan
Signed-off-by: Francois Gouget
---
examples/spiceqxl.xorg.conf.example | 7 +++
src/qxl.h | 1 +
src/qxl_driver.c| 2 ++
src/spiceqxl_spice_server.c | 15 +++
4 files changed, 25 insertions(+)
diff --git a/examples/spiceqxl
Signed-off-by: Francois Gouget
---
configure.ac | 26 ++-
src/Makefile.am| 8 +
src/channel-display-gst.c | 433 +
src/channel-display-priv.h | 6 +
src/channel-display.c | 10 ++
5 files changed, 482 insertions(+),
Signed-off-by: Francois Gouget
---
scripts/Xspice | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 15a5a5e..bf8112f 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -87,6 +87,7 @@ parser.add_argument('--zlib-glz-wan-compression',
# TO
This is faster and lets the encoder leverage past bitrate shaping
history to attain the target faster.
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/server/gstreamer-encoder.c b/server/gstreamer
This replaces the original channel-display-mjpeg API with a VideoDecoder
base class which can be reimplemented by other decoders.
Furthermore this moves the MJPEG-specific state information from the
display_stream struct to a derived class of VideoDecoder.
Signed-off-by: Francois Gouget
---
src/
This typically happens when sending very small frames (less than
16 pixels in one dimension) to the x264enc encoder.
This avoids repeatedly wasting time rebuilding the pipeline.
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 61 ++
1 f
GObject returns an error instead of clamping if given an out of range
property value.
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 67 ++
1 file changed, 50 insertions(+), 17 deletions(-)
diff --git a/server/gstreamer-encoder.c b/se
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 40 +---
1 file changed, 33 insertions(+), 7 deletions(-)
diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
index 3b223c9..2b20c99 100644
--- a/server/gstreamer-encoder.c
+++ b/
The video encoder uses the client reports and/or notifications of
server frame drops as its feedback mechanisms. In particular it keeps
track of the maximum video margin and reduces the bit rate whenever the
margin goes below certain thresholds or decreases too sharply.
It uses these to figure out
Signed-off-by: Francois Gouget
---
configure.ac | 1 +
server/gstreamer-encoder.c | 17 -
server/reds.c | 4 +++-
3 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 6093431..1e98523 100644
--- a/configure.
Note that we can only avoid copies for the first 1 Mpixels or so.
That's because Spice splits larger frames into more chunks than we can
fit GstMemory fragments in a GStreamer buffer. So if there are more
pixels we will avoid copies for the first 3840 KB and copy the rest.
Furthermore, while in pra
The GStreamer codecs don't follow the specified bit rate very closely:
they can decide to exceed it for ten seconds or more if they consider
the scene deserves it. Such long bursts are enough to cause network
congestion, resulting in many lost frames which cause significant
display corruption.
So t
This avoids getting stuck if the codec is buggy or fails to encode a
frame for whatever reason (e.g. odd frame size).
Signed-off-by: Francois Gouget
---
server/gstreamer-encoder.c | 105 ++---
1 file changed, 90 insertions(+), 15 deletions(-)
diff --git a
Signed-off-by: Francois Gouget
---
configure.ac | 1 +
server/gstreamer-encoder.c | 67 --
server/reds.c | 4 ++-
3 files changed, 63 insertions(+), 9 deletions(-)
diff --git a/configure.ac b/configure.ac
index 9904bc8..9bd
Signed-off-by: Francois Gouget
---
configure.ac | 4
server/gstreamer-encoder.c | 27 ++-
2 files changed, 30 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 9bd8ccb..6093431 100644
--- a/configure.ac
+++ b/configure.ac
@@ -
---
server/tests/replay.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index 7e4659b..025b20c 100644
--- a/server/tests/replay.c
+++ b/server/tests/replay.c
@@ -290,7 +290,7 @@ int main(int argc, char **argv)
{
This way the video encoder is not forced to use malloc()/free().
This also allows more flexibility in how the video encoder manages the
buffer which allows for a zero-copy implementation in both video
encoders.
Signed-off-by: Francois Gouget
---
server/dcc-send.c | 25 +++---
se
The Spice server administrator can specify the encoder and codec
preferences to optimize for CPU or bandwidth usage. Preferences are
described in a semi-colon separated list of encoder:codec pairs.
The server has a default preference list which can explicitly be
selected by specifying 'auto'.
Sign
The server picks a codec supported by the client based on the following
new client capabilities:
* SPICE_DISPLAY_CAP_MULTI_CODEC which denotes a recent client that
supports multiple codecs. This capability is needed to not have to
hardcode that MJPEG is supported. This makes it possible to w
This introduces a pared down GStreamer-based video encoder to serve as
the basis for later enhancements.
In this form the new encoder supports both regular and sized streams
but lacks any rate control. It should still work fine if bandwidth is
sufficient such as on LANs.
Signed-off-by: Francois Go
This replaces the original mjpeg_encoder API with a VideoEncoder base
class which can be reimplemented by other encoders.
This also renames the members and enums from mjpeg_* to video_*.
Signed-off-by: Francois Gouget
---
server/Makefile.am | 2 +-
server/dcc-send.c | 27 +
s
We may get stream reports after the stream has been closed, and even, in
extreme cases, after a new stream has started reusing the same stream
id. Neither case should cause the server to crash.
So restore dcc_handle_stream_report() to how it was before being moved
to dcc.c.
Signed-off-by: Francois
This patch series adds support for using GStreamer to encode and
decode the video streams, adding support for VP8 and h264 codecs.
As before the patches can also be grabbed from the gst branch of the
repositories below:
spice: https://github.com/fgouget/spice
spice-gtk: https://gi
On Tue, 2016-05-03 at 19:40 +0200, Marc-André Lureau wrote:
> On Tue, May 3, 2016 at 7:36 PM, Marc-André Lureau
> wrote:
> > +gtk_container_add(GTK_CONTAINER(display), d->stack);
>
>
> better with GTK_WIDGET() to avoid the warning, fixed
>
Thank you, ack
Pavel
On 05/03/2016 06:36 PM, Frediano Ziglio wrote:
On 05/02/2016 07:39 AM, Uri Lublin wrote:
On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote:
The problem happens when you run 'make dist' in a system without
asciidoc installed. Even though in configure time there is a check for
building the ma
On Tue, May 3, 2016 at 1:31 PM, Frediano Ziglio wrote:
>>
>> Frediano,
>>
>> On Tue, May 3, 2016 at 11:26 AM, Frediano Ziglio wrote:
>> > This program attempt multiple redirection combination:
>> > - passing handles using either CreateProcess or SetStdHandle;
>> > - having a console or not;
>> >
On Mon, May 2, 2016 at 11:43 PM, Fabiano Fidêncio wrote:
> On Fri, Apr 29, 2016 at 4:09 PM, Frediano Ziglio wrote:
>> This patch allows remote-viewer to redirect output/error streams to
>> files.
>> Also if launched from a console program (for instance from the command
>> prompt) you are able to
On Wed, 2016-05-04 at 05:12 -0400, Frediano Ziglio wrote:
> >
> >
> > Hi,
> >
> > as I said - switch to vt (ctrl+alt+fx), start typing, press capslock, it
> > will
> > bump after a while
> >
>
> Pavel... this is based on a known bug in the console handling keyboard leds
> and current code read
On Tue, 3 May 2016, Christophe Fergeau wrote:
[...]
> And GStreamer GstBus/GstAppSink API tends to be async, while we need
> encode_frame() to be sync, so there is indeed several useful APIs that
> we cannot use without additional complexity. I'm wondering if the
> simpler patch attached to this me
>
> Hi,
>
> as I said - switch to vt (ctrl+alt+fx), start typing, press capslock, it will
> bump after a while
>
Pavel... this is based on a known bug in the console handling keyboard leds
and current code reading leds.
> another example - open a text editor - press a key and keep it pressed,
Hi,
On Tue, May 03, 2016 at 11:37:43AM -0500, Jonathon Jongsma wrote:
> On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote:
> > Change cancel_file_xfer() helper function to file_xfer_status() so we
> > can send other status to the client.
>
> I like the idea, though I'd prefer a verb in the func
>
> On 05/03/2016 01:53 PM, Frediano Ziglio wrote:
> >>
> >> On 05/02/2016 11:25 AM, Frediano Ziglio wrote:
> >>> This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb
> >>> ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice
> >>> was changed.
> >>>
> >>> This coul
A patch of this size cannot be accepted, no matter how good it is.
We need to find a way to split it.
Any proposal would be good.
Frediano
>
> When using private structs with GObject, there's a maximum size of (I
> think) 64k, which was exceeded by the DisplayChannel object. To make
> this work
From: Visarion-Mingopol Alexandru
There is no reason to not include the spice_get_option_group
method in the generated bindings, as it can be useful.
---
src/spice-option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-option.c b/src/spice-option.c
index 46ae530..
On Wed, 2016-05-04 at 09:12 +0200, Pavel Grunt wrote:
> Hey,
>
> On Tue, 2016-05-03 at 15:00 -0500, Jonathon Jongsma wrote:
> > This is a public RedClient API that handles updating itself rather than
> > having the RedChannelClient poke around at the internal structure in
> > rec_channel_client_se
Hey,
On Tue, 2016-05-03 at 15:00 -0500, Jonathon Jongsma wrote:
> This is a public RedClient API that handles updating itself rather than
> having the RedChannelClient poke around at the internal structure in
> rec_channel_client_seamless_migration_done().
It looks good, I would drop the rcc para
67 matches
Mail list logo
