Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

2016-05-03 Thread Pavel Grunt
On Tue, 2016-05-03 at 14:56 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi Marc-André, > > > > On Tue, 2016-05-03 at 20:15 +0200, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt wrote: > > > > This patches introduces and us

[Spice-devel] [PATCH 12/14] Generate GTypes for spice-server enums

2016-05-03 Thread Jonathon Jongsma
--- server/Makefile.am | 31 +++ 1 file changed, 31 insertions(+) diff --git a/server/Makefile.am b/server/Makefile.am index f5822ad..4337dbf 100644 --- a/server/Makefile.am +++ b/server/Makefile.am @@ -64,6 +64,8 @@ libspice_serverinclude_HEADERS = \

[Spice-devel] [PATCH 01/14] Add red_client_seamless_migration_done_for_channel()

2016-05-03 Thread Jonathon Jongsma
This is a public RedClient API that handles updating itself rather than having the RedChannelClient poke around at the internal structure in rec_channel_client_seamless_migration_done(). --- server/red-channel.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletio

[Spice-devel] [PATCH 03/14] Move InputsChannelClient to a separate file

2016-05-03 Thread Jonathon Jongsma
Preparation for converting to GObject --- server/Makefile.am | 2 + server/inputs-channel-client.c | 92 ++ server/inputs-channel-client.h | 44 server/inputs-channel.c| 76 ++ server/

[Spice-devel] [PATCH 08/14] Add missing include to red-pipe-item.h

2016-05-03 Thread Jonathon Jongsma
This doesn't cause problems at the moment, because the files that include this file also include the other files that are needed, but just for completeness... --- server/red-pipe-item.h | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red-pipe-item.h b/server/red-pipe-item.h index 8bb12b

[Spice-devel] [PATCH 11/14] Move CursorChannelClient to separate file

2016-05-03 Thread Jonathon Jongsma
--- server/Makefile.am | 2 + server/cursor-channel-client.c | 122 + server/cursor-channel-client.h | 44 +++ server/cursor-channel.c| 104 --- server/cursor-channel.h| 15 + se

[Spice-devel] [PATCH 05/14] rename red_channel_peer_ function to red_channel_client_

2016-05-03 Thread Jonathon Jongsma
Use consistent naming --- server/red-channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 64c61ca..898036a 100644 --- a/server/red-channel.c +++ b/server/red-channel.c @@ -597,7 +597,7 @@ static inline void red_channel

[Spice-devel] [PATCH 06/14] Replace RedClient::channels with GList

2016-05-03 Thread Jonathon Jongsma
Allows us to not expose the client_link in RedChannelClient. --- server/red-channel.c | 51 --- server/red-channel.h | 5 + 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index 898036

[Spice-devel] [PATCH 09/14] Move CommonGraphicsChannelClient to a separate file

2016-05-03 Thread Jonathon Jongsma
This reduces the direct access to the struct in preparation for GObjectification --- server/Makefile.am | 3 ++ server/common-graphics-channel-client-private.h | 29 server/common-graphics-channel-client.c | 60 + server/co

[Spice-devel] [PATCH 07/14] Limit direct access to DisplayChannelClient

2016-05-03 Thread Jonathon Jongsma
Add a few more methods and accessors so that other files don't need to manipulate the struct members directly. Move the struct definition to a private header which only the dcc-* files will include. --- server/Makefile.am | 1 + server/dcc-encoders.c| 11 +++--- server/dcc-encoders.h

[Spice-devel] [PATCH 04/14] Replace RedChannel::clients with GList

2016-05-03 Thread Jonathon Jongsma
Instead of using a Ring, use a GList to store the list of channel clients. This allows us to iterate the clients without poking inside of the client struct to get the channel_link. This is required in order to make the RedChannelClient struct private. --- server/display-channel.c | 64 ---

[Spice-devel] [PATCH 00/14] Backported patches from refactory branch (May 3)

2016-05-03 Thread Jonathon Jongsma
Several patches were merged, a couple were dropped or delayed to later. Jonathon Jongsma (14): Add red_client_seamless_migration_done_for_channel() Move MainChannelClient to separate file Move InputsChannelClient to a separate file Replace RedChannel::clients with GList rename red_channe

[Spice-devel] [PATCH 02/14] Move MainChannelClient to separate file

2016-05-03 Thread Jonathon Jongsma
Preparation for converting to GObject --- server/Makefile.am | 2 + server/inputs-channel.c | 2 +- server/main-channel-client.c | 552 ++ server/main-channel-client.h | 163 server/main-channel.c| 616 +++-

Re: [Spice-devel] [PATCH 07/18] Change new_pipe_item_t function signature

2016-05-03 Thread Jonathon Jongsma
On Thu, 2016-04-28 at 13:15 -0400, Frediano Ziglio wrote: > > > > Now that pipe_item_init() does not require a RedChannelClient* argument > > anymore, the new_pipe_item_t callback function does not ever use the > > channel client object passed to it. So just remove this and simplify > > things. >

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

2016-05-03 Thread Marc-André Lureau
Hi - Original Message - > Hi Marc-André, > > On Tue, 2016-05-03 at 20:15 +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt wrote: > > > This patches introduces and uses a spice-gtk-session property > > > for disabling automatic modifiers sync. I

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

2016-05-03 Thread Pavel Grunt
Hi Marc-André, On Tue, 2016-05-03 at 20:15 +0200, Marc-André Lureau wrote: > Hi > > On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt wrote: > > This patches introduces and uses a spice-gtk-session property > > for disabling automatic modifiers sync. It can be useful in cases > > where syncing current

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

2016-05-03 Thread Marc-André Lureau
Hi On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt wrote: > This patches introduces and uses a spice-gtk-session property > for disabling automatic modifiers sync. It can be useful in cases > where syncing currently fails - eg not working leds on the guest side, > missmatch between client's and guest

Re: [Spice-devel] [PATCH spice-gtk] gtk: fix server-mode mouse

2016-05-03 Thread Marc-André Lureau
On Tue, May 3, 2016 at 7:36 PM, Marc-André Lureau wrote: > +gtk_container_add(GTK_CONTAINER(display), d->stack); better with GTK_WIDGET() to avoid the warning, fixed -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.

[Spice-devel] [PATCH spice-gtk] gtk: fix server-mode mouse

2016-05-03 Thread Marc-André Lureau
Since switching to gtkstack, server-side mouse mode has some issues with grabs. There seems to be some grab gtk+ issue, but it seems to fall under the API user responsability to have its own window when dealing with pointer grabs. And gtk+ commit 9d0e8401c (Turn stack into no-window widget) made th

Re: [Spice-devel] [spice v13 16/29] server: Give up after a while if GStreamer cannot handle the video

2016-05-03 Thread Francois Gouget
On Tue, 3 May 2016, Christophe Fergeau wrote: [...] > > I think it's useful to be able to print the name of the GStreamer > > encoder, particularly for this warning: > > > > spice_warning("GStreamer error: could not find the %s bitrate > > parameter", gstenc_name); > > Ah, for sure, I w

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

2016-05-03 Thread Francois Gouget
On Tue, 3 May 2016, Christophe Fergeau wrote: [...] > > > > + /* Copy the line */ > > > > + uint8_t *src = chunks->chunk[chunk_index].data + chunk_offset; > > > > + memcpy(dst, src, stream_stride); > > > > > > Are we guaranteed that we'll have at least 'stream_stride' bytes

Re: [Spice-devel] [PATCH spice-gtk 1/2] spice-gtk-session: Add sync modifiers property

2016-05-03 Thread Frediano Ziglio
> It will help in cases where syncing modifiers keys is complicated: > * not working leds for modifiers keys > * different keyboard layout on the guest side > --- > src/spice-gtk-session.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/src/spice-gtk-se

Re: [Spice-devel] [vdagent-linux v4 7/7] console-kit: implement check for session type

2016-05-03 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Implementing the function that was introduced in previous commit: > session_info_is_user() > > In console-kit we can gather the session type with GetSessionType api > from Session interface. This function is not

Re: [Spice-devel] [vdagent-linux v4 6/7] session-info: check if session belongs to user

2016-05-03 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > session-info back-ends such as console-kit and systemd-login have the > concept of session's class which informs if session belongs to user or > not [0]. We can disable features based on the session class. > > [0

Re: [Spice-devel] [vdagent-linux v4 4/7] session-info: check for a locked session

2016-05-03 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Each session back-end can return this information to vdagentd when > requested. > > The agent should use this on situations that should not work when > session is locked such as file-transfer-start which is fixed

Re: [Spice-devel] [vdagent-linux v4 3/7] console-kit: fix dangling pointer

2016-05-03 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Introduced recently by b1b8b71961b9a28cc4896e9973d3a3c1975ead39 > --- > src/console-kit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/console-kit.c b/src/console-kit.c > index c7e60df..6f86104 1

Re: [Spice-devel] [vdagent-linux v4 2/7] console-kit: Ignore unrequested messages from dbus

2016-05-03 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Instead of treating them as errors. > --- > src/console-kit.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/src/console-kit.c b/src/console-kit.c > index d4eecd7..c7e60d

Re: [Spice-devel] [vdagent-linux v4 1/7] vdagentd: send file-xfer status, generic version

2016-05-03 Thread Jonathon Jongsma
On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Change cancel_file_xfer() helper function to file_xfer_status() so we > can send other status to the client. I like the idea, though I'd prefer a verb in the function name to make it obvious that we're *sending* the status to the client. Some

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-03 Thread Uri Lublin
On 05/03/2016 01:53 PM, Frediano Ziglio wrote: On 05/02/2016 11:25 AM, Frediano Ziglio wrote: This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice was changed. This could be reproduced with: - start rhel7 mach

Re: [Spice-devel] [spice v13 10/29] server: Handle and recover from GStreamer encoding errors

2016-05-03 Thread Christophe Fergeau
On Tue, May 03, 2016 at 04:33:47PM +0200, Francois Gouget wrote: > On Mon, 2 May 2016, Christophe Fergeau wrote: > > > +#else > > > +gst_bus_set_sync_handler(bus, handle_pipeline_message, encoder, > > > NULL); > > > > Using _sync_handler which runs in a different thread seems quite > > compli

Re: [Spice-devel] [spice v13 16/29] server: Give up after a while if GStreamer cannot handle the video

2016-05-03 Thread Christophe Fergeau
On Tue, May 03, 2016 at 04:53:08PM +0200, Francois Gouget wrote: > On Mon, 2 May 2016, Christophe Fergeau wrote: > [...] > > > -/* A helper for spice_gst_encoder_encode_frame() */ > > > +static const gchar* get_gst_codec_name(SpiceGstEncoder *encoder) > > > +{ > > > +switch (encoder->base.codec

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

2016-05-03 Thread Christophe Fergeau
On Tue, May 03, 2016 at 03:58:58PM +0200, Francois Gouget wrote: > On Fri, 29 Apr 2016, Christophe Fergeau wrote: > [...] > > > +/* A helper for push_raw_frame() */ > > > +static inline int line_copy(SpiceGstEncoder *encoder, const SpiceBitmap > > > *bitmap, > > > +uint

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-03 Thread Frediano Ziglio
> > On 05/02/2016 07:39 AM, Uri Lublin wrote: > > On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: > >> The problem happens when you run 'make dist' in a system without > >> asciidoc installed. Even though in configure time there is a check for > >> building the manual, it is required to be b

Re: [Spice-devel] How to modify spice version?

2016-05-03 Thread Marc-André Lureau
Hi - Original Message - > >> 1) We should have specified --fallback in AC_INIT line > > > > Why "should we"? even autoconf.git (the source of the script) isn't using > > it. > > > > http://git.savannah.gnu.org/cgit/autoconf.git/tree/configure.ac > > > > Well, the fact that they are not

Re: [Spice-devel] How to modify spice version?

2016-05-03 Thread Eduardo Lima (Etrunko)
On 05/02/2016 09:46 AM, Marc-André Lureau wrote: > Hi > > On Fri, Apr 29, 2016 at 9:10 PM, Eduardo Lima (Etrunko) > wrote: >> On 04/29/2016 12:29 PM, Eduardo Lima (Etrunko) wrote: >>> On 04/28/2016 08:45 AM, Pavel Grunt wrote: Hi, On Thu, 2016-04-28 at 14:09 +0800, Chen yu wrote: >

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-03 Thread Eduardo Lima (Etrunko)
On 05/03/2016 06:08 AM, Uri Lublin wrote: > On 05/02/2016 03:32 PM, Eduardo Lima (Etrunko) wrote: >> On 05/02/2016 07:39 AM, Uri Lublin wrote: >>> On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: The problem happens when you run 'make dist' in a system without asciidoc installed. Eve

Re: [Spice-devel] [spice v13 16/29] server: Give up after a while if GStreamer cannot handle the video

2016-05-03 Thread Francois Gouget
On Mon, 2 May 2016, Christophe Fergeau wrote: [...] > > -/* A helper for spice_gst_encoder_encode_frame() */ > > +static const gchar* get_gst_codec_name(SpiceGstEncoder *encoder) > > +{ > > +switch (encoder->base.codec_type) > > +{ > > +case SPICE_VIDEO_CODEC_TYPE_MJPEG: > > +re

Re: [Spice-devel] [spice-devel]How to reduce the image resolution or definition ?

2016-05-03 Thread David Jaša
Hi, This code comment suggests that during streaming, JPG quality adjustment takes place: /* * Adjusting the stream jpeg quality and frame rate (fps): * When during_quality_eval=TRUE, we compress different frames with different * jpeg quality. By considering (1) the resulting compression ratio

Re: [Spice-devel] [spice v13 10/29] server: Handle and recover from GStreamer encoding errors

2016-05-03 Thread Francois Gouget
On Mon, 2 May 2016, Christophe Fergeau wrote: [...] > > +if (GST_MESSAGE_TYPE(msg) == GST_MESSAGE_ERROR) { > > +GError *err; > > 'err' must be set to NULL here. > > > +gchar *debug_info; > > +gst_message_parse_error(msg, &err, &debug_info); Done. Here is the explanati

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-03 Thread Frediano Ziglio
> > Hey, > > On Tue, May 03, 2016 at 06:53:49AM -0400, Frediano Ziglio wrote: > > > > Honestly more I look at the patch and this fix and more I think it's all > > a big bug... > > What I know for sure is that this patch fix a dandling pointer. > > NB: 'dangling' not 'dandling' (there is this ty

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

2016-05-03 Thread Francois Gouget
On Fri, 29 Apr 2016, Christophe Fergeau wrote: [...] > > +/* A helper for push_raw_frame() */ > > +static inline int line_copy(SpiceGstEncoder *encoder, const SpiceBitmap > > *bitmap, > > +uint32_t chunk_offset, uint32_t stream_stride, > > +u

[Spice-devel] [PATCH spice-gtk 2/2] spicy: Add option to control syncing modifiers

2016-05-03 Thread Pavel Grunt
--- src/spicy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/spicy.c b/src/spicy.c index 0475530..0826c03 100644 --- a/src/spicy.c +++ b/src/spicy.c @@ -712,6 +712,7 @@ static const char *spice_display_properties[] = { static const char *spice_gtk_session_properties[] = { "a

[Spice-devel] [PATCH spice-gtk 1/2] spice-gtk-session: Add sync modifiers property

2016-05-03 Thread Pavel Grunt
It will help in cases where syncing modifiers keys is complicated: * not working leds for modifiers keys * different keyboard layout on the guest side --- src/spice-gtk-session.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/spice-gtk-session.c b/src/spi

[Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

2016-05-03 Thread Pavel Grunt
Hi, This patches introduces and uses a spice-gtk-session property for disabling automatic modifiers sync. It can be useful in cases where syncing currently fails - eg not working leds on the guest side, missmatch between client's and guest's keyboard layout. Related: https://bugzilla.redhat.com/s

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-03 Thread Christophe Fergeau
Hey, On Tue, May 03, 2016 at 06:53:49AM -0400, Frediano Ziglio wrote: > > Honestly more I look at the patch and this fix and more I think it's all > a big bug... > What I know for sure is that this patch fix a dandling pointer. NB: 'dangling' not 'dandling' (there is this typo in the short log,

Re: [Spice-devel] [PATCH 2/2 v4] add a program to test redirection on Windows

2016-05-03 Thread Frediano Ziglio
> > Frediano, > > On Tue, May 3, 2016 at 11:26 AM, Frediano Ziglio wrote: > > This program attempt multiple redirection combination: > > - passing handles using either CreateProcess or SetStdHandle; > > - having a console or not; > > - redirection stdout/stderr yes or not. > > Would worth to me

Re: [Spice-devel] [spice-gtk EXP] Handle mismatching CapsLock

2016-05-03 Thread Pavel Grunt
Hi, as I said - switch to vt (ctrl+alt+fx), start typing, press capslock, it will bump after a while another example - open a text editor - press a key and keep it pressed, press capslock (keep pressing it) - sometimes the keys don't change, sometimes it changes and in a "second" it switches back

[Spice-devel] [vdagent-linux v4 4/7] session-info: check for a locked session

2016-05-03 Thread Victor Toso
Each session back-end can return this information to vdagentd when requested. The agent should use this on situations that should not work when session is locked such as file-transfer-start which is fixed by this patch. systemd-login is the only back-end implementing this function at the moment a

[Spice-devel] [vdagent-linux v4 5/7] console-kit: implement check for locked session

2016-05-03 Thread Victor Toso
We register to read the Lock, Unlock and IdleHintChanged signals from ConsoleKit.Session. The Lock/Unlock signals should be the right signals for the job but not all Desktop Managers implement its locking in a way that trigger those signals. That's why we double-check with IdleHintChanged signal th

[Spice-devel] [vdagent-linux v4 7/7] console-kit: implement check for session type

2016-05-03 Thread Victor Toso
Implementing the function that was introduced in previous commit: session_info_is_user() In console-kit we can gather the session type with GetSessionType api from Session interface. This function is not well documented but seems reliable enough as GDM was using it [0] [0] session_is_login_window

[Spice-devel] [vdagent-linux v4 3/7] console-kit: fix dangling pointer

2016-05-03 Thread Victor Toso
Introduced recently by b1b8b71961b9a28cc4896e9973d3a3c1975ead39 --- src/console-kit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/console-kit.c b/src/console-kit.c index c7e60df..6f86104 100644 --- a/src/console-kit.c +++ b/src/console-kit.c @@ -95,6 +95,7 @@ static void si_dbus_match_

[Spice-devel] [vdagent-linux v4 6/7] session-info: check if session belongs to user

2016-05-03 Thread Victor Toso
session-info back-ends such as console-kit and systemd-login have the concept of session's class which informs if session belongs to user or not [0]. We can disable features based on the session class. [0] Display-Managers are 'Greeter' and Display lock screens are 'lock-screen' This patch introd

[Spice-devel] [vdagent-linux v4 0/6] do not DnD on locked/login screen

2016-05-03 Thread Victor Toso
Good summary in the v2 of this series: https://lists.freedesktop.org/archives/spice-devel/2016-April/028461.html v3->v4: * Jonathon: - Fixed dangling pointers - Ignore unrequested messages from dbus instead of treating them as errors - Send error status instead of 'cancel' status about file

[Spice-devel] [vdagent-linux v4 1/7] vdagentd: send file-xfer status, generic version

2016-05-03 Thread Victor Toso
Change cancel_file_xfer() helper function to file_xfer_status() so we can send other status to the client. --- src/vdagentd.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/vdagentd.c b/src/vdagentd.c index 69332ff..263c288 100644 --- a/src/vdagentd.c +++

[Spice-devel] [vdagent-linux v4 2/7] console-kit: Ignore unrequested messages from dbus

2016-05-03 Thread Victor Toso
Instead of treating them as errors. --- src/console-kit.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/console-kit.c b/src/console-kit.c index d4eecd7..c7e60df 100644 --- a/src/console-kit.c +++ b/src/console-kit.c @@ -109,12 +109,6 @@ si_dbus_read_signals

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-03 Thread Frediano Ziglio
> > On 05/02/2016 11:25 AM, Frediano Ziglio wrote: > > This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb > > ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice > > was changed. > > > > This could be reproduced with: > > - start rhel7 machine > > - connect remot

Re: [Spice-devel] [PATCH 2/2 v4] add a program to test redirection on Windows

2016-05-03 Thread Fabiano Fidêncio
Frediano, On Tue, May 3, 2016 at 11:26 AM, Frediano Ziglio wrote: > This program attempt multiple redirection combination: > - passing handles using either CreateProcess or SetStdHandle; > - having a console or not; > - redirection stdout/stderr yes or not. Would worth to mention (even if it loo

Re: [Spice-devel] [spice-gtk EXP] Handle mismatching CapsLock

2016-05-03 Thread Frediano Ziglio
Hi, I don't follow. Which issues did you find? The patch does not introduce any delays. Can you do some examples of bumping? Frediano > > Hi Frediano, > > unfortunately this patch does not work, it was hard for me to write when > pressing and releasing capslock due to delays. Also the "bump"

Re: [Spice-devel] [spice-server 1/2] build-sys: Drop unneeded python check

2016-05-03 Thread Marc-André Lureau
ack - Original Message - > spice-gtk does not use python, the spice-common submodule needs it, but > it has its own python check through the use of AM_PATH_PYTHON > --- > configure.ac | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 66db560..2

Re: [Spice-devel] [spice-gtk 1/2] build-sys: Delete pygtk2-related files

2016-05-03 Thread Marc-André Lureau
ack - Original Message - > They are no longer needed since 0917002c which dropped pygtk2 support > --- > m4/check_python.m4| 46 > src/Makefile.am | 2 - > src/spice-client-gtk-module.c | 45 --- > src/spice-client-gtk.override | 171 > -

[Spice-devel] spice-html5 audio problem

2016-05-03 Thread Lorenzo Garcia
Hello, I've been using the spice-html5 client for few months in a project, but we found that audio seems to have stopped working properly. When we open the client it works well, but then it stops randomly; sometimes in a few seconds, sometimes it lasts more than a minute or two. Trying to figur

[Spice-devel] [spice-server 2/2] build-sys: Remove 'CXX' from configure summary

2016-05-03 Thread Christophe Fergeau
We no longer make use of a c++ compiler since dropping the client, so no need to show it in the configure summary. --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index 2d7499d..d11fcca 100644 --- a/configure.ac +++ b/configure.ac @@ -285,7 +285,6 @@

[Spice-devel] [spice-server 1/2] build-sys: Drop unneeded python check

2016-05-03 Thread Christophe Fergeau
spice-gtk does not use python, the spice-common submodule needs it, but it has its own python check through the use of AM_PATH_PYTHON --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 66db560..2d7499d 100644 --- a/configure.ac +++ b/configure.a

[Spice-devel] [spice-gtk 2/2] build-sys: Drop unneeded python check

2016-05-03 Thread Christophe Fergeau
spice-gtk does not use python, the spice-common submodule needs it, but it has its own python check through the use of AM_PATH_PYTHON --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ce80d88..f4d6680 100644 --- a/configure.ac +++ b/configure.ac

[Spice-devel] [spice-gtk 1/2] build-sys: Delete pygtk2-related files

2016-05-03 Thread Christophe Fergeau
They are no longer needed since 0917002c which dropped pygtk2 support --- m4/check_python.m4| 46 src/Makefile.am | 2 - src/spice-client-gtk-module.c | 45 --- src/spice-client-gtk.override | 171 -- 4 file

Re: [Spice-devel] [spice-gtk EXP] Handle mismatching CapsLock

2016-05-03 Thread Pavel Grunt
Hi Frediano, unfortunately this patch does not work, it was hard for me to write when pressing and releasing capslock due to delays. Also the "bump" still exists (it is enough to switch to vt to see it). imho the problem is on the server side (server sending capslock to the guest) Pavel On Fri,

[Spice-devel] [PATCH 2/2 v4] add a program to test redirection on Windows

2016-05-03 Thread Frediano Ziglio
This program attempt multiple redirection combination: - passing handles using either CreateProcess or SetStdHandle; - having a console or not; - redirection stdout/stderr yes or not. Signed-off-by: Frediano Ziglio --- tests/Makefile.am | 7 ++ tests/redirect-test.c | 335 +

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-03 Thread Uri Lublin
On 05/02/2016 03:32 PM, Eduardo Lima (Etrunko) wrote: On 05/02/2016 07:39 AM, Uri Lublin wrote: On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: The problem happens when you run 'make dist' in a system without asciidoc installed. Even though in configure time there is a check for building

Re: [Spice-devel] spice_get_option_group is skipped and has messy output

2016-05-03 Thread Fabiano Fidêncio
Visarion, On Tue, May 3, 2016 at 12:05 AM, Visarion-Mingopol Alexandru-Viorel wrote: > > Firstly, the spice_get_option_group is skipped when creating the Vala > binding and I need it for inserting the spice-gtk help menu in gnome-boxes. > > Secondly, the spice group options have a weird appearanc

Re: [Spice-devel] spice_get_option_group is skipped and has messy output

2016-05-03 Thread Pavel Grunt
Hi, On Tue, 2016-05-03 at 01:05 +0300, Visarion-Mingopol Alexandru-Viorel wrote: > > Firstly, the spice_get_option_group is skipped when creating the Vala binding > and I need it for inserting the spice-gtk help menu in gnome-boxes. > Secondly, the spice group options have a weird appearance on t

[Spice-devel] spice_get_option_group is skipped and has messy output

2016-05-03 Thread Visarion-Mingopol Alexandru-Viorel
Firstly, the spice_get_option_group is skipped when creating the Vala binding and I need it for inserting the spice-gtk help menu in gnome-boxes. Secondly, the spice group options have a weird appearance on the standard terminal wifth width 80. Because their entries are so long[1]