Re: [Spice-devel] [spice-gtk v1] spicevmc: don't disconnect on "cancel"

2016-05-02 Thread Victor Toso
Hi, On Mon, May 02, 2016 at 11:56:54AM -0500, Jonathon Jongsma wrote: > On Mon, 2016-05-02 at 15:16 +0200, Victor Toso wrote: > > spicevmc was designed so its _finish functions should always be called; > > With the gtask integration both _finish functions are trying to > > disconnect the GCancella

Re: [Spice-devel] [spice-gtk v1] spice-channel: fix small leak

2016-05-02 Thread Victor Toso
Hi, On Mon, May 02, 2016 at 04:35:44PM +0200, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau Thanks, pushed. > > On Mon, May 02, 2016 at 04:02:32PM +0200, Victor Toso wrote: > > 182 bytes in 1 blocks are definitely lost in loss record 9,048 of 9,889 > > at 0x4C2A988: calloc (vg_re

Re: [Spice-devel] [PATCH 1/2 v3] Attempt to manage redirection in a way similar to Unix

2016-05-02 Thread Fabiano Fidêncio
On Fri, Apr 29, 2016 at 4:09 PM, Frediano Ziglio wrote: > This patch allows remote-viewer to redirect output/error streams to > files. > Also if launched from a console program (for instance from the command > prompt) you are able to see output from the console where you launch > the program. > Th

Re: [Spice-devel] [PATCH 2/2 v3] add a program to test redirection on Windows

2016-05-02 Thread Fabiano Fidêncio
Frediano, On Fri, Apr 29, 2016 at 4:09 PM, Frediano Ziglio wrote: > This program attempt multiple redirection combination: > - passing handles using either CreateProcess or SetStdHandle; > - having a console or not; > - redirection stdout/stderr yes or not. > > Signed-off-by: Frediano Ziglio > -

Re: [Spice-devel] recipe for target 'red-channel.lo' failed

2016-05-02 Thread Eduardo Lima (Etrunko)
On 05/01/2016 06:40 AM, Eduards Šaraņins wrote: > Hi Eduardo, > I'm trying to build it on SmartOS using this guide: > http://permalink.gmane.org/gmane.os.smartos.general/125 Well, I know nothing about SmartOS, so in this case, I think you might have to find which file has SOL_TCP definition and ch

Re: [Spice-devel] [spice v13 16/29] server: Give up after a while if GStreamer cannot handle the video

2016-05-02 Thread Christophe Fergeau
On Tue, Apr 19, 2016 at 09:50:12AM +0200, Francois Gouget wrote: > This typically happens when sending very small frames (less than > 16 pixels in one dimension) to the x264enc encoder. > This avoids repeatedly wasting time rebuilding the pipeline. > > Signed-off-by: Francois Gouget > --- > serv

Re: [Spice-devel] [spice-gtk v1] spicevmc: don't disconnect on "cancel"

2016-05-02 Thread Jonathon Jongsma
On Mon, 2016-05-02 at 15:16 +0200, Victor Toso wrote: > spicevmc was designed so its _finish functions should always be called; > With the gtask integration both _finish functions are trying to > disconnect the GCancellabe even in the 'cancel' context which leads to > a deadlock as explained in the

Re: [Spice-devel] [spice v13 10/29] server: Handle and recover from GStreamer encoding errors

2016-05-02 Thread Christophe Fergeau
On Tue, Apr 19, 2016 at 09:49:39AM +0200, Francois Gouget wrote: > This avoids getting stuck if the codec is buggy or fails to encode a > frame for whatever reason (e.g. odd frame size). > > Signed-off-by: Francois Gouget > --- > server/gstreamer-encoder.c | 105 > ++

Re: [Spice-devel] [spice v13 09/29] server: Let the video encoder manage the compressed buffer

2016-05-02 Thread Christophe Fergeau
On Tue, Apr 19, 2016 at 09:49:33AM +0200, Francois Gouget wrote: > This way the video encoder is not forced to use malloc()/free(). > This also allows more flexibility in how the video encoder manages the > buffer which allows for a zero-copy implementation in both video > encoders. > > Signed-off

Re: [Spice-devel] [spice-gtk v1] spice-channel: fix small leak

2016-05-02 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, May 02, 2016 at 04:02:32PM +0200, Victor Toso wrote: > 182 bytes in 1 blocks are definitely lost in loss record 9,048 of 9,889 > at 0x4C2A988: calloc (vg_replace_malloc.c:711) > by 0xB5F4270: g_malloc0 (gmem.c:124) > by 0x7320678: spice_channel_recv_link_hdr

[Spice-devel] [spice-gtk v1] spice-channel: fix small leak

2016-05-02 Thread Victor Toso
182 bytes in 1 blocks are definitely lost in loss record 9,048 of 9,889 at 0x4C2A988: calloc (vg_replace_malloc.c:711) by 0xB5F4270: g_malloc0 (gmem.c:124) by 0x7320678: spice_channel_recv_link_hdr (spice-channel.c:1312) by 0x7320678: spice_channel_coroutine (spice-channel.c:2543) by 0x7355A4E: cor

[Spice-devel] [spice-gtk v1] spicevmc: don't disconnect on "cancel"

2016-05-02 Thread Victor Toso
spicevmc was designed so its _finish functions should always be called; With the gtask integration both _finish functions are trying to disconnect the GCancellabe even in the 'cancel' context which leads to a deadlock as explained in the documentation. Resolves: https://bugs.freedesktop.org/show_b

Re: [Spice-devel] [PATCH 0/3] Fixes to git-version-gen

2016-05-02 Thread Marc-André Lureau
On Mon, May 2, 2016 at 2:33 PM, Eduardo Lima (Etrunko) wrote: > See previous thread "How to modify spice version" replied there, --fallback is the wrong the solution to me. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedeskt

Re: [Spice-devel] How to modify spice version?

2016-05-02 Thread Marc-André Lureau
Hi On Fri, Apr 29, 2016 at 9:10 PM, Eduardo Lima (Etrunko) wrote: > On 04/29/2016 12:29 PM, Eduardo Lima (Etrunko) wrote: >> On 04/28/2016 08:45 AM, Pavel Grunt wrote: >>> Hi, >>> >>> On Thu, 2016-04-28 at 14:09 +0800, Chen yu wrote: Thank you for taking time out of your busy schedule to see

Re: [Spice-devel] [PATCH 0/3] Fixes to git-version-gen

2016-05-02 Thread Eduardo Lima (Etrunko)
On 04/29/2016 06:08 PM, Marc-André Lureau wrote: > > > - Original Message - >> I am sending this series for spice-server only, if we come to an >> agreement, I will provide similar patches for common and gtk. > > What does it actually fix? See previous thread "How to modify spice versio

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-02 Thread Eduardo Lima (Etrunko)
On 05/02/2016 07:39 AM, Uri Lublin wrote: > On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: >> The problem happens when you run 'make dist' in a system without >> asciidoc installed. Even though in configure time there is a check for >> building the manual, it is required to be built for dist

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-02 Thread Eduardo Lima (Etrunko)
On 04/30/2016 04:19 AM, Victor Toso wrote: > Hey, > > On Mon, Apr 25, 2016 at 06:23:25PM -0300, Eduardo Lima (Etrunko) wrote: >> The problem happens when you run 'make dist' in a system without >> asciidoc installed. Even though in configure time there is a check for >> building the manual, it is

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-02 Thread Christophe Fergeau
On Mon, Apr 25, 2016 at 06:23:25PM -0300, Eduardo Lima (Etrunko) wrote: > The problem happens when you run 'make dist' in a system without > asciidoc installed. Even though in configure time there is a check for > building the manual, it is required to be built for distribution. Dunno if we should

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-05-02 Thread Uri Lublin
On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: The problem happens when you run 'make dist' in a system without asciidoc installed. Even though in configure time there is a check for building the manual, it is required to be built for distribution. Hi, I think we should not force buildi

Re: [Spice-devel] [spice-devel]How to reduce the image resolution or definition ?

2016-05-02 Thread Uri Lublin
On 04/12/2016 12:18 PM, hongzhen_...@sina.com wrote: Hello Could you tell me how to reduce the image resolution or definition ? I plan to reduce the image definition so that decrease data transmission from server to client . For example ,I assume if I have a low bandwid

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-02 Thread Uri Lublin
On 05/02/2016 11:25 AM, Frediano Ziglio wrote: This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice was changed. This could be reproduced with: - start rhel7 machine - connect remote viewer (RV) - RV: login - co

Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop

2016-05-02 Thread Lukas Venhoda
Hi *From: *Victor Toso *Sent: *pondělí 2. května 2016 10:30 *To: *Lukas Venhoda *Cc: *spice-devel@lists.freedesktop.org *Subject: *Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop Hi, On Mon, May 02, 2016 at 10:05:33AM +0200, Lukas Venho

Re: [Spice-devel] [PATCH spice-gtk] Do not use deprecated GtkStock

2016-05-02 Thread Pavel Grunt
Thank you, pushed Pavel On Mon, 2016-05-02 at 09:41 +0200, Victor Toso wrote: > On Thu, Apr 07, 2016 at 01:03:51PM +0200, Pavel Grunt wrote: > > Use labels or named icons > > > > Deprecated since Gtk 3.10 > > Acked-by: Victor Toso > > > --- > >  src/spicy.c | 23 +++---

Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop

2016-05-02 Thread Victor Toso
Hi, On Mon, May 02, 2016 at 10:05:33AM +0200, Lukas Venhoda wrote: > Why not use the same struct in both contexts and a mutex to avoid > concurrency > problems? > > Cheers, > toso > > Because ServiceData is not used, when called with --no-service. > > It won’t be created

[Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

2016-05-02 Thread Frediano Ziglio
This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice was changed. This could be reproduced with: - start rhel7 machine - connect remote viewer (RV) - RV: login - connect ssh - SSH: stop agent - disconnect RV - SSH

Re: [Spice-devel] [phodav PATCH 1/3 v6] spice-webdavd-windows: Automount shared folder

2016-05-02 Thread Lukas Venhoda
Hi *From: *Victor Toso *Sent: *pondělí 2. května 2016 8:45 *To: *Lukáš Venhoda *Cc: *spice-devel@lists.freedesktop.org *Subject: *Re: [Spice-devel] [phodav PATCH 1/3 v6] spice-webdavd-windows: Automount shared folder Hey, On Thu, Apr 21, 2016 at 05:28:07PM +0200, Lukáš Venhoda wrote: > Fro

Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop

2016-05-02 Thread Lukas Venhoda
Hi *From: *Victor Toso *Sent: *pondělí 2. května 2016 9:08 *To: *Lukas Venhoda *Cc: *spice-devel@lists.freedesktop.org *Subject: *Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop Hey, Sorry, I forgot to reply to this sooner. On Fri, Apr

Re: [Spice-devel] [PATCH spice-gtk] Do not use deprecated GtkStock

2016-05-02 Thread Victor Toso
On Thu, Apr 07, 2016 at 01:03:51PM +0200, Pavel Grunt wrote: > Use labels or named icons > > Deprecated since Gtk 3.10 Acked-by: Victor Toso > --- > src/spicy.c | 23 +++ > src/usb-device-widget.c | 12 ++-- > 2 files changed, 17 insertions(+), 18 deletio

Re: [Spice-devel] [spice-devel]How to reduce the image resolution or definition ?

2016-05-02 Thread Victor Toso
Hi, On Tue, Apr 12, 2016 at 05:18:32PM +0800, hongzhen_...@sina.com wrote: > Hello > Could you tell me how to reduce the image resolution or definition ? > I plan to reduce the image definition so that decrease data > transmission from server to client. For example, I assume if I have a > l

Re: [Spice-devel] [spice] server: Correctly handle and trace stream report errors

2016-05-02 Thread Victor Toso
Hey, On Fri, Apr 15, 2016 at 04:50:42PM +0200, Francois Gouget wrote: > We may get stream reports after the stream has been closed, and even, in > extreme cases, after a new stream has started reusing the same stream > id. Neither case should cause the server to crash. > So restore dcc_handle_stre

Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop

2016-05-02 Thread Victor Toso
Hey, Sorry, I forgot to reply to this sooner. On Fri, Apr 08, 2016 at 01:10:43PM +0200, Lukas Venhoda wrote: > > > > > @@ -749,6 +749,7 @@ typedef enum _MapDriveEnum > > > > > > typedef struct _MapDriveData > > > { > > > + gchar * drive_letter; > > > > I think it is fine to use a gchar instead