Re: [Spice-devel] [vdagent-linux v3 4/4] console-kit: implement check for session type

2016-04-29 Thread Victor Toso
Hi, On Fri, Apr 29, 2016 at 02:52:03PM -0500, Jonathon Jongsma wrote: > On Thu, 2016-04-28 at 15:37 +0200, Victor Toso wrote: > > Implementing the function that was introduced in previous commit: > > session_info_is_user() > > > > In console-kit we can gather the session type with GetSessionType

Re: [Spice-devel] [vdagent-linux v3 3/4] session-info: check if session belongs to user

2016-04-29 Thread Victor Toso
Hi, On Fri, Apr 29, 2016 at 01:46:52PM -0500, Jonathon Jongsma wrote: > On Thu, 2016-04-28 at 15:37 +0200, Victor Toso wrote: > > session-info back-ends such as console-kit and systemd-login have the > > concept of session's class which informs if session belongs to user or > > not [0]. We can dis

Re: [Spice-devel] [vdagent-linux v3 2/4] console-kit: implement check for locked session

2016-04-29 Thread Victor Toso
Hi, On Fri, Apr 29, 2016 at 10:08:53AM -0500, Jonathon Jongsma wrote: > On Thu, 2016-04-28 at 15:37 +0200, Victor Toso wrote: > > We register to read the Lock, Unlock and IdleHintChanged signals from > > ConsoleKit.Session. The Lock/Unlock signals should be the right > > signals for the job but no

Re: [Spice-devel] [vdagent-linux v3 1/4] session-info: check for a locked session

2016-04-29 Thread Victor Toso
Hi, On Fri, Apr 29, 2016 at 09:59:03AM -0500, Jonathon Jongsma wrote: > On Thu, 2016-04-28 at 15:37 +0200, Victor Toso wrote: > > Each session back-end can return this information to vdagentd when > > requested. > > > > The agent should use this on situations that should not work when > > session

Re: [Spice-devel] [PATCH 0/3] Fixes to git-version-gen

2016-04-29 Thread Marc-André Lureau
- Original Message - > I am sending this series for spice-server only, if we come to an > agreement, I will provide similar patches for common and gtk. What does it actually fix? > > Eduardo Lima (Etrunko) (3): > Update git-version-gen to latest version > Fix git-version-gen output

[Spice-devel] [PATCH 0/3] Fixes to git-version-gen

2016-04-29 Thread Eduardo Lima (Etrunko)
I am sending this series for spice-server only, if we come to an agreement, I will provide similar patches for common and gtk. Eduardo Lima (Etrunko) (3): Update git-version-gen to latest version Fix git-version-gen output if --fallback is specified Pass fallback version to git-version-gen

[Spice-devel] [PATCH 2/3] Fix git-version-gen output if --fallback is specified

2016-04-29 Thread Eduardo Lima (Etrunko)
The output will use the value of fallback only if it is not empty *or* the result of 'git --version' command is not 0. But the only reason I can think of this command failing, is when the user does not have git installed. By removing the conditional it works every time. With or without git install

[Spice-devel] [PATCH 3/3] Pass fallback version to git-version-gen

2016-04-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 18b907a..35f2f06 100644 --- a/configure.ac +++ b/configure.ac @@ -15,7 +15,7 @@ m4_define([SPICE_CURRENT], [12]) m4_define([SPICE_REVISION]

[Spice-devel] [PATCH 1/3] Update git-version-gen to latest version

2016-04-29 Thread Eduardo Lima (Etrunko)
Pick the latest git-version-gen version from http://git.savannah.gnu.org/cgit/gnulib.git/plain/build-aux/git-version-gen Signed-off-by: Eduardo Lima (Etrunko) --- build-aux/git-version-gen | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/build-aux/git-version-gen

Re: [Spice-devel] [vdagent-linux v3 4/4] console-kit: implement check for session type

2016-04-29 Thread Jonathon Jongsma
On Thu, 2016-04-28 at 15:37 +0200, Victor Toso wrote: > Implementing the function that was introduced in previous commit: > session_info_is_user() > > In console-kit we can gather the session type with GetSessionType api > from Session interface. This function is not well documented but seems > re

Re: [Spice-devel] How to modify spice version?

2016-04-29 Thread Eduardo Lima (Etrunko)
On 04/29/2016 12:29 PM, Eduardo Lima (Etrunko) wrote: > On 04/28/2016 08:45 AM, Pavel Grunt wrote: >> Hi, >> >> On Thu, 2016-04-28 at 14:09 +0800, Chen yu wrote: >>> Thank you for taking time out of your busy schedule to see this letter. >>> I am trying to compile spice downloaded from github, but

Re: [Spice-devel] [vdagent-linux v3 3/4] session-info: check if session belongs to user

2016-04-29 Thread Jonathon Jongsma
On Thu, 2016-04-28 at 15:37 +0200, Victor Toso wrote: > session-info back-ends such as console-kit and systemd-login have the > concept of session's class which informs if session belongs to user or > not [0]. We can disable features based on the session class. > > [0] Display-Managers are 'Greete

Re: [Spice-devel] [spice v13 05/29] server: Let the administrator pick the video encoder and codec

2016-04-29 Thread Christophe Fergeau
On Tue, Apr 19, 2016 at 09:48:56AM +0200, Francois Gouget wrote: > The Spice server administrator can specify the encoder and codec > preferences to optimize for CPU or bandwidth usage. Preferences are > described in a semi-colon separated list of encoder:codec pairs. > The server has a default pre

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

2016-04-29 Thread Christophe Fergeau
Hey, A few small comments/questions On Tue, Apr 19, 2016 at 09:48:19AM +0200, Francois Gouget wrote: > +/* A helper for the *_copy() functions */ > +static int is_chunk_padded(const SpiceBitmap *bitmap, uint32_t index) > +{ > +SpiceChunks *chunks = bitmap->data; > +if (chunks->chunk[index

Re: [Spice-devel] How to modify spice version?

2016-04-29 Thread Eduardo Lima (Etrunko)
On 04/28/2016 08:45 AM, Pavel Grunt wrote: > Hi, > > On Thu, 2016-04-28 at 14:09 +0800, Chen yu wrote: >> Thank you for taking time out of your busy schedule to see this letter. >> I am trying to compile spice downloaded from github, but the versions of >> these >> are 'UNKNOWN'. when I compiled

Re: [Spice-devel] [vdagent-linux v3 2/4] console-kit: implement check for locked session

2016-04-29 Thread Jonathon Jongsma
On Thu, 2016-04-28 at 15:37 +0200, Victor Toso wrote: > We register to read the Lock, Unlock and IdleHintChanged signals from > ConsoleKit.Session. The Lock/Unlock signals should be the right > signals for the job but not all Desktop Managers implement its locking > in a way that trigger those sign

Re: [Spice-devel] [vdagent-linux v3 1/4] session-info: check for a locked session

2016-04-29 Thread Jonathon Jongsma
On Thu, 2016-04-28 at 15:37 +0200, Victor Toso wrote: > Each session back-end can return this information to vdagentd when > requested. > > The agent should use this on situations that should not work when > session is locked such as file-transfer-start which is fixed by this > patch. > > systemd

Re: [Spice-devel] recipe for target 'red-channel.lo' failed

2016-04-29 Thread Eduardo Lima (Etrunko)
On 04/22/2016 09:14 AM, Eduards Šaraņins wrote: > Hello, > I'm trying to build spice-0.12.7 and get the following errors: > > CFLAGS="-m64" LDFLAGS="-m64" ./configure --disable-client > --disable-werror --prefix=/opt/local > > > > CC red_channel.lo > red_channel.c: In function 'red_

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-04-29 Thread Eduardo Lima (Etrunko)
Any opinions here? On 04/25/2016 06:23 PM, Eduardo Lima (Etrunko) wrote: > The problem happens when you run 'make dist' in a system without > asciidoc installed. Even though in configure time there is a check for > building the manual, it is required to be built for distribution. > > Signed-off-b

[Spice-devel] [PATCH 1/2 v3] Attempt to manage redirection in a way similar to Unix

2016-04-29 Thread Frediano Ziglio
This patch allows remote-viewer to redirect output/error streams to files. Also if launched from a console program (for instance from the command prompt) you are able to see output from the console where you launch the program. This allow to launch the program with a syntax like > remote-viewer.e

[Spice-devel] [PATCH 2/2 v3] add a program to test redirection on Windows

2016-04-29 Thread Frediano Ziglio
This program attempt multiple redirection combination: - passing handles using either CreateProcess or SetStdHandle; - having a console or not; - redirection stdout/stderr yes or not. Signed-off-by: Frediano Ziglio --- src/Makefile.am | 4 + src/redirect-test.c | 329 ++

Re: [Spice-devel] [PATCH 04/18] Make red_client_remove_channel() a RedClient method

2016-04-29 Thread Frediano Ziglio
> > On Thu, 2016-04-28 at 13:09 -0400, Frediano Ziglio wrote: > > > > > > Explicitly pass RedClient* as first argument to this function, to mirror > > > red_client_add_channel(). This will eventually allow us to separate the > > > implementations of RedClient and RedChannelClient so that they do