Re: [Spice-devel] [PATCH] Fix make dist

2016-04-25 Thread Pavel Grunt
On Mon, 2016-04-25 at 17:21 -0300, Eduardo Lima (Etrunko) wrote: > spicec screenshot has been removed since commit > b0186fe1267dfa2b8534c7c083dc301791279f08 > > Signed-off-by: Eduardo Lima (Etrunko) Acked-by: Pavel Grunt Thanks, Pavel > --- >  docs/manual/Makefile.am | 1 - >  1 file changed, 1

Re: [Spice-devel] principle of compute_lines_gradual_score

2016-04-25 Thread 邱星翔
Oh, I see. And now I can understand what the code mean. But the question is that the same picture but different size would output different result, for e.g, use this picture( http://www.tophdwallpaersland.com/wp-content/uploads/2015/01/windows-desktop-widescreen-backgrounds.jpg) as the desktop, whe

[Spice-devel] [PATCH] Make asciidoc a hard requirement

2016-04-25 Thread Eduardo Lima (Etrunko)
The problem happens when you run 'make dist' in a system without asciidoc installed. Even though in configure time there is a check for building the manual, it is required to be built for distribution. Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac| 25 ++-

Re: [Spice-devel] [PATCH] build-sys: post-release bump

2016-04-25 Thread Eduardo Lima (Etrunko)
Please ignore, git send-email was called from wrong directory. On 04/25/2016 06:21 PM, Eduardo Lima (Etrunko) wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/conf

[Spice-devel] [PATCH] build-sys: post-release bump

2016-04-25 Thread Eduardo Lima (Etrunko)
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6d96f76..dd2d373 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7 @@ AC_PREREQ([2.57]) m4_define([SPICE_MAJ

[Spice-devel] [PATCH] Fix make dist

2016-04-25 Thread Eduardo Lima (Etrunko)
spicec screenshot has been removed since commit b0186fe1267dfa2b8534c7c083dc301791279f08 Signed-off-by: Eduardo Lima (Etrunko) --- docs/manual/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/manual/Makefile.am b/docs/manual/Makefile.am index ead5f46..24a11fe 100644 --- a/doc

[Spice-devel] [spice-gtk v3] Spice-widget: Use new gdk_event_get_scancode if available

2016-04-25 Thread Frediano Ziglio
This new Gdk API allows in Windows to retrieve the raw scancodes sent by Windows. This allows us to do some translations getting the right value without many hacks and supporting all possible layouts. Windows convert the scancodes into virtual key codes. The translation is 1 -> N based on different

Re: [Spice-devel] [spice-gtk v2] Spice-widget: Use new gdk_event_get_scancode if available

2016-04-25 Thread Frediano Ziglio
> > On Mon, Apr 25, 2016 at 04:03:47PM +0100, Frediano Ziglio wrote: > > This new Gdk API allows in Windows to retrieve the raw scancodes sent > > by Windows. > > This allows us to do some translations getting the right value without > > many hacks and supporting all possible layouts. > > For fut

Re: [Spice-devel] [spice-gtk v2] Spice-widget: Use new gdk_event_get_scancode if available

2016-04-25 Thread Christophe Fergeau
On Mon, Apr 25, 2016 at 04:03:47PM +0100, Frediano Ziglio wrote: > This new Gdk API allows in Windows to retrieve the raw scancodes sent > by Windows. > This allows us to do some translations getting the right value without > many hacks and supporting all possible layouts. For future reference, ca

[Spice-devel] [spice-gtk v2] Spice-widget: Use new gdk_event_get_scancode if available

2016-04-25 Thread Frediano Ziglio
This new Gdk API allows in Windows to retrieve the raw scancodes sent by Windows. This allows us to do some translations getting the right value without many hacks and supporting all possible layouts. Signed-off-by: Frediano Ziglio --- configure.ac | 8 src/spice-widget.c | 22 ++

[Spice-devel] [spice-gtk] Spice-widget: Use new gdk_event_get_scancode if available

2016-04-25 Thread Frediano Ziglio
This new Gdk API allows in Windows to retrieve the raw scancodes sent by Windows. This allows us to do some translations getting the right value without many hacks and supporting all possible layouts. Signed-off-by: Frediano Ziglio --- src/spice-widget.c | 22 +++--- 1 file chang

Re: [Spice-devel] principle of compute_lines_gradual_score

2016-04-25 Thread Frediano Ziglio
> > Hi, I'm a beginner at SPICE project. Today, I was reading the code, > the function which named `_get_bitmap_graduality_level` at line 5979 > in file server/red_worker.c (the version of spice is 0.12.7 and my OS > is Fedora 23). It seems that get a score value from a image by the > function and

[Spice-devel] principle of compute_lines_gradual_score

2016-04-25 Thread 邱星翔
Hi, I'm a beginner at SPICE project. Today, I was reading the code, the function which named `_get_bitmap_graduality_level` at line 5979 in file server/red_worker.c (the version of spice is 0.12.7 and my OS is Fedora 23). It seems that get a score value from a image by the function and I also found

Re: [Spice-devel] [server PATCH v2] LZ4 compression is now available at the Spicevmc channel

2016-04-25 Thread Victor Toso
Hi Snir, On Thu, Apr 14, 2016 at 12:04:28PM +0300, Snir Sheriber wrote: > Compressed message type is CompressedData which contains compression > type (1 byte) followed by the uncompressed data size (4 bytes) followed > by the compressed data size (4 bytes) followed by the compressed data > > If SP

Re: [Spice-devel] [vdagent-linux v2 1/6] console-kit: use define for dbus paths

2016-04-25 Thread Victor Toso
Hey, On Mon, Apr 25, 2016 at 12:55:21PM +0200, Pavel Grunt wrote: > Hi, > > On Mon, 2016-04-25 at 12:40 +0200, Victor Toso wrote: > > Hi, > > > > On Mon, Apr 25, 2016 at 06:30:42AM -0400, Frediano Ziglio wrote: > > > > > > > > Hi, > > > > > > > > On Mon, Apr 25, 2016 at 05:08:08AM -0400, Fredi

Re: [Spice-devel] [vdagent-linux v2 1/6] console-kit: use define for dbus paths

2016-04-25 Thread Pavel Grunt
Hi, On Mon, 2016-04-25 at 12:40 +0200, Victor Toso wrote: > Hi, > > On Mon, Apr 25, 2016 at 06:30:42AM -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > > > On Mon, Apr 25, 2016 at 05:08:08AM -0400, Frediano Ziglio wrote: > > > > > > > > > > This improves readability of all paths related t

Re: [Spice-devel] [vdagent-linux v2 1/6] console-kit: use define for dbus paths

2016-04-25 Thread Victor Toso
Hi, On Mon, Apr 25, 2016 at 06:30:42AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Mon, Apr 25, 2016 at 05:08:08AM -0400, Frediano Ziglio wrote: > > > > > > > > This improves readability of all paths related to dbus methods. This > > > > patch > > > > only > > > > applies for interface

Re: [Spice-devel] [vdagent-linux v2 1/6] console-kit: use define for dbus paths

2016-04-25 Thread Frediano Ziglio
> > Hi, > > On Mon, Apr 25, 2016 at 05:08:08AM -0400, Frediano Ziglio wrote: > > > > > > This improves readability of all paths related to dbus methods. This > > > patch > > > only > > > applies for interfaces and object paths, later one it is included for > > > signals > > > as > > > well. > >

Re: [Spice-devel] [vdagent-linux v2 1/6] console-kit: use define for dbus paths

2016-04-25 Thread Victor Toso
Hi, On Mon, Apr 25, 2016 at 05:08:08AM -0400, Frediano Ziglio wrote: > > > > This improves readability of all paths related to dbus methods. This patch > > only > > applies for interfaces and object paths, later one it is included for > > signals > > as > > well. > > --- > > src/console-kit.c |

Re: [Spice-devel] Interested in contribution

2016-04-25 Thread Frediano Ziglio
> Hi all, > I am Sagar Ghuge, I am here to expand my knowledge base and I am very much > interested in the project "Spice". > My previous experiences with open source are contributions in GNOME > applications (Xpad, Gedit, GTG) and internship with Echinopsii open source > community. > I would like

[Spice-devel] Interested in contribution

2016-04-25 Thread Sagar Ghuge
Hi all, I am Sagar Ghuge, I am here to expand my knowledge base and I am very much interested in the project "Spice". My previous experiences with open source are contributions in GNOME applications (Xpad, Gedit, GTG) and internship with Echinopsii open source community. I would like to start with

Re: [Spice-devel] [spice-gtk 2/4] coverity: avoid string overflow

2016-04-25 Thread Fabiano Fidêncio
On Mon, Apr 25, 2016 at 10:59 AM, Frediano Ziglio wrote: >> >> On Mon, Apr 4, 2016 at 9:59 AM, Fabiano Fidêncio wrote: >> > sockaddr_un.sun_path has 108 bytes, while pipe_name has >> > PIPE_NAME_MAX_LEN (256 bytes) >> > --- >> > src/controller/test.c | 6 ++ >> > 1 file changed, 6 insertions

Re: [Spice-devel] [spice-gtk 1/4] coverity: fix unitialized use of mem.data

2016-04-25 Thread Fabiano Fidêncio
On Mon, Apr 25, 2016 at 11:04 AM, Frediano Ziglio wrote: >> >> --- >> src/channel-main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/channel-main.c b/src/channel-main.c >> index 4a1f58a..93537d2 100644 >> --- a/src/channel-main.c >> +++ b/src/channel-main.c >>

Re: [Spice-devel] [vdagent-linux v2 1/6] console-kit: use define for dbus paths

2016-04-25 Thread Frediano Ziglio
> > This improves readability of all paths related to dbus methods. This patch > only > applies for interfaces and object paths, later one it is included for signals > as > well. > --- > src/console-kit.c | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-) >

Re: [Spice-devel] [spice-common 8/8] Use g_getenv() instead of getenv()

2016-04-25 Thread Frediano Ziglio
> > --- > common/log.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/log.c b/common/log.c > index 8d47cb6..91d3181 100644 > --- a/common/log.c > +++ b/common/log.c > @@ -59,7 +59,7 @@ static GLogLevelFlags spice_log_level_to_glib(SpiceLogLevel > level) > st

Re: [Spice-devel] [spice-gtk 1/4] coverity: fix unitialized use of mem.data

2016-04-25 Thread Frediano Ziglio
> > --- > src/channel-main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/channel-main.c b/src/channel-main.c > index 4a1f58a..93537d2 100644 > --- a/src/channel-main.c > +++ b/src/channel-main.c > @@ -1021,9 +1021,9 @@ static void agent_msg_queue_many(SpiceMainCh

Re: [Spice-devel] [spice-gtk 2/4] coverity: avoid string overflow

2016-04-25 Thread Frediano Ziglio
> > On Mon, Apr 4, 2016 at 9:59 AM, Fabiano Fidêncio wrote: > > sockaddr_un.sun_path has 108 bytes, while pipe_name has > > PIPE_NAME_MAX_LEN (256 bytes) > > --- > > src/controller/test.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/src/controller/test.c b/src/controller/

Re: [Spice-devel] [spice-common 8/8] Use g_getenv() instead of getenv()

2016-04-25 Thread Christophe Fergeau
On Mon, Apr 25, 2016 at 09:08:23AM +0200, Fabiano Fidêncio wrote: > On Mon, Apr 4, 2016 at 10:21 AM, Christophe Fergeau > wrote: > > On Mon, Apr 04, 2016 at 10:03:39AM +0200, Fabiano Fidêncio wrote: > >> --- > >> common/log.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> >

Re: [Spice-devel] [virt-tools-list] [PATCH] Disable IME to allow receiving all keys

2016-04-25 Thread Takao Fujiwara
Today I got a reply from the customer. The customer verified the reported bugs are fixed with the patches of spice-gtk but without the patch of ImmDisableIME(-1). And some users wish to show the IME icon in the task bar during running remote-viewer.exe So I'd suggest to back-port only the patch

Re: [Spice-devel] [spice-common 8/8] Use g_getenv() instead of getenv()

2016-04-25 Thread Fabiano Fidêncio
On Mon, Apr 4, 2016 at 10:21 AM, Christophe Fergeau wrote: > On Mon, Apr 04, 2016 at 10:03:39AM +0200, Fabiano Fidêncio wrote: >> --- >> common/log.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/common/log.c b/common/log.c >> index 8d47cb6..91d3181 100644 >> ---

Re: [Spice-devel] [spice-common 3/8] coverity: avoid out of bounds access

2016-04-25 Thread Fabiano Fidêncio
On Mon, Apr 4, 2016 at 10:29 AM, Christophe Fergeau wrote: > On Mon, Apr 04, 2016 at 10:03:34AM +0200, Fabiano Fidêncio wrote: >> We are allocating insufficient memory for the terminating null of the >> string. >> --- >> common/ssl_verify.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletion