Re: [Spice-devel] [virt-tools-list] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Takao Fujiwara
On 04/21/16 01:17, Frediano Ziglio-san wrote: On Wed, Apr 20, 2016 at 05:37:52PM +0900, Takao Fujiwara wrote: My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key events even if the title bar is focused when IME is enabled. I attached the screenshot of the problem when ImmDisabl

Re: [Spice-devel] [virt-tools-list] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Takao Fujiwara
On 04/20/16 23:45, Christophe Fergeau-san wrote: On Wed, Apr 20, 2016 at 05:37:52PM +0900, Takao Fujiwara wrote: My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key events even if the title bar is focused when IME is enabled. I attached the screenshot of the problem when ImmDisa

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Takao Fujiwara
On 04/20/16 23:29, Frediano Ziglio-san wrote: My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key events even if the title bar is focused when IME is enabled. I attached the screenshot of the problem when ImmDisableIME(-1) is not applied. https://bugzilla.redhat.com/show_bug.cgi

Re: [Spice-devel] [PATCH 01/16] UpgradeItem: use base PipeItem for refcounting

2016-04-20 Thread Jonathon Jongsma
On Wed, 2016-04-20 at 04:18 -0400, Frediano Ziglio wrote: > > > > No need to re-implement refcounting in this subclass. However, I needed > > to add a new 'dcc' member to UpgradeItem to be able to unref properly. > > --- > > Change since last patch: take ref on dcc > > > > server/dcc.c

[Spice-devel] [PATCH v2] Use GQueue for RedCharDevice::send_queue

2016-04-20 Thread Jonathon Jongsma
From: Christophe Fergeau There was an extra RedCharDeviceMsgToClientItem type whose only purpose was to manage a linked list of items to send. GQueue has the same purpose as this type in addition to being generic. As the length of the send queue is tracked, a GQueue is more appropriate than a GLi

Re: [Spice-devel] [PATCH 04/16] Use GQueue for RedCharDevice::send_queue

2016-04-20 Thread Jonathon Jongsma
On Wed, 2016-04-20 at 09:48 -0500, Jonathon Jongsma wrote: > On Wed, 2016-04-20 at 04:38 -0400, Frediano Ziglio wrote: > > > > > > From: Christophe Fergeau > > > > > > There was an extra RedCharDeviceMsgToClientItem type whose only > > > purpose was to manage a linked list of items to send. GQue

Re: [Spice-devel] [PATCH 02/16] Replace RedCharDevice::on_free_self_token with a signal

2016-04-20 Thread Christophe Fergeau
Hey, On Wed, Apr 20, 2016 at 04:29:56AM -0400, Frediano Ziglio wrote: > > > > From: Christophe Fergeau > > > > It's more natural to do things this way with glib, and this allows to > > remove some coupling between Reds and RedCharDeviceVDIPort. Before this > > commit, the RedCharDeviceVDIPort h

Re: [Spice-devel] [virt-tools-list] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Frediano Ziglio
> > On Wed, Apr 20, 2016 at 05:37:52PM +0900, Takao Fujiwara wrote: > > My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key > > events even if the title bar is focused when IME is enabled. > > I attached the screenshot of the problem when ImmDisableIME(-1) is not > > applied. > >

Re: [Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-20 Thread David Jaša
On Po, 2016-04-18 at 05:17 -0400, Frediano Ziglio wrote: > > On Thu, 2016-04-14 at 16:50 -0500, Jonathon Jongsma wrote: > > > From: Christophe Fergeau > > > > > > There was an extra RedCharDeviceMsgToClientItem type whose only > > > purpose was to manage a linked list of items to send. GQueue has

Re: [Spice-devel] [PATCH 04/16] Use GQueue for RedCharDevice::send_queue

2016-04-20 Thread Jonathon Jongsma
On Wed, 2016-04-20 at 04:38 -0400, Frediano Ziglio wrote: > > > > From: Christophe Fergeau > > > > There was an extra RedCharDeviceMsgToClientItem type whose only > > purpose was to manage a linked list of items to send. GQueue has the > > same purpose as this type in addition to being generic.

Re: [Spice-devel] [virt-tools-list] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Christophe Fergeau
On Wed, Apr 20, 2016 at 05:37:52PM +0900, Takao Fujiwara wrote: > My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key > events even if the title bar is focused when IME is enabled. > I attached the screenshot of the problem when ImmDisableIME(-1) is not > applied. > https://bugzil

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Frediano Ziglio
> > My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key events > even if the title bar is focused when IME is enabled. > I attached the screenshot of the problem when ImmDisableIME(-1) is not > applied. > https://bugzilla.redhat.com/show_bug.cgi?id=1311858#c42 > > But spice-gtk c

Re: [Spice-devel] spice-xpi deprecated soon

2016-04-20 Thread Christophe Fergeau
On Tue, Apr 19, 2016 at 07:46:14PM +0530, RK RK wrote: > Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production > environment with 250 Virtual Desktops accessed from within the office > premises. > > Our users will have thin client devices running trimmed down version of > CentO

Re: [Spice-devel] [PATCH 08/16] char device: use _reset_dev_instance() to set 'sin'

2016-04-20 Thread Frediano Ziglio
> > Internally, use the method to set the 'sin' member variable so that we > don't have to duplicate the g_object_notify() calls, and there are > consistent debug statements whenever this value is modified. This also > means that we need to handle NULL arguments to this function. > --- > server/c

Re: [Spice-devel] [PATCH 06/16] char-device: notify when device instance is changed

2016-04-20 Thread Frediano Ziglio
> > Since the device instance ("sin") is a gobject property, we should make > sure to notify when it changes, particularly since we do some > initialization in response to the "notify::sin" signal. > --- > server/char-device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/server/cha

Re: [Spice-devel] [PATCH 07/16] char device: use 'device' rather than 'state' for var names

2016-04-20 Thread Frediano Ziglio
> > Since the type name was changed, use variable names / debug statements > that are consistent with the new name. > --- > server/char-device.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/server/char-device.c b/server/char-device.c > index 90e

Re: [Spice-devel] [PATCH 04/16] Use GQueue for RedCharDevice::send_queue

2016-04-20 Thread Frediano Ziglio
> > From: Christophe Fergeau > > There was an extra RedCharDeviceMsgToClientItem type whose only > purpose was to manage a linked list of items to send. GQueue has the > same purpose as this type in addition to being generic. As the length of > the send queue is tracked, a GQueue is more appropr

Re: [Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-20 Thread Takao Fujiwara
My understanding is, Virt-Viewer with ImmDisableIME(-1) can send key events even if the title bar is focused when IME is enabled. I attached the screenshot of the problem when ImmDisableIME(-1) is not applied. https://bugzilla.redhat.com/show_bug.cgi?id=1311858#c42 But spice-gtk can receives all

Re: [Spice-devel] [PATCH 02/16] Replace RedCharDevice::on_free_self_token with a signal

2016-04-20 Thread Frediano Ziglio
> > From: Christophe Fergeau > > It's more natural to do things this way with glib, and this allows to > remove some coupling between Reds and RedCharDeviceVDIPort. Before this > commit, the RedCharDeviceVDIPort has to provide a on_free_self_token() > because Reds needs to know about it. With a

Re: [Spice-devel] [PATCH 01/16] UpgradeItem: use base PipeItem for refcounting

2016-04-20 Thread Frediano Ziglio
> > No need to re-implement refcounting in this subclass. However, I needed > to add a new 'dcc' member to UpgradeItem to be able to unref properly. > --- > Change since last patch: take ref on dcc > > server/dcc.c | 18 +- > server/display-channel.c | 4 +--- > serv