Re: [Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

2016-04-18 Thread Francois Gouget
On Tue, 19 Apr 2016, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > > I don't know if this is right but it is currently necessary to compile > the Spice server. Ah. I see now that spice is not yet using the spice-common tip. So this patch is not needed. At least not yet. --

[Spice-devel] spice-xpi deprecated soon

2016-04-18 Thread RK RK
Hi Team, I have seen in https://bugs.freedesktop.org/enter_bug.cgi?product=Spice that xpi-activex (Browser plugins (to be deprecated)). Does it mean that spice-xpi (Provided via yum in fedora and centos) will be deprecated and not supported in future releases? If so, then what will be drop in rep

Re: [Spice-devel] 答复: Re: [spice-common PATCH] build-sys: Define opengl GL_LIBS and GL_CFLAGS in generated Makefile.in

2016-04-18 Thread Lin Ma
>>> Christophe Fergeau 2016/4/18 星期一 下午 4:56 >>> >On Mon, Apr 18, 2016 at 02:28:00AM -0600, Lin Ma wrote: >> >>> Christophe Fergeau 2016/4/18 星期一 下午 3:40 >>> >> >Hey, >> > >> >On Mon, Apr 18, 2016 at 03:18:25PM +0800, Lin Ma wrote: >> >> Because we missed variables GL_LIBS and GL_CFLAGS in gene

Re: [Spice-devel] [spice-common v3] use specific subdomains for better filtering

2016-04-18 Thread Victor Toso
Hi, On Mon, Apr 18, 2016 at 05:18:52PM +0200, David Jaša wrote: > On Po, 2016-04-18 at 15:58 +0200, Victor Toso wrote: > > Hi, > > > > On Fri, Apr 15, 2016 at 04:22:05PM +0200, David Jaša wrote: > > > Hi, I like the approach a lot. It seems quite clear and nice to me, > > > but ... > > > > > > On

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

2016-04-18 Thread Francois Gouget
On Mon, 18 Apr 2016, Victor Toso wrote: > Hi, > > On Wed, Mar 02, 2016 at 04:27:34PM +0100, Victor Toso wrote: > > > As I don't see any new issues and also due the fact that stream-video is > > > off by default, I'd ack this two patches > > > > > > Acked-by: Victor Toso > > > > * I tested both p

[Spice-devel] [common] canvas: canvas_fix_alignment() is unused so remove it.

2016-04-18 Thread Francois Gouget
Signed-off-by: Francois Gouget --- I don't know if this is right but it is currently necessary to compile the Spice server. common/canvas_base.c | 17 - 1 file changed, 17 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 45dd75f..7f6231b 100644 --- a

Re: [Spice-devel] [PATCH] fix 16 bpp LZ image decompression

2016-04-18 Thread Frediano Ziglio
> > On Čt, 2016-04-14 at 17:56 +0100, Frediano Ziglio wrote: > > LZ image decompression was broken for 16 bpp: > > - stride was computed not computed correctly (as width*4). This caused > > IMO one extra 'computed' here. > Yes, Jonathon reported the same issue but unfortunately patch was alread

Re: [Spice-devel] [spice-common v3] use specific subdomains for better filtering

2016-04-18 Thread David Jaša
On Po, 2016-04-18 at 15:58 +0200, Victor Toso wrote: > Hi, > > On Fri, Apr 15, 2016 at 04:22:05PM +0200, David Jaša wrote: > > Hi, I like the approach a lot. It seems quite clear and nice to me, > > but ... > > > > On So, 2016-03-12 at 15:32 +0100, Victor Toso wrote: > > > Hi! I've rebased this se

Re: [Spice-devel] [PATCH] fix 16 bpp LZ image decompression

2016-04-18 Thread David Jaša
On Čt, 2016-04-14 at 17:56 +0100, Frediano Ziglio wrote: > LZ image decompression was broken for 16 bpp: > - stride was computed not computed correctly (as width*4). This caused IMO one extra 'computed' here. > also a buffer underflow; > - stride in pixman is always multiple of 4 bytes (so for

Re: [Spice-devel] [spice-gtk v3 18/19] log: create subdomains for spice-gtk

2016-04-18 Thread Eduardo Lima (Etrunko)
On 04/18/2016 10:49 AM, Victor Toso wrote: > Hey, > > On Fri, Apr 15, 2016 at 03:39:44PM +0200, David Jaša wrote: >> Will it be possible to print all existing subdomains? Or would it be >> hard to add? > > It isn't hard to add as a list to print out when requested. > But note that at this moment

Re: [Spice-devel] [spice-common v3] use specific subdomains for better filtering

2016-04-18 Thread Victor Toso
Hi, On Fri, Apr 15, 2016 at 04:22:05PM +0200, David Jaša wrote: > Hi, I like the approach a lot. It seems quite clear and nice to me, > but ... > > On So, 2016-03-12 at 15:32 +0100, Victor Toso wrote: > > Hi! I've rebased this series and pushed to my remote branch in > > freedesktop [0] [1]. I'll

[Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-18 Thread Frediano Ziglio
From: Christophe Fergeau This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1297640 Acked-by: Frediano Ziglio --- src/virt-viewer-util.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c index 279f9a5..8cf52ec 100644 --- a/src/virt-v

Re: [Spice-devel] [spice-gtk v3 18/19] log: create subdomains for spice-gtk

2016-04-18 Thread Victor Toso
Hey, On Fri, Apr 15, 2016 at 03:39:44PM +0200, David Jaša wrote: > Will it be possible to print all existing subdomains? Or would it be > hard to add? It isn't hard to add as a list to print out when requested. But note that at this moment the subdomains are loaded at runtime. > > On So, 2016-03

[Spice-devel] [PATCH] Attempt to manage redirection in a way similar to Unix

2016-04-18 Thread Frediano Ziglio
This patch allows remote-viewer to redirect output/error streams to files. Also if launched from a console program (for instance from the command prompt) you are able to see output from the console where you launch the program. This allow to launch the program with a syntax like > remote-viewer.e

[Spice-devel] [PATCH] Disable IME to allow receiving all keys

2016-04-18 Thread Frediano Ziglio
From: Christophe Fergeau This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1297640 Acked-by: Frediano Ziglio --- src/virt-viewer-util.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c index 279f9a5..8cf52ec 100644 --- a/src/virt-v

Re: [Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-18 Thread Frediano Ziglio
> > On Fri, Apr 15, 2016 at 03:01:37PM -0500, Jonathon Jongsma wrote: > > > @@ -394,21 +376,17 @@ static int > > > red_char_device_read_from_device(RedCharDevice *dev) > > > > > > static void red_char_device_client_send_queue_push(RedCharDeviceClient > > > *dev_client) > > > { > > > -RingI

Re: [Spice-devel] [PATCH 1/2] server: Remove the width and height parameters of encode_frame()

2016-04-18 Thread Victor Toso
Hi, On Wed, Mar 02, 2016 at 04:27:34PM +0100, Victor Toso wrote: > > As I don't see any new issues and also due the fact that stream-video is > > off by default, I'd ack this two patches > > > > Acked-by: Victor Toso > > * I tested both patches but only the first one is related to the > sized-s

Re: [Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-18 Thread Christophe Fergeau
On Fri, Apr 15, 2016 at 03:01:37PM -0500, Jonathon Jongsma wrote: > > @@ -394,21 +376,17 @@ static int > > red_char_device_read_from_device(RedCharDevice *dev) > > > > static void red_char_device_client_send_queue_push(RedCharDeviceClient > > *dev_client) > > { > > -RingItem *item; > > -

Re: [Spice-devel] [PATCH server] coverity: avoid resource leak (82248)

2016-04-18 Thread Frediano Ziglio
> > free data(SpiceChunks) in case of an error > --- > server/red-parse-qxl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c > index 18b7ea6..915056a 100644 > --- a/server/red-parse-qxl.c > +++ b/server/red-parse-qxl.c > @@ -378,6 +378,7

Re: [Spice-devel] [PATCH server] coverity: avoid double free (82258)

2016-04-18 Thread Frediano Ziglio
> > Assign qxl to NULL if red_replay_data_chunks_free(which also free qxl) > is being called > --- > server/red-replay-qxl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c > index 281bc7a..09e79b8 100644 > --- a/server/red-replay-qxl.c

[Spice-devel] [PATCH server] coverity: avoid resource leak (82248)

2016-04-18 Thread Snir Sheriber
free data(SpiceChunks) in case of an error --- server/red-parse-qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c index 18b7ea6..915056a 100644 --- a/server/red-parse-qxl.c +++ b/server/red-parse-qxl.c @@ -378,6 +378,7 @@ static SpiceChunks *

[Spice-devel] [PATCH server] coverity: avoid double free (82258)

2016-04-18 Thread Snir Sheriber
Assign qxl to NULL if red_replay_data_chunks_free(which also free qxl) is being called --- server/red-replay-qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c index 281bc7a..09e79b8 100644 --- a/server/red-replay-qxl.c +++ b/server/red-repl

Re: [Spice-devel] [spice-gtk v4 0/3] Windows Japanese layout workarounds

2016-04-18 Thread Takao Fujiwara
On 04/18/16 18:03, Frediano Ziglio-san wrote: Hi, the patches looks good to me. They should not cause regressions in non-japanese/korean env. Missing release key events can be eventually fixed somewhere else (Windows ? gtk+ ?). Thanks, Pavel Merged! Lot of TODOs... For the scancode I think

Re: [Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-18 Thread Frediano Ziglio
> On Thu, 2016-04-14 at 16:50 -0500, Jonathon Jongsma wrote: > > From: Christophe Fergeau > > > > There was an extra RedCharDeviceMsgToClientItem type whose only > > purpose was to manage a linked list of items to send. GQueue has the > > same purpose as this type in addition to being generic. A

Re: [Spice-devel] [spice-gtk v4 0/3] Windows Japanese layout workarounds

2016-04-18 Thread Frediano Ziglio
> > Hi, > > the patches looks good to me. They should not cause regressions in > non-japanese/korean env. Missing release key events can be eventually > fixed somewhere else (Windows ? gtk+ ?). > > Thanks, > Pavel > Merged! Lot of TODOs... For the scancode I think the best place is GDK (with

Re: [Spice-devel] 答复: Re: [spice-common PATCH] build-sys: Define opengl GL_LIBS and GL_CFLAGS in generated Makefile.in

2016-04-18 Thread Christophe Fergeau
On Mon, Apr 18, 2016 at 02:28:00AM -0600, Lin Ma wrote: > >>> Christophe Fergeau 2016/4/18 星期一 下午 3:40 >>> > >Hey, > > > >On Mon, Apr 18, 2016 at 03:18:25PM +0800, Lin Ma wrote: > >> Because we missed variables GL_LIBS and GL_CFLAGS in generated Makefile.in, > >> The linker flag and the compiler f

[Spice-devel] 答复: Re: [spice-common PATCH] build-sys: Define opengl GL_LIBS and GL_CFLAGS in generated Makefile.in

2016-04-18 Thread Lin Ma
>>> Christophe Fergeau 2016/4/18 星期一 下午 3:40 >>> >Hey, > >On Mon, Apr 18, 2016 at 03:18:25PM +0800, Lin Ma wrote: >> Because we missed variables GL_LIBS and GL_CFLAGS in generated Makefile.in, >> The linker flag and the compiler flag wont be generated in Makefile. >> It causes spice-gtk building f

Re: [Spice-devel] [spice-gtk v4 0/3] Windows Japanese layout workarounds

2016-04-18 Thread Pavel Grunt
Hi, the patches looks good to me. They should not cause regressions in  non-japanese/korean env. Missing release key events can be eventually fixed somewhere else (Windows ? gtk+ ?). Thanks, Pavel On Fri, 2016-04-15 at 12:11 +0100, Frediano Ziglio wrote: > This version contains style change: > -

[Spice-devel] Protocol extensions

2016-04-18 Thread thke...@bluewin.ch
Hi all, I have studied the protocol that a spice client sends to a spice server. If I have a socket listening on a specific port (in spice for example the port 5900). I get on the socket listener a RED_LINK message. From this message I cannot get additional parameters like for example spice://my

Re: [Spice-devel] [spice-common PATCH] build-sys: Define opengl GL_LIBS and GL_CFLAGS in generated Makefile.in

2016-04-18 Thread Christophe Fergeau
Hey, On Mon, Apr 18, 2016 at 03:18:25PM +0800, Lin Ma wrote: > Because we missed variables GL_LIBS and GL_CFLAGS in generated Makefile.in, > The linker flag and the compiler flag wont be generated in Makefile. > It causes spice-gtk building failure with --enable-opengl option. Can you give more d

[Spice-devel] [spice-common PATCH] build-sys: Define opengl GL_LIBS and GL_CFLAGS in generated Makefile.in

2016-04-18 Thread Lin Ma
Because we missed variables GL_LIBS and GL_CFLAGS in generated Makefile.in, The linker flag and the compiler flag wont be generated in Makefile. It causes spice-gtk building failure with --enable-opengl option. The patch fixes this issue. Signed-off-by: Lin Ma --- m4/spice-deps.m4 | 2 ++ 1 fil

Re: [Spice-devel] [spice-gtk v4 1/3] Send Zenkaku_Hankaku key in JP keyboard

2016-04-18 Thread Takao Fujiwara
I verified v4. On 04/15/16 20:11, Frediano Ziglio-san wrote: > From: Takao Fujiwara > > Zenkaku_Hankaku key has the different virtual-key codes between WM_KEYDOWN > and WM_KEYUP and MapVirtualKey() cannot get the scancode from virtual-key > code of WM_KEYDOWN (VK_DBE_DBCSCHAR) and spice-gtk didn