Acked-by: Jonathon Jongsma
On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote:
> From: Christophe Fergeau
>
> Now that client messages are always RedPipeItem, we don't need virtual
> functions to know how to ref/unref them.
> ---
> server/char-device.c | 26 --
>
Acked-by: Jonathon Jongsma
On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote:
> From: Christophe Fergeau
>
> Now that all derived classes use a type deriving from RedPipeItem for
> their RedCharDeviceMsgToClient, we can make this explicit in the
> RedCharDeviceClass vfuncs, and remove t
On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote:
> From: Christophe Fergeau
>
> This allows to reuse red_pipe_item_{ref, unref} rather than
> reimplementing them in spicevmc.c
> ---
> server/spicevmc.c | 31 ---
> 1 file changed, 8 insertions(+), 23 deletion
On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote:
> From: Christophe Fergeau
>
> This allows to reuse red_pipe_item_{ref, unref} rather than
> reimplementing them in smartcard.c
> ---
> server/smartcard.c | 37 +
> 1 file changed, 13 insertions(+), 24
On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote:
> From: Christophe Fergeau
>
> Since RedPipeItem is already refcounted, this allows to remove various
> layers of ref/unref helpers from reds.c, and use the generic
> red_pipe_item_{ref, unref} instead.
Hmm, I don't know if I like making
On Mon, 2016-04-11 at 09:40 +0200, Christophe Fergeau wrote:
> On Fri, Apr 08, 2016 at 03:33:03PM -0500, Jonathon Jongsma wrote:
> > I don't know if something got messed up during a rebase (that doesn't appear
> > to
> > be the case), but I don't really understand this commit or how the patch
> > r
>
> Zenkaku_Hankaku key has the different virtual-key codes between WM_KEYDOWN
> and WM_KEYUP and MapVirtualKey() cannot get the scancode from virtual-key
> code of WM_KEYDOWN (VK_DBE_DBCSCHAR) and spice-gtk didn't send the key
> press events and caused the desktop freeze with unlimited key releas
>
> Please note the internal ImmDisableIME.patch needs to be disabled to get the
> WM_INPUTLANGCHANGE signal with mouse but no ImmDisableIME.patch causes a
> SEGV with Ctrl+Shift or Alt+Shift.
>
Is not clear what you are suggesting with this.
Should ImmDisableIME.patch be used or not? Why it SEG
>
> On Fri, Apr 08, 2016 at 09:48:32AM +0200, Pavel Grunt wrote:
> > Hi,
> >
> > On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote:
> > > From: Christophe Fergeau
> > >
> > > related to 7d375e0
> > > workaround a runtime check in red_pipe_item_ref()
> >
> > Should the refcount be initia
>
> From: Christophe Fergeau
>
> This is similar to PipeItem (which is a type id + a RingItem linked list
> member), except that it's refcounted. A user-defined callback is called
> when the refcount drops to 0.
> Refcounted is open coded for several classes deriving from PipeItem, so
> this bas
https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl
0001-Remove-unused-variables.patch
...
0036-spiceqxl_audio-Stop-the-playback-channel-if-there-is.patch
36 patches queueing from the last xf86-video-qxl release - 0.1.4,
dates from 2015-04-02 - over a year.
Perhaps the time is right for a
Hi,
On Mon, Apr 11, 2016 at 11:59:58AM +0200, Pavel Grunt wrote:
> On Mon, 2016-04-11 at 11:54 +0200, Victor Toso wrote:
>
> Acked-by: Pavel Grunt
Thanks, pushed
> > ---
> > ChangeLog| 2 +-
> > src/console-kit.c| 10 +-
> > src/dummy-session-info.c
On Mon, 2016-04-11 at 11:54 +0200, Victor Toso wrote:
Acked-by: Pavel Grunt
> ---
> ChangeLog| 2 +-
> src/console-kit.c| 10 +-
> src/dummy-session-info.c | 6 +++---
> src/session-info.h | 6 +++---
> src/systemd-login.c | 6 ++
---
ChangeLog| 2 +-
src/console-kit.c| 10 +-
src/dummy-session-info.c | 6 +++---
src/session-info.h | 6 +++---
src/systemd-login.c | 6 +++---
src/udscs.c | 8
src/udscs.h | 8 --
Hi,
On Mon, Apr 11, 2016 at 11:47:47AM +0200, Pavel Grunt wrote:
> Hi,
>
> git grep "[[:space:]]$" shows one more in the ChangeLog
>
> Pavel
Thanks! I'm sending the v3 shortly ;)
>
> On Mon, 2016-04-11 at 11:33 +0200, Victor Toso wrote:
> > ---
> > src/console-kit.c| 10 +-
>
Hi,
git grep "[[:space:]]$" shows one more in the ChangeLog
Pavel
On Mon, 2016-04-11 at 11:33 +0200, Victor Toso wrote:
> ---
> src/console-kit.c| 10 +-
> src/dummy-session-info.c | 6 +++---
> src/session-info.h | 6 +++---
> src/systemd-login.c |
---
src/console-kit.c| 10 +-
src/dummy-session-info.c | 6 +++---
src/session-info.h | 6 +++---
src/systemd-login.c | 6 +++---
src/udscs.c | 8
src/udscs.h | 8
src/vdagent-file-xfers.c | 6
Hi,
On Mon, Apr 11, 2016 at 10:19:05AM +0200, Christophe Fergeau wrote:
> On Mon, Apr 11, 2016 at 10:00:45AM +0200, Victor Toso wrote:
> > Removing glib-compat header as it isn't used anymore.
>
> Acked-by: Christophe Fergeau
Thanks, pushed
>
> > ---
> > Makefile.am | 3 +--
> >
>
> Hmm, I don't think I really agree here. I don't object to the typedefs, but
> in
> general I'd prefer a wrapper function to a cast for added type-safety.
>
Me too. We are getting too much type unsafe for my tastes.
> Reviewed-by: Jonathon Jongsma
>
>
Frediano
> On Thu, 2016-04-07 at 1
On Mon, Apr 11, 2016 at 10:00:45AM +0200, Victor Toso wrote:
> Removing glib-compat header as it isn't used anymore.
Acked-by: Christophe Fergeau
> ---
> Makefile.am | 3 +--
> configure.ac | 2 +-
> src/glib-compat.h| 43 --
Hey everyone,
I've cut another development release, with once again a lot of changes.
The cleanup of the spice-server codebase has been moving forward.
THIS IS STILL AN UNSTABLE RELEASE. It's meant as a checkpoint of the work
going on, and will let early testers try it out. Bugs can be reported
Removing glib-compat header as it isn't used anymore.
---
Makefile.am | 3 +--
configure.ac | 2 +-
src/glib-compat.h| 43 ---
src/vdagent-file-xfers.c | 1 -
4 files changed, 2 insertions(+), 47 deletions(-)
delete mode
Hi,
On Mon, Apr 11, 2016 at 09:44:57AM +0200, Christophe Fergeau wrote:
> On Sat, Apr 09, 2016 at 09:16:37AM +0200, Victor Toso wrote:
> > ConsoleKit is no longer maintained upstream. New code should be focusing
> > with the integration with systemd-logind.
>
> Is that causing actual issues? (apar
On Sat, Apr 09, 2016 at 09:16:37AM +0200, Victor Toso wrote:
> ConsoleKit is no longer maintained upstream. New code should be focusing
> with the integration with systemd-logind.
Is that causing actual issues? (apart from the need to keep it
around/maintain it). Older distros do not have systemd
On Sat, Apr 09, 2016 at 10:58:47AM +0200, Victor Toso wrote:
> Hi,
>
> On Sat, Apr 09, 2016 at 04:43:17AM -0400, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> > > 2.38 is the version that we are using in spice-gtk since:
> > > 8693e7d3f7de1ff102082212fa6e35fb1a252ef7
> > >
On Mon, Apr 11, 2016 at 09:29:59AM +0200, Christophe Fergeau wrote:
> One more duplicate typedef, once in reds.c and another time in
> reds-private.h
> RedsState::agent_dev is defined in reds-private.h but only used in
> reds.c, so longer term this could all be moved back to reds.c
Acked-by: Victo
On Fri, Apr 08, 2016 at 03:33:03PM -0500, Jonathon Jongsma wrote:
> I don't know if something got messed up during a rebase (that doesn't appear
> to
> be the case), but I don't really understand this commit or how the patch
> relates
> to the commit log...
>
Fairly cryptic indeed, and it does
One more duplicate typedef, once in reds.c and another time in
reds-private.h
RedsState::agent_dev is defined in reds-private.h but only used in
reds.c, so longer term this could all be moved back to reds.c
---
server/reds.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/reds.c b/server
28 matches
Mail list logo
