[Spice-devel] [vdagent-linux v1] remove trailing spaces

2016-04-08 Thread Victor Toso
--- src/console-kit.c| 10 +- src/dummy-session-info.c | 6 +++--- src/glib-compat.h| 6 +++--- src/session-info.h | 6 +++--- src/systemd-login.c | 6 +++--- src/udscs.c | 8 src/udscs.h | 8 ++

Re: [Spice-devel] [PATCH 04/14] reds: Put PipeItem first in VDIReadBuf

2016-04-08 Thread Jonathon Jongsma
I don't know if something got messed up during a rebase (that doesn't appear to be the case), but I don't really understand this commit or how the patch relates to the commit log... On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > This is a bit artificial

Re: [Spice-devel] [PATCH 03/14] Introduce simple RedPipeItem class

2016-04-08 Thread Jonathon Jongsma
On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > This is similar to PipeItem (which is a type id + a RingItem linked list > member), except that it's refcounted. A user-defined callback is called > when the refcount drops to 0. It's not so much "like" a P

Re: [Spice-devel] [PATCH 01/14] Move RedCharDeviceCallbacks into RedCharDeviceClass

2016-04-08 Thread Jonathon Jongsma
This patch has already merged On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > This structure holding virtual function pointers was kept until now as a > RedCharDevice member in order to make the GObject conversion easier. > Now that all RedCharDevice chi

Re: [Spice-devel] [PATCH 02/14] RedCharDevice: Add typedef for class virtual functions

2016-04-08 Thread Jonathon Jongsma
Hmm, I don't think I really agree here. I don't object to the typedefs, but in general I'd prefer a wrapper function to a cast for added type-safety. Reviewed-by: Jonathon Jongsma On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > When initializing the c

Re: [Spice-devel] [PATCH spice-gtk] Ensure that file transfers get cancelled

2016-04-08 Thread Jonathon Jongsma
Thanks, pushed On Fri, 2016-04-08 at 11:28 +0200, Pavel Grunt wrote: > On Thu, 2016-04-07 at 15:51 -0500, Jonathon Jongsma wrote: > > When canceling a file transfer task in spicy, the client would often > > stop sending additional data, but it would not send a "CANCELLED" > > message to the guest

Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop

2016-04-08 Thread Lukas Venhoda
Hi. *From: *Victor Toso *Sent: *pátek 8. dubna 2016 9:12 *To: *Lukas Venhoda *Cc: *spice-devel@lists.freedesktop.org *Subject: *Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop > @@ -749,6 +749,7 @@ typedef enum _MapDriveEnum > > typedef

Re: [Spice-devel] [PATCH 06/14] FIXME/HACK: RedPipeItem/VDIPortBuf refcounting hack

2016-04-08 Thread Fergeau, Christophe
On Fri, Apr 08, 2016 at 09:48:32AM +0200, Pavel Grunt wrote: > Hi, > > On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote: > > From: Christophe Fergeau > > > > related to 7d375e0 > > workaround a runtime check in red_pipe_item_ref() > > Should the refcount be initialized by red_pipe_item_

Re: [Spice-devel] [PATCH spice-gtk] Ensure that file transfers get cancelled

2016-04-08 Thread Pavel Grunt
On Thu, 2016-04-07 at 15:51 -0500, Jonathon Jongsma wrote: > When canceling a file transfer task in spicy, the client would often > stop sending additional data, but it would not send a "CANCELLED" > message to the guest. Because of this, the partial file would remain > in > the guest's downloads f

Re: [Spice-devel] [PATCH 10/10] Move RedCharDeviceCallbacks into RedCharDeviceClass

2016-04-08 Thread Christophe Fergeau
Hey, On Thu, Apr 07, 2016 at 11:58:05AM -0500, Jonathon Jongsma wrote: > On Thu, 2016-04-07 at 11:54 +0200, Christophe Fergeau wrote: > > On Fri, Apr 01, 2016 at 03:51:44PM -0500, Jonathon Jongsma wrote: > > > diff --git a/server/smartcard.c b/server/smartcard.c > > > index 52d56ea..0238efe 100644

Re: [Spice-devel] [PATCH 06/14] FIXME/HACK: RedPipeItem/VDIPortBuf refcounting hack

2016-04-08 Thread Pavel Grunt
Hi, On Thu, 2016-04-07 at 17:11 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > related to 7d375e0 > workaround a runtime check in red_pipe_item_ref() Should the refcount be initialized by red_pipe_item_init? Pavel > --- >  server/reds.c | 3 ++- >  1 file changed, 2 insertions(+)

Re: [Spice-devel] [phodav PATCH 3/3 v5] spice-webdavd-windows: Dismount shared folder on service stop

2016-04-08 Thread Victor Toso
Hi, On Thu, Apr 07, 2016 at 05:44:53PM +0200, Lukas Venhoda wrote: > When stopping the service, automatically disconnect shared folder on > windows. Not dismounting could lead to multiple shared folders. > --- > Changes since v4: > - Dont lookup drive letter when unmapping > - Uses a service_