When you try to redirect a usb device to the guest and it fails, we
uncheck the checkbox for this device. This causes the 'clicked' signal
to be emitted, which causes us to try to disconnect the device (which is
not currently connected, since the connect operation failed).
When we try to disconnec
_connect_device_async_cb() just turned TRUE unconditionally even if the
sub-task had failed. Instad, introduce a
_spice_usb_device_manager_connect_device_finish() function which passes
up the result of the subtask.
---
src/usb-device-manager.c | 19 +--
1 file changed, 17 insertion
I discovered that the UsbDeviceManager doesn't handle device connection errors
properly after the latest GTask and async usb changes. I reproduced this
because my usb acl helper executable wasn't properly owned by root with u+s, so
the set_facl() function failed. In this situation, the usb device w
On 03/24/2016 01:26 PM, Cole Robinson wrote:
> On 03/24/2016 01:08 PM, Christophe Fergeau wrote:
>> On Thu, Mar 24, 2016 at 12:59:04PM -0400, Cole Robinson wrote:
+Configuration
+-
+
+.Using libvirt
+
+You need to add a virtio-gpu video device to your virtu
On 03/24/2016 01:08 PM, Christophe Fergeau wrote:
> On Thu, Mar 24, 2016 at 12:59:04PM -0400, Cole Robinson wrote:
>> I'm trying to test this stuff at the moment. Some comments and questions
>> below
>> (not an ACK or NACK, I see the patch was already pushed)
>>
>> On 03/18/2016 12:12 PM, Christop
On Thu, Mar 24, 2016 at 12:59:04PM -0400, Cole Robinson wrote:
> I'm trying to test this stuff at the moment. Some comments and questions below
> (not an ACK or NACK, I see the patch was already pushed)
>
> On 03/18/2016 12:12 PM, Christophe Fergeau wrote:
> > Document how to use virgl with QEMU/l
I'm trying to test this stuff at the moment. Some comments and questions below
(not an ACK or NACK, I see the patch was already pushed)
On 03/18/2016 12:12 PM, Christophe Fergeau wrote:
> Document how to use virgl with QEMU/libvirt
>
> virt-manager documentation still needs to be added.
> ---
>
On 03/24/2016 10:20 AM, Christophe Fergeau wrote:
> Hey,
>
> Sorry, hadn't noticed this message earlier.
>
> On Wed, Mar 09, 2016 at 01:43:14PM -0600, Jeremy White wrote:
>> I realize I'm rather late to the party, but this change causes
>> troubles with Xspice.
>>
>> That is, Xorg, on startup, c
Yes, this is the most significant problem of this project. I do not have
time at all now. All I can to do now is to suggest you to try put the
line to the repaint function I wrote you some time ago and put an debug
output about the damage argument.
You will see then how does it affects to the
On Thu, Mar 24, 2016 at 11:08:15AM -0500, Jonathon Jongsma wrote:
> Yeah, I agree that it's not clear who should free all of this stuff. The
> mismatch in types was probably caused by recent changes and rebasing old
> patches
> on top?
>
Yes, exactly that.
Christophe
signature.asc
Descriptio
Il 24/03/2016 17:13, Yury Shvedov ha scritto:
Fabio, can you please explain me, why do you continue performance
testing the thing what already known to have an awful performance and
the way of fixing that?
You right, I must try to do significant changes instead (probably
following rdp composi
CursorChannel and DisplayChannel was initialized half in red_worker_new
and half in red_dispatcher_init using some accessor for RedWorker
(red_worker_get_cursor_channel and red_worker_get_display_channel).
Moving directly into red_worker_new make easier to follow code path.
Signed-off-by: Frediano
>
> Hey,
>
> On Thu, Mar 24, 2016 at 02:19:21PM +, Frediano Ziglio wrote:
> > There is no need callbacks knows about internal QXLState.
> >
> looks good,
> Acked-by: Christophe Fergeau
>
> Reminded me of
> https://lists.freedesktop.org/archives/spice-devel/2016-March/027330.html
> which is
>
> On Tue, Mar 15, 2016 at 05:11:36PM -0400, Frediano Ziglio wrote:
> > > -static void red_channel_client_default_disconnect(RedChannelClient
> > > *base)
> > > +static void red_channel_client_default_disconnect(RedChannelClient
> > > *base,
> > > gpointer cbs_data)
> > > {
> > > red_channe
Fabio, can you please explain me, why do you continue performance
testing the thing what already known to have an awful performance and
the way of fixing that?
On 03/24/2016 07:08 PM, Fabio Fantoni wrote:
Il 24/03/2016 16:47, Yury Shvedov ha scritto:
Hi!
Very thank you, but we know and alrea
On Wed, 2016-03-23 at 12:46 -0400, Frediano Ziglio wrote:
> >
> > On Wed, Mar 23, 2016 at 12:48:28PM +, Frediano Ziglio wrote:
> > > From: Jonathon Jongsma
> > >
> > > ---
> > > server/red-qxl.c | 7 +++
> > > server/red-qxl.h | 1 +
> > > server/reds.c| 2 ++
> > > 3 files changed,
Il 24/03/2016 16:47, Yury Shvedov ha scritto:
Hi!
Very thank you, but we know and already fixed that =)
On 03/24/2016 06:40 PM, Christophe Fergeau wrote:
Hey,
On Sun, Feb 28, 2016 at 03:36:58PM +0100, Fabio Fantoni wrote:
I did fast build tests, I fixed one my mistake in Makefile.am and
afte
On Thu, 2016-03-24 at 12:18 +0100, Marc-André Lureau wrote:
> Hi Jonathon
>
> On Wed, Mar 23, 2016 at 8:58 PM, Jonathon Jongsma wrote:
> > > It also solves/avoids problems with a guest running on wayland when the
> > > "resize-guest" property is TRUE.
> > > See bug https://bugzilla.redhat.com/sho
Hi!
Very thank you, but we know and already fixed that =)
On 03/24/2016 06:40 PM, Christophe Fergeau wrote:
Hey,
On Sun, Feb 28, 2016 at 03:36:58PM +0100, Fabio Fantoni wrote:
I did fast build tests, I fixed one my mistake in Makefile.am and after I
had this error:
src/spice/weston_basic_eve
Check whether Spice Folder is already mapped.
If yes, don't try to map another one.
---
Changes since v3:
- changed function is_spice_folder_mapped to get_spice_folder_letter
- Now returns the mapped folder drive letter
- This can be used to call unmap_drive
- No need for global variab
Hey,
On Sun, Feb 28, 2016 at 03:36:58PM +0100, Fabio Fantoni wrote:
>
> I did fast build tests, I fixed one my mistake in Makefile.am and after I
> had this error:
> >src/spice/weston_basic_event_loop.h:27:31: fatal error: weston/compositor.h:
> >No such file or directory
> I fixed with this eve
When stopping the service, automatically disconnect shared folder on
windows. Not dismounting could lead to multiple shared folders.
---
Changes since v3:
- Better handeling of string names
- Syntax cleanup
- Remove global variable drive_letter
- Now scans for mapped drive and unmaps it
Cha
Try to connect to shared folder automatically on Windows.
On each loop of run_service(), run a GTask, that waits for 0.5s.
If sharing is disabled, read_thread will immediately return and cause the
main_loop to stop.
This in turn causes the cancellable object to be canceled and the loop stops.
If
Hey,
Sorry, hadn't noticed this message earlier.
On Wed, Mar 09, 2016 at 01:43:14PM -0600, Jeremy White wrote:
> I realize I'm rather late to the party, but this change causes troubles
> with Xspice.
>
> That is, Xorg, on startup, closes stdout.
>
> Since the g_log_default_handler writes to std
H
On Thu, Mar 24, 2016 at 10:34 AM, Victor Toso wrote:
> Hi,
>
> On Thu, Mar 17, 2016 at 02:47:51PM +0100, Lukas Venhoda wrote:
> > When stopping the service, automatically disconnect shared folder on
> > windows. Not dismounting could lead to multiple shared folders.
>
> But when user disconnec
Hi,
On Thu, Mar 24, 2016 at 10:46 AM, Victor Toso wrote:
> Hi,
>
> On Thu, Mar 17, 2016 at 02:47:50PM +0100, Lukas Venhoda wrote:
> > Check whether Spice Folder is already mapped.
> > If yes, don't try to map another one.
>
> I have found some issue with this. If I disconnect a session that
> wa
On Thu, Mar 24, 2016 at 02:19:22PM +, Frediano Ziglio wrote:
> CursorChannel and DisplayChannel was initialized half in red_worker_new
> and half in red_dispatcher_init using some accessor for RedWorker
> (red_worker_get_cursor_channel and red_worker_get_display_channel).
> Moving directly into
Hey,
On Thu, Mar 24, 2016 at 02:19:21PM +, Frediano Ziglio wrote:
> There is no need callbacks knows about internal QXLState.
>
looks good,
Acked-by: Christophe Fergeau
Reminded me of
https://lists.freedesktop.org/archives/spice-devel/2016-March/027330.html
which is still pending :(
Chris
Hey,
On Mon, Mar 14, 2016 at 12:39:02AM +0100, Francois Gouget wrote:
> Rename the function to channel_supports_multiple_clients() as
> channel_is_secondary() is unclear and was coded to return the opposite
> of what was originally intended.
> Also there are few channel types and whether they supp
CursorChannel and DisplayChannel was initialized half in red_worker_new
and half in red_dispatcher_init using some accessor for RedWorker
(red_worker_get_cursor_channel and red_worker_get_display_channel).
Moving directly into red_worker_new make easier to follow code path.
Signed-off-by: Frediano
There is no need callbacks knows about internal QXLState.
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index c8e1378..8ba6fd6 100644
--- a/serve
On Thu, Mar 17, 2016 at 01:37:13PM -0500, Jeremy White wrote:
> Hi Eric,
>
> This is great; thanks for taking the time to put this together.
Yes, thanks for that ;)
>
> Could I ask a few favors, though? This version did not apply to the git
> tip for me. I think a few corrections Christophe m
On Fri, Mar 18, 2016 at 04:09:14PM -0500, Jeremy White wrote:
> Hey Francois,
>
> On 03/18/2016 09:31 AM, Francois Gouget wrote:
> >
> > While testing the video streaming I ran into a number of issues caused
> > by Xspice's audio playback. So I investigated those and found fixes
> > which gives
>
> Hi,
>
> On Thu, Mar 24, 2016 at 08:53:01AM +, Frediano Ziglio wrote:
> > This function is used only for debugging
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/spice-bitmap-utils.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/server/spice-bitmap-utils.c
On Wed, Mar 23, 2016 at 05:59:03PM +0100, Pavel Grunt wrote:
> On Wed, 2016-03-23 at 17:45 +0100, Christophe Fergeau wrote:
> > But it seems these are good enough, when I tested this, Xorg was
> > picking
> > the QXL driver, which gave me a blackscreen with the f23 packages.
> > With
> > packages f
On Thu, 2016-03-24 at 12:32 +0100, Marc-André Lureau wrote:
> Once the egl/GL context are initialized, check if there is a scanout
> to
> associate to display widget. This solves races when scanout update is
> happening before the egl/GL context is ready.
>
> Signed-off-by: Marc-André Lureau
Acke
Removed in
*39e1cbe3211b06bca6e5d906ffb4d0582440c5cc*
I would ack it but Fabiano had some comments about it
https://lists.freedesktop.org/archives/spice-devel/2015-November/024060.html
On Thu, Mar 24, 2016 at 12:45 PM, Victor Toso wrote:
> Hi,
>
> On Thu, Mar 24, 2016 at 08:53:00AM +,
Hi,
On Thu, Mar 24, 2016 at 08:53:00AM +, Frediano Ziglio wrote:
> Support for this debugging was removed time ago.
>
Can you point it out when it was removed?
Thanks,
> Signed-off-by: Frediano Ziglio
> ---
> server/tree.c | 161
> --
Hi,
On Thu, Mar 24, 2016 at 08:53:02AM +, Frediano Ziglio wrote:
> No need to have callback registered internally no static
Acked-by: Victor Toso
>
> Signed-off-by: Frediano Ziglio
> ---
> server/smartcard.c | 4 ++--
> server/spicevmc.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 de
Hi,
On Thu, Mar 24, 2016 at 08:53:01AM +, Frediano Ziglio wrote:
> This function is used only for debugging
>
> Signed-off-by: Frediano Ziglio
> ---
> server/spice-bitmap-utils.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/server/spice-bitmap-utils.c b/server/spice-bitmap-uti
Hi,
On Thu, Mar 24, 2016 at 08:52:59AM +, Frediano Ziglio wrote:
> This helper call a deprecated callback.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> server/red-qxl.c | 6 --
> server/red-qxl.h | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/server/red
Hi,
On Thu, Mar 24, 2016 at 08:52:58AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> server/reds.c | 10 --
> server/reds.h | 1 -
> 2 files changed, 11 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 38a369c..eb2430
Once the egl/GL context are initialized, check if there is a scanout to
associate to display widget. This solves races when scanout update is
happening before the egl/GL context is ready.
Signed-off-by: Marc-André Lureau
---
src/spice-widget-egl.c | 6 ++
1 file changed, 6 insertions(+)
dif
If egl display is enabled, use GL scanout geometry to check intersection
with the monitor area. This solves displaying GL display without
software canvas (currently d->area is empty and gl drawing fails)
Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
---
src/spice-widget.c | 41
The following changes will call these functions from spice-widget-egl.c
Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
---
src/spice-widget-priv.h | 3 +++
src/spice-widget.c | 17 +++--
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/src/spice-widget-p
If there is no valid scanout, return NULL.
Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
---
src/channel-display.c | 4 ++--
src/spice-widget.c| 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/channel-display.c b/src/channel-display.c
index 2c54df7..90d155e
With virgl, set_monitor_ready() may be called each time the scanout is
updated to set the monitor area. This will call
spice_main_update_display(), and keep the timer postponed even if the
monitor configuration didn't change. Treat unchanged configuration as a
no-op and keep configuration timer unc
The GLArea is realized lazily, when it is made visible in
set_egl_enabled(). The egl context is initialized once the GLArea is
realized. Enable egl before updating the scanout.
Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
---
src/spice-widget.c | 6 +++---
1 file changed, 3 insertions
Add a new GL status field to check if the GL context is ready. This
helps debugging races where GL is called before the context is ready.
Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
---
src/spice-widget-egl.c | 10 --
src/spice-widget-priv.h | 1 +
src/spice-widget.c |
d->ready is updated based on monitor area & canvas. In case of GL
rendering, update it based on monitor area & scanout and add check
before drawing update.
Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
---
src/spice-widget-egl.c | 6 ++
src/spice-widget.c | 6 +-
2 files ch
The following series fixes GL-only display (when there is no 2d
primary canvas at all). A few cleanups also fix Wayland display.
v2->v3:
- use != NULL in condition
- improve commit messages, add acked tags
- add some code comments
- reorder last 2 patches
v1->v2:
- fix mingw build
- add a patch t
The egl call is already inside a X11 conditional block.
Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
---
src/spice-widget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 08040d3..2a64443 100644
--- a/src/spice-widget.c
+++ b/src/spi
Hi,
On Wed, Mar 23, 2016 at 03:47:37PM +0100, Christophe Fergeau wrote:
> Acked-by: Christophe Fergeau
>
Thanks, pushed.
> On Wed, Mar 23, 2016 at 03:42:30PM +0100, Victor Toso wrote:
> > 7 bytes in 1 blocks are definitely lost in loss record 128 of 10,009
> >at 0x4C2A988: calloc (vg_replac
Hi Jonathon
On Wed, Mar 23, 2016 at 8:58 PM, Jonathon Jongsma wrote:
>> It also solves/avoids problems with a guest running on wayland when the
>> "resize-guest" property is TRUE.
>> See bug https://bugzilla.redhat.com/show_bug.cgi?id=1266484 ;
>> It avoids destroying the primary surface when the
On Thu, 2016-03-24 at 11:59 +0100, Marc-André Lureau wrote:
> On Thu, Mar 24, 2016 at 12:39 AM, Marc-André Lureau om> wrote:
> >
> > >
> > > When / how it can happen ? Looking at gl_scanout() there is
> > > g_return if
> > > scanout == NULL, if NULL is a valid/expected return value then
> > > th
On Thu, Mar 24, 2016 at 12:39 AM, Marc-André Lureau wrote:
>> When / how it can happen ? Looking at gl_scanout() there is g_return if
>> scanout == NULL, if NULL is a valid/expected return value then that
>> g_return should be changed.
>
> Good point. AI think I wrote this initially thinking that
Hi,
On Thu, Mar 24, 2016 at 10:57:49AM +0100, Victor Toso wrote:
> Hi,
>
> On Thu, Mar 17, 2016 at 02:47:44PM +0100, Lukas Venhoda wrote:
> > This is hopefully the final automounting patch series.
> >
> > Includes small bug fixes, that I found when working on windows shared
> > folder auto mounti
Hi,
On Thu, Mar 17, 2016 at 02:47:44PM +0100, Lukas Venhoda wrote:
> This is hopefully the final automounting patch series.
>
> Includes small bug fixes, that I found when working on windows shared folder
> auto mounting
> Theese were already ACKed, but weren't pushed yet.
Yep. I'll be pushing t
Hi,
On Thu, Mar 17, 2016 at 02:47:50PM +0100, Lukas Venhoda wrote:
> Check whether Spice Folder is already mapped.
> If yes, don't try to map another one.
I have found some issue with this. If I disconnect a session that
was sharing the folder (~/public) and connect again and start sharing
(~/dow
Hi,
On Thu, Mar 17, 2016 at 02:47:51PM +0100, Lukas Venhoda wrote:
> When stopping the service, automatically disconnect shared folder on
> windows. Not dismounting could lead to multiple shared folders.
But when user disconnect, the service is not stopped, correct? I think
we need some integrati
No need to have callback registered internally no static
Signed-off-by: Frediano Ziglio
---
server/smartcard.c | 4 ++--
server/spicevmc.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/smartcard.c b/server/smartcard.c
index c63fea3..e933c38 100644
--- a/server/
This helper call a deprecated callback.
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c | 6 --
server/red-qxl.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index fbce510..c8e1378 100644
--- a/server/red-qxl.c
+++ b/server/red-qxl.c
@@ -657,12
This set of patches remove some unused functions and
make static some functions not required to be global.
Frediano Ziglio (5):
remove unused reds_set_mm_time
removed unused red_qxl_set_mm_time
removed unused tree debugging function
do not compile dump_bitmap if not necessary
make some f
Signed-off-by: Frediano Ziglio
---
server/reds.c | 10 --
server/reds.h | 1 -
2 files changed, 11 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 38a369c..eb24303 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -4151,16 +4151,6 @@ void reds_client_monitors_config(RedsSt
This function is used only for debugging
Signed-off-by: Frediano Ziglio
---
server/spice-bitmap-utils.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/server/spice-bitmap-utils.c b/server/spice-bitmap-utils.c
index d13d757..a423ad9 100644
--- a/server/spice-bitmap-utils.c
+++ b/server/spi
Support for this debugging was removed time ago.
Signed-off-by: Frediano Ziglio
---
server/tree.c | 161 --
server/tree.h | 1 -
2 files changed, 162 deletions(-)
diff --git a/server/tree.c b/server/tree.c
index 9e5a281..3866616 100644
-
66 matches
Mail list logo
