On Mon, Mar 14, 2016 at 10:41 PM, Jonathon Jongsma wrote:
> Looks good to me. ACK series.
Pushed, thanks!
>
> On Mon, 2016-03-14 at 16:18 +0100, Fabiano Fidêncio wrote:
>> Changes since v2:
>> - Rebase on top of upstream/master
>> - usb-acl-helper doesn't crash anymore, due to Jonathon's
>> pa
Looks good to me. ACK series.
On Mon, 2016-03-14 at 16:18 +0100, Fabiano Fidêncio wrote:
> Changes since v2:
> - Rebase on top of upstream/master
> - usb-acl-helper doesn't crash anymore, due to Jonathon's
> patches pushed before the release
> - All patches got ACK'ed by Jonathon at some point,
Hi there,
I realized I was going the wrong way to fix the issue. The keyboard layout
shouldnt be setup by the client end as it's defined by Xorg end. But Xspice
ignores keyboard config. This could be fixed thanks to setxkbmap in .xinitrc.
In fact whatever the key is A or Q the keycode sent to X
can_feed() depends on the time and thus could return false in
process_fifos(), causing it to stop reading from the fifos, and then
true in watch_or_wait() so that the wall_timer would not be set, but
the fifos would not be watched either because they already contain
data to process. The audio playb
Simply keep reading from the fifos in reasonably sized chunks.
Signed-off-by: Francois Gouget
---
src/spiceqxl_audio.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/src/spiceqxl_audio.c b/src/spiceqxl_audio.c
index 1aebe8d..080a6f9 100
It's always called at the same time as red_channel_register_client_cbs()
and the data is used by the callbacks, so we can pass the data as an
argument to red_channel_register_client_cbs().
---
server/inputs-channel.c | 2 +-
server/main-channel.c | 2 +-
server/red-channel.c| 13 --
It's only used by these callbacks, moving it there makes things clearer
about its intended use.
---
server/inputs-channel.c | 5 +++--
server/main-channel.c | 2 +-
server/red-channel.c| 24 +---
server/red-channel.h| 9 -
server/red-qxl.c| 25 +
---
server/red-qxl.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index f720fd5..408159d 100644
--- a/server/red-qxl.c
+++ b/server/red-qxl.c
@@ -1005,12 +1005,6 @@ struct Dispatcher *red_qxl_get_dispatcher(QXLState
*qxl_state)
return &qxl_stat
---
server/dcc-send.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index a1f9214..eb866cf 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -2307,12 +2307,12 @@ static void marshall_gl_scanout(RedChannelClient *rcc,
Add red_qxl_ methods wrapping the QXLInterface vfuncs. This allows to
remove most of the qxl_get_interface() use outside of red-qxl.c
---
server/cursor-channel.c | 2 +-
server/display-channel.c | 4 +--
server/red-qxl.c | 78 +++-
server/red-
Hey,
This series really is 2 separate ones, first 3 patches, and then the rest. I
can try to separate them if that makes reviewing easier.
First 3 patches are some cleanup around ClientCbs, they move the user_data
associated with the callbacks to the ClientCbs structure as was done recently
for Vi
---
server/red-qxl.h| 1 +
server/red-worker.c | 8
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/server/red-qxl.h b/server/red-qxl.h
index f58d42b..7287740 100644
--- a/server/red-qxl.h
+++ b/server/red-qxl.h
@@ -44,6 +44,7 @@ gboolean red_qxl_get_allow_client_mouse(
This seems to make more sense this way, QXLInstance is the 'main' object
with QXLState being its private data. External users then use QXLInstance
rather than passing a pointer to the private data to red-qxl.h methods.
---
server/dcc-send.c| 4 +-
server/display-channel.c | 2 +-
serve
num_common_cap rather than num_common_caps was not consistent with
the naming of the other arguments.
---
server/red-channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red-channel.h b/server/red-channel.h
index 51d606e..ca06b4a 100644
--- a/server/red-channel.h
++
Signed-off-by: Francois Gouget
---
More are probably needed but at least those would have helped me when I
started looking at this code. (As would renaming SndWorker to SndState
and making it clearer it's a base class.)
server/sound.c | 12
1 file changed, 8 insertions(+), 4 dele
Signed-off-by: Francois Gouget
---
server/sound.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 1aa3a74..03d88eb 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -183,13 +183,13 @@ static uint32_t playback_compression = TRU
Hi
- Original Message -
> On Fr, 2016-03-11 at 21:50 +0100, Marc-André Lureau wrote:
> > 3.16 is the minimal version for GtkGLArea widget, used in following
> > patches.
>
> > - 3.0) GTK_REQUIRED=2.91.3
> > + 3.0) GTK_REQUIRED=3.16
>
> That puts the bar pretty high. 3.16 is only one y
On Fr, 2016-03-11 at 21:50 +0100, Marc-André Lureau wrote:
> 3.16 is the minimal version for GtkGLArea widget, used in following
> patches.
> - 3.0) GTK_REQUIRED=2.91.3
> + 3.0) GTK_REQUIRED=3.16
That puts the bar pretty high. 3.16 is only one year old and hasn't yet
found its way into LTS and
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/usb-acl-helper.c | 61 +++-
1 file changed, 27 insertions(+), 34 deletions(-)
diff --git a/src/usb-acl-helper.c
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/spice-channel.c | 32 +---
1 file changed, 13 insertions(+), 19 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/smartcard-manager.c | 38 ++
1 file changed, 14 insertions(+), 24 deletions(-)
diff --git a/src/smartcard-manager.c b/src/s
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/usb-device-manager.c | 58 ++--
1 file changed, 27 insertions(+), 31 deletions(-)
diff --git a/src/usb-device-manag
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/spice-gstaudio.c | 44 ++--
1 file changed, 14 insertions(+), 30 deletions(-)
diff --git a/src/spice-gstaudio.c b/src/s
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/wocky-http-proxy.c | 48 +---
1 file changed, 17 insertions(+), 31 deletions(-)
diff --git a/src/wocky-http-proxy.c
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/channel-port.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/channel-port.c b/src/channel-port.c
index 6e01caa..20ee2fa 100644
--- a
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/win-usb-driver-install.c | 90 +---
1 file changed, 42 insertions(+), 48 deletions(-)
diff --git a/src/win-usb-driver-i
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/channel-usbredir.c | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/src/channel-usbredir.c b/src/cha
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/spice-pulse.c | 92 ---
1 file changed, 34 insertions(+), 58 deletions(-)
diff --git a/src/spice-pulse.c b/
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/vmcstream.c | 129 +++-
1 file changed, 52 insertions(+), 77 deletions(-)
diff --git a/src/vmcstream.c b/sr
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
For using the new GTask API, let's bump GIO (part of GLib) dependency
version to 2.36, which is safe based on major distro support:
- Debian Jessie: glib-2.42
- RHEL-7.1: glib-2.40
- SLES12: glib-2.38
-
Instead of using GSimpleAsyncResult, use the new GTask API, which is
much more straightforward.
Signed-off-by: Fabiano Fidêncio
---
src/channel-main.c | 82 ++
1 file changed, 33 insertions(+), 49 deletions(-)
diff --git a/src/channel-main.c b
Changes since v2:
- Rebase on top of upstream/master
- usb-acl-helper doesn't crash anymore, due to Jonathon's
patches pushed before the release
- All patches got ACK'ed by Jonathon at some point, but
then we have the issues related to usb-acl-helper ...
Changes since v1:
- All comments from Ch
Hi,
Thanks for your reply :)
On Mon, Mar 14, 2016 at 02:02:26PM +0100, Marc-André Lureau wrote:
> > So, first of all, I don't want to introduce something that everybody
> > need to understand in order to get proper debug. The main idea is able
> > to filter in/out stuff that you don't want to see
Hey,
On Wed, Mar 09, 2016 at 04:08:49PM +, Eric Grammatico wrote:
> Hi There,
>
> Of course.
>
> My suggestion is to create a subfolder where I'll put my
> modified files named as the following:
> utils_fr-FR.js
> atKeynames_fr-FR.js
>
> Add the original files in the subdir as:
> utils_en-
Hi
On Sat, Mar 12, 2016 at 3:32 PM, Victor Toso wrote:
> Hi! I've rebased this series and pushed to my remote branch in
> freedesktop [0] [1]. I'll try to clarify the ideia for working on this
> and if it does not get any positive feedback I'll take it as something
> not interesting to have...
>
On Mon, Mar 14, 2016 at 11:30 AM, Marc-André Lureau
wrote:
> Hi
>
> On Mon, Mar 14, 2016 at 9:22 AM, Fabiano Fidêncio wrote:
>> Can you elaborate a bit more here, please?
>
>
> Move the GtkDrawingArea in a GtkStack, so other widgets can be switched
> to for the display: the next patch adds a GtkG
On Mon, Mar 14, 2016 at 11:31 AM, Marc-André Lureau
wrote:
> On Mon, Mar 14, 2016 at 9:22 AM, Fabiano Fidêncio wrote:
>> On Fri, Mar 11, 2016 at 9:50 PM, Marc-André Lureau
>> wrote:
>>> GtkGLArea is the proper modern way to have opengl in an gtk+
>>> application. Unfortunately, it may use variou
On Mon, Mar 14, 2016 at 9:22 AM, Fabiano Fidêncio wrote:
> On Fri, Mar 11, 2016 at 9:50 PM, Marc-André Lureau
> wrote:
>> GtkGLArea is the proper modern way to have opengl in an gtk+
>> application. Unfortunately, it may use various backends and interfaces
>> to initialize it, but dmabuf image sh
Hi
On Mon, Mar 14, 2016 at 9:22 AM, Fabiano Fidêncio wrote:
> Can you elaborate a bit more here, please?
Move the GtkDrawingArea in a GtkStack, so other widgets can be switched
to for the display: the next patch adds a GtkGLArea for an opengl renderning.
We can imagine other display widgets to
On Fri, Mar 11, 2016 at 9:50 PM, Marc-André Lureau
wrote:
> Move the GtkDrawingArea in a GtkStack, so other widgets can be switched
> to for the display.
Can you elaborate a bit more here, please?
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-widget-priv.h | 4 +--
> src/spice-widget
On Fri, Mar 11, 2016 at 9:50 PM, Marc-André Lureau
wrote:
> GtkGLArea is the proper modern way to have opengl in an gtk+
> application. Unfortunately, it may use various backends and interfaces
> to initialize it, but dmabuf image sharing requires egl atm.
>
> This patch keeps using our egl setup
41 matches
Mail list logo
