3.16 is the minimal version for GtkGLArea widget, used in following
patches.
Drop conditionnal epoxy, as it is now also required by gtk+.
Signed-off-by: Marc-André Lureau
---
configure.ac| 29 ++---
src/Makefile.am | 9 +
src/spice-widget-pri
Breaking ABI is a good time to remove deprecated code.
Signed-off-by: Marc-André Lureau
---
src/spice-widget.c | 71 --
src/spice-widget.h | 7 --
2 files changed, 78 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index
Not so many systems require gtk+ 2.0 these days, let's move on.
This drops the old python bindings (non-gir based), and the
unsteady/experimental gtk2-only XShm support.
Signed-off-by: Marc-André Lureau
---
Makefile.am| 2 +-
configure.ac | 124 +-
GtkGLArea is the proper modern way to have opengl in an gtk+
application. Unfortunately, it may use various backends and interfaces
to initialize it, but dmabuf image sharing requires egl atm.
This patch keeps using our egl setup on X11, while it uses gtkglarea on
known gdk backend based on egl, s
Do not leak internals of SpiceUsbDeviceWidget in public headers. This makes also
the class final, which let us extend more easily without fear of breaking ABI.
Signed-off-by: Marc-André Lureau
---
src/usb-device-widget.c | 16
src/usb-device-widget.h | 36 ---
Do not leak internals of SpiceGrabSequence in public headers. This makes also
the class final, which let us extend more easily without fear of breaking ABI.
Signed-off-by: Marc-André Lureau
---
src/Makefile.am | 1 +
src/spice-grabsequence-priv.h | 28
Do not leak internals of SpiceGtkSession in our headers. This makes also
the class final, which let us extend more easily without fear of
breaking ABI.
Signed-off-by: Marc-André Lureau
---
src/spice-gtk-session-priv.h | 13 +
src/spice-gtk-session.h | 33
Move the GtkDrawingArea in a GtkStack, so other widgets can be switched
to for the display.
Signed-off-by: Marc-André Lureau
---
src/spice-widget-priv.h | 4 +--
src/spice-widget.c | 69 -
2 files changed, 47 insertions(+), 26 deletions(-)
d
The following patches need to break the ABI (in particular the parent of the
SpiceDisplay widget).
Signed-off-by: Marc-André Lureau
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 68884e6..e35c046 100644
--- a/src/Ma
Do not leak internals of SpiceDisplay in our headers. This makes also
the class final, which let us extend more easily without fear of
breaking ABI.
Signed-off-by: Marc-André Lureau
---
src/spice-widget-priv.h | 15 +++
src/spice-widget.h | 35 ---
Using GtkGlArea is the proper way of doing opengl with gtk+ and solves
virgl-client on wayland. Unfortunately, it requires spice-gtk to break ABI or
API since the widget is a child of GtkDrawingArea and this is part of the ABI.
We may want to introduce a new widget (new API), but then each and ever
Hi!
The Spice team is pleased to release a new spice-gtk version 0.31,
with the following highlights:
- NOTE: this is the last release to support gtk+ 2.0
- add local GL scanout support for virtio-gpu/virgl guests
- new file-transfer API, to be able to monitor transfers etc
- new spice_display_ch
Hi
- Original Message -
> Hmm, that initial empty noinst_PROGRAMS looks a bit like a mistake. Perhaps
> add
> a $(NULL) to that to make it explicit?
It's fairly idiomatic to initialize variables with empty. $(NULL) is mainly use
to help with sorted-lines and trailing \ (for the last line
Hmm, that initial empty noinst_PROGRAMS looks a bit like a mistake. Perhaps add
a $(NULL) to that to make it explicit?
ACK either way
Acked-by: Jonathon Jongsma
On Fri, 2016-03-11 at 20:04 +0100, Marc-André Lureau wrote:
> acl-helper needs polkit (and unix atm) to build.
>
> Signed-off-by: M
acl-helper needs polkit (and unix atm) to build.
Signed-off-by: Marc-André Lureau
---
tests/Makefile.am | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 24d45c9..c1d95c1 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile
acl-helper needs polkit (and unix atm) to build.
Signed-off-by: Marc-André Lureau
---
tests/Makefile.am | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 24d45c9..3348b35 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.
acl-helper test is unix-only.
Signed-off-by: Marc-André Lureau
---
tests/Makefile.am | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 24d45c9..ccf14bc 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -3,16 +3,18 @
ok. ACK series, but fix the "optionnal" typo in the subject.
On Fri, 2016-03-11 at 18:15 +0100, Marc-André Lureau wrote:
> This fixes make check failing because of recent spice-common logging
> switch to glib.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-session.c | 2 +-
> 1 file ch
This fixes make check failing because of recent spice-common logging
switch to glib.
Signed-off-by: Marc-André Lureau
---
src/spice-session.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spice-session.c b/src/spice-session.c
index a36dcea..249e2d1 100644
--- a/src/spic
spice-gtk uses SPICE_DEBUG for debug lines (for now), and prefer direct
glib glog/g_warning.
Signed-off-by: Marc-André Lureau
---
src/channel-main.c | 8
src/spice-audio.c | 2 +-
src/spice-channel.c | 8
src/spice-pulse.c | 4 ++--
src/spice-session.c | 8
5 file
On Thu, Mar 10, 2016 at 5:32 PM, Marc-André Lureau
wrote:
> Signed-off-by: Marc-André Lureau
> ---
> NEWS | 18 ++
> src/usb-device-manager.c | 2 ++
> 2 files changed, 20 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 86f2a8c..0cb5359 100644
> --- a/NEWS
Hi
- Original Message -
> On Fri, 2016-03-11 at 10:26 +0100, Christophe Fergeau wrote:
> > On Thu, Mar 10, 2016 at 11:17:16AM -0600, Jonathon Jongsma wrote:
> > > This allows us to execute a custom mock acl helper binary for testing
> > > purposes.
> > > ---
> > > src/usb-acl-helper.c | 5
On Fri, 2016-03-11 at 10:26 +0100, Christophe Fergeau wrote:
> On Thu, Mar 10, 2016 at 11:17:16AM -0600, Jonathon Jongsma wrote:
> > This allows us to execute a custom mock acl helper binary for testing
> > purposes.
> > ---
> > src/usb-acl-helper.c | 5 -
> > 1 file changed, 4 insertions(+),
Hey all,
I've just released version 0.12.11 of spice-protocol. A major change
is the removal of the code generation scripts that were included in
the previous release, but created build dependencies issues. It can be
downloaded from the following location:
http://www.spice-space.org/download/rele
Acked-by: Christophe Fergeau
On Thu, Mar 10, 2016 at 05:04:27PM +0100, Marc-André Lureau wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> NEWS | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index a342d38..4f500e2 100644
> --- a/NEW
On Fri, Mar 11, 2016 at 10:48 AM, Uwe Laverenz wrote:
> Hi,
>
> Am 10.03.2016 um 17:18 schrieb Jean-Marie Perron:
>
>> Hello,
>>
>> OVirt 3.6.3 is installed on CentOS 7.
>>
>> I use 64-bit Windows 10 client with spice display.
>>
>> After installing the spice-guest-tools and oVirt-tools-setup on
Hi Frediano,
On Fri, 2016-03-11 at 05:37 -0500, Frediano Ziglio wrote:
> >
> >
> > Related:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1061942
> Not so important but I'll put some more information on the
> message. Would make easier to understand if somebody looks
> at the change without op
On Fri, Mar 11, 2016 at 05:42:15AM -0500, Frediano Ziglio wrote:
> Fatal error exit usually with abort() causing SIGABRT to be triggered
> which can have problems with core dump generation depending on system
> settings. Capturing and exiting on this signal solve the problem.
> This is a workaround
The patch (and 2/3) are fine.
The only thing I would change is the subject, specifically I
would remove the "learn how" part like
"replay: count commands"
"replay: skip the first N (slow) commands"
Acked-by: Frediano Ziglio
Frediano
>
> ---
> server/tests/replay.c | 8
> 1 file cha
>
> Apparently, after using g_option_context_parse with G_OPTION_REMAINING
> argv is modified and should not be used.
> This patch uses "file" instead of "argv" and makes sure
> file is freed later.
> No free is called upon error - exit takes care of it.
>
> Signed-off-by: Uri Lublin
> Acked-by:
Hi,
On Fri, Mar 11, 2016 at 09:08:07AM +0100, Pavel Grunt wrote:
> Related:
> https://bugzilla.redhat.com/show_bug.cgi?id=1061942
> ---
> src/channel-display.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/channel-display.c b/src/channel-display.c
> index 5111d
Fatal error exit usually with abort() causing SIGABRT to be triggered
which can have problems with core dump generation depending on system
settings. Capturing and exiting on this signal solve the problem.
This is a workaround to some system configurations which could cause
test to fail.
Signed-of
>
> Related:
> https://bugzilla.redhat.com/show_bug.cgi?id=1061942
Not so important but I'll put some more information on the
message. Would make easier to understand if somebody looks
at the change without opening an external website.
I think you can close the bug once this get into master.
Th
>
> Hey,
>
> Yep, thanks for sending it. For what it's worth, git commit has a
> --author option ;)
>
> Christophe
>
It's true but the commit is composed by code changes and commit message.
Frediano
> On Thu, Mar 10, 2016 at 04:29:39PM +, Frediano Ziglio wrote:
> > Avoid overflows using
On Thu, Mar 10, 2016 at 11:17:16AM -0600, Jonathon Jongsma wrote:
> This allows us to execute a custom mock acl helper binary for testing
> purposes.
> ---
> src/usb-acl-helper.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/usb-acl-helper.c b/src/usb-acl-helper
- Forwarded message from Paolo Bonzini -
> Date: Thu, 10 Mar 2016 19:09:01 +0100
> From: Paolo Bonzini
> To: qemu-devel , KVM list ,
> libvir-l...@redhat.com,
> "edk2-de...@ml01.01.org" , "seab...@seabios.org"
> , Linux Virtualization
>
> Subject: [libvirt] KVM Forum 2016:
On Thu, Mar 10, 2016 at 04:29:40PM +, Frediano Ziglio wrote:
> Fatal error exit usually with abort() causing SIGABRT to be triggered
> which can have problems with core dump generation depending on system
> settings. Capturing and exiting on this signal solve the problem.
I still think this lo
Hey,
Yep, thanks for sending it. For what it's worth, git commit has a
--author option ;)
Christophe
On Thu, Mar 10, 2016 at 04:29:39PM +, Frediano Ziglio wrote:
> Avoid overflows using its values.
> The patch was originally written by Christophe Fergeau
> ---
> common/log.c | 3 ++-
> 1 fi
Related:
https://bugzilla.redhat.com/show_bug.cgi?id=1061942
---
src/channel-display.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/channel-display.c b/src/channel-display.c
index 5111d3d..dc00c31 100644
--- a/src/channel-display.c
+++ b/src/channel-display.c
@@ -18
39 matches
Mail list logo
