>
> On Thu, 3 Mar 2016, Frediano Ziglio wrote:
> [...]
> > void red_qxl_init(QXLInstance *qxl)
> > {
> > -RedDispatcher *red_dispatcher;
> > +QXLState *qxl_state;
> > RedChannel *channel;
> > ClientCbs client_cbs = { NULL, };
> >
> > spice_return_if_fail(qxl != NULL);
>
Hi
- Original Message -
> This just adds a few basic tests to verify that we handle the usb-acl helper
> properly. The first patch is actually a bugfix for an issue that was
> discovered
> while writing the tests.
>
> The second patch provides some infrastructure for the tests. I'm not su
---
tests/Makefile.am | 15 ++--
tests/mock-acl-helper.c | 94 +++
tests/usb-acl-helper.c | 197
3 files changed, 301 insertions(+), 5 deletions(-)
create mode 100644 tests/mock-acl-helper.c
create mode 100644 tests/us
cancelled_cb() (which is triggered when the GCancellable's "cancelled"
signal is emitted) called spice_usb_acl_helper_close_acl(), which calls
spice_usb_acl_helper_cleanup(), which in turn calls
g_cancellable_disconnect(). Calling g_cancellable_disconnect() from
within a "cancelled" handler results
This just adds a few basic tests to verify that we handle the usb-acl helper
properly. The first patch is actually a bugfix for an issue that was discovered
while writing the tests.
The second patch provides some infrastructure for the tests. I'm not sure that
adding this acl-helper-path property
This allows you to specify a path to a custom binary that will be
spawned by SpiceUsbAclHelper to obtain permission for a particular USB
device. This will be used for testing so that we can use a mock acl
helper binary that can be manipulated to return arbitary responses.
This makes it easier to ve
On Thu, 3 Mar 2016, Frediano Ziglio wrote:
[...]
> void red_qxl_init(QXLInstance *qxl)
> {
> -RedDispatcher *red_dispatcher;
> +QXLState *qxl_state;
> RedChannel *channel;
> ClientCbs client_cbs = { NULL, };
>
> spice_return_if_fail(qxl != NULL);
> -spice_return_if_fa
>
> Commit e9ed125d introduced a dead-lock regression by taking twice the
> same lock recursively. The previous code checked if a dmabuf was set
> without taking the lock, for queuing scanout messages. Since the message
> is being processed later on, it make sense to queue and delay until it
> is
Commit e9ed125d introduced a dead-lock regression by taking twice the
same lock recursively. The previous code checked if a dmabuf was set
without taking the lock, for queuing scanout messages. Since the message
is being processed later on, it make sense to queue and delay until it
is sent to check
From: Kirill Moizik
On Windows when using usbdk, opening and closing USB device handle,
i.e. calling libusb_open()/libusb_unref_device() can block for a few
seconds (3-5 second more specifically on patch author's HW).
libusb_open() is called by spice_usbredir_channel_open_device().
libusb_unref
From: Kirill Moizik
Signed-off-by: Kirill Moizik
Signed-off-by: Dmitry Fleytman
---
src/channel-usbredir.c | 48 +---
1 file changed, 41 insertions(+), 7 deletions(-)
diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
index 7253ce6..ba9e4a
From: Kirill Moizik
Signed-off-by: Kirill Moizik
Signed-off-by: Dmitry Fleytman
---
src/usb-device-widget.c | 42 +-
1 file changed, 33 insertions(+), 9 deletions(-)
diff --git a/src/usb-device-widget.c b/src/usb-device-widget.c
index 56bdeaf..cafaf78 1
From: Kirill Moizik
During device connection, unwanted hotplug events may happen.
We need to ignore those therefore we track redirection operations
in progress.
See also comment to commit
"Do not process USB hotplug events while redirection is in progress"
that introduces corresponding filtering
From: Kirill Moizik
USB redirection flow on Windows includes a number of reset requests issued
to the port that hosts the device deing redirected.
Each port reset emulates device removal and reinsertion and produces
corresponding hotplug events and a number of device list updates on
different le
From: Kirill Moizik
During device disconnection, unwanted hotplug events may happen.
We need to ignore those therefore we track disconnection operations
in progress.
See also comment to commit
"Do not process USB hotplug events while redirection is in progress"
that introduces corresponding filt
From: Kirill Moizik
Gray out redirection controls while there are
asynchronous redirection flows in progress.
Signed-off-by: Kirill Moizik
Signed-off-by: Dmitry Fleytman
---
src/usb-device-widget.c | 38 --
1 file changed, 20 insertions(+), 18 deletions(-)
From: Kirill Moizik
This commit adds locking to ensure thread safety required
after start/stop redirection flows moved to separate threads.
This is done in preparation to following commits that
will introduce actual multithreaded access to corresponding
routines.
Signed-off-by: Kirill Moizik
Si
From: Dmitry Fleytman
Asynchronous disconnection should be used instead.
Signed-off-by: Dmitry Fleytman
---
src/usb-device-manager.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/usb-device-manager.h b/src/usb-device-manager.h
index a9a4f7a..6a8d0ac 100644
--- a/src/usb-device-man
From: Kirill Moizik
Signed-off-by: Kirill Moizik
Signed-off-by: Dmitry Fleytman
---
src/map-file | 1 +
src/usb-device-manager.c | 23 +++
src/usb-device-manager.h | 2 ++
src/usb-device-widget.c | 7 +++
4 files changed, 33 insertions(+)
diff --git a/s
From: Kirill Moizik
This commit introduces redirecting property of GUdevClient
This property indicates when a redirection operation
is in progress on a device. It's set back to FALSE
once the device is fully redirected to the guest.
Signed-off-by: Kirill Moizik
Signed-off-by: Dmitry Fleytman
This patch fixes device list change notification handing
logic for cases when more than one device being plugged
or unplugged simultaneously.
The simplest way to reproduce the problematic scenario
is (un)plugging of a usb HUB with a few devices inserted.
Signed-off-by: Dmitry Fleytman
---
src/w
From: Kirill Moizik
This commit introduces functions for asynchronous disconnection flows.
Following commits will make use of those.
Thread safety is ensured the same way it was done for connection
flow in previous commits. Disconnect logic is protected by the same
locks that protect connect/usb
Changes since v6:
- changes and fixes as suggested by Jonathon. Jonathon, thanks for the review.
- reworked patch that fixes device list handling in case of multiple device
state change
- synchronous disconnection method deprecated but left in the public interface
Changes since v5:
- changes an
From: Kirill Moizik
This commit introduces channel mutex to allow usage of
channel objects in mutithreaded environments.
This mutex will be used by future commits to protect
thread unsafe usbredir functions and data structures.
Signed-off-by: Kirill Moizik
Signed-off-by: Dmitry Fleytman
---
> On 1 Mar 2016, at 22:20 PM, Jonathon Jongsma wrote:
>
> I apologize for not responding to your questions about deprecation earlier.
>
> Basically, if you look at spice-channel.h you can see an example of how to
> deprecate this function instead of removing it from the API. Basically:
>
> #if
> On 1 Mar 2016, at 22:17 PM, Jonathon Jongsma wrote:
>
> On Sun, 2016-02-28 at 11:54 +0200, Dmitry Fleytman wrote:
>> From: Kirill Moizik
>>
>> Signed-off-by: Kirill Moizik
>> Signed-off-by: Dmitry Fleytman
>> ---
>> src/usb-device-widget.c | 33 -
>> 1 file c
> On 1 Mar 2016, at 21:25 PM, Jonathon Jongsma wrote:
>
> On Sun, 2016-02-28 at 11:54 +0200, Dmitry Fleytman wrote:
>> From: Kirill Moizik
>>
>> Signed-off-by: Kirill Moizik
>> Signed-off-by: Dmitry Fleytman
>> ---
>> src/channel-usbredir.c | 38 +++---
>> 1 fi
> On 1 Mar 2016, at 21:14 PM, Jonathon Jongsma wrote:
>
> As I mentioned in the previous patch, I'd really like this rebased on
> Fabiano's
> GTask work. I understand that it's annoying to have to rebase this stuff, so
> I'm
> willing to do it for you if you'd prefer.
That would be great, tha
> On 1 Mar 2016, at 17:58 PM, Jonathon Jongsma wrote:
>
> On Sun, 2016-02-28 at 11:54 +0200, Dmitry Fleytman wrote:
>> From: Kirill Moizik
>>
>> On Windows when using usbdk, opening and closing USB device handle,
>> i.e. calling libusb_open()/libusb_unref_device() can block for a few
>> second
> On 1 Mar 2016, at 24:55 AM, Jonathon Jongsma wrote:
>
> On Sun, 2016-02-28 at 11:54 +0200, Dmitry Fleytman wrote:
>> From: Kirill Moizik
>>
>> This commit introduces channel mutex to allow usage of
>> channel objects in mutithreaded environments.
>>
>> This mutex will be used by future comm
> On 1 Mar 2016, at 24:06 AM, Jonathon Jongsma wrote:
>
> On Sun, 2016-02-28 at 11:54 +0200, Dmitry Fleytman wrote:
>> This patch fixes device list change notification handing
>> logic for cases when more than one device being plugged
>> or unplugged simultaneously.
>>
>> The simplest way to re
On Tue, Mar 08, 2016 at 11:44:43AM +0100, Pavel Grunt wrote:
> Acked-by: Pavel Grunt
Thanks, pushed.
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mail
Acked-by: Pavel Grunt
On Tue, 2016-03-08 at 11:39 +0100, Christophe Fergeau wrote:
> ---
> utils.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/utils.js b/utils.js
> index 9eb42ff..f1a5748 100644
> --- a/utils.js
> +++ b/utils.js
> @@ -100,7 +100,7 @@ function h
---
utils.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utils.js b/utils.js
index 9eb42ff..f1a5748 100644
--- a/utils.js
+++ b/utils.js
@@ -100,7 +100,7 @@ function hexdump_buffer(a)
/*
** Co
Hey,
I experimented a bit with this..
On Mon, Mar 07, 2016 at 02:43:16PM +, Eric Grammatico wrote:
> The comments from the js file says:
>
> * definition of the AT84/MF101/MF102 Keyboard
>
> I had a look in Google to see a picture of a AT84 Wahou ! Does someone
> believe a user will ty
On Mi, 2016-03-02 at 14:32 +, Frediano Ziglio wrote:
> If you have hardware cursor and you are reconnecting the VNC client
> you need to send the cursor. Failing to do so make the cursor invisible
> till is changed.
>
> Signed-off-by: Frediano Ziglio
added to ui patch queue.
thanks,
Gerd
36 matches
Mail list logo
