The db argument must end with " or \n.
Found thanks to clang scan-build.
Signed-off-by: Marc-André Lureau
Reported-by: Miroslav Rezanina
---
src/vcard_emul_nss.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/vcard_emul_nss.c b/src/vcard_emul_nss.c
index 08a60c6..156a916 100644
--
scan-build gives a false-positive error because it gets confused that
optarg may be NULL. Help him by adding an assert.
Signed-off-by: Marc-André Lureau
Reported-by: Miroslav Rezanina
---
src/vscclient.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/vscclient.c b/src/vscclient.c
ind
On Wed, 2 Mar 2016, Christophe Fergeau wrote:
[...]
> > +if test "x$enable_gstreamer" != "xno"; then
> > +SPICE_CHECK_GSTREAMER(GSTREAMER_1_0, 1.0, [gstreamer-1.0
> > gstreamer-base-1.0 gstreamer-app-1.0 gstreamer-video-1.0],
> > +[enable_gstreamer="yes"
> > + SPICE_CHECK_GSTRE
>
> This patch allows remote-viewer to redirect output/error streams to
> files.
> Also if launched from a console program (for instance from the command
> prompt) you are able to see output from the console where you launch
> the program.
> This allow to launch the program with a syntax like
>
>
> Frediano,
>
> On Tue, Mar 1, 2016 at 6:12 PM, Frediano Ziglio wrote:
> >
> >>
> >> Hi
> >>
> >> - Original Message -
> >> > These utility use some trick to use console even if they are GUI
> >> > application (not supposed to have a console by default).
> >> > This make output redirec
This patch allows remote-viewer to redirect output/error streams to
files.
Also if launched from a console program (for instance from the command
prompt) you are able to see output from the console where you launch
the program.
This allow to launch the program with a syntax like
> remote-viewer.e
Hey,
Mostly looks good, a few comments/questions below.
On Tue, Mar 01, 2016 at 04:50:57PM +0100, Francois Gouget wrote:
> This introduces a pared down GStreamer-based video encoder to serve as
> the basis for later enhancements.
> In this form the new encoder supports both regular and sized stre
I believe this was already reviewed separately, in a way it's odd to
store instance data along with vfunc (ie class) data, but why not, makes
more sense this way indeed.
Acked-by: Christophe Fergeau
On Tue, Mar 01, 2016 at 04:50:32PM +0100, Francois Gouget wrote:
> It has the same lifetime as th
Frediano,
On Tue, Mar 1, 2016 at 6:12 PM, Frediano Ziglio wrote:
>
>>
>> Hi
>>
>> - Original Message -
>> > These utility use some trick to use console even if they are GUI
>> > application (not supposed to have a console by default).
>> > This make output redirection harder as output by
Acked-by: Christophe Fergeau
On Tue, Mar 01, 2016 at 04:50:45PM +0100, Francois Gouget wrote:
> This replaces the original mjpeg_encoder API with a VideoEncoder base
> class which can be reimplemented by other encoders.
> This also renames the members and enums from mjpeg_* to video_*.
>
> Sign
Hi,
Small fixes to my last email :)
On Wed, Mar 02, 2016 at 04:14:09PM +0100, Victor Toso wrote:
> I did get what you mean here, are you referring to
> drawable->red_drawable->u.copy.src_area ?
* s/did/did not/
> With and without those two patches, following bug happens:
> https://bugs.freedesk
Hi,
On Sat, Feb 27, 2016 at 01:53:16PM -0500, Frediano Ziglio wrote:
> > Hi,
> >
> > On Fri, Feb 26, 2016 at 10:03:40PM +0100, Victor Toso wrote:
> > > Hi,
> > >
> > > On Wed, Feb 24, 2016 at 06:30:34PM +0100, Francois Gouget wrote:
> > > > They always match the size of the source bitmap area:
>
>
> On Tue, Feb 23, 2016 at 01:57:59PM -0600, Jonathon Jongsma wrote:
> >
> > I'm a bit ambivalent about this change. Although it may generate better
> > code, I
> > think that it makes the code slightly more difficult to read. I'd almost
> > prefer
> > a #define to the enum solution. But I guess
On Wed, Mar 02, 2016 at 04:59:38PM +0200, Yedidyah Bar David wrote:
> On Wed, Mar 2, 2016 at 4:47 PM, Christophe Fergeau
> wrote:
> > Hey,
> >
> > On Wed, Feb 10, 2016 at 12:16:59PM +0200, Yedidyah Bar David wrote:
> >> From: Sandro Bonazzola
> >>
> >> Change-Id: I1bc61dbbaa39a6e0d5d5866065d6c12
On Wed, Mar 2, 2016 at 4:47 PM, Christophe Fergeau wrote:
> Hey,
>
> On Wed, Feb 10, 2016 at 12:16:59PM +0200, Yedidyah Bar David wrote:
>> From: Sandro Bonazzola
>>
>> Change-Id: I1bc61dbbaa39a6e0d5d5866065d6c12c5af51bf7
>> Signed-off-by: Sandro Bonazzola
>> ---
>> ovirt-guest-tools-iso.spec.i
Hey,
On Wed, Feb 10, 2016 at 12:16:59PM +0200, Yedidyah Bar David wrote:
> From: Sandro Bonazzola
>
> Change-Id: I1bc61dbbaa39a6e0d5d5866065d6c12c5af51bf7
> Signed-off-by: Sandro Bonazzola
> ---
> ovirt-guest-tools-iso.spec.in | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
On Tue, Feb 23, 2016 at 01:57:59PM -0600, Jonathon Jongsma wrote:
>
> I'm a bit ambivalent about this change. Although it may generate better code,
> I
> think that it makes the code slightly more difficult to read. I'd almost
> prefer
> a #define to the enum solution. But I guess I don't care t
If you have hardware cursor and you are reconnecting the VNC client
you need to send the cursor. Failing to do so make the cursor invisible
till is changed.
Signed-off-by: Frediano Ziglio
---
ui/vnc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/vnc.c b/ui/vnc.c
index ce4c669..825e6
On Wed, 2 Mar 2016, Frediano Ziglio wrote:
> >
> > Signed-off-by: Francois Gouget
> > ---
> >
> > In theory this could be needed by the next patch.
> >
>
> Are you saying that now compression is done in another thread?
Nothing has changed with regards to threading. My understanding is that
Hey,
On Wed, Feb 17, 2016 at 01:54:48PM +0330, Hamid Mazrae Mollaie wrote:
> Hi,
> Tank you for replay.
> yes, my mouse and keyboard are usb and redirect to vm... and all pressed
> key sent to vm
> all hotkeys and Ctrl+Alt+F[n] does not work for example. but if i avoid
> from spice-usbredir-redire
Hey,
On Fri, Feb 26, 2016 at 11:53:25PM +, Eric Grammatico wrote:
> Hello There,
>
> I am currently testing spice-html5. I find it very promessing and I'd
> like to give a hand if possible.
>
> I am currently experiencing an irritating issue with key mapping. I
> win to have French keymap im
Enable additional checks for this macro.
Signed-off-by: Frediano Ziglio
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index f5445c0..c1b1b3a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,7 +82,7 @@ dnl
Looks good to me, ACK.
Christophe
On Wed, Mar 02, 2016 at 11:26:05AM +, Frediano Ziglio wrote:
> This prevents incompatibility if users (like old spice-server/spice-gtk)
> are not expected to have this additional restriction.
>
> Signed-off-by: Frediano Ziglio
> ---
> spice/macros.h | 7 ++
>
> Signed-off-by: Francois Gouget
> ---
>
> In theory this could be needed by the next patch.
>
Are you saying that now compression is done in another thread?
> server/red-parse-qxl.h | 4 ++--
> server/red-worker.c| 7 ++-
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> dif
This prevents incompatibility if users (like old spice-server/spice-gtk)
are not expected to have this additional restriction.
Signed-off-by: Frediano Ziglio
---
spice/macros.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Changes since v1:
- macro name;
- added code comment.
dif
Hi,
On Thu, Feb 11, 2016 at 11:12:49PM +, Rafael Send wrote:
> Hello-
> I've built spice-gtk-3 from spice-space.org on tinycore linux (64-bit). For
> this, I also had to built the server, the protocol and qemu itself with
> spice support; all of which seem to work fine (and things work great i
Hi,
On Thu, Feb 04, 2016 at 10:54:44AM -0600, Matthew wrote:
> Hello,
>
> I know you have multiple PDFs on your website about how to use Spice. All
> of it is confusing to me, and I have a lot of questions.
You might go to the frequent asked questions before checking the PDFs ;)
http://www.spice-
27 matches
Mail list logo
