Re: [Spice-devel] [PATCH 3/3] make allocation fixed instead of variable

I'm a bit ambivalent about this change. Although it may generate better code, I think that it makes the code slightly more difficult to read. I'd almost prefer a #define to the enum solution. But I guess I don't care too much. On Tue, 2016-02-23 at 16:06 +, Frediano Ziglio wrote: > Due to th

Re: [Spice-devel] [PATCH 2/3] use G_N_ELEMENTS instead of manually compute array size

Acked-by: Jonathon Jongsma On Tue, 2016-02-23 at 16:06 +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/reds.c b/server/reds.c > index 444d7ac..e58cec5 100644 > --- a/server/red

Re: [Spice-devel] [PATCH 1/3] constify some global variables

Acked-by: Jonathon Jongsma On Tue, 2016-02-23 at 16:06 +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/main-channel.c | 2 +- > server/red-channel.c| 32 > server/reds.c | 4 ++-- > server/spice-bitmap

Re: [Spice-devel] [RFC PATCH 3/3] worker: use manual flushing on stream to decrease packet fragmentation

On Mon, 2016-02-22 at 13:38 -0500, Frediano Ziglio wrote: > > > > On Tue, 2016-02-16 at 15:36 +, Frediano Ziglio wrote: > > > Signed-off-by: Frediano Ziglio > > > --- > > > server/red-channel.c | 12 > > > server/red-worker.c | 24 +--- > > > 2 files changed

[Spice-devel] [PATCH 3/3] make allocation fixed instead of variable

Due to the way C handle constant variable the usage of these constant were used as variable making compiler generate something like alloca call while could compute allocation size statically. Fix this using enum. You can see the difference in the generated object file. Signed-off-by: Frediano Zigl

[Spice-devel] [PATCH 1/3] constify some global variables

Signed-off-by: Frediano Ziglio --- server/main-channel.c | 2 +- server/red-channel.c| 32 server/reds.c | 4 ++-- server/spice-bitmap-utils.c | 2 +- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/server/main-chann

[Spice-devel] [PATCH 2/3] use G_N_ELEMENTS instead of manually compute array size

Signed-off-by: Frediano Ziglio --- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index 444d7ac..e58cec5 100644 --- a/server/reds.c +++ b/server/reds.c @@ -880,7 +880,7 @@ static const int secondary_channels[] = { static int channe

Re: [Spice-devel] [vd-agent-win32 v2 0/2] Add support for WDDM driver

Hi El 16/02/16 a las 15:23, Victor Toso escribió: Hi Javier, On Tue, Feb 16, 2016 at 10:50:22AM +0100, Javier Celaya wrote: El 15/02/16 a las 17:01, Javier Celaya escribió: El 15/02/16 a las 16:38, Victor Toso escribió: Hi, On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote: Th

Re: [Spice-devel] [PATCH] spice-gtk: Fix the signedness of a couple of mm-time traces

And pushed. Thanks! On Mon, Feb 22, 2016 at 10:29:37AM -0500, Marc-André Lureau wrote: > ack > > - Original Message - > > Signed-off-by: Francois Gouget > > --- > > src/channel-playback.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/channel-pl

Re: [Spice-devel] [spice-gtk] namedpipelistener: do not leak the error message

On Tue, Feb 23, 2016 at 9:06 AM, Fabiano Fidêncio wrote: > From: Ignacio Casal Quinteiro > > --- > src/controller/namedpipelistener.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/controller/namedpipelistener.c > b/src/controller/namedpipelistener.c > index 820c606..b4b6057 10064

[Spice-devel] [spice-gtk] namedpipelistener: do not leak the error message

From: Ignacio Casal Quinteiro --- src/controller/namedpipelistener.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/controller/namedpipelistener.c b/src/controller/namedpipelistener.c index 820c606..b4b6057 100644 --- a/src/controller/namedpipelistener.c +++ b/src/controller/namedpipel