On Mi, 2016-02-03 at 13:27 +0900, Sunny Shin wrote:
> I heard that iptv uses udp multicast, so I thought that performance
> might be better if we use udp for video streaming.
spice != tv. No multicast here. Oh, and udp/multicast doesn't improve
performance, it reduces the bandwidth needed.
> W
On Tue, 2016-02-02 at 13:23 -0600, Jonathon Jongsma wrote:
> On Fri, 2016-01-29 at 11:31 +0100, Pavel Grunt wrote:
> > On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> > > From: Jonathon Jongsma
> > >
> > > Since this is public API, we can't easily change the signature of
> > > the
> >
I heard that iptv uses udp multicast, so I thought that performance might
be better if we use udp for video streaming. We can ignore missing and out
of order frames. Does it make sense?
I understand that we need tcp channels for all others such as input and
audio channels.
2016-02-02 23:03 GMT+09
Ack with minor changes below
Acked-by: Jonathon Jongsma
On Fri, 2016-01-29 at 10:53 +, Frediano Ziglio wrote:
> Make sure we process commands after we can send data to client.
> If during processing we detected that there was too data in the clients
too much data
> queues the processing of
Removing more global variables
---
v2:
- use gboolean type instead of int
server/reds-private.h | 1 +
server/reds.c | 10 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index bc790e8..504cb27 100644
--- a/server
On Fri, 2016-01-29 at 10:53 +, Frediano Ziglio wrote:
> The req_cmd_notification callback is called by spice-server when it
> has processed all commands and wants to be notified (by a wakeup) that
> new commands has been appended to the command queue.
s/has/have/
> Replay utility try to fill
On Fri, 2016-01-29 at 10:53 +, Frediano Ziglio wrote:
> Data were pushed during the main red worker loop.
> However there was no garantiee that there was some activities that
> make the loop do another iteration.
> This could cause in some condition the loop to stop till a new event
> was sent.
On Fri, 2016-01-29 at 11:31 +0100, Pavel Grunt wrote:
> On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> > From: Jonathon Jongsma
> >
> > Since this is public API, we can't easily change the signature of the
> > function to take a RedsState argument, so instead we apply a hack and
> >
On Mon, 2016-02-01 at 08:47 -0500, Frediano Ziglio wrote:
> >
> > From: Jonathon Jongsma
> >
> > Acked-by: Frediano Ziglio
> > ---
> > server/display-channel.c | 13 +++--
> > server/display-channel.h | 3 +--
> > server/reds-private.h| 1 +
> > server/reds.c| 20
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 11 +
server/reds.c | 65 ++-
2 files changed, 39 insertions(+), 37 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 504
From: Jonathon Jongsma
---
server/dcc-send.c| 6 +++---
server/display-channel.c | 12 ++--
server/main-channel.c| 2 +-
server/red-channel.c | 4 ++--
server/red-worker.c | 12 ++--
server/reds.c| 22 +++---
server/reds.h
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 1 +
server/reds.c | 6 +++---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 9c3db70..5042773 100644
--- a/server/reds-private.h
+++ b/se
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 1 +
server/reds.c | 16
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 52f88f8..9c3db70 100644
--- a/server/reds-privat
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 1 +
server/reds.c | 16
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 9bfade8..52f88f8 100644
--- a/server/reds-privat
From: Jonathon Jongsma
Also add reds_get_core_interface() accessor for external use.
---
server/char-device.c| 32 ---
server/inputs-channel.c | 7 ---
server/main-channel.c | 13 +++--
server/reds-private.h | 2 ++
server/reds-stream.c| 12 +
From: Jonathon Jongsma
Acked-by: Frediano Ziglio
---
server/display-channel.c | 13 +++--
server/display-channel.h | 3 +--
server/reds-private.h| 1 +
server/reds.c| 22 +-
server/reds.h| 5 ++---
5 files changed, 24 insertions(+), 20
From: Jonathon Jongsma
---
server/main-dispatcher.c | 2 +-
server/reds.c| 2 +-
server/reds.h| 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c
index 132a693..777a44f 100644
--- a/server/main-dispatc
From: Jonathon Jongsma
This allows us to use local 'reds' variables in all of the various async
callbacks rather than using the global 'reds' variable.
---
server/reds.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 8b2da
From: Jonathon Jongsma
---
server/reds.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 690985c..8b2dab5 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2265,7 +2265,7 @@ static void reds_handle_ssl_accept(int fd, int even
From: Jonathon Jongsma
Rather than using global 'reds' variable
---
server/reds.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 9ec80f2..ba6ab43 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3583,13 +3583,11 @@ SPICE_GNUC_VISIBLE
From: Jonathon Jongsma
Also required adding reds_get_zlib_glz_state() for external access.
---
server/red-worker.c | 2 +-
server/reds-private.h | 1 +
server/reds.c | 9 +++--
server/reds.h | 2 +-
4 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/server/red-
From: Jonathon Jongsma
Since this is technically a RedsState method, name it as such.
---
server/reds.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 14857c2..8be151c 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -174,7 +174,7
From: Jonathon Jongsma
Required adding a RedsState arg to reds_get_agent_mouse()
---
server/inputs-channel.c | 8
server/reds-private.h | 2 ++
server/reds.c | 10 +-
server/reds.h | 2 +-
4 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/
Changes:
- merged some patches;
- added other patches to list.
Jonathon Jongsma (18):
Change spice_server_set_ticket() to use local 'reds'
spice_server_add_interface: use local 'reds' variable
Remove use of global 'reds' var from spice_server_remove_interface()
Store 'renderers' as GArray
From: Jonathon Jongsma
Prefer local argument variable over global 'reds' variable
---
server/reds.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index ba6ab43..0b04f5f 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3160,13 +3160,11 @
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 1 +
server/reds.c | 10 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index bc790e8..c76f3b0 100644
--- a/server/reds-private.h
++
From: Jonathon Jongsma
Also requires adding reds_get_streaming_video() accessor so that other
files can check this value.
---
server/red-dispatcher.c | 7 ---
server/red-worker.c | 2 +-
server/reds-private.h | 1 +
server/reds.c | 9 +++--
server/reds.h | 2 +-
From: Jonathon Jongsma
Since this is public API, we can't easily change the signature of the
function to take a RedsState argument, so instead we apply a hack and
store the reds argument inside the device state struct when the
interface is added, and retrieve it for use later when it is removed.
>
> From: Jonathon Jongsma
>
> Also required adding reds_get_jpeg_state() for external access.
> ---
> server/red-worker.c | 2 +-
> server/reds-private.h | 1 +
> server/reds.c | 9 +++--
> server/reds.h | 2 +-
> 4 files changed, 10 insertions(+), 4 deletions(-)
>
> dif
>
> From: Jonathon Jongsma
>
> Removing more global variables
> ---
> server/red-dispatcher.c | 4 ++--
> server/red-worker.c | 3 ++-
> server/reds-private.h | 1 +
> server/reds.c | 14 +++---
> server/reds.h | 1 -
> 5 files changed, 12 insertions(+), 11
>
> From: Jonathon Jongsma
>
> Move them into the RedsState struct, adjust functions that use these
> variables to take a RedsState arg.
> ---
> server/reds-private.h | 4
> server/reds.c | 27 ---
> 2 files changed, 16 insertions(+), 15 deletions(-)
>
> d
On Di, 2016-02-02 at 10:24 +0100, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Feb 02, 2016 at 06:10:28PM +0900, Sunny Shin wrote:
> > I have a few questions about udp version of spice protocol.
> >
> > Is there a plan to support udp in spice protocol?
> >
> > If we support udp, what do we need
On Út, 2016-02-02 at 10:24 +0100, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Feb 02, 2016 at 06:10:28PM +0900, Sunny Shin wrote:
> > I have a few questions about udp version of spice protocol.
> >
> > Is there a plan to support udp in spice protocol?
> >
> > If we support udp, what do we need
On Mon, Feb 01, 2016 at 10:36:52AM +, Frediano Ziglio wrote:
> This patch use old code to implement timer events.
> The new version use some function from GLib 2.34 however some systems
> (like RHEL 6) have former GLib version (RHEL 6 has GLib 2.28 installed)
>
> Signed-off-by: Frediano Ziglio
Hey,
On Tue, Feb 02, 2016 at 06:10:28PM +0900, Sunny Shin wrote:
> I have a few questions about udp version of spice protocol.
>
> Is there a plan to support udp in spice protocol?
>
> If we support udp, what do we need to implement?
> Is it enough to change tcp channels to udp ones?
Maybe that
> Hi All,
> I have a few questions about udp version of spice protocol.
> Is there a plan to support udp in spice protocol?
> If we support udp, what do we need to implement?
> Is it enough to change tcp channels to udp ones?
> Would there be any benefits over tcp version? possibly better perf
Hey,
On Tue, Feb 02, 2016 at 09:39:41AM +0800, 牛立新 wrote:
> thanks a lot.
Feel free to change your preferences in the mailman.
Enter your mail and press the unsubscribe button at
http://lists.freedesktop.org/mailman/options/spice-devel
Cheers,
>
> 在 2016年2月2日，上午4:00，spice-devel-requ...@lists.
Hi All,
I have a few questions about udp version of spice protocol.
Is there a plan to support udp in spice protocol?
If we support udp, what do we need to implement?
Is it enough to change tcp channels to udp ones?
Would there be any benefits over tcp version? possibly better performance?
Su
38 matches
Mail list logo
