Re: [Spice-devel] [PATCH 3/3] worker: avoid server hanging when no client are connected.

On Wed, 2016-01-20 at 11:46 -0500, Frediano Ziglio wrote: > > > > From: Marc-André Lureau > > > > --- > > server/red-worker.c | 27 ++- > > 1 file changed, 18 insertions(+), 9 deletions(-) > > > > diff --git a/server/red-worker.c b/server/red-worker.c > > index a98c4a6.

Re: [Spice-devel] [PATCH 1/3] worker: use glib main loop

On Wed, 2016-01-20 at 11:42 -0500, Frediano Ziglio wrote: > > > > Use the glib mainloop instead of writing our own. The glib loop is both > > cleaner to use and is more extensible. It is also very mature and > > reduces the maintenance burden on the spice server. > > > > Signed-off-by: Marc-André

Re: [Spice-devel] [PATCH 0/3] Glib loop in RedWorker

On Wed, 2016-01-20 at 16:32 +, Frediano Ziglio wrote: > Finally is time to approach again these patches to use GLib loop > functions for RedWorker. > Patches has been through so many passages that I'm posting as they > are. > > Frediano Ziglio (1): > worker: use glib main loop > > Marc-Andr

Re: [Spice-devel] [PATCH 2/2] usb-device-widget: Add counter of free channels

On Wed, Jan 20, 2016 at 5:28 PM, Marc-André Lureau wrote: > Hi > > - Original Message - >> On Wed, 2016-01-20 at 10:11 +0100, Fabiano Fidêncio wrote: >> > On Wed, Jan 20, 2016 at 9:59 AM, Victor Toso wrote: >> > > Hi, >> > > >> > > On Tue, Jan 19, 2016 at 10:36:38PM +0100, Fabiano Fidênci

Re: [Spice-devel] [PATCH 2/2] usb-device-widget: Add counter of free channels

On Wed, Jan 20, 2016 at 5:24 PM, Jonathon Jongsma wrote: > On Wed, 2016-01-20 at 10:11 +0100, Fabiano Fidêncio wrote: >> On Wed, Jan 20, 2016 at 9:59 AM, Victor Toso wrote: >> > Hi, >> > >> > On Tue, Jan 19, 2016 at 10:36:38PM +0100, Fabiano Fidêncio wrote: >> > > As the message showed when the l

Re: [Spice-devel] [PATCH 3/3] worker: avoid server hanging when no client are connected.

> > From: Marc-André Lureau > > --- > server/red-worker.c | 27 ++- > 1 file changed, 18 insertions(+), 9 deletions(-) > > diff --git a/server/red-worker.c b/server/red-worker.c > index a98c4a6..991a816 100644 > --- a/server/red-worker.c > +++ b/server/red-worker.c > @@

Re: [Spice-devel] [PATCH 2/3] server: move dispatcher GSource handling code

> > From: Marc-André Lureau > > Acked-by: Jonathon Jongsma > --- > server/dispatcher.c | 25 + > server/dispatcher.h | 2 ++ > server/red-worker.c | 39 --- > 3 files changed, 39 insertions(+), 27 deletions(-) > > diff --git a/serve

Re: [Spice-devel] [PATCH 1/3] worker: use glib main loop

> > Use the glib mainloop instead of writing our own. The glib loop is both > cleaner to use and is more extensible. It is also very mature and > reduces the maintenance burden on the spice server. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Jonathon Jongsma > Signed-off-by: Frediano

Re: [Spice-devel] [PATCH 08/14] spice-pulse: Use GTask instead of GSimpleAsyncResult

On Wed, 2016-01-20 at 16:21 +0100, Christophe Fergeau wrote: > On Wed, Jan 20, 2016 at 04:09:44PM +0100, Fabiano Fidêncio wrote: > > > > static void spice_pulse_complete_async_task(struct async_task *task, > > > > const gchar *err_msg) > > > > @@ -1157,19 +1143,13 @@ static void > > > > pulse_stre

[Spice-devel] [PATCH 3/3] worker: avoid server hanging when no client are connected.

From: Marc-André Lureau --- server/red-worker.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/server/red-worker.c b/server/red-worker.c index a98c4a6..991a816 100644 --- a/server/red-worker.c +++ b/server/red-worker.c @@ -227,7 +227,6 @@ static

[Spice-devel] [PATCH 2/3] server: move dispatcher GSource handling code

From: Marc-André Lureau Acked-by: Jonathon Jongsma --- server/dispatcher.c | 25 + server/dispatcher.h | 2 ++ server/red-worker.c | 39 --- 3 files changed, 39 insertions(+), 27 deletions(-) diff --git a/server/dispatcher.c b/server

[Spice-devel] [PATCH 0/3] Glib loop in RedWorker

Finally is time to approach again these patches to use GLib loop functions for RedWorker. Patches has been through so many passages that I'm posting as they are. Frediano Ziglio (1): worker: use glib main loop Marc-André Lureau (2): server: move dispatcher GSource handling code worker: avoi

[Spice-devel] [PATCH 1/3] worker: use glib main loop

Use the glib mainloop instead of writing our own. The glib loop is both cleaner to use and is more extensible. It is also very mature and reduces the maintenance burden on the spice server. Signed-off-by: Marc-André Lureau Signed-off-by: Jonathon Jongsma Signed-off-by: Frediano Ziglio --- serv

Re: [Spice-devel] [PATCH 2/2] usb-device-widget: Add counter of free channels

On Wed, 2016-01-20 at 10:11 +0100, Fabiano Fidêncio wrote: > On Wed, Jan 20, 2016 at 9:59 AM, Victor Toso wrote: > > Hi, > > > > On Tue, Jan 19, 2016 at 10:36:38PM +0100, Fabiano Fidêncio wrote: > > > As the message showed when the last usbredir channel is taken can be a > > > bit confusing, let'

Re: [Spice-devel] [PATCH] tests: add explanation for test_qxl_pasring_SOURCES

On Wed, 2016-01-20 at 11:18 -0500, Frediano Ziglio wrote: > > > > On Tue, 2016-01-19 at 05:42 -0500, Frediano Ziglio wrote: > > > > Subject: [PATCH] tests: add explanation for test_qxl_pasring_SOURCES > > > > > > > > > > Typo on subject. Already fixed > > > > > > > Instead of using libserver.a

Re: [Spice-devel] [PATCH 2/2] usb-device-widget: Add counter of free channels

Hi - Original Message - > On Wed, 2016-01-20 at 10:11 +0100, Fabiano Fidêncio wrote: > > On Wed, Jan 20, 2016 at 9:59 AM, Victor Toso wrote: > > > Hi, > > > > > > On Tue, Jan 19, 2016 at 10:36:38PM +0100, Fabiano Fidêncio wrote: > > > > As the message showed when the last usbredir channe

Re: [Spice-devel] [PATCH v4 0/5] Event loop improves

> > On Tue, 2016-01-19 at 11:54 +, Frediano Ziglio wrote: > > These set of patches try to improve current event loop code. > > > > Patches improve test event loop, make a template from > > them and use for main loop. > > These patches also improve glib main loop patch from Marc and > > superc

Re: [Spice-devel] [PATCH] tests: add explanation for test_qxl_pasring_SOURCES

> > On Tue, 2016-01-19 at 05:42 -0500, Frediano Ziglio wrote: > > > Subject: [PATCH] tests: add explanation for test_qxl_pasring_SOURCES > > > > > > > Typo on subject. Already fixed > > > > > Instead of using libserver.a to include necessary functions we include > > > single files to check for

Re: [Spice-devel] [PATCH spice-common v2] draw: Add spice_image_descriptor_is_lossy

> > It will be used in the server code > --- > v2: changed to static inline function > --- > common/canvas_base.c | 8 ++-- > common/draw.h| 6 ++ > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/common/canvas_base.c b/common/canvas_base.c > index d918441..fa4d

[Spice-devel] [PATCH 15/16] Change spice_server_set_ticket() to use local 's'

From: Jonathon Jongsma Rather than using global 'reds' variable --- server/reds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index 080c0f6..c112be4 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3608,16 +3608,16 @@ SPICE_GNUC_VISIB

Re: [Spice-devel] [PATCH 16/16] spice_server_add_interface: use local 's' variable

> > From: Jonathon Jongsma > > Prefer local argument variable over global 'reds' variable > --- > server/reds.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index c112be4..d39f93e 100644 > --- a/server/reds.c > +++ b/server/reds

Re: [Spice-devel] [PATCH 15/16] Change spice_server_set_ticket() to use local 's'

> From: Jonathon Jongsma > > Rather than using global 'reds' variable > --- > server/reds.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 080c0f6..c112be4 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -3608,16 +360

Re: [Spice-devel] [PATCH 1/2] usb-device-widget: Improve "there are no free USB channnels" string

On Wed, 2016-01-20 at 10:09 +0100, Fabiano Fidêncio wrote: > On Wed, Jan 20, 2016 at 9:53 AM, Victor Toso wrote: > > Hi, > > > > On Tue, Jan 19, 2016 at 10:36:37PM +0100, Fabiano Fidêncio wrote: > > > As the message can be understand as an error message, let's replace it > > > for a more user-fri

[Spice-devel] [PATCH 11/16] Change reds_char_device_remove_state() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index 1546b07..8adc656 100644 --- a/server/reds.c +++ b/server/reds.c @@ -209,7 +209,7 @@ static void reds_mig_target_client_free(RedsState *reds, Red

[Spice-devel] [PATCH 16/16] spice_server_add_interface: use local 's' variable

From: Jonathon Jongsma Prefer local argument variable over global 'reds' variable --- server/reds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index c112be4..d39f93e 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3246,9 +3246,9 @@

[Spice-devel] [PATCH 09/16] Change attach_to_red_agent() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 38e4aef..0db2ad5 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2974,7 +2974,7 @@ void reds_disable_mm_time(RedsState *reds) reds->mm_time

[Spice-devel] [PATCH 10/16] Change reds_char_device_add_state() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index 0db2ad5..1546b07 100644 --- a/server/reds.c +++ b/server/reds.c @@ -208,7 +208,7 @@ static RedsMigTargetClient* reds_mig_target_client_find(Reds

[Spice-devel] [PATCH 04/16] Change reds_migrate_channels_seamless() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index fa29993..9d0391f 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2903,7 +2903,7 @@ static void reds_mig_remove_wait_disconnect_client(RedsState

[Spice-devel] [PATCH 13/16] Change spice_server_char_device_remove_interface to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index c2f06af..00fd1ac 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3167,7 +3167,7 @@ static int spice_server_char_device_add_interface(SpiceServe

[Spice-devel] [PATCH 12/16] Change reds_on_char_device_state_destroy() to take RedsState arg

From: Jonathon Jongsma --- server/char-device.c | 2 +- server/reds.c| 2 +- server/reds.h| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/char-device.c b/server/char-device.c index 19e8419..7c209cd 100644 --- a/server/char-device.c +++ b/server/char-

[Spice-devel] [PATCH 07/16] Change reds_enable_mm_time() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 2 +- server/reds.h | 2 +- server/sound.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index da2555a..6232f1d 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2962,7 +2962,7 @@ uint32_t reds

[Spice-devel] [PATCH 08/16] Change reds_disable_mm_time() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 2 +- server/reds.h | 2 +- server/sound.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index 6232f1d..38e4aef 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2969,7 +2969,7 @@ void reds_ena

[Spice-devel] [PATCH 03/16] Change reds_mig_remove_wait_disconnect_client() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index 0b389c2..fa29993 100644 --- a/server/reds.c +++ b/server/reds.c @@ -207,7 +207,7 @@ static void migrate_timeout(void *opaque); static RedsMigTar

[Spice-devel] [PATCH 14/16] Change migrate_timeout() to take reds as data arg

From: Jonathon Jongsma --- server/reds.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index 00fd1ac..080c0f6 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2944,6 +2944,7 @@ static void reds_mig_switch(RedsState *reds) static void mig

[Spice-devel] [PATCH 06/16] Change reds_mig_switch() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 6a2277c..da2555a 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2932,7 +2932,7 @@ static void reds_mig_finished(RedsState *reds, int completed

[Spice-devel] [PATCH 00/16] Backported some patches from refactory branches (20th Jan) 2nd

Many new patches try to incrementally remove global reds variable so they add RedsState* as parameter. All previous patches except "Change spice_server_set_ticket() to use local 's'" were merged. Jonathon Jongsma (16): Change reds_mig_fill_wait_disconnect() to take RedsState arg Change reds_m

[Spice-devel] [PATCH 01/16] Change reds_mig_fill_wait_disconnect() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index d018b1d..101e957 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2850,7 +2850,7 @@ static void reds_mig_started(RedsState *reds) core->time

[Spice-devel] [PATCH 05/16] Change reds_mig_finished() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 9d0391f..6a2277c 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2912,7 +2912,7 @@ static void reds_migrate_channels_seamless(RedsState *reds)

[Spice-devel] [PATCH 02/16] Change reds_mig_cleanup_wait_disconnect() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index 101e957..0b389c2 100644 --- a/server/reds.c +++ b/server/reds.c @@ -206,7 +206,7 @@ struct ChannelSecurityOptions { static void migrate_timeout(

Re: [Spice-devel] [PATCH 15/15] Change reds_mig_started() to take RedsState arg

On Wed, 2016-01-20 at 10:16 -0500, Frediano Ziglio wrote: > > > > On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > > > From: Jonathon Jongsma > > > > > Acked-by: Pavel Grunt > > > --- > > >  server/reds.c | 4 ++-- > > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > di

Re: [Spice-devel] [PATCH 08/14] spice-pulse: Use GTask instead of GSimpleAsyncResult

On Wed, Jan 20, 2016 at 04:09:44PM +0100, Fabiano Fidêncio wrote: > >> static void spice_pulse_complete_async_task(struct async_task *task, > >> const gchar *err_msg) > >> @@ -1157,19 +1143,13 @@ static void > >> pulse_stream_restore_info_async(gboolean is_playback, > >>

Re: [Spice-devel] [PATCH 15/15] Change reds_mig_started() to take RedsState arg

> > On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > > From: Jonathon Jongsma > > > Acked-by: Pavel Grunt > > --- > >  server/reds.c | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/server/reds.c b/server/reds.c > > index 67b2071..566d346 100644 > >

Re: [Spice-devel] [PATCH v4 0/5] Event loop improves

> > On Tue, Jan 19, 2016 at 11:54:47AM +, Frediano Ziglio wrote: > > These set of patches try to improve current event loop code. > > > > Patches improve test event loop, make a template from > > them and use for main loop. > > These patches also improve glib main loop patch from Marc and > >

Re: [Spice-devel] [PATCH 08/14] spice-pulse: Use GTask instead of GSimpleAsyncResult

On Mon, Jan 18, 2016 at 2:55 PM, Christophe Fergeau wrote: > On Mon, Jan 18, 2016 at 10:05:44AM +0100, Fabiano Fidêncio wrote: >> Instead of using GSimpleAsyncResult, use the new GTask API, which is >> much more straightforward. >> --- >> src/spice-pulse.c | 96 >> +++

Re: [Spice-devel] [PATCH 12/15] Change on_activating_ticketing() to take RedsState arg

> > On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > > From: Jonathon Jongsma > --- > >  server/reds.c | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/server/reds.c b/server/reds.c > > index 91fab12..3f7ee27 100644 > > --- a/server/reds.c > > +++ b/s

Re: [Spice-devel] [PATCH 2/2] usb-device-widget: Add counter of free channels

On Tue, Jan 19, 2016 at 10:36 PM, Fabiano Fidêncio wrote: > As the message showed when the last usbredir channel is taken can be a > bit confusing, let's add a counter of free channels to the widget's > label. > In order to add the counter, two new helper functions got introduced > spice_usb_devic

[Spice-devel] [PATCH spice-common v2] draw: Add spice_image_descriptor_is_lossy

It will be used in the server code --- v2: changed to static inline function --- common/canvas_base.c | 8 ++-- common/draw.h| 6 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index d918441..fa4d373 100644 --- a/common

Re: [Spice-devel] [PATCH 02/14] channel-main: Use GTask instead of GSimpleAsyncResult

On Wed, Jan 20, 2016 at 02:45:59PM +0100, Fabiano Fidêncio wrote: > On Wed, Jan 20, 2016 at 2:39 PM, Christophe Fergeau > wrote: > > I don't really understand what you are getting at. > > The way I read the code is > > "if we have an error, then return from the async call and report an > > error,

Re: [Spice-devel] [PATCH 15/15] Change reds_mig_started() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 67b2071..566d346 100644 > --- a/server/reds.c > ++

Re: [Spice-devel] [PATCH 14/15] Change reds_mig_release to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 10 +- >  1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index e47c694..67b2071 100644 > --- a/server/reds

Re: [Spice-devel] [PATCH 13/15] Change spice_server_set_ticket() to use local 's'

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > > Rather than using global 'reds' variable Acked-by: Pavel Grunt > --- >  server/reds.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 3f7ee2

Re: [Spice-devel] [PATCH 12/15] Change on_activating_ticketing() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma --- >  server/reds.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 91fab12..3f7ee27 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -2787

Re: [Spice-devel] [PATCH 11/15] Change reds_init_ssl() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 824e149..91fab12 100644 > --- a/server/reds.c > ++

Re: [Spice-devel] [PATCH 10/15] Change do_spice_init() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 81d253c..824e149 100644 > --- a/server/reds.c > ++

Re: [Spice-devel] [PATCH 09/15] Change reds_init_net() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 58e45ae..81d253c 100644 > --- a/server/reds.c > ++

Re: [Spice-devel] [PATCH 08/15] Change reds_set_client_mm_time_latency() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/main-dispatcher.c | 4 ++-- >  server/reds.c| 2 +- >  server/reds.h| 2 +- >  3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server

Re: [Spice-devel] [PATCH 05/15] Change reds_handle_other_links() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 77e9bd6..1923bf5 100644 > --- a/server/reds.c > ++

Re: [Spice-devel] [PATCH 07/15] Change reds_send_mm_time() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 10 +- >  1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index d8ee53d..a2e1542 100644 > --- a/server/reds

Re: [Spice-devel] [PATCH 06/15] Change reds_handle_link() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 8 >  1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 1923bf5..d8ee53d 100644 > --- a/server/reds.c

Re: [Spice-devel] [PATCH 04/15] Change reds_on_client_semi_seamless_migrate_complete() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/red-channel.c | 2 +- >  server/reds.c| 2 +- >  server/reds.h| 2 +- >  3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/server/red-channel.c

Re: [Spice-devel] [PATCH 02/15] Change reds_on_migrate_dst_set_seamless() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma Acked-by: Pavel Grunt > > --- >  server/main-channel.c | 2 +- >  server/reds.c | 2 +- >  server/reds.h | 2 +- >  3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/server/main-chan

Re: [Spice-devel] [PATCH 03/15] Change reds_on_client_seamless_migrate_complete() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/main-dispatcher.c | 4 ++-- >  server/reds.c| 2 +- >  server/reds.h| 2 +- >  3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server

Re: [Spice-devel] [PATCH 01/15] Change reds_link_mig_target_channels() to take RedsState arg

On Wed, 2016-01-20 at 13:25 +, Frediano Ziglio wrote: > From: Jonathon Jongsma > Acked-by: Pavel Grunt > --- >  server/reds.c | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 0e31b59..52fcb5e 100644 > --- a/server/reds.c >

Re: [Spice-devel] [PATCH v4 0/5] Event loop improves

On Tue, Jan 19, 2016 at 11:54:47AM +, Frediano Ziglio wrote: > These set of patches try to improve current event loop code. > > Patches improve test event loop, make a template from > them and use for main loop. > These patches also improve glib main loop patch from Marc and > supercede fixes

Re: [Spice-devel] [PATCH 02/14] channel-main: Use GTask instead of GSimpleAsyncResult

On Wed, Jan 20, 2016 at 2:39 PM, Christophe Fergeau wrote: > On Wed, Jan 20, 2016 at 02:29:19PM +0100, Fabiano Fidêncio wrote: >> On Wed, Jan 20, 2016 at 2:03 PM, Christophe Fergeau >> wrote: >> > On Wed, Jan 20, 2016 at 01:38:52PM +0100, Fabiano Fidêncio wrote: >> >> On Mon, Jan 18, 2016 at 11:

Re: [Spice-devel] [PATCH 02/14] channel-main: Use GTask instead of GSimpleAsyncResult

On Wed, Jan 20, 2016 at 02:29:19PM +0100, Fabiano Fidêncio wrote: > On Wed, Jan 20, 2016 at 2:03 PM, Christophe Fergeau > wrote: > > On Wed, Jan 20, 2016 at 01:38:52PM +0100, Fabiano Fidêncio wrote: > >> On Mon, Jan 18, 2016 at 11:31 AM, Christophe Fergeau > >> wrote: > >> > On Mon, Jan 18, 2016

Re: [Spice-devel] [PATCH spice v3 3/6] dcc-send: Use dcc_compress_image to compress image

> > --- > v3: Uses a helper function from spice-common > --- > server/dcc-send.c | 44 ++-- > 1 file changed, 2 insertions(+), 42 deletions(-) > > diff --git a/server/dcc-send.c b/server/dcc-send.c > index c3f79ef..3cb50ba 100644 > --- a/server/dcc-send.c

Re: [Spice-devel] [PATCH spice-common] draw: Add spice_image_descriptor_is_lossy

> > It will be used in the server code > --- > common/canvas_base.c | 12 +++- > common/draw.h| 2 ++ > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/common/canvas_base.c b/common/canvas_base.c > index d918441..509e0bf 100644 > --- a/common/canvas_base.c > ++

Re: [Spice-devel] [PATCH 02/14] channel-main: Use GTask instead of GSimpleAsyncResult

On Wed, Jan 20, 2016 at 2:03 PM, Christophe Fergeau wrote: > On Wed, Jan 20, 2016 at 01:38:52PM +0100, Fabiano Fidêncio wrote: >> On Mon, Jan 18, 2016 at 11:31 AM, Christophe Fergeau >> wrote: >> > On Mon, Jan 18, 2016 at 10:05:38AM +0100, Fabiano Fidêncio wrote: >> >> @@ -1794,15 +1785,15 @@ sta

[Spice-devel] [PATCH 09/15] Change reds_init_net() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 58e45ae..81d253c 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2570,7 +2570,7 @@ void reds_set_client_mm_time_latency(RedsState *reds, RedCli

[Spice-devel] [PATCH 02/15] Change reds_on_migrate_dst_set_seamless() to take RedsState arg

From: Jonathon Jongsma --- server/main-channel.c | 2 +- server/reds.c | 2 +- server/reds.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/main-channel.c b/server/main-channel.c index 802187b..9623224 100644 --- a/server/main-channel.c +++ b/server

[Spice-devel] [PATCH 05/15] Change reds_handle_other_links() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 77e9bd6..1923bf5 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1868,7 +1868,7 @@ void reds_on_client_semi_seamless_migrate_complete(RedsState

[Spice-devel] [PATCH 15/15] Change reds_mig_started() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 67b2071..566d346 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2840,7 +2840,7 @@ static void reds_mig_release(RedsState *reds) } } -st

[Spice-devel] [PATCH 14/15] Change reds_mig_release to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/reds.c b/server/reds.c index e47c694..67b2071 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2830,7 +2830,7 @@ typedef struct RedsMigCertPubKeyInfo { uint32_t l

[Spice-devel] [PATCH 11/15] Change reds_init_ssl() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 824e149..91fab12 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2686,7 +2686,7 @@ static void openssl_thread_setup(void) CRYPTO_set_lockin

[Spice-devel] [PATCH 13/15] Change spice_server_set_ticket() to use local 's'

From: Jonathon Jongsma Rather than using global 'reds' variable --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 3f7ee27..e47c694 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3607,12 +3607,12 @@ SPICE_GNUC_VISIBLE

[Spice-devel] [PATCH 10/15] Change do_spice_init() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 81d253c..824e149 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3343,7 +3343,7 @@ static void init_vd_agent_resources(void) const char *vers

[Spice-devel] [PATCH 12/15] Change on_activating_ticketing() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index 91fab12..3f7ee27 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2787,7 +2787,7 @@ static void reds_exit(void) #endif } -static inline void

[Spice-devel] [PATCH 08/15] Change reds_set_client_mm_time_latency() to take RedsState arg

From: Jonathon Jongsma --- server/main-dispatcher.c | 4 ++-- server/reds.c| 2 +- server/reds.h| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c index 01290d2..132a693 100644 --- a/server/main-dispa

[Spice-devel] [PATCH 01/15] Change reds_link_mig_target_channels() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index 0e31b59..52fcb5e 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1791,7 +1791,7 @@ static void reds_channel_do_link(RedChannel *channel, RedC

[Spice-devel] [PATCH 00/15] Backported some patches from refactory branches (20th Jan)

Many new patches try to incrementally remove global reds variable so they add RedsState* as parameter. All previous patches were merged. Jonathon Jongsma (15): Change reds_link_mig_target_channels() to take RedsState arg Change reds_on_migrate_dst_set_seamless() to take RedsState arg Change

[Spice-devel] [PATCH 07/15] Change reds_send_mm_time() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/reds.c b/server/reds.c index d8ee53d..a2e1542 100644 --- a/server/reds.c +++ b/server/reds.c @@ -210,7 +210,7 @@ static void reds_mig_cleanup_wait_disconnect(void); sta

[Spice-devel] [PATCH 06/15] Change reds_handle_link() to take RedsState arg

From: Jonathon Jongsma --- server/reds.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index 1923bf5..d8ee53d 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1926,7 +1926,7 @@ static void reds_handle_other_links(RedsState *reds, Red

[Spice-devel] [PATCH 04/15] Change reds_on_client_semi_seamless_migrate_complete() to take RedsState arg

From: Jonathon Jongsma --- server/red-channel.c | 2 +- server/reds.c| 2 +- server/reds.h| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index efe889a..2cf190c 100644 --- a/server/red-channel.c +++ b/server/red-c

[Spice-devel] [PATCH 03/15] Change reds_on_client_seamless_migrate_complete() to take RedsState arg

From: Jonathon Jongsma --- server/main-dispatcher.c | 4 ++-- server/reds.c| 2 +- server/reds.h| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c index db87e05..01290d2 100644 --- a/server/main-dispa

Re: [Spice-devel] [PATCH 14/15] Change reds_handle_main_link() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/reds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index fdf2be8..ad59cfc 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -1652,7 +1652,7 @@ static RedClient *reds_get_client(Re

Re: [Spice-devel] [PATCH 15/15] Change reds_set_client_mouse_allowed() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/red-dispatcher.c | 2 +- > server/reds.c | 2 +- > server/reds.h | 3 ++- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/server/red-dispatcher.c b/server/red-dispatcher.c > index dc958d9..b4bbe85 100644 > ---

Re: [Spice-devel] [PATCH 13/15] Change reds_get_client() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/reds.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 6d34554..fdf2be8 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -1639,7 +1639,7 @@ static int reds_find_client(Reds

Re: [Spice-devel] [PATCH 10/15] Change reds_mig_target_client_free() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/reds.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index d57b1bf..b079e02 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -205,7 +205,7 @@ struct ChannelSecurityOptions { >

Re: [Spice-devel] [PATCH 11/15] Change reds_mig_target_client_disconnect_all() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/reds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index b079e02..a277df9 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -1613,7 +1613,7 @@ static void reds_mig_target_client_f

Re: [Spice-devel] [PATCH 12/15] Change reds_find_client() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/reds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index a277df9..6d34554 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -1623,7 +1623,7 @@ static void > reds_mig_target_client

[Spice-devel] [PATCH spice v3 6/6] dcc: Move COMPRESS_DEBUG to compression functions

--- server/dcc.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 6f7babf..5e642b8 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -662,6 +662,10 @@ static int dcc_compress_image_glz(DisplayChannelClient *d

Re: [Spice-devel] [PATCH 09/15] Change reds_mig_target_client_find() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/reds.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index e713cf4..d57b1bf 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -204,7 +204,7 @@ struct ChannelSecurityOptions

[Spice-devel] [PATCH spice v3 5/6] dcc: Rewrite dcc_image_compress

Rules are now: Compression type: off -> uncompressed quic -> jpeg if possible else quic else off lz -> lz if possible else off glz -> glz if possible else lz else off auto_lz -> lz if possible else jpeg else quic else off auto_glz -> glz if possible else lz else jp

Re: [Spice-devel] [PATCH 06/15] Change reds_handle_migrate_data() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/main-channel.c | 2 +- > server/reds.c | 3 ++- > server/reds.h | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/server/main-channel.c b/server/main-channel.c > index f584aff..802187b 100644 > --- a/server/m

Re: [Spice-devel] [PATCH 07/15] Change reds_send_link_ack() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/reds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index a3636fc..3e360d3 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -1410,7 +1410,7 @@ static bool red_link_info_test_capab

[Spice-devel] [PATCH spice v3 4/6] dcc: make dcc_compress_image_*() private

Reviewed-by: Victor Toso Acked-by: Frediano Ziglio --- server/dcc.c | 30 +++--- server/dcc.h | 15 --- 2 files changed, 15 insertions(+), 30 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 613d7af..bf692f8 100644 --- a/server/dcc.c +++ b/server/d

Re: [Spice-devel] [PATCH 08/15] Change reds_mig_target_client_add() to take RedsState arg

> > From: Jonathon Jongsma > > --- > server/reds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c > index 3e360d3..e713cf4 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -1554,7 +1554,7 @@ int reds_expects_link_id(uint32_t co

[Spice-devel] [PATCH spice v3 1/6] build-sys: Update spice-common submodule

For spice_image_descriptor_is_lossy() --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index b61f43f..723e50d 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit b61f43f228950505ef809dccd6a73aefdfd44ce1 +Subpro

[Spice-devel] [PATCH spice v3 2/6] dcc_compress_image: Handle NULL drawable

It will be used in the following commit. The GLZ compression cannot be used when the drawable is NULL. Acked-by: Frediano Ziglio --- server/dcc.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 2568e24..613d7af 1

  1   2   >