Re: [Spice-devel] [PATCH 07/16] worker: remove some unnecessary inline

Acked-by: Pavel Grunt On Thu, 2015-11-26 at 16:06 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- >  server/dcc-send.c   | 10 +- >  server/red_worker.c |  8 >  2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/server/dcc-send.c b/server/dcc-send

Re: [Spice-devel] [PATCH v6 00/10] Add support for UsbDk backend

Hi, I tested this quite a bit and major issue that I've found [0] should be solved in the next UsbDk release. [0] https://bugs.freedesktop.org/show_bug.cgi?id=92867 I thought it would make sense to put this feedback here :) Cheers, Victor Toso On Thu, Oct 29, 2015 at 05:26:35PM +0200, Dmitry

[Spice-devel] [PATCH 1/1] channel: add optional tcp keepalive timeout to channels

Hi, With firewall running between spice server and client, if idle time is larger than firewall session timeout, spice sessions freeze and users lose their keyboard and mouse control. To workaround this issue, I made a patch to add tcp keepalive timeout to spice server. The timeout can be added t

Re: [Spice-devel] [PATCH spice-common v2] m4: Add macro for --with-sasl

On 11/26/2015 11:59 AM, Uri Lublin wrote: > On 11/26/2015 03:46 PM, Pavel Grunt wrote: >> Hi Uri, >> >> On Thu, 2015-11-26 at 15:26 +0200, Uri Lublin wrote: >>> On 11/26/2015 09:53 AM, Pavel Grunt wrote: It is not used by spice-common, but both server and client can use it. Compared to cu

[Spice-devel] [PATCH 14/16] red_channel: cleanup of red_channel_client blocking methods

From: Yonit Halperin (1) receive timeout as a parameter. (2) add a return value and pass the handling of failures to the calling routine. --- server/cursor-channel.c | 1 + server/dcc.h| 1 + server/red_channel.c| 8 +--- server/red_worker.c | 4 ++-- 4 files changed,

[Spice-devel] [PATCH 08/16] misc cleanups

From: Marc-André Lureau --- server/cursor-channel.c | 2 +- server/dcc-send.c | 4 +--- server/red_worker.c | 4 ++-- server/red_worker.h | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index 9d72299..840ff30

[Spice-devel] [PATCH 11/16] worker: merge handle_new_display_channel

From: Marc-André Lureau --- server/red_worker.c | 49 - 1 file changed, 16 insertions(+), 33 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 2a58052..cf20ccd 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -

[Spice-devel] [PATCH 15/16] tests: test_display_base: use a faster wakeup time to easily test multiple client blocking

From: Alon Levy --- server/tests/test_display_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index c2c5705..575c704 100644 --- a/server/tests/test_display_base.c +++ b/server/tests/test_display_base.c

[Spice-devel] [PATCH 10/16] display: add update_compression() method

From: Marc-André Lureau --- server/display-channel.c | 17 + server/display-channel.h | 2 ++ server/red_worker.c | 21 - 3 files changed, 23 insertions(+), 17 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 28fd565..

[Spice-devel] [PATCH 12/16] worker: remove useless QXL_CMD_MESSAGE

From: Marc-André Lureau Unsecure code shouldn't be compiled in even in debug mode. Doesn't seem to be used, and probably should be handled at qemu qxl driver level instead. --- server/red_parse_qxl.c | 26 -- server/red_parse_qxl.h | 4 server/red_worker.c| 18 -

[Spice-devel] [PATCH 07/16] worker: remove some unnecessary inline

From: Marc-André Lureau --- server/dcc-send.c | 10 +- server/red_worker.c | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/server/dcc-send.c b/server/dcc-send.c index 634084a..2340252 100644 --- a/server/dcc-send.c +++ b/server/dcc-send.c @@ -191,9 +191,9

[Spice-devel] [PATCH 16/16] worker: rename process_commands process_display

From: Marc-André Lureau --- server/red_worker.c | 53 ++--- 1 file changed, 26 insertions(+), 27 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 5175839..d9b98d5 100644 --- a/server/red_worker.c +++ b/server/red_worker.c

[Spice-devel] [PATCH 09/16] worker: move red_process_surface

From: Marc-André Lureau --- server/display-channel.c | 59 +++ server/display-channel.h | 4 +++ server/red_worker.c | 66 +++- 3 files changed, 67 insertions(+), 62 deletions(-) diff --git a/server/displa

[Spice-devel] [PATCH 00/16] Backported some patches from refactory branches (26th Nov)

This patchset supersedes last patchset. Changes: - rebased on current master; - removed merged patches; - added some patches. Didn't find time to split "display: move more logic in add_drawable()" Some patches on discussion were not posted. Alon Levy (1): tests: test_display_base: use a fast

[Spice-devel] [PATCH 13/16] red_worker: cleanup red_clear_surface_drawables_from_pipes

From: Yonit Halperin (1) merge 'force' and 'wait_for_outgoing_item' to one parameter. 'wait_for_outgoing_item' is a derivative of 'force'. (2) move the call to red_wait_outgoing_item to red_clear_surface_drawables_from_pipe --- server/dcc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [Spice-devel] [PATCH 13/18] display: replace some dubious asserts

On 11/26/2015 02:34 PM, Frediano Ziglio wrote: On 11/25/2015 02:23 PM, Frediano Ziglio wrote: On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: From: Marc-André Lureau Reviewed-by: Jonathon Jongsma As I said in my previous review, I think that using g_return_if_fail() here is app

Re: [Spice-devel] [PATCH 07/19] display: move more logic in add_drawable()

> > On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/display-channel.c | 229 +++-- > > server/display-channel.h | 23 ++--- > > server/red_worker.c | 258 > > +++

Re: [Spice-devel] [PATCH spice-common v2] m4: Add macro for --with-sasl

On 11/26/2015 03:46 PM, Pavel Grunt wrote: Hi Uri, On Thu, 2015-11-26 at 15:26 +0200, Uri Lublin wrote: On 11/26/2015 09:53 AM, Pavel Grunt wrote: It is not used by spice-common, but both server and client can use it. Compared to current checks in spice-gtk and spice server this macro only sup

[Spice-devel] [PATCH spice-server v2] build-sys: Use sasl check from spice-common

The default option --with-sasl='check' works like 'yes', ie throwing an error when sasl is not found. Use check from spice-common which handles it properly. It also renames the default option 'check' to 'auto'. Support only libsasl2 providing libsasl2.pc file --- depends on http://lists.freedesk

[Spice-devel] [PATCH spice-gtk v2] build-sys: Use sasl check from spice-common

Support only libsasl2 providing libsasl2.pc file --- depends on http://lists.freedesktop.org/archives/spice-devel/2015-November/024332.html --- configure.ac | 45 + 1 file changed, 1 insertion(+), 44 deletions(-) diff --git a/configure.ac b/configure.a

Re: [Spice-devel] [PATCH spice-common v2] m4: Add macro for --with-sasl

Hi Uri, On Thu, 2015-11-26 at 15:26 +0200, Uri Lublin wrote: > On 11/26/2015 09:53 AM, Pavel Grunt wrote: > > It is not used by spice-common, but both server and client can use it. > > Compared to current checks in spice-gtk and spice server this macro only > > supports libsasl2. > > --- > > v2: -

Re: [Spice-devel] [PATCH] worker: improve validation for update command

On 11/26/2015 03:15 PM, Pavel Grunt wrote: On Thu, 2015-11-26 at 12:26 +, Frediano Ziglio wrote: If surface_id is not valid we should still release resource allocated by red_get_update_cmd and from the guest. This to reduce leaks in case of a race or another error in the guest driver. Also n

Re: [Spice-devel] [PATCH 09/19] worker: move dcc_send & marshallers to dcc-send.c

On Thu, Nov 26, 2015 at 11:46 AM, Frediano Ziglio wrote: >> >> > >> > This patch is freaking huge :-\ >> > Is there some automated way to check whether a function move is just a >> > move or something else changed? >> > >> >> Do you mean something like this? >> >> >> --- before.c 2015-11-26 09:57

Re: [Spice-devel] [PATCH spice-common v2] m4: Add macro for --with-sasl

On 11/26/2015 09:53 AM, Pavel Grunt wrote: It is not used by spice-common, but both server and client can use it. Compared to current checks in spice-gtk and spice server this macro only supports libsasl2. --- v2: - only supports libsasl2 - PKG_CHECK_MODULES is used instead of AC_CHECK_LIB a

Re: [Spice-devel] [PATCH] worker: improve validation for update command

On Thu, 2015-11-26 at 12:26 +, Frediano Ziglio wrote: > If surface_id is not valid we should still release resource allocated > by red_get_update_cmd and from the guest. > This to reduce leaks in case of a race or another error in the guest > driver. > Also not issue a warning on invalid surfac

Re: [Spice-devel] [PATCH v2] server: move LZ_IMAGE_TYPE_* enum to dcc

On Thu, 2015-11-26 at 14:07 +0100, Fabiano Fidêncio wrote: > From: Marc-André Lureau > > Signed-off-by: Fabiano Fidêncio > --- >  server/dcc.c| 18 -- >  server/red_common.h | 14 -- >  2 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/server/

[Spice-devel] [PATCH v2] server: move LZ_IMAGE_TYPE_* enum to dcc

From: Marc-André Lureau Signed-off-by: Fabiano Fidêncio --- server/dcc.c| 18 -- server/red_common.h | 14 -- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 6c089da..ffe5b34 100644 --- a/server/dcc.c +++ b/s

Re: [Spice-devel] [PATCH 08/19] worker: remove redundant check

> > On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > The check is done in draw() > > --- > > server/red_worker.c | 4 > > 1 file changed, 4 deletions(-) > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > index 84048fe..2b5c162 1006

Re: [Spice-devel] [PATCH 13/18] display: replace some dubious asserts

> > On 11/25/2015 02:23 PM, Frediano Ziglio wrote: > >> > >> On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > >>> From: Marc-André Lureau > >>> > >>> Reviewed-by: Jonathon Jongsma > >> > >> As I said in my previous review, I think that using g_return_if_fail() > >> here > >> is > >> a

[Spice-devel] [PATCH] worker: improve validation for update command

If surface_id is not valid we should still release resource allocated by red_get_update_cmd and from the guest. This to reduce leaks in case of a race or another error in the guest driver. Also not issue a warning on invalid surface number to avoid filling log space unconditionally. Signed-off-by:

Re: [Spice-devel] [PATCH 11/19] server: move enum and struct away from red_common

On Thu, Nov 26, 2015 at 12:25 PM, Frediano Ziglio wrote: >> >> On Thu, Nov 26, 2015 at 10:29 AM, Fabiano Fidêncio >> wrote: >> > On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio >> > wrote: >> >> From: Marc-André Lureau >> >> >> >> --- >> >> server/dcc.c| 18 -- >> >

Re: [Spice-devel] [PATCH] canvas_utils: Remove trailing whitespace

On Čt, 2015-11-26 at 08:15 +0100, Pavel Grunt wrote: > Hi Lukas, > > can you get all of them? > > Thanks, > Pavel > > On Wed, 2015-11-25 at 16:25 +0100, Lukas Venhoda wrote: > > --- > > common/canvas_utils.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/common/

Re: [Spice-devel] [PATCH 11/19] server: move enum and struct away from red_common

> > On Thu, Nov 26, 2015 at 10:29 AM, Fabiano Fidêncio > wrote: > > On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio > > wrote: > >> From: Marc-André Lureau > >> > >> --- > >> server/dcc.c| 18 -- > >> server/red_common.h | 14 -- > >> server/red_dis

Re: [Spice-devel] [PATCH 17/19] display: fix generate_uid name

> > On Wed, 2015-11-25 at 11:26 -0500, Frediano Ziglio wrote: > > > > > > From: Marc-André Lureau > > > > > > --- > > >  server/dcc-send.c| 2 +- > > >  server/display-channel.c | 4 ++-- > > >  server/display-channel.h | 1 - > > >  3 files changed, 3 insertions(+), 4 deletions(-) > > >

Re: [Spice-devel] [PATCH 17/19] display: fix generate_uid name

On Wed, 2015-11-25 at 11:26 -0500, Frediano Ziglio wrote: > > > > From: Marc-André Lureau > > > > --- > >  server/dcc-send.c| 2 +- > >  server/display-channel.c | 4 ++-- > >  server/display-channel.h | 1 - > >  3 files changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/server

Re: [Spice-devel] [PATCH 11/19] server: move enum and struct away from red_common

On Thu, 2015-11-26 at 10:33 +0100, Fabiano Fidêncio wrote: > On Thu, Nov 26, 2015 at 10:29 AM, Fabiano Fidêncio > wrote: > > On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > > > From: Marc-André Lureau > > > > > > --- > > >  server/dcc.c| 18 -- > > >  server

Re: [Spice-devel] [PATCH 09/19] worker: move dcc_send & marshallers to dcc-send.c

> > > > > This patch is freaking huge :-\ > > Is there some automated way to check whether a function move is just a > > move or something else changed? > > > > Do you mean something like this? > > > --- before.c 2015-11-26 09:57:02.327008820 + > +++ after.c 2015-11-26 09:19:38.6425249

Re: [Spice-devel] [PATCH 19/19] display: remove some public declarations

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 6 -- > server/display-channel.h | 3 --- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c > index 811

Re: [Spice-devel] [PATCH 18/19] display: rename detach_streams_behind

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 12 ++-- > server/display-channel.h | 1 - > server/stream.c | 2 +- > server/stream.h | 3 +++ > 4 files changed, 10 insertions(+), 8 deletions(-)

[Spice-devel] Add option to make possible streaming setting change client-side for each session

Actually it is possible to setting streaming option server-side only and that is applied for any session. I think it would be a good option to have streaming session also client-side; like "preferred compression", for example "preferred streaming". In my case I will have streaming disabled in lan w

Re: [Spice-devel] [PATCH 09/19] worker: move dcc_send & marshallers to dcc-send.c

> > This patch is freaking huge :-\ > Is there some automated way to check whether a function move is just a > move or something else changed? > Do you mean something like this? --- before.c2015-11-26 09:57:02.327008820 + +++ after.c 2015-11-26 09:19:38.642524996 + @@ -34,20 +3

Re: [Spice-devel] [PATCH 16/19] worker: move red_pipes_remove_drawable

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 22 ++ > server/display-channel.h | 1 - > server/red_worker.c | 14 -- > 3 files changed, 18 insertions(+), 19 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH 15/19] worker: move current_remove*

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 61 > server/display-channel.h | 3 -- > server/red_worker.c | 80 > > server/stream

Re: [Spice-devel] [PATCH 15/19] worker: move current_remove*

On Thu, Nov 26, 2015 at 10:52 AM, Fabiano Fidêncio wrote: > On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: >> From: Marc-André Lureau >> >> --- >> server/display-channel.c | 61 >> server/display-channel.h | 3 -- >> server/red_worker.c | 80

Re: [Spice-devel] [PATCH 14/19] worker: move more stream functions

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc.c| 14 + > server/dcc.h| 2 + > server/red_worker.c | 177 > +--- > server/stream.c | 159 +++

Re: [Spice-devel] [PATCH 12/19] server: rename _tmpl files

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- > server/Makefile.am | 8 +- > server/cache-item.tmpl.c | 143 ++ > server/cache_item.tmpl.c | 1

Re: [Spice-devel] [PATCH 11/19] server: move enum and struct away from red_common

On Thu, Nov 26, 2015 at 10:29 AM, Fabiano Fidêncio wrote: > On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: >> From: Marc-André Lureau >> >> --- >> server/dcc.c| 18 -- >> server/red_common.h | 14 -- >> server/red_dispatcher.c | 15 ++

Re: [Spice-devel] [PATCH] display: factor out current_find_intersects_rect

On 11/25/2015 03:30 PM, Fabiano Fidêncio wrote: From: Marc-André Lureau Acked-by: Fabiano Fidêncio Acked-by: Uri Lublin --- server/display-channel.c | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/server/display-chann

Re: [Spice-devel] [PATCH 11/19] server: move enum and struct away from red_common

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc.c| 18 -- > server/red_common.h | 14 -- > server/red_dispatcher.c | 15 +-- > server/reds.c | 2 +- > server/stream.h

Re: [Spice-devel] [PATCH 18/18] display: factor out current_find_intersects_rect

On 11/23/2015 07:02 PM, Frediano Ziglio wrote: From: Marc-André Lureau --- server/display-channel.c | 51 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index a78f86a..ab7094

Re: [Spice-devel] [PATCH v2 1/3] worker: s/validate_area/surface_update_dest

On 11/23/2015 09:39 PM, Jonathon Jongsma wrote: On Mon, 2015-11-23 at 13:33 -0600, Jonathon Jongsma wrote: Acked-by: Jonathon Jongsma I take it back. This should probably be re-merged with the next patch. See below. On Mon, 2015-11-23 at 19:45 +0100, Fabiano Fidêncio wrote: From: Marc-

Re: [Spice-devel] [PATCH v2 1/3] worker: s/validate_area/surface_update_dest

On Thu, Nov 26, 2015 at 10:18 AM, Uri Lublin wrote: > On 11/23/2015 09:39 PM, Jonathon Jongsma wrote: >> >> On Mon, 2015-11-23 at 13:33 -0600, Jonathon Jongsma wrote: >>> >>> Acked-by: Jonathon Jongsma >>> >> >> I take it back. This should probably be re-merged with the next patch. >> See >> bel

Re: [Spice-devel] [PATCH 1/3] worker: s/validate_area/surface_update_dest

On 11/23/2015 08:36 PM, Fabiano Fidêncio wrote: From: Marc-André Lureau --- server/red_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index becd42f..efadd91 100644 --- a/server/red_worker.c +++ b/server/red_worke

Re: [Spice-devel] [PATCH 10/19] server: cleanups

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/Makefile.am | 1 - > server/dispatcher.h | 1 + > server/display-channel.h| 1 - > server/pixmap-cache.h | 1 - > server/red_dispatcher.c | 1 - > server/red_wor

Re: [Spice-devel] [PATCH 13/18] display: replace some dubious asserts

On 11/25/2015 02:23 PM, Frediano Ziglio wrote: On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: From: Marc-André Lureau Reviewed-by: Jonathon Jongsma As I said in my previous review, I think that using g_return_if_fail() here is appropriate. Yes, actually the only caller ignor

Re: [Spice-devel] [PATCH 08/19] worker: remove redundant check

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > The check is done in draw() > --- > server/red_worker.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index 84048fe..2b5c162 100644 > --- a/server/red_w

Re: [Spice-devel] missing spicec client

Hello, Dňa 23.11.2015 o 17:46 David Jaša napísal(a): > Zdravím, > > On Po, 2015-11-23 at 15:15 +0100, Fabiano Fidêncio wrote: >> On Sun, Nov 22, 2015 at 5:48 PM, Martin Filo >> wrote: >>> Hello, >>> >>> Spicec has been best spice client. It has nice user interface, no >>> annoying toolbar or icon

Re: [Spice-devel] [PATCH 07/19] display: move more logic in add_drawable()

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 229 +++-- > server/display-channel.h | 23 ++--- > server/red_worker.c | 258 > +++ > 3 f