[Spice-devel] [PATCH spice-common v2] m4: Add macro for --with-sasl

It is not used by spice-common, but both server and client can use it. Compared to current checks in spice-gtk and spice server this macro only supports libsasl2. --- v2: - only supports libsasl2 - PKG_CHECK_MODULES is used instead of AC_CHECK_LIB and AC_CHECK_HEADER --- m4/spice-deps.m4 | 28

Re: [Spice-devel] [PATCH] canvas_utils: Remove trailing whitespace

Hi Lukas, can you get all of them? Thanks, Pavel On Wed, 2015-11-25 at 16:25 +0100, Lukas Venhoda wrote: > --- >  common/canvas_utils.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/canvas_utils.c b/common/canvas_utils.c > index 0d1591a..789cd76 100644 > --- a/

Re: [Spice-devel] Passed: SPICE/libcacard#9 (v2.5.1 - e3e3780)

Can this be set up so it only emails on failures? On Wed, 2015-11-25 at 14:37 +, Travis CI wrote: > SPICE / libcacard (v2.5.1) > > Build #9 passed.> > 1 minute and 0 seconds > > Marc-André Lureau>> e3e3780 Changeset → > >> NEWS: update for 2.5.1 release > > Signed-of

Re: [Spice-devel] spice-server, logging and style

On Tue, 2015-11-24 at 06:20 -0500, Frediano Ziglio wrote: > > > > On Mon, Nov 23, 2015 at 12:28:49PM -0500, Frediano Ziglio wrote: > > > > Maybe you are suggesting more or less the same thing :). > > > > To me, from worst to "less worse", when something unexpected happens: > > > > - not detected,

Re: [Spice-devel] [spice-gtk] Update spice-common submodule

On Wed, 2015-11-25 at 11:35 -0600, Jonathon Jongsma wrote: > Acked-by: Jonathon Jongsma And now I notice that you've already pushed this ;) > > > On Wed, 2015-11-25 at 10:56 +0100, Christophe Fergeau wrote: > > The next commit is going to use SPICE_WARNING which was added recently > > to spi

Re: [Spice-devel] [spice-gtk] Update spice-common submodule

Acked-by: Jonathon Jongsma On Wed, 2015-11-25 at 10:56 +0100, Christophe Fergeau wrote: > The next commit is going to use SPICE_WARNING which was added recently > to spice-common > > This submodule update changes: > > Christophe Fergeau (5): > build-sys: Add gio-2.0 to SPICE_CHECK_GLIB2

Re: [Spice-devel] [PATCH 13/18] display: replace some dubious asserts

Acked-by: Jonathon Jongsma On Wed, 2015-11-25 at 11:51 -0500, Frediano Ziglio wrote: > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- > server/display-channel.c | 7 +-- > server/red_worker.c | 4 +--- > 2 files changed, 6 insertions(+), 5 deletions(-) > > >

Re: [Spice-devel] [PATCH 06/19] display: Simplify display_channel_create_surface

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 32 +--- > 1 file changed, 13 insertions(+), 19 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c > index b8d5a81..4a

Re: [Spice-devel] [PATCH 13/18] display: replace some dubious asserts

Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/display-channel.c | 7 +-- server/red_worker.c | 4 +--- 2 files changed, 6 insertions(+), 5 deletions(-) Changes: - move checks from worker to display; - remove the assert, it's now redundant. diff --git a/

Re: [Spice-devel] [PATCH 05/19] display: reuse code in display_channel_draw_until

On Wed, Nov 25, 2015 at 5:42 PM, Fabiano Fidêncio wrote: > On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: >> From: Marc-André Lureau >> >> --- >> server/display-channel.c | 44 >> server/display-channel.h | 2 +- >> server/red_worker.c

Re: [Spice-devel] [PATCH 05/19] display: reuse code in display_channel_draw_until

On Wed, Nov 25, 2015 at 4:27 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 44 > server/display-channel.h | 2 +- > server/red_worker.c | 5 ++--- > 3 files changed, 15 insertions(+), 36 deletions(-)

Re: [Spice-devel] [PATCH 17/19] display: fix generate_uid name

> > From: Marc-André Lureau > > --- > server/dcc-send.c| 2 +- > server/display-channel.c | 4 ++-- > server/display-channel.h | 1 - > 3 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/server/dcc-send.c b/server/dcc-send.c > index 1dc9dcf..f0bbfec 100644 > --- a/server

[Spice-devel] [common PATCH 6/9 v4] ppc: Fix colors on ppc when using LZ

Fixes color order on PowerPC when using LZ image compression. --- Changes since v3: Changes since v2: - No changes Changes since v1: - New commit --- common/canvas_base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index

[Spice-devel] [common PATCH 9/9 v4] ppc: Fix alpha state checking on BE machines

The surface before conversion can be either LE or BE on a BE machine. Check against both BE and LE color order on BE machine. --- Changes since v3: - Removed alpha clearing - The change actually broke alpha - Added dual color order checking - On BE machines it can be both ARGB and RGBA C

[Spice-devel] [common PATCH 5/9 v4] ppc: Fix colors on ppc when using QUIC

Fixes color order on PowerPC when using QUIC image compression. --- Changes since v3: Changes since v2: Changes since v1: - No changes --- common/canvas_base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 30baa22..b99f

[Spice-devel] [common PATCH 1/9 v4] ppc: Always convert surface on BE machine

The newly created surface can be converted, if saved_want_original equals TRUE. On BE machine we want to always convert, in order to properly byteswap colors from LE order to BE order. This is done by first creating BGRA/X surface with LE order data, and then copying the data into a new A/XRGB su

[Spice-devel] [common PATCH 4/9 v4] ppc: Add support for bigendian color byte order

On LE machine, color order when creating surface will always be A/XRGB. On BE machines the color order will sometimes be ARGB and sometimes BGRA/X. This is because we actually create the surface two times on BE machines. Once with BE order, and then again with LE order. Copying data inbetween thee

[Spice-devel] [common PATCH 0/9 v4] Fix colors on BE clients, when using image compression

When using image compression on BE client, the color order was wrong. (BGRA instead of ARGB) Theese patches try to fix this issue in most of the image compressions. For most of the fixes, new macros for color order were implemented. Theese macros changed according to the endianness of the machine

[Spice-devel] [common PATCH 7/9 v4] ppc: Fix colors on ppc when using LZ4

Fixes color order on PowerPC when using LZ4 image compression. --- Changes since v3: Changes since v2: - No changes Changes since v1: - New commit --- common/canvas_base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index

[Spice-devel] [common PATCH 8/9 v4] ppc: Fix colors on ppc when using jpeg

Fixes color order on PowerPC when using jpeg compression. --- Changes since v3: - None Changes since v2: - New commit --- common/canvas_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 736eacb..cc87f55 100644 --- a/

[Spice-devel] [common PATCH 3/9 v4] pixman_utils: Use PIXMAN_LE_ constants in spice_bitmap_try_as_pixman()

After the previous commit, spice_bitmap_try_as_pixman() can be simplified as its #ifdef WORDS_BIGENDIAN exactly match what the PIXMAN_LE_ constants do. --- Changes since v3: - None Changes since v2: - Improved commit msg Changes since v1: - New commit --- common/pixman_utils.c | 18 +++---

[Spice-devel] [common PATCH 2/9 v4] pixman_utils: Add macros for color byte ordering

When using image compression on PowerPC architecture, colors are in wrong order ARGB -> BGRA. This commit introduces macros, that will change the color order according to machine endianness. Theese macros are similar to QEMU macros in qemu-pixman.h --- Changes since v3: Changes since v2: - None

[Spice-devel] Rudimentary guide to audio in XSpice

nahamu on #spice asked for some pointers to getting XSpice audio working. Making this automatic in the XSpice script itself is still on my todo list. I'm afraid it is fiddly. The easy part is getting Xspice to send audio placed in a file across the wire; the hard part is getting pulseaudio to pu

Re: [Spice-devel] [PATCH 02/19] worker: change some asserts in stream functions

On Wed, 2015-11-25 at 15:27 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/stream.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/server/stream.c b/server/stream.c > index 8d16658..85136ea 100644 > --- a/server/stream.c > +

[Spice-devel] [PATCH 12/19] server: rename _tmpl files

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/Makefile.am | 8 +- server/cache-item.tmpl.c | 143 ++ server/cache_item.tmpl.c | 143 -- server/cursor-channel.c | 2 +- server/dcc.c

[Spice-devel] [PATCH 16/19] worker: move red_pipes_remove_drawable

From: Marc-André Lureau --- server/display-channel.c | 22 ++ server/display-channel.h | 1 - server/red_worker.c | 14 -- 3 files changed, 18 insertions(+), 19 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index aa3e7fb..e29

[Spice-devel] [PATCH 07/19] display: move more logic in add_drawable()

From: Marc-André Lureau --- server/display-channel.c | 229 +++-- server/display-channel.h | 23 ++--- server/red_worker.c | 258 +++ 3 files changed, 243 insertions(+), 267 deletions(-) diff --git a/server/di

[Spice-devel] [PATCH 05/19] display: reuse code in display_channel_draw_until

From: Marc-André Lureau --- server/display-channel.c | 44 server/display-channel.h | 2 +- server/red_worker.c | 5 ++--- 3 files changed, 15 insertions(+), 36 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c inde

[Spice-devel] [PATCH 15/19] worker: move current_remove*

From: Marc-André Lureau --- server/display-channel.c | 61 server/display-channel.h | 3 -- server/red_worker.c | 80 server/stream.c | 19 server/stream.h | 2 ++ 5 files

[Spice-devel] [PATCH 06/19] display: Simplify display_channel_create_surface

From: Marc-André Lureau --- server/display-channel.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index b8d5a81..4a533db 100644 --- a/server/display-channel.c +++ b/server/display-channe

[Spice-devel] [PATCH 14/19] worker: move more stream functions

From: Marc-André Lureau --- server/dcc.c| 14 + server/dcc.h| 2 + server/red_worker.c | 177 +--- server/stream.c | 159 ++ server/stream.h | 2 + 5 files changed, 179 in

Re: [Spice-devel] [PATCH 01/19] worker: changed some spice_assert in display_channel_draw_till

On Wed, 2015-11-25 at 15:27 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c > index 1496f07..cffd6fa 100644 > --- a/server/

[Spice-devel] [PATCH 19/19] display: remove some public declarations

From: Marc-André Lureau --- server/display-channel.c | 6 -- server/display-channel.h | 3 --- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 811799a..fe4dd3e 100644 --- a/server/display-channel.c +++ b/server/display-

[Spice-devel] [PATCH 02/19] worker: change some asserts in stream functions

From: Marc-André Lureau --- server/stream.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/server/stream.c b/server/stream.c index 8d16658..85136ea 100644 --- a/server/stream.c +++ b/server/stream.c @@ -263,8 +263,11 @@ static void attach_stream(DisplayCha

[Spice-devel] [PATCH 11/19] server: move enum and struct away from red_common

From: Marc-André Lureau --- server/dcc.c| 18 -- server/red_common.h | 14 -- server/red_dispatcher.c | 15 +-- server/reds.c | 2 +- server/stream.h | 7 +++ 5 files changed, 37 insertions(+), 19 deletions(-) diff

[Spice-devel] [PATCH 18/19] display: rename detach_streams_behind

From: Marc-André Lureau --- server/display-channel.c | 12 ++-- server/display-channel.h | 1 - server/stream.c | 2 +- server/stream.h | 3 +++ 4 files changed, 10 insertions(+), 8 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index

[Spice-devel] [PATCH 03/19] worker: use spice_return_if_fail() instead of spice_assert() in release_item

From: Marc-André Lureau --- server/display-channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/display-channel.c b/server/display-channel.c index cffd6fa..1be3334 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -1662,7 +1662,7 @@ static vo

[Spice-devel] [PATCH 10/19] server: cleanups

From: Marc-André Lureau --- server/Makefile.am | 1 - server/dispatcher.h | 1 + server/display-channel.h| 1 - server/pixmap-cache.h | 1 - server/red_dispatcher.c | 1 - server/red_worker.c | 14 -- server/red_worker.h | 13 ++

[Spice-devel] [PATCH 00/19] Backported some patches from refactory branches (25th Nov)

This patchset supersedes last patchset. Changes: - rebased on current master; - removed merged patches; - merge Pavel's split of "worker: simplify surface_update_dest()"; - added some patches. Some patches on discussion were not posted. Marc-André Lureau (19): worker: changed some spice_assert

[Spice-devel] [PATCH 17/19] display: fix generate_uid name

From: Marc-André Lureau --- server/dcc-send.c| 2 +- server/display-channel.c | 4 ++-- server/display-channel.h | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/server/dcc-send.c b/server/dcc-send.c index 1dc9dcf..f0bbfec 100644 --- a/server/dcc-send.c +++ b/server/

[Spice-devel] [PATCH 08/19] worker: remove redundant check

From: Marc-André Lureau The check is done in draw() --- server/red_worker.c | 4 1 file changed, 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 84048fe..2b5c162 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -647,10 +647,6 @@ static int red_proce

[Spice-devel] [PATCH 01/19] worker: changed some spice_assert in display_channel_draw_till

From: Marc-André Lureau --- server/display-channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 1496f07..cffd6fa 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -1344,8 +1344,8 @@ void

[Spice-devel] [PATCH] canvas_utils: Remove trailing whitespace

--- common/canvas_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/canvas_utils.c b/common/canvas_utils.c index 0d1591a..789cd76 100644 --- a/common/canvas_utils.c +++ b/common/canvas_utils.c @@ -293,7 +293,7 @@ pixman_image_t *alloc_lz_image_surface(LzDecodeUsrDa

[Spice-devel] [PATCH spice 3/3] Add travis CI file

Signed-off-by: Marc-André Lureau --- .travis.yml | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 000..ca72072 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,31 @@ +notificatio

[Spice-devel] [PATCH spice 1/3] build-sys: remove --enable-opengl

OpenGL was removed in commit c5c176a5c7, enabling it on discheck will fail to link with spice-common gl-enabled library Signed-off-by: Marc-André Lureau --- Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index cada94d..7eb0f28 100644 --- a/Makefile.am ++

[Spice-devel] [PATCH spice 2/3] Update spice-common

Fix distcheck --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index f471022..f8db887 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit f471022453c20e7fcfb54b865d5fbfbcf71fa6c2 +Subproject commit f8db887eb0f0

[Spice-devel] Passed: SPICE/libcacard#9 (v2.5.1 - e3e3780)

Build Update for SPICE/libcacard - Build: #9 Status: Passed Duration: 1 minute and 0 seconds Commit: e3e3780 (v2.5.1) Author: Marc-André Lureau Message: NEWS: update for 2.5.1 release Signed-off-by: Marc-André Lureau View the changeset: https://github.com/SP

[Spice-devel] [PATCH spice 0/3] Add travis CI

The following patches enable travis CI build. The build succeed with gcc and fails with clang, it will be a good time to check if email notificatication works well. Marc-André Lureau (3): build-sys: remove --enable-opengl Update spice-common Add travis CI file .travis.yml | 31 +++

Re: [Spice-devel] [PATCH 18/18] worker: remove redundant check

On Wed, 2015-11-25 at 09:30 -0500, Frediano Ziglio wrote: > > > > On Tue, 2015-11-24 at 11:13 +, Frediano Ziglio wrote: > > > From: Marc-André Lureau > > > > > > The check is done in draw() > > I don't see it in display_channel_draw(), it also prevented calling > > notify_update(). > > > >

Re: [Spice-devel] [PATCH 18/18] worker: remove redundant check

> > On Tue, 2015-11-24 at 11:13 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > The check is done in draw() > I don't see it in display_channel_draw(), it also prevented calling > notify_update(). > > I think the patch should be dropped. > > Pavel > > Reviewed-by: Pavel Grun

Re: [Spice-devel] [PATCH] dcc: remove possible dandling pointers

> > Can we fix the typo in the subject though? dandling -> dangling > Sorry, was already pushed. I'll have to remind this I really thought spelling was right with d! Frediano > > On Tue, 2015-11-24 at 17:42 +0100, Pavel Grunt wrote: > > On Tue, 2015-11-24 at 16:17 +, Frediano Ziglio wro

Re: [Spice-devel] [PATCH spice-server 1/2] display: Remove extra parameters from create_canvas_for_surface

> > From: Marc-André Lureau > > Get them from the surface > > Acked-by: Pavel Grunt > --- > server/display-channel.c | 16 +--- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c > index 051d597..45a63eb 100644

Re: [Spice-devel] [PATCH] m4: Add macro for --with-sasl

Hi, On Wed, 2015-11-25 at 14:58 +0100, Christophe Fergeau wrote: > Hey, > > On Tue, Nov 24, 2015 at 11:38:26AM +0100, Pavel Grunt wrote: > > Imported from spice-gtk e3c455b86dba0f924165fe0dc51583f48aecc8fb. > > It is not used by spice-common, but both server and client can use it. > > Couple of

Re: [Spice-devel] [PATCH] demarshall: Add safe method for unaligned byte access.

> > Usefull for ARM. Enable with "USE_MEMCPY" define. > Should be better to add "--use-memcpy" to configure.ac > > Signed-off-by: Anton D. Kachalov Are you sure there are not other way except memcpy? > --- > python_modules/demarshal.py | 29 +++-- > 1 file changed, 19

Re: [Spice-devel] [PATCH] display: factor out draw_until

> > On Wed, Nov 25, 2015 at 2:50 PM, Frediano Ziglio wrote: > >> > >> From: Marc-André Lureau > >> > >> Acked-by: Fabiano Fidêncio > >> --- > >> server/display-channel.c | 62 > >> +++- > >> 1 file changed, 30 insertions(+), 32 deletions(-) > >> > >

Re: [Spice-devel] [PATCH] m4: Add macro for --with-sasl

Hey, On Tue, Nov 24, 2015 at 11:38:26AM +0100, Pavel Grunt wrote: > Imported from spice-gtk e3c455b86dba0f924165fe0dc51583f48aecc8fb. > It is not used by spice-common, but both server and client can use it. Couple of comments, most of them are more things which could be added on top of this chang

Re: [Spice-devel] [PATCH] display: factor out draw_until

On Wed, Nov 25, 2015 at 2:50 PM, Frediano Ziglio wrote: >> >> From: Marc-André Lureau >> >> Acked-by: Fabiano Fidêncio >> --- >> server/display-channel.c | 62 >> +++- >> 1 file changed, 30 insertions(+), 32 deletions(-) >> >> diff --git a/server/dis

Re: [Spice-devel] [PATCH] display: factor out draw_until

> > From: Marc-André Lureau > > Acked-by: Fabiano Fidêncio > --- > server/display-channel.c | 62 > +++- > 1 file changed, 30 insertions(+), 32 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c > index d54f725..1837c

[Spice-devel] [PATCH] display: factor out current_find_intersects_rect

From: Marc-André Lureau Acked-by: Fabiano Fidêncio --- server/display-channel.c | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 1837c9b..0d482c0 100644 --- a/server/disp

[Spice-devel] [PATCH] display: factor out draw_until

From: Marc-André Lureau Acked-by: Fabiano Fidêncio --- server/display-channel.c | 62 +++- 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index d54f725..1837c9b 100644 --- a/server/d

[Spice-devel] [PATCH] demarshall: Add safe method for unaligned byte access.

Usefull for ARM. Enable with "USE_MEMCPY" define. Should be better to add "--use-memcpy" to configure.ac Signed-off-by: Anton D. Kachalov --- python_modules/demarshal.py | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/python_modules/demarshal

Re: [Spice-devel] [PATCH 13/18] display: replace some dubious asserts

> > On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Reviewed-by: Jonathon Jongsma > > As I said in my previous review, I think that using g_return_if_fail() here > is > appropriate. > > Yes, actually the only caller ignore the result so false or

Re: [Spice-devel] [NSIS 10/13] build: Add make dist

On Wed, Nov 25, 2015 at 11:09:14AM +0200, Yedidyah Bar David wrote: > On Wed, Nov 25, 2015 at 10:46 AM, Christophe Fergeau > wrote: > > As I said in the previous iterations, I'd rather drop 1/10. > > In case you missed that, we made it show the nsis branding only for ovirt. I know, I still disag

Re: [Spice-devel] [spice-common 0/2] ssl-verify: Follow-up to the GInetAddress switch

On Wed, Nov 25, 2015 at 11:37 AM, Christophe Fergeau wrote: > On Wed, Nov 25, 2015 at 11:32:29AM +0100, Fabiano Fidêncio wrote: >> On Wed, Nov 25, 2015 at 10:48 AM, Christophe Fergeau >> wrote: >> > On Fri, Oct 23, 2015 at 11:45:54AM +0200, Christophe Fergeau wrote: >> >> Took a look at the GInet

Re: [Spice-devel] [spice-common 0/2] ssl-verify: Follow-up to the GInetAddress switch

On Wed, Nov 25, 2015 at 11:32:29AM +0100, Fabiano Fidêncio wrote: > On Wed, Nov 25, 2015 at 10:48 AM, Christophe Fergeau > wrote: > > On Fri, Oct 23, 2015 at 11:45:54AM +0200, Christophe Fergeau wrote: > >> Took a look at the GInetAddress changes in spice-common, I believe we need > >> these 2 pat

Re: [Spice-devel] [spice-common 0/2] ssl-verify: Follow-up to the GInetAddress switch

On Wed, Nov 25, 2015 at 10:48 AM, Christophe Fergeau wrote: > On Fri, Oct 23, 2015 at 11:45:54AM +0200, Christophe Fergeau wrote: >> Took a look at the GInetAddress changes in spice-common, I believe we need >> these 2 patches (but I have only compile-tested them). > > Ping? Seems that I reviewed

Re: [Spice-devel] [PATCH 12/18] worker: move display_channel_new

--- server/dcc.c | 26 ++ server/dcc.h | 3 + server/display-channel.c | 149 server/display-channel.h | 19 + server/red_worker.c | 215 +++ 5 files changed, 209 insertions(+), 2

Re: [Spice-devel] [PATCH 12/18] worker: move display_channel_new

> > Reduced diff: > > > --- before.c 2015-11-25 10:09:19.413943460 + > +++ after.c 2015-11-25 09:56:05.709537277 + > @@ -1700,20 +1700,21 @@ > > RedsStream >

Re: [Spice-devel] [PATCH 12/18] worker: move display_channel_new

Reduced diff: --- before.c2015-11-25 10:09:19.413943460 + +++ after.c 2015-11-25 09:56:05.709537277 + @@ -1700,20 +1700,21 @@ RedsStream *stream,

[Spice-devel] [spice-gtk] Update spice-common submodule

The next commit is going to use SPICE_WARNING which was added recently to spice-common This submodule update changes: Christophe Fergeau (5): build-sys: Add gio-2.0 to SPICE_CHECK_GLIB2 build-sys: Fix error in SPICE_CHECK_LZ4 description build-sys: Set automake conditional in SP

Re: [Spice-devel] [PATCH 13/18] worker: move destroy_surface() familly

> > From: Marc-André Lureau > > --- > server/dcc.c | 80 ++ > server/dcc.h | 2 + > server/display-channel.c | 69 ++- > server/display-channel.h | 20 ++ > server/red_worker.c | 173 > ++-

Re: [Spice-devel] [spice-common 0/2] ssl-verify: Follow-up to the GInetAddress switch

On Fri, Oct 23, 2015 at 11:45:54AM +0200, Christophe Fergeau wrote: > Took a look at the GInetAddress changes in spice-common, I believe we need > these 2 patches (but I have only compile-tested them). Ping? Christophe signature.asc Description: PGP signature ___

Re: [Spice-devel] [client v2] build-sys: Use SPICE_WARNING() to issue the DBus warning

Hey, Acked-by: Christophe Fergeau Going to push this along with a submodule update. Christophe On Mon, Nov 23, 2015 at 05:33:15PM +0100, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > configure.ac | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a

Re: [Spice-devel] [PATCH 14/18] worker: move display_channel_create_surface

> > From: Marc-André Lureau > > --- > server/display-channel.c | 92 ++ > server/display-channel.h | 4 ++ > server/red_worker.c | 125 > +++ > 3 files changed, 103 insertions(+), 118 deletions(-) > > diff --g

Re: [Spice-devel] refactory and file names

On Tue, Nov 24, 2015 at 4:52 PM, Frediano Ziglio wrote: >> >> Hi, >> >> On Mon, 2015-11-23 at 12:44 -0500, Frediano Ziglio wrote: >> > Hi, >> > as part of the refactory there are some file renames. Actually >> > the patches with files renames where removed if the file was already >> > present an

Re: [Spice-devel] [NSIS 10/13] build: Add make dist

On Wed, Nov 25, 2015 at 10:46 AM, Christophe Fergeau wrote: > Hi, > > On Wed, Nov 25, 2015 at 10:03:06AM +0200, Yedidyah Bar David wrote: >> On Fri, Nov 20, 2015 at 5:05 PM, Christophe Fergeau >> wrote: >> > On Thu, Nov 19, 2015 at 03:58:18PM +0100, Christophe Fergeau wrote: >> >> On Thu, Nov 19

Re: [Spice-devel] refactory and file names

On 11/24/2015 07:38 PM, Marc-André Lureau wrote: - Original Message - On 11/24/2015 05:52 PM, Frediano Ziglio wrote: Hi, On Mon, 2015-11-23 at 12:44 -0500, Frediano Ziglio wrote: Hi, as part of the refactory there are some file renames. Actually the patches with files renames w

Re: [Spice-devel] video playback issue with vp8/h264 patch

Hi, This message was sent 3 times in a row. We received it in case you are wondering it ;) http://lists.freedesktop.org/archives/spice-devel/2015-November/024252.html Cheers, toso On Wed, Nov 25, 2015 at 05:51:30PM +0900, Sunny Shin wrote: > Hello Francois Gouget, > > While applying and testi

[Spice-devel] video playback issue with vp8/h264 patch

Hello Francois Gouget, While applying and testing your patches supporting VP8 and H264, I had an issue that VM gets hung when playing video. From gstack, it seems stuck in gstreamer. Please check the details below, and let me know what might be wrong. Thank you. - OS: CentOS 7 - Patches from git

[Spice-devel] video playback issue with VP8/H264 patch

Hello Francois Gouget, While applying and testing your patches supporting VP8 and H264, I had an issue that VM gets hung when playing video. From gstack, it seems stuck in gstreamer. Please check the details below, and let me know what might be wrong. Thank you. - OS: CentOS 7 - Patches from git

Re: [Spice-devel] [NSIS 10/13] build: Add make dist

Hi, On Wed, Nov 25, 2015 at 10:03:06AM +0200, Yedidyah Bar David wrote: > On Fri, Nov 20, 2015 at 5:05 PM, Christophe Fergeau > wrote: > > On Thu, Nov 19, 2015 at 03:58:18PM +0100, Christophe Fergeau wrote: > >> On Thu, Nov 19, 2015 at 04:48:20PM +0200, Yedidyah Bar David wrote: > >> > From: Chr

[Spice-devel] (no subject)

Hello Francois Gouget, While applying and testing your patches supporting VP8 and H264, I had an issue that VM gets hung when playing video. From gstack, it seems stuck in gstreamer. Please check the details below, and let me know what might be wrong. Thank you. - OS: CentOS 7 - Patches from git

Re: [Spice-devel] [NSIS 10/13] build: Add make dist

On Fri, Nov 20, 2015 at 5:05 PM, Christophe Fergeau wrote: > On Thu, Nov 19, 2015 at 03:58:18PM +0100, Christophe Fergeau wrote: >> On Thu, Nov 19, 2015 at 04:48:20PM +0200, Yedidyah Bar David wrote: >> > From: Christophe Fergeau >> >> When splitting these patches, I've mistakenly changed ownersh