[Spice-devel] [PATCH spice-common 2/2] Use new libcacard.h

This require bumping libcacard requirement, which shouldn't be an issue as soon as it is released. Signed-off-by: Marc-André Lureau --- common/messages.h | 2 +- m4/spice-deps.m4 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/messages.h b/common/messages.h index 5

[Spice-devel] [PATCH spice-common 1/2] Fix make distcheck

Fix make distcheck both with standalone spice-common and with spice server. Signed-off-by: Marc-André Lureau --- Makefile.am | 2 +- tests/Makefile.am| 3 ++- tests/test-marshallers.c | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Make

Re: [Spice-devel] [spice-common PATCH] canvas_base: Remove redundant switch case block

On Mon, 2015-11-23 at 17:37 +0100, Lukas Venhoda wrote: > --- >  common/canvas_base.c | 5 + >  1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/common/canvas_base.c b/common/canvas_base.c > index 6f48340..6747465 100644 > --- a/common/canvas_base.c > +++ b/common/canvas_base.c >

Re: [Spice-devel] refactory and file names

Hi, On Mon, 2015-11-23 at 12:44 -0500, Frediano Ziglio wrote: > Hi, >   as part of the refactory there are some file renames. Actually > the patches with files renames where removed if the file was already > present and all new files has already the new names. > > The files should be (as the orig

Re: [Spice-devel] [PATCH v2 1/3] worker: s/validate_area/surface_update_dest

On Mon, Nov 23, 2015 at 8:39 PM, Jonathon Jongsma wrote: > On Mon, 2015-11-23 at 13:33 -0600, Jonathon Jongsma wrote: >> Acked-by: Jonathon Jongsma >> > > I take it back. This should probably be re-merged with the next patch. See > below. > >> >> >> On Mon, 2015-11-23 at 19:45 +0100, Fabiano Fid

Re: [Spice-devel] [PATCH 13/18] display: replace some dubious asserts

On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > Reviewed-by: Jonathon Jongsma As I said in my previous review, I think that using g_return_if_fail() here is appropriate. > --- > server/display-channel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

Re: [Spice-devel] [PATCH 12/18] worker: move drawable_draw

On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 236 > server/display-channel.h | 8 ++ > server/red_worker.c | 251 +- > - > 3

Re: [Spice-devel] [PATCH 11/18] worker: use spice_return_if_fail() instead of spice_assert() in release_item

On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index 656f9ab..65d5dea 100644 > --- a/server/red_worker.c > +++

Re: [Spice-devel] [PATCH 10/18] worker: remove display_channel prefix from channel callbacks

On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index ac1ef0c..656f9ab 100644 > --- a/ser

Re: [Spice-devel] [PATCH 09/18] worker: move dcc_release_item

On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc.c | 124 ++ > server/dcc.h | 3 ++ > server/display-channel.h | 7 +++ > server/red_worker.c | 136 +--

Re: [Spice-devel] [PATCH 06/18] worker: tidy up cursor_connect a bit

On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 65 +--- > - > 1 file changed, 31 insertions(+), 34 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index

Re: [Spice-devel] [PATCH 05/18] worker: change some asserts in stream functions

On Mon, 2015-11-23 at 17:01 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/stream.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/server/stream.c b/server/stream.c > index 8d16658..85136ea 100644 > --- a/server/stream.c > +

Re: [Spice-devel] [PATCH v2 2/3] worker: remove not used argument from surface_update_dest()

NACK, see my comments on patch 1/3. This should probably be merged with that patch. On Mon, 2015-11-23 at 19:45 +0100, Fabiano Fidêncio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/server/re

Re: [Spice-devel] [PATCH v2 1/3] worker: s/validate_area/surface_update_dest

On Mon, 2015-11-23 at 13:33 -0600, Jonathon Jongsma wrote: > Acked-by: Jonathon Jongsma > I take it back. This should probably be re-merged with the next patch. See below. > > > On Mon, 2015-11-23 at 19:45 +0100, Fabiano Fidêncio wrote: > > From: Marc-André Lureau > > > > --- > > server/r

Re: [Spice-devel] [PATCH v2 1/3] worker: s/validate_area/surface_update_dest

Acked-by: Jonathon Jongsma On Mon, 2015-11-23 at 19:45 +0100, Fabiano Fidêncio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index becd42f..efadd91 1

Re: [Spice-devel] [PATCH 16/18] worker: move display_channel_draw

On Mon, Nov 23, 2015 at 6:02 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 155 > +++ > server/red_worker.c | 154 -- > 2 files changed, 155 insertions(+), 15

Re: [Spice-devel] [PATCH 18/18] display: factor out current_find_intersects_rect

On Mon, Nov 23, 2015 at 6:02 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 51 > > 1 file changed, 30 insertions(+), 21 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c

Re: [Spice-devel] [PATCH 17/18] display: factor out draw_until

On Mon, Nov 23, 2015 at 8:05 PM, Fabiano Fidêncio wrote: > On Mon, Nov 23, 2015 at 6:02 PM, Frediano Ziglio wrote: >> From: Marc-André Lureau >> >> --- >> server/display-channel.c | 70 >> ++-- >> 1 file changed, 32 insertions(+), 38 deletions(-) >>

Re: [Spice-devel] [PATCH 17/18] display: factor out draw_until

On Mon, Nov 23, 2015 at 6:02 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 70 > ++-- > 1 file changed, 32 insertions(+), 38 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c

[Spice-devel] [PATCH v2 3/3] worker: simplify surface_update_dest()

From: Marc-André Lureau --- server/red_worker.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index fc30aff..a82a871 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -938,21 +938,21 @@ stati

[Spice-devel] [PATCH v2 2/3] worker: remove not used argument from surface_update_dest()

From: Marc-André Lureau --- server/red_worker.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index efadd91..fc30aff 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -936,11 +936,8 @@ static void image_surfa

[Spice-devel] [PATCH v2 0/3] Split: "worker: s/validate_area/surface_update_dest"

Changes since v1: - Fix the broken compilation due to the v1 changes in the second patch Marc-André Lureau (3): worker: s/validate_area/surface_update_dest worker: remove not used argument from surface_update_dest() worker: simplify surface_update_dest() server/red_worker.c | 35 ++

[Spice-devel] [PATCH v2 1/3] worker: s/validate_area/surface_update_dest

From: Marc-André Lureau --- server/red_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index becd42f..efadd91 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -936,7 +936,7 @@ static void image_surface_in

[Spice-devel] [PATCH 1/3] worker: s/validate_area/surface_update_dest

From: Marc-André Lureau --- server/red_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index becd42f..efadd91 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -936,7 +936,7 @@ static void image_surface_in

[Spice-devel] [PATCH 3/3] worker: simplify surface_update_dest()

From: Marc-André Lureau --- server/red_worker.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 308e84f..a82a871 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -938,24 +938,21 @@ stat

[Spice-devel] [PATCH 2/3] worker: remove not used argument from surface_update_dest()

From: Marc-André Lureau --- server/red_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index efadd91..308e84f 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -936,7 +936,7 @@ static void image_surface_in

[Spice-devel] [PATCH 0/3] Split: "worker: s/validate_area/surface_update_dest"

The use-after-free caught by Frediano is not fixed by this split. :-\ Marc-André Lureau (2): worker: s/validate_area/surface_update_dest worker: remove not used argument from surface_update_dest() worker: simplify surface_update_dest() server/red_worker.c | 35 -

Re: [Spice-devel] [PATCH 15/18] worker: s/validate_area/surface_update_dest

On Mon, Nov 23, 2015 at 7:11 PM, Frediano Ziglio wrote: >> >> From: Marc-André Lureau >> >> --- >> server/red_worker.c | 35 --- >> 1 file changed, 16 insertions(+), 19 deletions(-) >> >> diff --git a/server/red_worker.c b/server/red_worker.c >> index becd42f..a82

Re: [Spice-devel] [PATCH 15/18] worker: s/validate_area/surface_update_dest

> > From: Marc-André Lureau > > --- > server/red_worker.c | 35 --- > 1 file changed, 16 insertions(+), 19 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index becd42f..a82a871 100644 > --- a/server/red_worker.c > +++ b/server/red_work

Re: [Spice-devel] [PATCH 14/18] worker:fix constant

On Mon, Nov 23, 2015 at 6:02 PM, Frediano Ziglio wrote: > Use mnemonic instead of constant to return enumeration value > > Signed-off-by: Frediano Ziglio > --- > server/red_worker.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red_worker.c b/server/red_worker.c

Re: [Spice-devel] [PATCH 08/18] worker: simplify handle_migrate_data functions

On Mon, Nov 23, 2015 at 6:01 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index 5d32f4f..47b6b82 100644 > --- a/server/red_worker.c >

Re: [Spice-devel] [PATCH 04/18] worker: move attach_stream

On Mon, Nov 23, 2015 at 6:01 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 56 > - > server/stream.c | 56 > + > server/stream.h | 1 - > 3 fi

Re: [Spice-devel] [PATCH 03/18] worker: move dcc_add_drawable*

On Mon, Nov 23, 2015 at 6:01 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc.c | 87 > server/dcc.h | 18 ++ > server/display-channel.c | 65 + > server/display-channel.h | 19 +-- > se

[Spice-devel] refactory and file names

Hi, as part of the refactory there are some file renames. Actually the patches with files renames where removed if the file was already present and all new files has already the new names. The files should be (as the original changes) renamed like red_parse_qxl.c -> red-parse-qxl.c red_record_q

Re: [Spice-devel] [PATCH 02/18] worker: move dcc_handle_message

On Mon, Nov 23, 2015 at 6:01 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc-encoders.c | 131 +- > server/dcc-encoders.h | 7 ++ > server/dcc.c | 81 > server/dcc.h | 3 + > server/red_worker.c | 250 >

Re: [Spice-devel] spice-server, logging and style

> Hi, > > On Fri, Nov 20, 2015 at 01:12:27PM -0500, Frediano Ziglio wrote: > > assert (the base C) abort on condition failed and can be compiled out. > > Somebody > > by default disable these checks on release (I call it the Windows style) > > while > > other prefer to never disable (I call the Un

Re: [Spice-devel] [PATCH 01/18] worker: do not set worker image compression on client request

On Mon, Nov 23, 2015 at 6:01 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > Display client can ask to change the preferred compression. > Previously this setting change the entire worker setting > so every future client created would have this setting. > Remove the setting in the worker

Re: [Spice-devel] [PATCH] server: Remove unneeded asserts in mjpeg_encoder_get_stats()

> > No other function checks the 'this' pointer and if not given a buffer > to return the statistics we can simply not return any. > > Signed-off-by: Francois Gouget > --- > server/mjpeg_encoder.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > So following the logging discussion

[Spice-devel] [PATCH 17/18] display: factor out draw_until

From: Marc-André Lureau --- server/display-channel.c | 70 ++-- 1 file changed, 32 insertions(+), 38 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index c5a69e3..a78f86a 100644 --- a/server/display-channel.c +++ b/serve

[Spice-devel] [PATCH 18/18] display: factor out current_find_intersects_rect

From: Marc-André Lureau --- server/display-channel.c | 51 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index a78f86a..ab70947 100644 --- a/server/display-channel.c +++ b/serve

[Spice-devel] [PATCH 05/18] worker: change some asserts in stream functions

From: Marc-André Lureau --- server/stream.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/server/stream.c b/server/stream.c index 8d16658..85136ea 100644 --- a/server/stream.c +++ b/server/stream.c @@ -263,8 +263,11 @@ static void attach_stream(DisplayCha

[Spice-devel] [PATCH 09/18] worker: move dcc_release_item

From: Marc-André Lureau --- server/dcc.c | 124 ++ server/dcc.h | 3 ++ server/display-channel.h | 7 +++ server/red_worker.c | 136 +-- 4 files changed, 136 insertions(+), 134 de

[Spice-devel] [PATCH 08/18] worker: simplify handle_migrate_data functions

From: Marc-André Lureau --- server/red_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 5d32f4f..47b6b82 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4260,7 +4260,7 @@ static int display_channe

[Spice-devel] [PATCH 07/18] worker: move dcc_handle_migrate_data

From: Marc-André Lureau Acked-by: Fabiano Fidêncio --- server/dcc.c| 135 +++ server/dcc.h| 5 ++ server/red_worker.c | 161 +--- 3 files changed, 143 insertions(+), 158 deletions(-) diff

[Spice-devel] [PATCH 14/18] worker:fix constant

Use mnemonic instead of constant to return enumeration value Signed-off-by: Frediano Ziglio --- server/red_worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 9ac7e29..becd42f 100644 --- a/server/red_worker.c +++ b/server/r

[Spice-devel] [PATCH 15/18] worker: s/validate_area/surface_update_dest

From: Marc-André Lureau --- server/red_worker.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index becd42f..a82a871 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -936,26 +936,23

[Spice-devel] [PATCH 13/18] display: replace some dubious asserts

From: Marc-André Lureau Reviewed-by: Jonathon Jongsma --- server/display-channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 5e75019..a178cc9 100644 --- a/server/display-channel.c +++ b/server/display-channe

[Spice-devel] [PATCH 12/18] worker: move drawable_draw

From: Marc-André Lureau --- server/display-channel.c | 236 server/display-channel.h | 8 ++ server/red_worker.c | 251 +-- 3 files changed, 248 insertions(+), 247 deletions(-) diff --git a/server/di

[Spice-devel] [PATCH 00/18] Backported some patches from refactory branches (23th Nov)

This patchset supersedes last patchset. Changes: - rebased on current master; - removed merged patches; - merge split of some patches (Fabiano and me); - added some patches. There is still the "worker: move drawable_draw" patch which have some possible problems. Frediano Ziglio (1): worker:fix

[Spice-devel] [PATCH 16/18] worker: move display_channel_draw

From: Marc-André Lureau --- server/display-channel.c | 155 +++ server/red_worker.c | 154 -- 2 files changed, 155 insertions(+), 154 deletions(-) diff --git a/server/display-channel.c b/server/display-

[Spice-devel] [PATCH 11/18] worker: use spice_return_if_fail() instead of spice_assert() in release_item

From: Marc-André Lureau --- server/red_worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 656f9ab..65d5dea 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4453,7 +4453,7 @@ static void release_item(RedChanne

[Spice-devel] [PATCH 10/18] worker: remove display_channel prefix from channel callbacks

From: Marc-André Lureau --- server/red_worker.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index ac1ef0c..656f9ab 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -3847,7 +3847,7 @@ static void

[Spice-devel] [PATCH 06/18] worker: tidy up cursor_connect a bit

From: Marc-André Lureau --- server/red_worker.c | 65 + 1 file changed, 31 insertions(+), 34 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index f64befa..e0fd6e5 100644 --- a/server/red_worker.c +++ b/server/red_worker.c

[Spice-devel] [PATCH 01/18] worker: do not set worker image compression on client request

From: Marc-André Lureau Display client can ask to change the preferred compression. Previously this setting change the entire worker setting so every future client created would have this setting. Remove the setting in the worker make the change local to the client live. Signed-off-by: Marc-Andr

[Spice-devel] [PATCH 04/18] worker: move attach_stream

From: Marc-André Lureau --- server/red_worker.c | 56 - server/stream.c | 56 + server/stream.h | 1 - 3 files changed, 56 insertions(+), 57 deletions(-) diff --git a/server/red_work

[Spice-devel] [PATCH 02/18] worker: move dcc_handle_message

From: Marc-André Lureau --- server/dcc-encoders.c | 131 +- server/dcc-encoders.h | 7 ++ server/dcc.c | 81 server/dcc.h | 3 + server/red_worker.c | 250 ++ 5 files changed, 228 in

[Spice-devel] [PATCH 03/18] worker: move dcc_add_drawable*

From: Marc-André Lureau --- server/dcc.c | 87 server/dcc.h | 18 ++ server/display-channel.c | 65 + server/display-channel.h | 19 +-- server/red_worker.c | 144 +--

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, 2015-11-20 at 22:22 +0100, David Jaša wrote: > On Pá, 2015-11-20 at 16:26 +0100, Francois Gouget wrote: > > On Thu, 19 Nov 2015, Frediano Ziglio wrote: > > [...] > > > > What do you mean by "100% compatible with the current code"? (why is > > > > g_return_if-fail() not "100% compatible with

Re: [Spice-devel] missing spicec client

Zdravím, On Po, 2015-11-23 at 15:15 +0100, Fabiano Fidêncio wrote: > On Sun, Nov 22, 2015 at 5:48 PM, Martin Filo > wrote: > > Hello, > > > > Spicec has been best spice client. It has nice user interface, no > > annoying toolbar or icons, it has hotkeys for ungrab mouse and > > fullscreen. Everyt

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Mon, 2015-11-23 at 16:20 +0100, Francois Gouget wrote: > On Fri, 20 Nov 2015, Christophe Fergeau wrote: > [...] > > > 5. And you propose adding spice_return_if_fail_warning() to fix this mess. > > > > > > I really don't see how adding more functions is going to make this less > > > confusing a

[Spice-devel] [spice-common PATCH] canvas_base: Remove redundant switch case block

--- common/canvas_base.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 6f48340..6747465 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -1147,10 +1147,7 @@ static pixman_image_t *canvas_get_image_internal(

[Spice-devel] [client] build-sys: Prefix the configure audio GStreamer variables with GSTAUDIO_

This lets us avoid naming conflicts when using GStreamer for other purposes. Signed-off-by: Francois Gouget --- configure.ac| 18 +- src/Makefile.am | 4 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index db2891f..dea9a30

[Spice-devel] [client v2] build-sys: Use SPICE_WARNING() to issue the DBus warning

Signed-off-by: Francois Gouget --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 7033cbb..db2891f 100644 --- a/configure.ac +++ b/configure.ac @@ -671,6 +671,8 @@ have_dbus=no if test "x$enable_dbus" != "xno"; then AC_

[Spice-devel] [PATCH 2/2] server: Remove MJPEG's video callback assert

A NULL get_roundtrip_ms() callback simply disables rate control so that mjpeg_encoder_get_source_fps() will not be called. Should it be called despite this, simply return the highest allowed framerate (get_source_fps()'s value is only an estimate anyway). Finally update_client_playback_delay() is a

[Spice-devel] [PATCH 3/3] worker: use spice_return_if_fail() instead of spice_assert() in release_item

From: Marc-André Lureau --- server/red_worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index d371cc3..3873da4 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4537,7 +4537,7 @@ static void release_item(RedChanne

[Spice-devel] [PATCH 0/3] Split: [PATCH 13/18] worker: move dcc_release_item

Marc-André Lureau (3): worker: move dcc_release_item worker: remove display_channel prefix from channel callbacks worker: use spice_return_if_fail() instead of spice_assert() in release_item server/dcc.c | 124 + server/dcc.h |

[Spice-devel] [PATCH 2/3] worker: remove display_channel prefix from channel callbacks

From: Marc-André Lureau --- server/red_worker.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index d13dc62..d371cc3 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -3932,7 +3932,7 @@ static void

[Spice-devel] [PATCH 1/3] worker: move dcc_release_item

From: Marc-André Lureau --- server/dcc.c | 124 ++ server/dcc.h | 3 ++ server/display-channel.h | 7 +++ server/red_worker.c | 136 +-- 4 files changed, 136 insertions(+), 134 de

[Spice-devel] [PATCH v5] server: Provide a framerate estimate based on the initial frames

This way the video encoder can actually count on a real estimate when it is initializing. Signed-off-by: Francois Gouget --- server/display-channel.h | 1 + server/red_worker.c | 3 ++- server/stream.c | 20 +--- server/stream.h | 1 + 4 files changed, 2

[Spice-devel] [PATCH 1/2] server: Encapsulate the get_source_fps() video encoder callback

Signed-off-by: Francois Gouget --- server/mjpeg_encoder.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/server/mjpeg_encoder.c b/server/mjpeg_encoder.c index 7d17517..946ce8b 100644 --- a/server/mjpeg_encoder.c +++ b/server/mjpeg_encoder.c @@ -328,6 +328

[Spice-devel] [PATCH] server: Remove unneeded asserts in mjpeg_encoder_get_stats()

No other function checks the 'this' pointer and if not given a buffer to return the statistics we can simply not return any. Signed-off-by: Francois Gouget --- server/mjpeg_encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) So following the logging discussion it looks like we wou

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, 20 Nov 2015, Christophe Fergeau wrote: [...] > > 5. And you propose adding spice_return_if_fail_warning() to fix this mess. > > > > I really don't see how adding more functions is going to make this less > > confusing and error prone! Particularly if there is not a concerted > > and swif

Re: [Spice-devel] missing spicec client

On Sun, Nov 22, 2015 at 5:48 PM, Martin Filo wrote: > Hello, > > Spicec has been best spice client. It has nice user interface, no > annoying toolbar or icons, it has hotkeys for ungrab mouse and > fullscreen. Everything needed can be configured via command line. And it > hasn't much dependencies.

[Spice-devel] missing spicec client

Hello, Spicec has been best spice client. It has nice user interface, no annoying toolbar or icons, it has hotkeys for ungrab mouse and fullscreen. Everything needed can be configured via command line. And it hasn't much dependencies. But Spicec has been removed as obsolete in spice 0.12.6. What i

Re: [Spice-devel] [PATCH 11/18] worker: move dcc_handle_message

Hi, On Mon, 2015-11-23 at 14:13 +0100, Fabiano Fidêncio wrote: > On Mon, Nov 23, 2015 at 1:59 PM, Frediano Ziglio wrote: > > > > > > On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio > > > wrote: > > > > From: Marc-André Lureau > > > > > > > > --- > > > >  server/dcc-encoders.c | 131

Re: [Spice-devel] [PATCH 05/18] worker: tidy up cursor_connect a bit

> > On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/cursor-channel.c | 4 > > server/red_worker.c | 60 > > + > > 2 files changed, 30 insertions(+), 34 deletions(-) > > > > dif

Re: [Spice-devel] [PATCH 13/18] worker: move dcc_release_item

On Mon, Nov 23, 2015 at 2:36 PM, Frediano Ziglio wrote: >> >> On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: >> > From: Marc-André Lureau >> > >> > --- >> > server/dcc.c | 124 + >> > server/dcc.h | 3 + >> > server/display

Re: [Spice-devel] [PATCH 13/18] worker: move dcc_release_item

> > On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/dcc.c | 124 + > > server/dcc.h | 3 + > > server/display-channel.h | 7 +++ > > server/red_worker.c | 158 > > ++

Re: [Spice-devel] [PATCH 16/18] worker: move drawable_draw

> Reduced diff > > > --- before.c 2015-11-23 13:20:37.534895725 + > +++ after.c 2015-11-23 13:12:44.527503563 + > @@ -1034,53 +1034,53 @@ > drawable->tree_item.base.type = TREE_ITEM_TYPE_DRAWABLE; > region_init(&drawable->tree_item.base.rgn); > ring_init(&drawable->pipe

Re: [Spice-devel] [PATCH 16/18] worker: move drawable_draw

Reduced diff --- before.c2015-11-23 13:20:37.534895725 + +++ after.c 2015-11-23 13:12:44.527503563 + @@ -1034,53 +1034,53 @@ drawable->tree_item.base.type = TREE_ITEM_TYPE_DRAWABLE; region_init(&drawable->tree_item.base.rgn); ring_init(&drawable->pipes); ring_i

Re: [Spice-devel] [PATCH 11/18] worker: move dcc_handle_message

On Mon, Nov 23, 2015 at 1:59 PM, Frediano Ziglio wrote: >> >> On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: >> > From: Marc-André Lureau >> > >> > --- >> > server/dcc-encoders.c | 131 +- >> > server/dcc-encoders.h | 7 ++ >> > server/dcc.c | 82 ++

Re: [Spice-devel] [PATCH 14/18] worker: move spice_bitmap_get_line

> > On Fri, Nov 20, 2015 at 5:48 PM, Jonathon Jongsma > wrote: > > > > > > On Fri, 2015-11-20 at 11:38 -0500, Frediano Ziglio wrote: > >> > > >> > Perhaps "add spice_bitmap_get_line()" would be a better commit message. > >> > But why is this added? where is it going to be used? If it was really >

Re: [Spice-devel] [PATCH 11/18] worker: move dcc_handle_message

> > On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/dcc-encoders.c | 131 +- > > server/dcc-encoders.h | 7 ++ > > server/dcc.c | 82 + > > server/dcc.h | 3 + > > server/r

Re: [Spice-devel] spice-server, logging and style

Hi, On Fri, Nov 20, 2015 at 01:12:27PM -0500, Frediano Ziglio wrote: > assert (the base C) abort on condition failed and can be compiled out. > Somebody > by default disable these checks on release (I call it the Windows style) while > other prefer to never disable (I call the Unix style). If dis

Re: [Spice-devel] spice-server, logging and style

On Fri, Nov 20, 2015 at 01:14:20PM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Fri, Nov 20, 2015 at 01:01:30PM -0500, Frediano Ziglio wrote: > > > > > > > > On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote: > > > > > Problems: > > > > > - the Spice_

Re: [Spice-devel] [PATCH] reuse red_get_monotonic_time function

> > Hi Frediano, > > I noticed that red_get_monotonic_time() returns int64_t. Should it be > uint64_t? > Well... the 63 bit precision allow dates till 2192 which is enough. However some computation on unsigned values could lead to overflow/underflow while with signed values is much harder to ha

Re: [Spice-devel] [PATCH 07/18] stream: minor simplification

> > On Fri, Nov 20, 2015 at 3:55 PM, Fabiano Fidêncio > wrote: > > On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio > > wrote: > >> From: Marc-André Lureau > >> > >> --- > >> server/red_worker.c | 2 +- > >> server/stream.c | 21 +++-- > >> server/stream.h | 3 +-- >

Re: [Spice-devel] Keyboard autorepeat issues

Strangely enough this autorepeat problem disappears if I add USB keyboard next to default PS/2 one via libvirt. This will cause another problem though - you are not able to shutdown guest while pressing power off button on client PC. -- On Mon, 2015-11-23 at 09:59 +0200, Tadas wrote: > Hello l

Re: [Spice-devel] [PATCH spice-server v2 11/11] main channel: Remove unused main_channel_client_get_link_id

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It was introduced in 9cece23ba3e49e6eec9e380daa95d6ee0133c91c > but never used. > > Signed-off-by: Pavel Grunt > --- > server/main_channel.c | 5 - > server/main_channel.h | 1 - > 2 files changed, 6 deletions(-) > > diff --git a/server/

Re: [Spice-devel] [PATCH spice-server v2 10/11] main channel: Remove unused main_channel_push_notify

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It is not needed since 8d44aa032892ea6643925fa7485d9af32853e127 > > Signed-off-by: Pavel Grunt > --- > server/main_channel.c | 6 -- > server/main_channel.h | 1 - > 2 files changed, 7 deletions(-) > > diff --git a/server/main_channel.c

Re: [Spice-devel] [PATCH spice-server v2 09/11] red channel: Remove unused red_channel_apply_clients_data

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It was introduced in 7e8e13593ee681cf04c349bca57dd225d7802494 > but never used. > > Signed-off-by: Pavel Grunt > --- > server/red_channel.c | 12 > server/red_channel.h | 1 - > 2 files changed, 13 deletions(-) > > diff --git a

Re: [Spice-devel] [PATCH spice-server v2 08/11] red channel: Remove unused declaration of red_channel_pipes_remove

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It was introduced in 09ae4700d27b7c1cca64c2ce4c90f0c6cdf81ccf > but never used. > > Signed-off-by: Pavel Grunt > --- > server/red_channel.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/server/red_channel.h b/server/red_channel.h

Re: [Spice-devel] [PATCH spice-server v2 07/11] red channel: Remove unused red_channel_push_set_ack

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It is not needed since 8e7b22b7861d2859167767822f29749bfe3ecc16 > > Signed-off-by: Pavel Grunt > --- > server/red_channel.c | 5 - > server/red_channel.h | 1 - > 2 files changed, 6 deletions(-) > > diff --git a/server/red_channel.c b/se

Re: [Spice-devel] [PATCH spice-server v2 04/11] red channel: Remove unused red_channel_test_remote_common_cap

On Mon, Nov 23, 2015 at 10:56 AM, Fabiano Fidêncio wrote: > On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: >> It was introduced in 49a8d68303f3d8681a9c61d74e0675279649d480 >> but never used. > > This is the kind of function usually added for completeness (?) of the code. > >> >> Signed-off-

Re: [Spice-devel] [PATCH spice-server v2 05/11] red channel: Remove unused red_channel_pipes_new_add_tail

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It was introduced in 0f0bdb190b8586ef7ac20fcefffe641e44eb15b9 > but never used. This case is exactly the same one of the last patch ... > > Signed-off-by: Pavel Grunt > --- > server/red_channel.c | 6 -- > server/red_channel.h | 1 - >

Re: [Spice-devel] [PATCH spice-server v2 04/11] red channel: Remove unused red_channel_test_remote_common_cap

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It was introduced in 49a8d68303f3d8681a9c61d74e0675279649d480 > but never used. This is the kind of function usually added for completeness (?) of the code. > > Signed-off-by: Pavel Grunt > --- > server/red_channel.c | 14 -- >

Re: [Spice-devel] [PATCH spice-server v2 03/11] red dispatcher: Remove unused declaration of red_dispatcher_set_mm_time

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It is not used since c541d7e29dc0053e6434d053a50454bb8a7121e9 > > Signed-off-by: Pavel Grunt > --- > server/red_dispatcher.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/server/red_dispatcher.h b/server/red_dispatcher.h > index fe

Re: [Spice-devel] [PATCH spice-server v2 02/11] dispatcher: Remove unused dispatcher_read_message

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It is not needed since d3153f861065235c2a7a7120375be5db948c5a77 > > Signed-off-by: Pavel Grunt > --- > server/dispatcher.c | 13 - > server/dispatcher.h | 1 - > 2 files changed, 14 deletions(-) > > diff --git a/server/dispatche

Re: [Spice-devel] [PATCH spice-server v2 01/11] tree: Remove unused tree_item_dump

On Mon, Nov 23, 2015 at 10:43 AM, Pavel Grunt wrote: > It is not needed since 39e1cbe3211b06bca6e5d906ffb4d0582440c5cc > > Signed-off-by: Pavel Grunt > --- > server/tree.c | 161 > -- > server/tree.h | 1 - > 2 files changed, 162 deletio

[Spice-devel] [PATCH spice-server v2 10/11] main channel: Remove unused main_channel_push_notify

It is not needed since 8d44aa032892ea6643925fa7485d9af32853e127 Signed-off-by: Pavel Grunt --- server/main_channel.c | 6 -- server/main_channel.h | 1 - 2 files changed, 7 deletions(-) diff --git a/server/main_channel.c b/server/main_channel.c index 0ecc9df..252d799 100644 --- a/server/mai

  1   2   >