On Pá, 2015-11-20 at 16:26 +0100, Francois Gouget wrote:
> On Thu, 19 Nov 2015, Frediano Ziglio wrote:
> [...]
> > > What do you mean by "100% compatible with the current code"? (why is
> > > g_return_if-fail() not "100% compatible with the current code" ?)
> >
> > well... implementation is quite
hi
i try to implement this channel now in my project.
How i can to initiate emitting record-start/stop signals from guest
system? Which linux DE is correct for it?
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.or
Hi
- Original Message -
> On Fri, Nov 20, 2015 at 01:01:30PM -0500, Frediano Ziglio wrote:
> > >
> > > On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote:
> > > > Problems:
> > > > - the Spice_style.odt is outdated;
> > > > - spice_assert recall the standard assert but instea
>
> Hey,
>
> So there has been quite some discussions about logging.
>
> To sum up my personal thoughts on this:
>
> - we should just switch to using glib for logging. This means some mass
> renaming will need to be done at some point. Maybe it's possible to do
> it on the whole refactoring
On Fri, Nov 20, 2015 at 01:01:30PM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote:
> > > Problems:
> > > - the Spice_style.odt is outdated;
> > > - spice_assert recall the standard assert but instead it mainly
> > > call spice_error which li
>
> On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote:
> > Problems:
> > - the Spice_style.odt is outdated;
> > - spice_assert recall the standard assert but instead it mainly
> > call spice_error which like GLib is fatal and should call exit/abort.
> > It is not affected by NDEB
Hey,
So there has been quite some discussions about logging.
To sum up my personal thoughts on this:
- we should just switch to using glib for logging. This means some mass
renaming will need to be done at some point. Maybe it's possible to do
it on the whole refactoring branch through git f
On Fri, Nov 20, 2015 at 5:48 PM, Jonathon Jongsma wrote:
>
>
> On Fri, 2015-11-20 at 11:38 -0500, Frediano Ziglio wrote:
>> >
>> > Perhaps "add spice_bitmap_get_line()" would be a better commit message.
>> > But why is this added? where is it going to be used? If it was really
>> > supposed to be
On Fri, Nov 20, 2015 at 10:36:12AM -0600, Jonathon Jongsma wrote:
> On Fri, 2015-11-20 at 17:15 +0100, Christophe Fergeau wrote:
> > On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote:
> > > I looked at this today, one different between glib log functions and
> > > SPICE is that the
On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote:
> Problems:
> - the Spice_style.odt is outdated;
> - spice_assert recall the standard assert but instead it mainly
> call spice_error which like GLib is fatal and should call exit/abort.
> It is not affected by NDEBUG or other def
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Author:Marc-André Lureau
> ---
> server/dcc-encoders.c| 25 +
> server/dcc-encoders.h| 3 +-
> server/display-channel.c | 108 ++
> server/display-ch
On Fri, Nov 20, 2015 at 5:00 PM, Jonathon Jongsma wrote:
> Fine with me.
>
> Acked-by: Jonathon Jongsma
>
> On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote:
>> From: Marc-André Lureau
>>
>> ---
>> server/display-channel.c | 13 +++--
>> server/display-channel.h | 10 +++---
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/display-channel.c | 236
> server/display-channel.h | 4 +
> server/red_worker.c | 251
> +--
> 3 f
Hello,
On Wed, Nov 11, 2015 at 08:35:01PM +0200, Uri Lublin wrote:
> On 11/03/2015 05:11 PM, Christophe Fergeau wrote:
> I think we should distinguish between internal-errors (spice-server
> and maybe also qemu-kvm) and external-errors (spice-client and guest).
>
> For internal-errors, an unexpec
On Fri, 2015-11-20 at 11:38 -0500, Frediano Ziglio wrote:
> >
> > Perhaps "add spice_bitmap_get_line()" would be a better commit message.
> > But why is this added? where is it going to be used? If it was really
> > supposed to be moved ... moved from where?
> >
> > On Fri, Nov 20, 2015 at 12:1
hmm, rebase error? here's the original commit from alon's branch: http://cgit.fr
eedesktop.org/~alon/spice/commit/?h=wip/replay&id=dfd114c195befecfbcfd79076670c4
aeda82f945
On Fri, 2015-11-20 at 17:25 +0100, Fabiano Fidêncio wrote:
> Perhaps "add spice_bitmap_get_line()" would be a better commit
>
> Perhaps "add spice_bitmap_get_line()" would be a better commit message.
> But why is this added? where is it going to be used? If it was really
> supposed to be moved ... moved from where?
>
> On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
>
On Fri, 2015-11-20 at 17:15 +0100, Christophe Fergeau wrote:
> On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote:
> > I looked at this today, one different between glib log functions and
> > SPICE is that the SPICE ones append the file name/line number/function
> > name to the logg
On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/display-channel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/display-channel.c b/server/display-channel.c
> index 381a582..7aa3ea9 100644
> --- a/server/
Perhaps "add spice_bitmap_get_line()" would be a better commit message.
But why is this added? where is it going to be used? If it was really
supposed to be moved ... moved from where?
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/spice_bitm
On Fri, Nov 20, 2015 at 5:22 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> This is really not supported, requires X11, so better to remove it for
> now. Some day it might be revived, using DRM, ..
>
> Note for later, this could be removed too (not used by client):
> - spice-common/comm
From: Marc-André Lureau
This is really not supported, requires X11, so better to remove it for
now. Some day it might be revived, using DRM, ..
Note for later, this could be removed too (not used by client):
- spice-common/common/ogl_ctx
---
configure.ac | 7 -
server/Makefile.
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/dcc.c | 124 +
> server/dcc.h | 3 +
> server/display-channel.h | 7 +++
> server/red_worker.c | 158
> ---
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/dcc.c| 135 ++
> server/dcc.h| 5 ++
> server/red_worker.c | 165
> ++--
> 3 files change
On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote:
> On Fri, Nov 20, 2015 at 04:26:22PM +0100, Francois Gouget wrote:
> > Does it matter?
> > The client uses the g_return_xxx() functions already. Would it be a
> > problem if the server did too instead of going its separate way?
>
On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote:
> I looked at this today, one different between glib log functions and
> SPICE is that the SPICE ones append the file name/line number/function
> name to the logged message.
Thinking a bit more about this, while it's nice to have
On Fri, Nov 20, 2015 at 5:04 PM, Frediano Ziglio wrote:
>>
>> On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
>> > From: Marc-André Lureau
>> >
>> > ---
>> > server/dcc.c | 82 +++
>> > server/dcc.h | 17 ++
>> > server/display-chan
>
> On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/dcc.c | 82 +++
> > server/dcc.h | 17 ++
> > server/display-channel.c | 65 +
> > server/display-channel.h
Hey,
On Fri, Nov 20, 2015 at 04:26:22PM +0100, Francois Gouget wrote:
> On Thu, 19 Nov 2015, Frediano Ziglio wrote:
> [...]
> > > What do you mean by "100% compatible with the current code"? (why is
> > > g_return_if-fail() not "100% compatible with the current code" ?)
> >
> > well... implementa
On Fri, Nov 20, 2015 at 08:53:19AM -0600, Jonathon Jongsma wrote:
> On Fri, 2015-11-20 at 12:31 +, Frediano Ziglio wrote:
> > Due to implementation details spice_return is by default fatal (program
> > is aborting). This is quite confusing but changing the current macros
> > would possibly brea
Fine with me.
Acked-by: Jonathon Jongsma
On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/display-channel.c | 13 +++--
> server/display-channel.h | 10 +++---
> server/red_worker.c | 24
> 3 files c
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/dcc-encoders.c | 131 +-
> server/dcc-encoders.h | 7 ++
> server/dcc.c | 82 +
> server/dcc.h | 3 +
> server/red_worker.c | 251
On Fri, 2015-11-20 at 16:26 +0100, Francois Gouget wrote:
> On Thu, 19 Nov 2015, Frediano Ziglio wrote:
> [...]
> > > What do you mean by "100% compatible with the current code"? (why is
> > > g_return_if-fail() not "100% compatible with the current code" ?)
> >
> > well... implementation is quite
Acked-by: Jonathon Jongsma
On Fri, 2015-11-20 at 13:47 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Author:Marc-André Lureau
> ---
> server/Makefile.am | 1 +
> server/dcc.c| 62 +++
> server/red_worker.c | 121 ++
>
> On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > Acked-by: Fabiano Fidêncio
>
> ^^^
>
>
> Do we need further review on this? Were there changes?
>
>
>
Yes, sorry, already pushed.
I did some additional checks, patches was not loo
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/stream.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/server/stream.c b/server/stream.c
index bd56601..85136ea 100644
--- a/server/stream.c
+++ b/server/stream.c
@@ -643,7 +643,7 @@ static uint64
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/red_worker.c | 2 +-
server/stream.c | 4 +++-
server/stream.h | 3 +--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 09ebc0d..ef27ebe 100644
--- a/server/red
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 53
> +
> 1 file changed, 17 insertions(+), 36 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index b
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/stream.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/server/stream.c b/server/stream.c
index 4d078de..bd56601 100644
--- a/server/stream.c
+++ b/server/stream.c
@@ -596,8 +596,7 @@ static void
dcc_upda
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 26 +++---
> 1 file changed, 11 insertions(+), 15 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 8c0758e..b007040 100644
> --- a
On Thu, 19 Nov 2015, Frediano Ziglio wrote:
[...]
> > What do you mean by "100% compatible with the current code"? (why is
> > g_return_if-fail() not "100% compatible with the current code" ?)
>
> well... implementation is quite different. I didn't get all differences but
> - spice_logv use some e
On Thu, Nov 19, 2015 at 03:58:18PM +0100, Christophe Fergeau wrote:
> On Thu, Nov 19, 2015 at 04:48:20PM +0200, Yedidyah Bar David wrote:
> > From: Christophe Fergeau
>
> When splitting these patches, I've mistakenly changed ownership of this
> patch. I've set it back to you in my local repositor
On Fri, 2015-11-20 at 09:02 -0600, Jonathon Jongsma wrote:
> Acked-by: Jonathon Jongsma
>
> (just testing whether this format marks the patch as acked in patchwork) ;)
hey, it works!
>
> On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > This is rea
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> This is really not supported, requires X11, so better to remove it for
> now. Some day it might be revived, using DRM, ..
>
> Note for later, this could be removed too (not used by client):
> - spice-common/com
Acked-by: Jonathon Jongsma
(just testing whether this format marks the patch as acked in patchwork) ;)
On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> This is really not supported, requires X11, so better to remove it for
> now. Some day it might be revi
On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Acked-by: Fabiano Fidêncio
^^^
Do we need further review on this? Were there changes?
> ---
> server/dcc-encoders.c| 55 ++
> server/dcc-encoders.h
On Fri, 2015-11-20 at 09:12 -0500, Frediano Ziglio wrote:
> > On Fri, 2015-11-20 at 10:50 +0100, Fabiano Fidêncio wrote:
> > > On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote:
> > > > Signed-off-by: Pavel Grunt
> > > > ---
> > > > Seems that free functions haven't been used since there were i
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 2 +-
> server/stream.c | 21 +++--
> server/stream.h | 3 +--
> 3 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/server/red_worker.c b/
>
> On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 35 ++-
> > 1 file changed, 2 insertions(+), 33 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index 6e
On Fri, 2015-11-20 at 12:31 +, Frediano Ziglio wrote:
> Due to implementation details spice_return is by default fatal (program
> is aborting). This is quite confusing but changing the current macros
> would possibly break existing code.
> Add not fatal (at least by default) macros. They use wa
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/cursor-channel.c | 4
> server/red_worker.c | 60
> +
> 2 files changed, 30 insertions(+), 34 deletions(-)
>
> diff --git a/server/cursor
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/dcc.c | 82 +++
> server/dcc.h | 17 ++
> server/display-channel.c | 65 +
> server/display-channel.h | 19 +--
> se
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 35 ++-
> 1 file changed, 2 insertions(+), 33 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 6e859fe..f6dfe28 100644
Okay, the patch that I have applied (git-pw apply 994) seems a bit
different from this one as it doesn't have the changes on dcc.c, which
are unrelated anyway.
The commit message should be clear about moving detach_streams function as well.
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote
> > On Fri, 2015-11-20 at 10:50 +0100, Fabiano Fidêncio wrote:
> > > On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote:
> > > > Signed-off-by: Pavel Grunt
> > > > ---
> > > > Seems that free functions haven't been used since there were introduced
> > > > [1]
> > > >
> > > > [1]
> > > > http://
> On Fri, 2015-11-20 at 10:50 +0100, Fabiano Fidêncio wrote:
> > On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote:
> > > Signed-off-by: Pavel Grunt
> > > ---
> > > Seems that free functions haven't been used since there were introduced
> > > [1]
> > >
> > > [1]
> > > http://lists.freedesktop.
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/Makefile.am | 1 +
server/dcc.c| 62 +++
server/red_worker.c | 121 ++--
server/utils.c | 50 ++
server/utils.h |
>
> Reduced diff (I'm getting good at it!):
>
>
> --- before.c 2015-11-20 13:30:01.465786520 +
> +++ after.c 2015-11-20 13:27:42.931050275 +
> @@ -128,20 +128,21 @@
> spice_bitmap_utils.c\
> spice_server_utils.h\
> spice_image_cache.h
Reduced diff (I'm getting good at it!):
--- before.c2015-11-20 13:30:01.465786520 +
+++ after.c 2015-11-20 13:27:42.931050275 +
@@ -128,20 +128,21 @@
spice_bitmap_utils.c\
spice_server_utils.h\
spice_image_cache.h
On Fri, 2015-11-20 at 10:50 +0100, Fabiano Fidêncio wrote:
> On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote:
> > Signed-off-by: Pavel Grunt
> > ---
> > Seems that free functions haven't been used since there were introduced [1]
> >
> > [1] http://lists.freedesktop.org/archives/spice-devel/2
On Fri, 2015-11-20 at 12:53 +0100, Christophe Fergeau wrote:
> On Thu, Nov 19, 2015 at 08:44:50PM +0100, Pavel Grunt wrote:
> > Hi,
> >
> > I noticed that there are some unused functions in our code.
>
> Did you find these functions manually? Or did you use something somehow
> programmatic to det
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/Makefile.am | 1 +
server/dcc.c| 62 +++
server/red_worker.c | 121 ++--
server/utils.c | 50 ++
server/utils.h |
On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Author:Marc-André Lureau
> ---
> server/Makefile.am | 1 +
> server/dcc.c| 62 +++
> server/red_worker.c | 121
> ++--
>
Due to implementation details spice_return is by default fatal (program
is aborting). This is quite confusing but changing the current macros
would possibly break existing code.
Add not fatal (at least by default) macros. They use warning level
instead of critical.
This is also compatible with Glib
Signed-off-by: Frediano Ziglio
---
server/main_channel.c | 10 ++
server/mjpeg_encoder.c | 9 +++--
server/red_channel.c | 13 +++--
3 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/server/main_channel.c b/server/main_channel.c
index 0ecc9df..176584a 100644
Signed-off-by: Frediano Ziglio
---
server/display-channel.h | 1 +
server/red_worker.c | 13 ++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/server/display-channel.h b/server/display-channel.h
index d47abf7..990d756 100644
--- a/server/display-channel.h
+++ b/se
>
> On Thu, Nov 19, 2015 at 08:44:50PM +0100, Pavel Grunt wrote:
> > Hi,
> >
> > I noticed that there are some unused functions in our code.
>
> Did you find these functions manually? Or did you use something somehow
> programmatic to detect them?
>
> Christophe
>
I don't know how Pavel did i
On Thu, Nov 19, 2015 at 08:44:50PM +0100, Pavel Grunt wrote:
> Hi,
>
> I noticed that there are some unused functions in our code.
Did you find these functions manually? Or did you use something somehow
programmatic to detect them?
Christophe
signature.asc
Description: PGP signature
__
>
> Hi,
>
> I know this was merged already but just one comment bellow:
>
> On Wed, Nov 18, 2015 at 03:42:26PM -0600, Jonathon Jongsma wrote:
> > From: Marc-André Lureau
> > +static SPICE_GNUC_NORETURN SPICE_GNUC_PRINTF(2, 3) void
> > +quic_usr_error(QuicUsrContext *usr, const char *fmt, ...)
>
On Thu, Nov 19, 2015 at 11:39:51AM -0500, Frediano Ziglio wrote:
> > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > > From: Marc-André Lureau
> > >
> > > ---
> > > server/cursor-channel.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/serv
Hi,
On Fri, Nov 20, 2015 at 11:47:41AM +0100, Pavel Grunt wrote:
> On Fri, 2015-11-20 at 04:32 -0500, Frediano Ziglio wrote:
> > >
> > > Hi,
> > >
> > > I noticed that there are some unused functions in our code.
> > > Some of them were just defined, but haven't been used, others
> > > stopped b
>
> Avoid problem when compiling with lz4 and without COMPRESS_STAT
>
> dcc.c: In function 'dcc_compress_image_lz4':
> dcc.c:657:21: error: unused variable 'display_channel'
> [-Werror=unused-variable]
> DisplayChannel *display_channel = DCC_TO_DC(dcc);
> ---
> server/dcc.c | 5 ++---
> 1 f
On Thu, Nov 19, 2015 at 01:45:44PM -0500, Marc-André Lureau wrote:
>
>
> - Original Message -
> > On Thu, Nov 19, 2015 at 02:18:25PM -0200, Eduardo Lima (Etrunko) wrote:
> > > On 11/19/2015 02:00 PM, Marc-André Lureau wrote:
> > > >
> > > >
> > > > - Original Message -
> > > >>
>
> Hi,
>
> On Thu, Nov 19, 2015 at 10:50:35AM +0100, Fabiano Fidêncio wrote:
> > On Wed, Nov 18, 2015 at 5:19 PM, Frediano Ziglio
> > wrote:
> > >>
> > >> This patchset supersedes last patchset.
> > >>
> > >> Changes:
> > >> - rebased;
> > >> - removed merged patches;
> > >> - added some patche
From: Marc-André Lureau
---
server/display-channel.c | 236
server/display-channel.h | 4 +
server/red_worker.c | 251 +--
3 files changed, 244 insertions(+), 247 deletions(-)
diff --git a/server/dis
From: Marc-André Lureau
---
server/display-channel.c | 13 +++--
server/display-channel.h | 10 +++---
server/red_worker.c | 24
3 files changed, 26 insertions(+), 21 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 7a
From: Marc-André Lureau
---
server/red_worker.c | 53 +
1 file changed, 17 insertions(+), 36 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index b007040..337748d 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
From: Marc-André Lureau
---
server/dcc-encoders.c | 131 +-
server/dcc-encoders.h | 7 ++
server/dcc.c | 82 +
server/dcc.h | 3 +
server/red_worker.c | 251 ++
5 files changed, 229 i
From: Marc-André Lureau
---
server/dcc.c | 124 +
server/dcc.h | 3 +
server/display-channel.h | 7 +++
server/red_worker.c | 158 ---
4 files changed, 147 insertions(+), 145 deletion
From: Marc-André Lureau
---
server/dcc.c| 135 ++
server/dcc.h| 5 ++
server/red_worker.c | 165 ++--
3 files changed, 145 insertions(+), 160 deletions(-)
diff --git a/server/dcc.c b/server
From: Marc-André Lureau
---
server/display-channel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 381a582..7aa3ea9 100644
--- a/server/display-channel.c
+++ b/server/display-channel.c
@@ -860,10 +860,10 @@ int d
From: Marc-André Lureau
---
server/spice_bitmap_utils.c | 27 +++
server/spice_bitmap_utils.h | 3 +++
2 files changed, 30 insertions(+)
diff --git a/server/spice_bitmap_utils.c b/server/spice_bitmap_utils.c
index ae3fc8b..3b992a7 100644
--- a/server/spice_bitmap_utils.
From: Marc-André Lureau
---
server/red_worker.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 8c0758e..b007040 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -5236,24 +5236,20 @@ sta
From: Marc-André Lureau
This is really not supported, requires X11, so better to remove it for
now. Some day it might be revived, using DRM, ..
Note for later, this could be removed too (not used by client):
- spice-common/common/ogl_ctx
---
server/Makefile.am | 7 -
server/display-c
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/dcc-encoders.c| 25 +
server/dcc-encoders.h| 3 +-
server/display-channel.c | 108 ++
server/display-channel.h | 6 +++
server/red_worker.c | 134 +++
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/Makefile.am | 1 +
server/dcc.c| 62 +++
server/red_worker.c | 121 ++--
server/utils.c | 46
server/utils.h | 4
From: Marc-André Lureau
---
server/red_worker.c | 35 ++-
1 file changed, 2 insertions(+), 33 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 6e859fe..f6dfe28 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -223,8 +223,8 @@
From: Marc-André Lureau
---
server/dcc.c| 5 ++--
server/red_worker.c | 74 +++--
server/stream.c | 65 --
server/stream.h | 1 -
4 files changed, 74 insertions(+), 71 deletions(-)
diff
From: Marc-André Lureau
---
server/cursor-channel.c | 4
server/red_worker.c | 60 +
2 files changed, 30 insertions(+), 34 deletions(-)
diff --git a/server/cursor-channel.c b/server/cursor-channel.c
index aafc807..5eb2647 100644
--- a/se
From: Marc-André Lureau
---
server/dcc.c | 82 +++
server/dcc.h | 17 ++
server/display-channel.c | 65 +
server/display-channel.h | 19 +--
server/red_worker.c | 144 +---
From: Marc-André Lureau
Acked-by: Fabiano Fidêncio
---
server/dcc-encoders.c| 55 ++
server/dcc-encoders.h| 7 +++--
server/display-channel.c | 22 +++
server/display-channel.h | 1 +
server/red_worker.c | 69 ---
From: Marc-André Lureau
---
server/red_worker.c | 2 +-
server/stream.c | 21 +++--
server/stream.h | 3 +--
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 09ebc0d..ef27ebe 100644
--- a/server/red_worker.
This patchset supersedes last patchset.
Changes:
- rebased;
- removed merged patches;
- added some patches.
I didn't push "worker: move more free_glz_drawable" patch,
wants to do some checks on Fabiano comments.
Marc-André Lureau (18):
worker: move more free_glz_drawable
worker: move attach_
Avoid problem when compiling with lz4 and without COMPRESS_STAT
dcc.c: In function 'dcc_compress_image_lz4':
dcc.c:657:21: error: unused variable 'display_channel' [-Werror=unused-variable]
DisplayChannel *display_channel = DCC_TO_DC(dcc);
---
server/dcc.c | 5 ++---
1 file changed, 2 insert
On Fri, 2015-11-20 at 04:32 -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > I noticed that there are some unused functions in our code.
> > Some of them were just defined, but haven't been used, others
> > stopped being used because some other functions were changed/removed.
> > I'm not sure ab
> >
> > From: Marc-André Lureau
> >
> > ---
> > server/dcc.c | 12 +++-
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/server/dcc.c b/server/dcc.c
> > index bb6001e..8e25c67 100644
> > --- a/server/dcc.c
> > +++ b/server/dcc.c
> > @@ -343,7 +343,8 @@ static Re
>
> NACK, I don't see a reason for changing it.
>
> Pavel
>
> On Thu, 2015-11-19 at 18:01 +, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/server/red_worker.c b/server/
>
> On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 22 +-
> > 1 file changed, 9 insertions(+), 13 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index e31dd08..30dcbce
>
> On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/dcc.c| 90
> >
> > server/dcc.h| 2 ++
> > server/red_worker.c | 91
> >
>
> On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 14 ++
> > server/stream.c | 12
> > server/stream.h | 6 --
> > 3 files changed, 18 insertions(+), 14 deletions(-)
> >
> > diff --
1 - 100 of 117 matches
Mail list logo
