It is not needed since 39e1cbe3211b06bca6e5d906ffb4d0582440c5cc
Signed-off-by: Pavel Grunt
---
v2: Remove functions called by tree_item_dump
---
server/tree.c | 161 --
server/tree.h | 1 -
2 files changed, 162 deletions(-)
diff --git a/
Hi Jonathon,
On Thu, 2015-11-19 at 14:32 -0600, Jonathon Jongsma wrote:
> Are you sure we're not just leaking the encoder right now? Perhaps we should
> be
> calling this function somewhere. Same for lz4_encoder_destroy().
>
I know that it is unused. As I said in the cover letter, it is strange t
ACK
On Thu, 2015-11-19 at 18:01 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 21 -
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 2759857..747bb9e 100644
> ---
ACK
On Thu, 2015-11-19 at 17:59 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/dcc-encoders.c | 47 +++
> server/red_worker.c | 50 ++
> server/red_worker.h | 3 +++
> 3 fi
On Thu, 2015-11-19 at 10:03 -0500, Frediano Ziglio wrote:
> > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > > From: Marc-André Lureau
> > >
> > > ---
> > > server/display-channel.c | 11 +++
> > > server/display-channel.h | 1 +
> > > server/red_worker.c | 22 +++
On 11/19/2015 02:58 PM, Marc-André Lureau wrote:
>
>
> - Original Message -
>> On 11/19/2015 02:25 PM, Marc-André Lureau wrote:
>>>
>>>
>>> - Original Message -
On 11/19/2015 02:00 PM, Marc-André Lureau wrote:
>
>
> - Original Message -
>> On 11/19/201
On Thu, 2015-11-19 at 14:16 +, Frediano Ziglio wrote:
> Signed-off-by: Marc-André Lureau
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc.c | 631 +++
> server/dcc.h | 31 +++
> server/display-channel.h | 4 +
> server/red
On Thu, 2015-11-19 at 14:16 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/display-channel.h | 2 ++
> server/red_worker.c | 13 ++---
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/server/display-channel.h b/server/display-channe
Thanks, I've pushed it to the git repository.
On Thu, 2015-11-19 at 17:47 +0800, Jay.han wrote:
> According to windows vdagent fileXfer, it requires a
> VD_AGENT_FILE_XFER_STATUS_CANCELLED msg when user cancel a file transfer.
> Currently our code only send VD_AGENT_FILE_XFER_STATUS_ERROR, thi
Are you sure we're not just leaking the encoder right now? Perhaps we should be
calling this function somewhere. Same for lz4_encoder_destroy().
On Thu, 2015-11-19 at 20:45 +0100, Pavel Grunt wrote:
> It was introduced in 263646a1f7e705766f7d46017679812d4b1406b8
> but never used.
>
> Signed-off
It is not needed since d3153f861065235c2a7a7120375be5db948c5a77
Signed-off-by: Pavel Grunt
---
server/dispatcher.c | 13 -
server/dispatcher.h | 1 -
2 files changed, 14 deletions(-)
diff --git a/server/dispatcher.c b/server/dispatcher.c
index 945edba..d6c03ca 100644
--- a/server/d
It was introduced in 263646a1f7e705766f7d46017679812d4b1406b8
but never used.
Signed-off-by: Pavel Grunt
---
server/jpeg_encoder.c | 6 --
server/jpeg_encoder.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/server/jpeg_encoder.c b/server/jpeg_encoder.c
index 0296e9b..0e72621 100644
--
It was introduced in 49a8d68303f3d8681a9c61d74e0675279649d480
but never used.
Signed-off-by: Pavel Grunt
---
server/red_channel.c | 14 --
server/red_channel.h | 1 -
2 files changed, 15 deletions(-)
diff --git a/server/red_channel.c b/server/red_channel.c
index 7330ae2..1c9cfc6 10
It was introduced in 9cece23ba3e49e6eec9e380daa95d6ee0133c91c
but never used.
Signed-off-by: Pavel Grunt
---
server/main_channel.c | 5 -
server/main_channel.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/server/main_channel.c b/server/main_channel.c
index 252d799..d6b121a 100644
---
It was introduced in 09ae4700d27b7c1cca64c2ce4c90f0c6cdf81ccf
but never used.
Signed-off-by: Pavel Grunt
---
server/red_channel.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/server/red_channel.h b/server/red_channel.h
index 89d06ee..a755d21 100644
--- a/server/red_channel.h
+++ b/server
It was introduced in 7e8e13593ee681cf04c349bca57dd225d7802494
but never used.
Signed-off-by: Pavel Grunt
---
server/red_channel.c | 12
server/red_channel.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/server/red_channel.c b/server/red_channel.c
index c47ded5..c03c95a 1006
It was introduced in 0f0bdb190b8586ef7ac20fcefffe641e44eb15b9
but never used.
Signed-off-by: Pavel Grunt
---
server/red_channel.c | 6 --
server/red_channel.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/server/red_channel.c b/server/red_channel.c
index 1c9cfc6..a57415e 100644
--- a/
It is not used since c541d7e29dc0053e6434d053a50454bb8a7121e9
Signed-off-by: Pavel Grunt
---
server/red_dispatcher.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/red_dispatcher.h b/server/red_dispatcher.h
index fef067c..9f3474f 100644
--- a/server/red_dispatcher.h
+++ b/server/red_d
It was introduced in c1b79eb035fa158fb2ac3bc8e559809611070016
but never used.
Signed-off-by: Pavel Grunt
---
server/reds.c | 19 ---
server/stat.h | 4
2 files changed, 23 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 9bd28df..d99cf97 100644
--- a/server/re
It is not needed since 8d44aa032892ea6643925fa7485d9af32853e127
Signed-off-by: Pavel Grunt
---
server/main_channel.c | 6 --
server/main_channel.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/server/main_channel.c b/server/main_channel.c
index 0ecc9df..252d799 100644
--- a/server/mai
Hi,
I noticed that there are some unused functions in our code.
Some of them were just defined, but haven't been used, others
stopped being used because some other functions were changed/removed.
I'm not sure about last 3-4 patches - if _create() is called then
it would make sense to call _destroy
It was introduced in e3bc21957086ce03edcb3867affc2d820291fe75
but never used.
Signed-off-by: Pavel Grunt
---
server/spice_timer_queue.c | 24
server/spice_timer_queue.h | 1 -
2 files changed, 25 deletions(-)
diff --git a/server/spice_timer_queue.c b/server/spice_timer
It is not needed since 39e1cbe3211b06bca6e5d906ffb4d0582440c5cc
Signed-off-by: Pavel Grunt
---
server/tree.c | 8
server/tree.h | 1 -
2 files changed, 9 deletions(-)
diff --git a/server/tree.c b/server/tree.c
index a3dfbde..39ad62d 100644
--- a/server/tree.c
+++ b/server/tree.c
@@ -17
It is not needed since ef9a8bf05328d290f82613037f5419f0d5e87eb5
Signed-off-by: Pavel Grunt
---
server/red_channel.c | 6 --
server/red_channel.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/server/red_channel.c b/server/red_channel.c
index a57415e..6a3155a 100644
--- a/server/red_cha
It was introduced in b532ef0866cefe260ad0f08550f7c40d3580d0d7
but never used.
Signed-off-by: Pavel Grunt
---
server/lz4_encoder.c | 5 -
server/lz4_encoder.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c
index b3e38b2..7d4e7f3 100644
--- a/s
It is not needed since 8e7b22b7861d2859167767822f29749bfe3ecc16
Signed-off-by: Pavel Grunt
---
server/red_channel.c | 5 -
server/red_channel.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/server/red_channel.c b/server/red_channel.c
index 6a3155a..c47ded5 100644
--- a/server/red_chan
- Original Message -
> On Thu, Nov 19, 2015 at 02:18:25PM -0200, Eduardo Lima (Etrunko) wrote:
> > On 11/19/2015 02:00 PM, Marc-André Lureau wrote:
> > >
> > >
> > > - Original Message -
> > >> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> > >>> If the compiler in use is a
On Thu, Nov 19, 2015 at 02:18:25PM -0200, Eduardo Lima (Etrunko) wrote:
> On 11/19/2015 02:00 PM, Marc-André Lureau wrote:
> >
> >
> > - Original Message -
> >> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> >>> If the compiler in use is a C++ compiler, adds extern "C" around the
> >>
Hey,
For what it's worth, I read the shortlog opposite to what this commit is
doing: I read it as "warn if libcacard.h is included", not sure how to
make this clearer though :(
Christophe
On Thu, Nov 19, 2015 at 01:30:37PM +0100, Marc-André Lureau wrote:
> Only libcacard.h should be included dir
On Thu, Nov 19, 2015 at 11:33:47AM +0100, Pavel Grunt wrote:
> On Thu, 2015-11-19 at 11:25 +0100, Christophe Fergeau wrote:
> > ---
> > docs/manual/manual.txt | 4
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt
> > index f6aa86f..2c00
On Wed, Nov 18, 2015 at 06:14:25AM -0500, Frediano Ziglio wrote:
> Also the function cast is not portable (I thing can core on x86!).
I think this is undefined behaviour indeed, but on the other hand, it's
used quite often in the glib/GNOME world, so I don't expect bad things
to happen in practice
From: Marc-André Lureau
---
server/red_worker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 747bb9e..f6023bb 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -6150,7 +6150,7 @@ static void handle_dev_stop(void *
Split asserts -> returns.
Marc-André Lureau (2):
worker: few function renames
worker: change spice_assert in handle_dev_stop
server/red_worker.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
--
2.4.3
___
Spice-d
From: Marc-André Lureau
---
server/red_worker.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 2759857..747bb9e 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -182,7 +182,7 @@ static void r
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
Signed-off-by: Frediano Ziglio
---
server/dcc-encoders.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index 1f98d1a..1156513 100644
--- a/server/dcc-encoders
Split asserts -> returns.
Marc-André Lureau (2):
worker: move dcc_free_glz_drawable_instance
worker: change spice_assert in dcc_free_glz_drawable_instance
server/dcc-encoders.c | 47 +++
server/red_worker.c | 50 ++
From: Marc-André Lureau
---
server/dcc-encoders.c | 47 +++
server/red_worker.c | 50 ++
server/red_worker.h | 3 +++
3 files changed, 52 insertions(+), 48 deletions(-)
diff --git a/server/dcc-encod
On Thu, Nov 12, 2015 at 10:36:59AM -0500, Frediano Ziglio wrote:
>
> > On Thu, Nov 12, 2015 at 3:00 PM, Frediano Ziglio wrote:
> > > From: Marc-André Lureau
> > >
> > > ---
> > > server/red_worker.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/server/red
>
> Hey,
>
> On Thu, Nov 19, 2015 at 06:58:41AM -0500, Frediano Ziglio wrote:
> > >
> > > Hi
> > >
> > > - Original Message -
> > > > Due to implementation details spice_return is by default fatal (program
> > > > is aborting). This is quite confusing but changing the current macros
> >
- Original Message -
> Hey,
>
> On Thu, Nov 19, 2015 at 06:58:41AM -0500, Frediano Ziglio wrote:
> > >
> > > Hi
> > >
> > > - Original Message -
> > > > Due to implementation details spice_return is by default fatal (program
> > > > is aborting). This is quite confusing but cha
Hey,
On Thu, Nov 19, 2015 at 06:58:41AM -0500, Frediano Ziglio wrote:
> >
> > Hi
> >
> > - Original Message -
> > > Due to implementation details spice_return is by default fatal (program
> > > is aborting). This is quite confusing but changing the current macros
> > > would possibly bre
>
> From: Marc-André Lureau
>
> ---
> server/dcc.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/server/dcc.c b/server/dcc.c
> index bb6001e..8e25c67 100644
> --- a/server/dcc.c
> +++ b/server/dcc.c
> @@ -343,7 +343,8 @@ static RedGlzDrawable
> *get_glz_
Hi
On Mon, Oct 26, 2015 at 2:17 PM, Christophe Fergeau
wrote:
> I'm still a bit worried whether we are missing a more generic fix here
> :-/ the non-LE surfaces come from canvas_get_as_surface /
> canvas_put_image I guess?
>
So I was looking into this, and it turns out, that with my PPC fixes,
Hi,
I noticed in patches that g_slice* is being introduced to spice-server
code. Please mention it in release notes because it has implications for
debugging (namely need to set G_SLICE=(debug_blocks|always_malloc)
depending on problem type in code that uses g_slice).
David
_
- Original Message -
> On 11/19/2015 02:25 PM, Marc-André Lureau wrote:
> >
> >
> > - Original Message -
> >> On 11/19/2015 02:00 PM, Marc-André Lureau wrote:
> >>>
> >>>
> >>> - Original Message -
> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> > If the co
Hey,
On Tue, Nov 10, 2015 at 03:31:26PM +0100, Marc-André Lureau wrote:
> On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote:
> > From: Christophe Fergeau
> >
> > Make sure an allocated buffer is correctly referenced by the marshaller,
> > and can't be free and reused by mistake. Simplify th
> On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/cursor-channel.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> > index aafc807..794dcf3 100644
>
On 11/19/2015 02:25 PM, Marc-André Lureau wrote:
>
>
> - Original Message -
>> On 11/19/2015 02:00 PM, Marc-André Lureau wrote:
>>>
>>>
>>> - Original Message -
On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> If the compiler in use is a C++ compiler, adds extern "C" ar
- Original Message -
> On 11/19/2015 02:00 PM, Marc-André Lureau wrote:
> >
> >
> > - Original Message -
> >> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> >>> If the compiler in use is a C++ compiler, adds extern "C" around the
> >>> header.
> >>>
> >>> Signed-off-by: Marc
On 11/19/2015 02:00 PM, Marc-André Lureau wrote:
>
>
> - Original Message -
>> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
>>> If the compiler in use is a C++ compiler, adds extern "C" around the
>>> header.
>>>
>>> Signed-off-by: Marc-André Lureau
>>> ---
>>> src/libcacard.h | 6 +
- Original Message -
> On 11/19/2015 02:30 PM, Marc-André Lureau wrote:
> > Only libcacard.h should be included directly.
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > Makefile.am | 1 +
> > src/cac.h | 5 +
> > src/capcsc.h | 4
> > sr
On 11/19/2015 02:30 PM, Marc-André Lureau wrote:
Only libcacard.h should be included directly.
Signed-off-by: Marc-André Lureau
---
Makefile.am | 1 +
src/cac.h | 5 +
src/capcsc.h | 4
src/card_7816.c | 4
Hi Marc-Andre,
A C file ?
Reg
- Original Message -
> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> > Only libcacard.h should be included directly.
>
> ACK, although I don't really like this kind of restriction but it seems
> to be a convention with the project, so fine with me.
It's a convention in more and mor
On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> Only libcacard.h should be included directly.
ACK, although I don't really like this kind of restriction but it seems
to be a convention with the project, so fine with me.
The series is ok, except by the inclusion of glib.h in libcacard.h.
>
>
- Original Message -
> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> > If the compiler in use is a C++ compiler, adds extern "C" around the
> > header.
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > src/libcacard.h | 6 ++
> > 1 file changed, 6 insertions(+)
> >
> > dif
On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> If the compiler in use is a C++ compiler, adds extern "C" around the
> header.
>
> Signed-off-by: Marc-André Lureau
> ---
> src/libcacard.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/libcacard.h b/src/libcacard.h
> index
On 11/19/2015 01:51 PM, Eduardo Lima (Etrunko) wrote:
> On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
>> vscard_common.h uses glib G_BYTE_ORDER macros. Include glib.h in the
>> file, and thus move glib-2.0 as a Require package.
>>
>> Signed-off-by: Marc-André Lureau
>> ---
>> libcacard.pc.in
On 11/19/2015 10:30 AM, Marc-André Lureau wrote:
> vscard_common.h uses glib G_BYTE_ORDER macros. Include glib.h in the
> file, and thus move glib-2.0 as a Require package.
>
> Signed-off-by: Marc-André Lureau
> ---
> libcacard.pc.in | 3 ++-
> src/vscard_common.h | 1 +
> 2 files changed, 3
On Thu, Nov 19, 2015 at 5:28 PM, Christophe Fergeau wrote:
> On Thu, Nov 19, 2015 at 05:05:10PM +0200, Yedidyah Bar David wrote:
>> On Thu, Nov 19, 2015 at 4:03 PM, Christophe Fergeau
>> wrote:
>> > Hey,
>> >
>> > On Thu, Nov 19, 2015 at 03:13:35PM +0200, Yedidyah Bar David wrote:
>> >> I find m
On Thu, Nov 19, 2015 at 05:05:10PM +0200, Yedidyah Bar David wrote:
> On Thu, Nov 19, 2015 at 4:03 PM, Christophe Fergeau
> wrote:
> > Hey,
> >
> > On Thu, Nov 19, 2015 at 03:13:35PM +0200, Yedidyah Bar David wrote:
> >> I find more comfortable this semi-pull-requests mode of operation
> >> inste
Hi,
On Thu, Nov 19, 2015 at 02:41:52PM +, Frediano Ziglio wrote:
> Due to implementation details spice_return is by default fatal (program
> is aborting). This is quite confusing but changing the current macros
> would possibly break existing code.
> Add not fatal (at least by default) macros.
Hi,
On Thu, Nov 19, 2015 at 03:57:55PM +0100, Fabiano Fidêncio wrote:
> On Thu, Nov 19, 2015 at 3:42 PM, wrote:
> > From: Marek Kasik
> >
> > This patch adds SPICE_CLIENT_ERROR_AUTH_NEEDS_USERNAME error
> > for the case when authentication fails because of missing username.
> > This can happen
On Thu, Nov 19, 2015 at 4:03 PM, Christophe Fergeau wrote:
> Hey,
>
> On Thu, Nov 19, 2015 at 03:13:35PM +0200, Yedidyah Bar David wrote:
>> I find more comfortable this semi-pull-requests mode of operation
>> instead of posting patches to the list. Please notify if you prefer me
>> to also post,
> On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/display-channel.c | 11 +++
> > server/display-channel.h | 1 +
> > server/red_worker.c | 22 +++---
> > 3 files changed, 15 insertions(+), 19 deletions(-)
>
On Thu, Nov 19, 2015 at 04:48:20PM +0200, Yedidyah Bar David wrote:
> From: Christophe Fergeau
When splitting these patches, I've mistakenly changed ownership of this
patch. I've set it back to you in my local repository.
Christophe
signature.asc
Description: PGP signature
On Thu, Nov 19, 2015 at 3:42 PM, wrote:
> From: Marek Kasik
>
> This patch adds SPICE_CLIENT_ERROR_AUTH_NEEDS_USERNAME error
> for the case when authentication fails because of missing username.
> This can happen when GSSAPI method is used.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=92994
Add automation scripts/conf for ovirt jenkins.
Run builds on push to gerrit and on merge there.
Structure defined in [1].
[1] http://www.ovirt.org/CI/Build_and_test_standards
Change-Id: I209ec032794575fe0231eb53cdf8d5e0cf978e5a
Signed-off-by: Yedidyah Bar David
---
automation/README.md
Allow building the spice installer and building/installing the ovirt
installer.
Allow passing DISPLAYED_VERSION to make.
Allow passing MODE to make to choose between the two installers -
SPICE (default) or OVIRT.
Some of the code in the Makefile was copied and adapted from
ovirt-wgt-installer.sp
Allow passing:
DISPLAYED_VERSION (defaults to $VERSION): what's written to the
registry. This is what is shown to the user e.g. in the control panel.
EXE_VERSION (defaults to -$VERSION): appended to installer filename.
Not touching VERSION, which reflects the version of the installer's
source co
From: Lev Veyde
change-id was I8692e636d42f127f953f578d86c7cbe8f2bcc06a
renamed due to gerrit complications
Change-Id: Idb20091a41e1cae7ac6df538ee17eec38a8a714a
Signed-off-by: Lev Veyde
---
win-guest-tools.nsis | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/win-guest-t
From: Christophe Fergeau
This is only used when generating the oVirt installer as it does not
want any version number to be included in the .exe filename provided on
the ISO it ships. However, if someone was to ship a standalone .exe
outside of an ISO, an unversioned installer executable is not w
From: Christophe Fergeau
We can pass directly the name of the files we want to be in the iso.
Change-Id: I6c5d2ae82a23ae4ba1d0249b6aefc61ccbc5b0a6
Signed-off-by: Christophe Fergeau
---
Makefile | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index
From: Christophe Fergeau
While it makes sense to have a versioned .exe file when it's standalone,
when it's on an ISO, it's more natural to have an unversioned .exe
installer. This is achieved through the use of the --graft-points option
to mkisofs.
Change-Id: I1970348c6a72dcd44865c78d3348fc5776
qxl drivers are now supplied inside virtio-win drivers package.
Change-Id: Id8274f125ef7fa6b4fd76a7015958f24f2e358ea
Signed-off-by: Yedidyah Bar David
---
win-guest-tools.nsis | 1 -
1 file changed, 1 deletion(-)
diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis
index 8b52e26..ef4cf07 10
From: Christophe Fergeau
Use bz2 rather than gz, add version number to the output directory, and
use the more portable /dev/stdin instead of /proc/self/fd/0.
Change-Id: I90096405ded7eb9102818185482fa27dc4c33b72
Signed-off-by: Christophe Fergeau
---
Makefile | 4 ++--
1 file changed, 2 insertio
Copied and adapted from ovirt-wgt-toolchain. See [1] [2].
In order to not duplicate the source code's version in the spec file,
generate it by make.
[1] https://gerrit.ovirt.org/47432
[2] https://gerrit.ovirt.org/48425
Change-Id: Ie6dcb72da2fe13bb154784a27f1ee992e9d12b14
Signed-off-by: Yedidyah
From: Christophe Fergeau
Change-Id: I003ebdcc2b8c3778903a5b07eb02280aba4527b0
Signed-off-by: Christophe Fergeau
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 5be6894..068d774 100644
--- a/Makefile
+++ b/Makefile
@@ -137,7 +137,7 @@ is
The preferred method of distribution of the oVirt guest tools installer
is to have it in an ISO image wrapped in an RPM. This allows to easily
share installer updates with multiple Windows guests.
This commits adds an 'iso' target to the Makefile which will generate
such an ISO which can then be co
From: Christophe Fergeau
Some magic as we want to ship a generated .spec file in addition to the
files from the git repository.
Change-Id: I90d905697aa4f9092c65810467cd88dc611ed003
Signed-off-by: Christophe Fergeau
---
Makefile | 4
1 file changed, 4 insertions(+)
diff --git a/Makefile b
>
> This is a reduced diff (removed the move)
>
> --- before.c 2015-11-19 13:04:55.376919069 +
> +++ after.c 2015-11-19 12:53:18.73217 +
> @@ -305,21 +305,21 @@
> return;
> }
>
> dcc->surface_client_created[surface_id] = FALSE;
> destroy = surface_destroy_
From: Marek Kasik
This patch adds SPICE_CLIENT_ERROR_AUTH_NEEDS_USERNAME error
for the case when authentication fails because of missing username.
This can happen when GSSAPI method is used.
https://bugs.freedesktop.org/show_bug.cgi?id=92994
---
src/spice-channel-priv.h | 3 ++-
src/spice-chan
When an authentication error occurs SPICE_CLIENT_ERROR_AUTH_NEEDS_PASSWORD or
SPICE_CLIENT_ERROR_AUTH_NEEDS_PASSWORD_AND_USERNAME is returned as a channel
error. But it can happen that only username is needed when you use e.g. GSSAPI.
It would be useful to have SPICE_CLIENT_ERROR_AUTH_NEEDS_USERN
Due to implementation details spice_return is by default fatal (program
is aborting). This is quite confusing but changing the current macros
would possibly break existing code.
Add not fatal (at least by default) macros. They use warning level
instead of critical.
This is also compatible with Glib
From: Marek Kasik
This patch adds SPICE_CLIENT_ERROR_AUTH_NEEDS_USERNAME error
for the case when authentication fails because of missing username.
This can happen when GSSAPI method is used.
https://bugs.freedesktop.org/show_bug.cgi?id=92994
---
src/spice-channel-priv.h | 3 ++-
src/spice-chan
When an authentication error occurs SPICE_CLIENT_ERROR_AUTH_NEEDS_PASSWORD or
SPICE_CLIENT_ERROR_AUTH_NEEDS_PASSWORD_AND_USERNAME is returned as a channel
error. But it can happen that only username is needed when you use e.g. GSSAPI.
It would be useful to have SPICE_CLIENT_ERROR_AUTH_NEEDS_USERN
Signed-off-by: Marc-André Lureau
Signed-off-by: Frediano Ziglio
---
server/dcc.c | 631 +++
server/dcc.h | 31 +++
server/display-channel.h | 4 +
server/red_parse_qxl.h | 6 +
server/red_worker.c | 678 +
Instead of moving glz_drawable_count to DisplayChannelClient
move to DisplayChannel. This make the statistics using that
field work again.
Frediano Ziglio (2):
worker: move glz_drawable_count to DisplayChannel
worker: move compress to dcc_compress_image()
server/dcc.c | 631 +
Signed-off-by: Frediano Ziglio
---
server/display-channel.h | 2 ++
server/red_worker.c | 13 ++---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/server/display-channel.h b/server/display-channel.h
index 69ceb3c..7f3949f 100644
--- a/server/display-channel.h
+++ b/s
Hey,
On Thu, Nov 19, 2015 at 03:13:35PM +0200, Yedidyah Bar David wrote:
> I find more comfortable this semi-pull-requests mode of operation
> instead of posting patches to the list. Please notify if you prefer me
> to also post, but please use git fetch as it's easier to keep commit
> hashes unch
>
> This is a reduced diff (removed the move)
>
> --- before.c 2015-11-19 13:04:55.376919069 +
> +++ after.c 2015-11-19 12:53:18.73217 +
> @@ -305,21 +305,21 @@
> return;
> }
>
> dcc->surface_client_created[surface_id] = FALSE;
> destroy = surface_destroy_
On 11/19/2015 01:01 PM, Frediano Ziglio wrote:
Due to implementation details spice_return is by default fatal (program
is aborting). This is quite confusing but changing the current macros
would possibly break existing code.
Add not fatal (at least by default) macros. They use warning level
inste
Hi all,
Following my previous patchset, Christphe revised my changes a bit and
put his suggestion in [1].
I am fine with this version, except for some minor changes to the spec
file patch to adapt it to the changes in the Makefile.
I find more comfortable this semi-pull-requests mode of operatio
This is a reduced diff (removed the move)
--- before.c2015-11-19 13:04:55.376919069 +
+++ after.c 2015-11-19 12:53:18.73217 +
@@ -305,21 +305,21 @@
return;
}
dcc->surface_client_created[surface_id] = FALSE;
destroy = surface_destroy_item_new(channel, s
>
> On Wed, Nov 18, 2015 at 10:45 PM, Jonathon Jongsma
> wrote:
> > From: Marc-André Lureau
> >
> > ---
> > Changes since v1:
> > - rebased to resolve conflicts due to removed "fixme: remove?" lines from
> >patch 01/18
> >
> > server/dcc.c | 631
>
> On Thu, Nov 19, 2015 at 12:16 PM, Frediano Ziglio wrote:
> >
> > ---
> > server/Makefile.am | 3 ++
> > server/dcc-encoders.c| 1 -
> > server/dcc-encoders.h| 1 +
> > server/dcc.c | 137
> > +++
> > server/dcc.h
>
> On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/display-channel.c | 31 +++
> > server/display-channel.h | 1 +
> > server/red_worker.c | 31 ---
> > 3 files changed, 32
> On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > Author:Marc-André Lureau
> > ---
> > server/dcc.c | 170 +
> > server/dcc.h | 33 +++
> > server/display-channel.h | 7 +-
> > server
On Thu, Nov 19, 2015 at 12:16 PM, Frediano Ziglio wrote:
>
> ---
> server/Makefile.am | 3 ++
> server/dcc-encoders.c| 1 -
> server/dcc-encoders.h| 1 +
> server/dcc.c | 137
> +++
> server/dcc.h | 134 +
Only libcacard.h should be included directly.
Signed-off-by: Marc-André Lureau
---
Makefile.am | 1 +
src/cac.h | 5 +
src/capcsc.h | 4
src/card_7816.c | 4
src/card_7816.h | 4
src/card_7816t.h | 4
src/eventt.h |
vscard_common.h uses glib G_BYTE_ORDER macros. Include glib.h in the
file, and thus move glib-2.0 as a Require package.
Signed-off-by: Marc-André Lureau
---
libcacard.pc.in | 3 ++-
src/vscard_common.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libcacard.pc.in b/lib
1 - 100 of 132 matches
Mail list logo
