On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/cursor-channel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> index aafc807..794dcf3 100644
> --- a/server/curs
On Wed, Nov 18, 2015 at 10:54 PM, Jonathon Jongsma wrote:
> Not much value in this change at the moment. Both versions will result in an
> abort by default. I think in this case, it's better to avoid the abort since
> this function has a way to indicate failure (by returning FALSE). So I'd
> sugg
On Wed, Nov 18, 2015 at 10:42 PM, Jonathon Jongsma wrote:
> From: Marc-André Lureau
>
> Author:Marc-André Lureau
> Signed-off-by: Jonathon Jongsma
> ---
>
> Changes since v1
>
> - Remove extra space in "# define"
> - remove commented-out "fixme: remove?" lines
>
> server/Makefile.am
Not much value in this change at the moment. Both versions will result in an
abort by default. I think in this case, it's better to avoid the abort since
this function has a way to indicate failure (by returning FALSE). So I'd suggest
converting this one to g_return_val_if_fail().
On Wed, 2015-1
From: Marc-André Lureau
---
Changes since v1:
- rebased to resolve conflicts due to removed "fixme: remove?" lines from
patch 01/18
server/dcc.c | 631 ++
server/dcc.h | 33 +++
server/display-channel.h | 4 +
server/red_par
From: Marc-André Lureau
Author:Marc-André Lureau
Signed-off-by: Jonathon Jongsma
---
Changes since v1
- Remove extra space in "# define"
- remove commented-out "fixme: remove?" lines
server/Makefile.am | 2 +
server/dcc-encoders.c| 428
s
On Wed, 2015-11-18 at 11:29 +0800, Jay.han wrote:
>
> According to vdagent fileXfer, it requires a
> VD_AGENT_FILE_XFER_STATUS_CANCELLED msg when user cancel a file transfer.
> Currently our code only send VD_AGENT_FILE_XFER_STATUS_ERROR,
> this will cause the vdagent lock the file until it resta
Hi,
It seems your message was sent with HTML formatting, I can't apply it to
the tree. Can you try re-sending it with git send-email? You can find
the configuration settings for gmail in git send-email --help page.
Regards, Eduardo.
On 11/18/2015 01:29 AM, Jay.han wrote:
>
> According to vdagen
>
> From: Marc-André Lureau
>
> ---
> server/dcc-encoders.c | 2 +-
> server/dcc-encoders.h | 4 ++--
> server/dcc.c | 6 +++---
> server/red_worker.c | 6 +++---
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
> inde
Reduced diff, see http://pastebin.com/qmXJJYnv
There is manual function inlining (which is fine).
The move of the defines to red_worker.h and stream.h are a bit odd.
Frediano
> >
> > From: Marc-André Lureau
> >
> > ---
> > server/Makefile.am | 2 +
> > server/dcc-encoders.c| 1
>
> From: Marc-André Lureau
>
> ---
> server/Makefile.am | 2 +
> server/dcc-encoders.c| 1 -
> server/dcc-encoders.h| 1 +
> server/dcc.c | 137
> +++
> server/dcc.h | 133 +
On Wed, 2015-11-18 at 09:57 -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote:
> > > Instead of using spice_critical() when an encoder cannot be created, use
> > > a warning so that the server doesn't abort.
> >
> > I haven't seen an abor
>
> This patchset supersedes last patchset.
>
> Changes:
> - rebased;
> - removed merged patches;
> - added some patches.
>
Forget, I added again some patches on assert. I think we have more clear idea.
Frediano
> Marc-André Lureau (18):
> worker: move encoders to dcc-encoders
> worker: r
From: Marc-André Lureau
---
server/dcc.c| 90
server/dcc.h| 2 ++
server/red_worker.c | 91 -
3 files changed, 92 insertions(+), 91 deletions(-)
diff --git a/server/dcc.c b/
From: Marc-André Lureau
---
server/red_worker.c | 14 ++
server/stream.c | 12
server/stream.h | 6 --
3 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index aab3c73..e31dd08 100644
--- a/server/red_w
From: Marc-André Lureau
---
server/dcc-encoders.c | 9 +
server/dcc-encoders.h | 1 +
server/red_worker.c | 12 +---
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index 385b6b6..6cdac9d 100644
--- a/server/dcc-e
From: Marc-André Lureau
---
server/dcc.c | 637 ++
server/dcc.h | 33 +++
server/display-channel.h | 4 +
server/red_parse_qxl.h | 6 +
server/red_worker.c | 700 ++-
5 files c
From: Marc-André Lureau
---
server/red_worker.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 0144124..fd68753 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -182,7 +182,7 @@ static voi
From: Marc-André Lureau
---
server/Makefile.am | 2 +
server/dcc-encoders.c| 1 -
server/dcc-encoders.h| 1 +
server/dcc.c | 137 +++
server/dcc.h | 133 +
server/d
From: Marc-André Lureau
---
server/dcc-encoders.c | 2 +-
server/dcc-encoders.h | 4 ++--
server/dcc.c | 6 +++---
server/red_worker.c | 6 +++---
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c
index 0a0997a..90d0ce0 100644
From: Marc-André Lureau
---
server/dcc-encoders.c| 55 ++
server/dcc-encoders.h| 7 +++--
server/display-channel.c | 22 +++
server/display-channel.h | 1 +
server/red_worker.c | 69
5
From: Marc-André Lureau
---
server/dcc-encoders.c | 47 +++
server/red_worker.c | 50 ++
server/red_worker.h | 3 +++
3 files changed, 52 insertions(+), 48 deletions(-)
diff --git a/server/dcc-encod
From: Marc-André Lureau
---
server/dcc-encoders.c| 17 +
server/dcc-encoders.h| 2 ++
server/display-channel.c | 12
server/display-channel.h | 1 +
server/red_worker.c | 27 +--
5 files changed, 33 insertions(+), 26 deletions(-
From: Marc-André Lureau
---
server/red_worker.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index e31dd08..30dcbce 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -176,8 +176,7 @@ typedef stru
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/dcc.c | 170 +
server/dcc.h | 33 +++
server/display-channel.h | 7 +-
server/red_worker.c | 237 ---
4 files changed,
From: Marc-André Lureau
---
server/display-channel.c | 11 +++
server/display-channel.h | 1 +
server/red_worker.c | 22 +++---
3 files changed, 15 insertions(+), 19 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 1702bd6..ce973c
From: Marc-André Lureau
---
server/dcc.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index bb6001e..8e25c67 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -343,7 +343,8 @@ static RedGlzDrawable
*get_glz_drawable(DisplayChannelCli
This patchset supersedes last patchset.
Changes:
- rebased;
- removed merged patches;
- added some patches.
Marc-André Lureau (18):
worker: move encoders to dcc-encoders
worker: remove current_add assert
worker: remove cursor channel asserts
worker: start a DisplayChannelClient unit
wor
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/Makefile.am | 2 +
server/dcc-encoders.c| 428
server/dcc-encoders.h| 153 +
server/display-channel.c | 6 +-
server/display-channel.h | 74 ++-
server/red_wor
From: Marc-André Lureau
---
server/cursor-channel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/cursor-channel.c b/server/cursor-channel.c
index aafc807..794dcf3 100644
--- a/server/cursor-channel.c
+++ b/server/cursor-channel.c
@@ -223,7 +223,7 @@ static voi
From: Marc-André Lureau
---
server/display-channel.c | 31 +++
server/display-channel.h | 1 +
server/red_worker.c | 31 ---
3 files changed, 32 insertions(+), 31 deletions(-)
diff --git a/server/display-channel.c b/server/display-ch
From: Marc-André Lureau
---
server/display-channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index d4fcc7e..aed2080 100644
--- a/server/display-channel.c
+++ b/server/display-channel.c
@@ -736,7 +736,7 @@ static int
On Wed, Nov 18, 2015 at 06:29:23PM +0300, Anton D. Kachalov wrote:
>
>
> 18.11.2015, 17:46, "Christophe Fergeau" :
> >>
> >> May be better to use memcpy? It is align-safe.
> >
> > Oh yeah could definitely work better, not very familiar with this kind of
> > problems
> > :)
>
> memcpy works lik
>
> This patchset supersedes last patchset.
>
> Changes:
> - rebased;
> - added "worker: move stream_agent_stop and friends" and
> merged with "Move dcc_create_stream to display channel";
> - merged "Add red_worker_get_clockid()" back;
> - added back some patches waiting for some author confirm
Author:Marc-André Lureau
---
server/Makefile.am | 2 +
server/dcc-encoders.c| 428
server/dcc-encoders.h| 153 +
server/display-channel.c | 6 +-
server/display-channel.h | 74 ++-
server/red_worker.c | 553 ++--
18.11.2015, 17:46, "Christophe Fergeau" :
>>
>> May be better to use memcpy? It is align-safe.
>
> Oh yeah could definitely work better, not very familiar with this kind of
> problems
> :)
memcpy works like a charm! Visually I don't see any performance regression on
our ARM SoC during video s
Hi,
On Wed, 2015-11-18 at 06:45 -0500, Frediano Ziglio wrote:
> >
> >
> > Signed-off-by: Marc-André Lureau
> > [updated for the preferred compression]
> > Signed-off-by: Pavel Grunt
> > ---
> > server/display-channel.c | 9 -
> > server/display-channel.h | 8 +++-
> > server/red
>
> Hi,
>
> On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote:
> > Instead of using spice_critical() when an encoder cannot be created, use
> > a warning so that the server doesn't abort.
>
> I haven't seen an abort because of it, and I think abort is correct,
> otherwise
> you may end u
>
> Ack,
>
> Pavel
Merged
Frediano
> On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote:
> > ---
> > server/red_worker.c | 22 +++---
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index 8e3be5
On Wed, Nov 18, 2015 at 05:29:32PM +0300, Anton D. Kachalov wrote:
> Hi.
>
> 18.11.2015, 17:06, "Christophe Fergeau" :
> > Hey,
> [...]
> > By 'alignment-safe', I mean:
> > static uint16_t read_uint16(unsigned uint16_t *ptr)
>
> Do you mean "uint8_t *ptr"?
>
> > {
> > return (ptr[1] << 8) ||
18.11.2015, 17:29, "Anton D. Kachalov" :
> Hi.
>
>
> struct {
> uint16_t foo;
> uint32_t bar;
> }
>
> What alignment would be on "bar" access (ptr address input for read_uint32)?
This might work:
uint32_t read_uint32(uint8_t *ptr) {
return ptr[3] << 24 | ... | ptr[0];
}
but question in
>
> Your solution is exactly what I had in mind. ACK
>
>
Merged
Frediano
>
>
> On Wed, 2015-11-18 at 06:16 -0500, Frediano Ziglio wrote:
> > Make sure an allocated buffer is correctly referenced by the marshaller,
> > and can't be free and reused by mistake. Simplify the code by using
> > G
Hi.
18.11.2015, 17:06, "Christophe Fergeau" :
> Hey,
[...]
> By 'alignment-safe', I mean:
> static uint16_t read_uint16(unsigned uint16_t *ptr)
Do you mean "uint8_t *ptr"?
> {
> return (ptr[1] << 8) || ptr[0];
> }
> (or a macro version of it)
Would compiler generate byte-access code? It sho
Your solution is exactly what I had in mind. ACK
On Wed, 2015-11-18 at 06:16 -0500, Frediano Ziglio wrote:
> Make sure an allocated buffer is correctly referenced by the marshaller,
> and can't be free and reused by mistake. Simplify the code by using
> GSlice
> ---
> server/display-channel.h
Hey,
On Wed, Nov 18, 2015 at 04:03:16PM +0300, Anton D. Kachalov wrote:
> Hello.
>
> consume_* in parse_msgc_display_init()
>
> and a number of:
>
> spice_marshaller_add_int32
> spice_marshaller_add_uint16
> spice_marshaller_add_uint64
> spice_marshaller_add_uint32
>
Ah right, these would cau
>
> From: Marc-André Lureau
>
> ---
> server/red_worker.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/server/red_worker.h b/server/red_worker.h
> index 4989448..3604dfd 100644
> --- a/server/red_worker.h
> +++ b/server/red_worker.h
> @@ -109,6 +109,7 @@ bool red_worker_run(R
>
> From: Marc-André Lureau
>
> ---
> server/red_worker.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/server/red_worker.h b/server/red_worker.h
> index 2995b8f..4989448 100644
> --- a/server/red_worker.h
> +++ b/server/red_worker.h
> @@ -22,6 +22,7 @@
> #include
> #include "red
>
> ---
> server/red_worker.c | 18 --
> 1 file changed, 18 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 4620273..dba18ee 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -7045,24 +7045,6 @@ static inline void red_push(RedWork
>
> From: Marc-André Lureau
>
> ---
> server/display-channel.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/display-channel.h b/server/display-channel.h
> index b86d652..b81dbe2 100644
> --- a/server/display-channel.h
> +++ b/server/display-channel.h
> @@
Hi,
On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote:
> From: Marc-André Lureau
>
> Author:Marc-André Lureau
> ---
> server/Makefile.am | 2 +
> server/dcc-encoders.c| 419
> server/dcc-encoders.h| 153 +
> server/d
Ack,
Pavel
On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote:
> ---
> server/red_worker.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 8e3be51..4f1d481 100644
> --- a/server/red_worker.
From: Marc-André Lureau
---
server/red_worker.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/red_worker.h b/server/red_worker.h
index 4989448..3604dfd 100644
--- a/server/red_worker.h
+++ b/server/red_worker.h
@@ -109,6 +109,7 @@ bool red_worker_run(RedWorker *worker);
QXLIn
From: Marc-André Lureau
---
server/display-channel.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/display-channel.h b/server/display-channel.h
index b86d652..b81dbe2 100644
--- a/server/display-channel.h
+++ b/server/display-channel.h
@@ -211,8 +211,8 @@ struct
Hi,
I split the patch (version from ),
so it contains changes neccessary for the "move".
Thanks,
Pavel
Marc-André Lureau (4):
worker: move surfaces to DisplayChannel
display-channel: Keep macro definition in one line
worker: Add #include "red_parse_qxl.h"
worker: Add declaration of red_w
From: Marc-André Lureau
---
server/red_worker.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/red_worker.h b/server/red_worker.h
index 2995b8f..4989448 100644
--- a/server/red_worker.h
+++ b/server/red_worker.h
@@ -22,6 +22,7 @@
#include
#include "red_common.h"
#include "red_dis
---
server/red_worker.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 4620273..dba18ee 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -7045,24 +7045,6 @@ static inline void red_push(RedWorker *worker)
}
}
Hello.
consume_* in parse_msgc_display_init()
and a number of:
spice_marshaller_add_int32
spice_marshaller_add_uint16
spice_marshaller_add_uint64
spice_marshaller_add_uint32
in marshallers' functions like spice_marshall_msg_display_draw_copy()
So, for the packed structs, there are always unali
>
>
> Signed-off-by: Marc-André Lureau
> [updated for the preferred compression]
> Signed-off-by: Pavel Grunt
> ---
> server/display-channel.c | 9 -
> server/display-channel.h | 8 +++-
> server/red_worker.c | 32
> 3 files changed, 31 inser
Signed-off-by: Marc-André Lureau
[updated for the preferred compression]
Signed-off-by: Pavel Grunt
---
server/display-channel.c | 9 -
server/display-channel.h | 8 +++-
server/red_worker.c | 32
3 files changed, 31 insertions(+), 18 deletion
Make sure an allocated buffer is correctly referenced by the marshaller,
and can't be free and reused by mistake. Simplify the code by using
GSlice
---
server/display-channel.h | 3 --
server/red_worker.c | 116 ---
2 files changed, 30 insertions
>
> On Tue, 2015-11-17 at 16:37 +, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > Make sure an allocated buffer is correctly referenced by the marshaller,
> > and can't be free and reused by mistake. Simplify the code by using
> > GSlice
> > ---
> > server/display-channel.h |
Hi,
On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote:
> Instead of using spice_critical() when an encoder cannot be created, use
> a warning so that the server doesn't abort.
I haven't seen an abort because of it, and I think abort is correct, otherwise
you may end up calling encode func
Hi Frediano,
On Tue, 2015-11-17 at 14:14 +, Frediano Ziglio wrote:
> Remove some nested blocks using else if.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red_worker.c | 34 +++---
> 1 file changed, 15 insertions(+), 19 deletions(-)
>
> diff --git a/server/
Hi Snir,
thank you for the patch, it looks good. I put some comments inline.
On Wed, 2015-11-11 at 12:45 +0200, Snir Sheriber wrote:
> When using multiple monitors moving mouse between monitors releases
> keyboard grab.
>
> Reproduce bug
> -Open multiple monitors remote-viewer session
> -Click o
64 matches
Mail list logo
