[Spice-devel] [NSIS 4/6] packaging: add Makefile

2015-11-11 Thread Yedidyah Bar David
Allow 'make dist'. Allow building the spice installer and building/installing the ovirt installer. Also allow building an iso image containing the installer and the files it includes. Move VERSION maintenance from the nsis file to the Makefile. Allow passing DISPLAYED_VERSION to make. Allow pa

[Spice-devel] [NSIS 5/6] packaging: add ovirt-guest-tools-iso.spec.in

2015-11-11 Thread Yedidyah Bar David
Copied and adapted from ovirt-wgt-toolchain. See [1] [2]. In order to not duplicate the source code's version in the spec file, generate it by make. [1] https://gerrit.ovirt.org/47432 [2] https://gerrit.ovirt.org/48425 Change-Id: Ie6dcb72da2fe13bb154784a27f1ee992e9d12b14 Signed-off-by: Yedidyah

[Spice-devel] [NSIS 2/6] nsis: Drop separately-packaged qxl drivers

2015-11-11 Thread Yedidyah Bar David
qxl drivers are now supplied inside virtio-win drivers package. Change-Id: Id8274f125ef7fa6b4fd76a7015958f24f2e358ea Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 1 - 1 file changed, 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 8b52e26..ef4cf07 10

[Spice-devel] [NSIS 3/6] Allow custom installer filename and displayed name version

2015-11-11 Thread Yedidyah Bar David
Allow passing: DISPLAYED_VERSION (defaults to $VERSION): what's written to the registry. This is what is shown to the user e.g. in the control panel. EXE_VERSION (defaults to -$VERSION): appended to installer filename. Not touching VERSION, which reflects the version of the installer's source co

[Spice-devel] [NSIS 6/6] packaging: add ovirt jenkins automation

2015-11-11 Thread Yedidyah Bar David
Add automation scripts/conf for ovirt jenkins. Run builds on push to gerrit and on merge there. Structure defined in [1]. [1] http://www.ovirt.org/CI/Build_and_test_standards Change-Id: I209ec032794575fe0231eb53cdf8d5e0cf978e5a Signed-off-by: Yedidyah Bar David --- automation/README.md

[Spice-devel] [NSIS 1/6] packaging: Re-enable NSIS branding for oVirt

2015-11-11 Thread Yedidyah Bar David
From: Lev Veyde change-id was I8692e636d42f127f953f578d86c7cbe8f2bcc06a renamed due to gerrit complications Change-Id: Idb20091a41e1cae7ac6df538ee17eec38a8a714a Signed-off-by: Lev Veyde --- win-guest-tools.nsis | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/win-guest-t

Re: [Spice-devel] [NSIS 2/2] packaging: add Makefile, spec file, jenkins automation

2015-11-11 Thread Yedidyah Bar David
On Thu, Nov 5, 2015 at 3:45 PM, Christophe Fergeau wrote: > Hey, > > Some comments on the Makefile/.spec files > > On Mon, Oct 26, 2015 at 12:35:29PM +0200, Yedidyah Bar David wrote: >> Allow 'make dist'. >> >> Allow building the spice installer and building/installing the ovirt >> installer. >> >

Re: [Spice-devel] [PATCH 14/16] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-11 Thread Jonathon Jongsma
On Wed, 2015-11-11 at 12:17 -0500, Frediano Ziglio wrote: > > > > On Wed, 2015-11-11 at 06:47 -0500, Frediano Ziglio wrote: > > > > > > > > Hmm, this code was fairly weird. It's still a bit weird that the > > > > 'more_space' > > > > vfunc for the quic encoder has different semantics than all of

Re: [Spice-devel] spice-server, logging and style

2015-11-11 Thread Uri Lublin
On 11/03/2015 05:11 PM, Christophe Fergeau wrote: Hey, On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote: Style: Personal considerations: - it seems some changes in patchset change "if (cond) return" code with spice_return_if_fail(cond). As stated before the macro are very mis

Re: [Spice-devel] [PATCH 05/11] worker: move compression parameters to dcc

2015-11-11 Thread Pavel Grunt
On Wed, 2015-11-11 at 15:10 +0100, Pavel Grunt wrote: > Hi Fabiano, > > On Wed, 2015-11-11 at 14:45 +0100, Fabiano Fidêncio wrote: > > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > > > From: Marc-André Lureau > > > > > > --- > > >  server/display-channel.c |  9 - > > >  serv

Re: [Spice-devel] [PATCH 05/11] worker: move compression parameters to dcc

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 5:40 PM, Jonathon Jongsma wrote: > On Wed, 2015-11-11 at 14:45 +0100, Fabiano Fidêncio wrote: >> On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: >> > From: Marc-André Lureau >> > >> > --- >> > server/display-channel.c | 9 - >> > server/display-channel.h

Re: [Spice-devel] [PATCH 06/11] worker: move some tree container functions

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 5:10 PM, Frediano Ziglio wrote: >> >> On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: >> > From: Marc-André Lureau >> > >> > --- >> > server/red_worker.c | 32 >> > server/tree.c | 27 +++ >> > server

Re: [Spice-devel] [PATCH 07/11] worker: rename a bit current_add functions

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 4:19 PM, Frediano Ziglio wrote: >> >> On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: >> > From: Marc-André Lureau >> > >> > --- >> > server/red_worker.c | 24 >> > 1 file changed, 12 insertions(+), 12 deletions(-) >> > >> > diff --git a/

Re: [Spice-devel] [PATCH 14/16] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-11 Thread Frediano Ziglio
> > On Wed, 2015-11-11 at 06:47 -0500, Frediano Ziglio wrote: > > > > > > Hmm, this code was fairly weird. It's still a bit weird that the > > > 'more_space' > > > vfunc for the quic encoder has different semantics than all of the rest > > > of > > > them > > > (returning the number of uint32_t e

Re: [Spice-devel] [PATCH 05/11] worker: move compression parameters to dcc

2015-11-11 Thread Jonathon Jongsma
On Wed, 2015-11-11 at 14:45 +0100, Fabiano Fidêncio wrote: > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/display-channel.c | 9 - > > server/display-channel.h | 8 +++- > > server/red_worker.c | 31 +++

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to change the preferred compression on the fly

2015-11-11 Thread Pavel Grunt
Hi, On Wed, 2015-11-11 at 09:48 +0100, Victor Toso wrote: > Hi, > > On Tue, Nov 10, 2015 at 05:44:05PM +0100, Pavel Grunt wrote: > > Hi, > > > > this series adds new public function for changing the preferred image > > compression. > > The new function is used in spicy under Option -> Preferred

Re: [Spice-devel] [PATCH 06/11] worker: move some tree container functions

2015-11-11 Thread Frediano Ziglio
> > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/red_worker.c | 32 > > server/tree.c | 27 +++ > > server/tree.h | 2 ++ > > 3 files changed, 33 insertions(+), 28

Re: [Spice-devel] [PATCH 14/16] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-11 Thread Jonathon Jongsma
On Wed, 2015-11-11 at 06:47 -0500, Frediano Ziglio wrote: > > > > Hmm, this code was fairly weird. It's still a bit weird that the > > 'more_space' > > vfunc for the quic encoder has different semantics than all of the rest of > > them > > (returning the number of uint32_t elements allocated inste

Re: [Spice-devel] [PATCH 00/11] Backported some patches from refactory branches (11th Nov)

2015-11-11 Thread Frediano Ziglio
> > This patchset supersedes last patchset. > > Changes: > - rebased; > - merged split work from Jonathon; > - removed merged patches; > - the "worker: fix compiling with COMPRESS_STAT enabled" is > a fix for "worker: fix some fields access" discussed > in the ML; > - added some patches. > >

Re: [Spice-devel] [PATCH 02/11] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

2015-11-11 Thread Frediano Ziglio
> > On Wed, Nov 11, 2015 at 2:10 PM, Fabiano Fidêncio > wrote: > > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio > > wrote: > >> From: Jonathon Jongsma > >> > >> --- > >> server/red_worker.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/server/red_worker.c b/server/red_wo

Re: [Spice-devel] [PATCH 07/11] worker: rename a bit current_add functions

2015-11-11 Thread Frediano Ziglio
> > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/red_worker.c | 24 > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > index e82317c..7c67

Re: [Spice-devel] [PATCH 10/11] worker: fix compiling with COMPRESS_STAT enabled

2015-11-11 Thread Frediano Ziglio
> > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > > server/display-channel.c | 2 +- > > server/red_worker.c | 18 +- > > server/stat.h| 6 +++--- > > 3 files changed, 13 insertions(+), 13 deletions(-) > >

Re: [Spice-devel] [PATCH 11/11] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.h | 3 +-- > server/red_worker.c | 18 +- > 2 files changed, 10 insertions(+), 11 deletions(-) > > diff --git a/server/display-channel.h b/server/display-chann

Re: [Spice-devel] [PATCH 11/11] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-11 Thread Pavel Grunt
Hi, On Wed, 2015-11-11 at 12:20 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- >  server/display-channel.h |  3 +-- >  server/red_worker.c  | 18 +- >  2 files changed, 10 insertions(+), 11 deletions(-) > > diff --git a/server/display-channel.h b/server/displ

Re: [Spice-devel] [PATCH 10/11] worker: fix compiling with COMPRESS_STAT enabled

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/display-channel.c | 2 +- > server/red_worker.c | 18 +- > server/stat.h| 6 +++--- > 3 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/ser

Re: [Spice-devel] [PATCH 09/11] worker: fix some fields access

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c > index 163f6b7..fbd8a0e 100644 > -

Re: [Spice-devel] [PATCH 07/11] worker: rename a bit current_add functions

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index e82317c..7c67e2e 100644 > --- a/se

Re: [Spice-devel] [PATCH 06/11] worker: move some tree container functions

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 32 > server/tree.c | 27 +++ > server/tree.h | 2 ++ > 3 files changed, 33 insertions(+), 28 deletions(-) > > d

Re: [Spice-devel] [PATCH 04/11] worker: remove cursor channel asserts

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 2:44 PM, Victor Toso wrote: > On Wed, Nov 11, 2015 at 02:18:34PM +0100, Fabiano Fidêncio wrote: >> On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: >> > From: Marc-André Lureau >> > >> > --- >> > server/cursor-channel.c | 6 +++--- >> > 1 file changed, 3 insertion

Re: [Spice-devel] [PATCH 05/11] worker: move compression parameters to dcc

2015-11-11 Thread Pavel Grunt
Hi Fabiano, On Wed, 2015-11-11 at 14:45 +0100, Fabiano Fidêncio wrote: > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > >  server/display-channel.c |  9 - > >  server/display-channel.h |  8 +++- > >  server/red_worker.c  | 31 ++

Re: [Spice-devel] [PATCH 05/11] worker: move compression parameters to dcc

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 9 - > server/display-channel.h | 8 +++- > server/red_worker.c | 31 +++ > 3 files changed, 30 insertions(+), 18 deletions(-) > >

Re: [Spice-devel] [PATCH 04/11] worker: remove cursor channel asserts

2015-11-11 Thread Victor Toso
On Wed, Nov 11, 2015 at 02:18:34PM +0100, Fabiano Fidêncio wrote: > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/cursor-channel.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/server/cursor-chann

Re: [Spice-devel] [PATCH 02/11] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 2:10 PM, Fabiano Fidêncio wrote: > On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: >> From: Jonathon Jongsma >> >> --- >> server/red_worker.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/server/red_worker.c b/server/red_worker.c >> index 4d430ad..3a

Re: [Spice-devel] [PATCH 4/5] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 2:09 PM, Pavel Grunt wrote: > On Wed, 2015-11-11 at 00:37 +0100, Fabiano Fidêncio wrote: >> On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma >> wrote: >> > --- >> > server/red_worker.c | 1 - >> > 1 file changed, 1 deletion(-) >> > >> > diff --git a/server/red_worker.c

Re: [Spice-devel] [PATCH 04/11] worker: remove cursor channel asserts

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/cursor-channel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/server/cursor-channel.c b/server/cursor-channel.c > index aafc807..794dcf3 100644 > --- a/server/curs

Re: [Spice-devel] [PATCH 02/11] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > From: Jonathon Jongsma > > --- > server/red_worker.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index 4d430ad..3a33596 100644 > --- a/server/red_worker.c > +++ b/server/red_worker.c

Re: [Spice-devel] [PATCH 01/11] worker: Move stream functions to stream.c

2015-11-11 Thread Fabiano Fidêncio
On Wed, Nov 11, 2015 at 1:20 PM, Frediano Ziglio wrote: > From: Jonathon Jongsma > > --- > server/display-channel.h | 17 +++- > server/red_worker.c | 103 > --- > server/stream.c | 70 > server/str

Re: [Spice-devel] [PATCH 4/5] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

2015-11-11 Thread Pavel Grunt
On Wed, 2015-11-11 at 00:37 +0100, Fabiano Fidêncio wrote: > On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma wrote: > > --- > >  server/red_worker.c | 1 - > >  1 file changed, 1 deletion(-) > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > index dd4633c..8a2ff0e 100644 > > ---

Re: [Spice-devel] [PATCH 2/5] worker: Move drawable utility functions to display channel

2015-11-11 Thread Frediano Ziglio
> > On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma > wrote: > > Functions that check the equality of a patch, brush, etc are moved the > > display channel source file to prepare for moving the surfaces to the > > display channel. > > "equality of a patch" -> "equality of a path" > > > --- >

Re: [Spice-devel] [PATCH 3/5] worker: Move is_opaque_item() to tree.h

2015-11-11 Thread Frediano Ziglio
> On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma > wrote: > > --- > > server/red_worker.c | 6 -- > > server/tree.h | 6 ++ > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > index a2ed49b..dd4633c 100644 > >

[Spice-devel] [PATCH 07/11] worker: rename a bit current_add functions

2015-11-11 Thread Frediano Ziglio
From: Marc-André Lureau --- server/red_worker.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index e82317c..7c67e2e 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1293,8 +1293,8 @@ static

[Spice-devel] [PATCH 06/11] worker: move some tree container functions

2015-11-11 Thread Frediano Ziglio
From: Marc-André Lureau --- server/red_worker.c | 32 server/tree.c | 27 +++ server/tree.h | 2 ++ 3 files changed, 33 insertions(+), 28 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 5cdb348..e823

[Spice-devel] [PATCH 10/11] worker: fix compiling with COMPRESS_STAT enabled

2015-11-11 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/display-channel.c | 2 +- server/red_worker.c | 18 +- server/stat.h| 6 +++--- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index fbd8a0e..824f601

[Spice-devel] [PATCH 11/11] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-11 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.h | 3 +-- server/red_worker.c | 18 +- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/server/display-channel.h b/server/display-channel.h index 12ef60a..599cce7 100644 --- a/server/display-channel.h +++ b

[Spice-devel] [PATCH 08/11] worker: move RED_WORKER_STAT, make it compile again

2015-11-11 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.h | 9 +- server/red_worker.c | 228 --- server/stat.h| 92 ++- 3 files changed, 158 insertions(+), 171 deletions(-) diff --git a/server/display-channel.h b/server/

[Spice-devel] [PATCH 09/11] worker: fix some fields access

2015-11-11 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 163f6b7..fbd8a0e 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -20,18 +2

[Spice-devel] [PATCH 05/11] worker: move compression parameters to dcc

2015-11-11 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.c | 9 - server/display-channel.h | 8 +++- server/red_worker.c | 31 +++ 3 files changed, 30 insertions(+), 18 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 5

[Spice-devel] [PATCH 00/11] Backported some patches from refactory branches (11th Nov)

2015-11-11 Thread Frediano Ziglio
This patchset supersedes last patchset. Changes: - rebased; - merged split work from Jonathon; - removed merged patches; - the "worker: fix compiling with COMPRESS_STAT enabled" is a fix for "worker: fix some fields access" discussed in the ML; - added some patches. Excluded "worker: simplify

[Spice-devel] [PATCH 04/11] worker: remove cursor channel asserts

2015-11-11 Thread Frediano Ziglio
From: Marc-André Lureau --- server/cursor-channel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index aafc807..794dcf3 100644 --- a/server/cursor-channel.c +++ b/server/cursor-channel.c @@ -223,7 +223,7 @@ static voi

[Spice-devel] [PATCH 02/11] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

2015-11-11 Thread Frediano Ziglio
From: Jonathon Jongsma --- server/red_worker.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 4d430ad..3a33596 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -75,7 +75,6 @@ #define CMD_RING_POLL_RETRIES 200 #define DISPLAY_CL

[Spice-devel] [PATCH 01/11] worker: Move stream functions to stream.c

2015-11-11 Thread Frediano Ziglio
From: Jonathon Jongsma --- server/display-channel.h | 17 +++- server/red_worker.c | 103 --- server/stream.c | 70 server/stream.h | 12 +- 4 files changed, 103 insertions(+), 99 delet

Re: [Spice-devel] [PATCH 1/2] vdagent: Allow disabling the server-side udscs support

2015-11-11 Thread Victor Toso
Hi, On Thu, Nov 05, 2015 at 07:21:38PM +0100, Francois Gouget wrote: > To do so define UDSCS_NO_SERVER. > This simplifies reuse in client-only scenarios that don't need peer > credential support for instance. > The patch also reorders the client and server code so the > implementation is not peppe

Re: [Spice-devel] [PATCH 14/16] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-11 Thread Frediano Ziglio
> > Hmm, this code was fairly weird. It's still a bit weird that the 'more_space' > vfunc for the quic encoder has different semantics than all of the rest of > them > (returning the number of uint32_t elements allocated instead of the number of > bytes allocated). But the code is slightly less co

Re: [Spice-devel] [PATCH 12/16] worker: remove cursor channel asserts

2015-11-11 Thread Frediano Ziglio
> > ACK > Did you took into considerations all old comments? Like http://lists.freedesktop.org/archives/spice-devel/2015-November/023366.html Actually was not acked or nacked but there were comments. Frediano > On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > > From: Marc-André Lu

Re: [Spice-devel] [usbredir v2 2/2] Fix various typos in usbredirfilter.h comments

2015-11-11 Thread Victor Toso
Both patches looks good to me. On Fri, Nov 06, 2015 at 03:15:00PM +0100, Christophe Fergeau wrote: > --- > Changes since v1: > - fix a few more typos pointed out by Eduardo > > usbredirparser/usbredirfilter.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/usbre

Re: [Spice-devel] [PATCH spice-gtk 1/4] gtk: add spice_main_request_mouse_mode()

2015-11-11 Thread Victor Toso
Hi, On Tue, Nov 10, 2015 at 03:49:32PM +0100, Victor Toso wrote: > Hi, > > On Tue, Nov 10, 2015 at 02:05:23PM +0100, Marc-André Lureau wrote: > > Hi > > > > On Tue, Nov 10, 2015 at 11:05 AM, Victor Toso wrote: > > > Hi, > > > > > > On Mon, Nov 09, 2015 at 03:02:07PM +0100, Marc-André Lureau wrote

Re: [Spice-devel] [PATCH 00/16] Backported some patches from refactory branches (10th Nov)

2015-11-11 Thread Frediano Ziglio
> > > > > > This patchset supersedes last patchset. > > > > > > Changes: > > > - rebased on new master; > > > - split "worker: move stream to display channel"; > > > - added a patch to rollback one commit mistake; > > > - removed merged patches. > > > > > > Christophe Fergeau (1): > > > worker

Re: [Spice-devel] [PATCH 06/16] worker: move DisplayChannel/DisplayChannelClient functions together

2015-11-11 Thread Frediano Ziglio
> > ACK > Merged (yesterday) Frediano > On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Signed-off-by: Frediano Ziglio > > --- > > server/red_worker.c | 327 ++ > > --

Re: [Spice-devel] [PATCH 10/16] worker: move drawable to display

2015-11-11 Thread Frediano Ziglio
> > On Tue, 2015-11-10 at 11:42 -0600, Jonathon Jongsma wrote: > > I'd like to propose splitting out the changes related to UpgradeItem since > > they're not really related. I'll post a split patch. > > > Hmm, nevermind. Now that I look at it again, the only 'unrelated' UpgradeItem > change is t

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to change the preferred compression on the fly

2015-11-11 Thread Victor Toso
Hi, On Tue, Nov 10, 2015 at 05:44:05PM +0100, Pavel Grunt wrote: > Hi, > > this series adds new public function for changing the preferred image > compression. > The new function is used in spicy under Option -> Preferred Image compression > > Pavel Grunt (2): > channel-display: Add spice_displ