Re: [Spice-devel] [PATCH 4/5] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

2015-11-10 Thread Fabiano Fidêncio
On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma wrote: > --- > server/red_worker.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index dd4633c..8a2ff0e 100644 > --- a/server/red_worker.c > +++ b/server/red_worker.c > @@ -75,7 +75,6 @@ > #de

Re: [Spice-devel] [PATCH 3/5] worker: Move is_opaque_item() to tree.h

2015-11-10 Thread Fabiano Fidêncio
On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma wrote: > --- > server/red_worker.c | 6 -- > server/tree.h | 6 ++ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index a2ed49b..dd4633c 100644 > --- a/server/red_worke

Re: [Spice-devel] [PATCH 2/5] worker: Move drawable utility functions to display channel

2015-11-10 Thread Fabiano Fidêncio
On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma wrote: > Functions that check the equality of a patch, brush, etc are moved the > display channel source file to prepare for moving the surfaces to the > display channel. "equality of a patch" -> "equality of a path" > --- > server/display-chann

Re: [Spice-devel] [PATCH 1/5] worker: Move stream functions to stream.c

2015-11-10 Thread Fabiano Fidêncio
On Tue, Nov 10, 2015 at 9:41 PM, Jonathon Jongsma wrote: > --- > server/display-channel.h | 17 +++- > server/red_worker.c | 103 > --- > server/stream.c | 70 > server/stream.h | 12 +-

Re: [Spice-devel] [PATCH 14/16] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-10 Thread Jonathon Jongsma
Hmm, this code was fairly weird. It's still a bit weird that the 'more_space' vfunc for the quic encoder has different semantics than all of the rest of them (returning the number of uint32_t elements allocated instead of the number of bytes allocated). But the code is slightly less confusing now.

Re: [Spice-devel] [PATCH 12/16] worker: remove cursor channel asserts

2015-11-10 Thread Jonathon Jongsma
ACK On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/cursor-channel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/server/cursor-channel.c b/server/cursor-channel.c > index aafc807..794dcf3 100644 > --- a/ser

[Spice-devel] [PATCH 0/5] Split patch 11/16

2015-11-10 Thread Jonathon Jongsma
This is a split version of the patch "worker: move surfaces". The last patch in the series is still quite large, but I don't think it would be easy or worthwhile to split it up much further. Jonathon Jongsma (4): worker: Move stream functions to stream.c worker: Move drawable utility functions

[Spice-devel] [PATCH 1/5] worker: Move stream functions to stream.c

2015-11-10 Thread Jonathon Jongsma
--- server/display-channel.h | 17 +++- server/red_worker.c | 103 --- server/stream.c | 70 server/stream.h | 12 +- 4 files changed, 103 insertions(+), 99 deletions(-) diff --git a/ser

[Spice-devel] [PATCH 4/5] worker: Remove duplicate DISPLAY_CLIENT_TIMEOUT define

2015-11-10 Thread Jonathon Jongsma
--- server/red_worker.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index dd4633c..8a2ff0e 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -75,7 +75,6 @@ #define CMD_RING_POLL_RETRIES 200 #define DISPLAY_CLIENT_SHORT_TIMEOUT 15

[Spice-devel] [PATCH 3/5] worker: Move is_opaque_item() to tree.h

2015-11-10 Thread Jonathon Jongsma
--- server/red_worker.c | 6 -- server/tree.h | 6 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index a2ed49b..dd4633c 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1389,12 +1389,6 @@ static void exclude_

[Spice-devel] [PATCH 2/5] worker: Move drawable utility functions to display channel

2015-11-10 Thread Jonathon Jongsma
Functions that check the equality of a patch, brush, etc are moved the display channel source file to prepare for moving the surfaces to the display channel. --- server/display-channel.h | 89 + server/red_worker.c | 95 ++---

Re: [Spice-devel] [PATCH 10/16] worker: move drawable to display

2015-11-10 Thread Jonathon Jongsma
On Tue, 2015-11-10 at 11:42 -0600, Jonathon Jongsma wrote: > I'd like to propose splitting out the changes related to UpgradeItem since > they're not really related. I'll post a split patch. Hmm, nevermind. Now that I look at it again, the only 'unrelated' UpgradeItem change is that release_upgra

Re: [Spice-devel] [PATCH 09/16] worker: move current to display

2015-11-10 Thread Frediano Ziglio
> > ACK > Merged Frediano > On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/display-channel.h | 3 +++ > > server/red_worker.c | 29 + > > 2 files changed, 20 insertions(+), 12 deletions(-) > > >

Re: [Spice-devel] [PATCH 00/16] Backported some patches from refactory branches (10th Nov)

2015-11-10 Thread Frediano Ziglio
> > > > This patchset supersedes last patchset. > > > > Changes: > > - rebased on new master; > > - split "worker: move stream to display channel"; > > - added a patch to rollback one commit mistake; > > - removed merged patches. > > > > Christophe Fergeau (1): > > worker: simplify RedCompress

Re: [Spice-devel] [PATCH 08/16] worker: move red_destroy_surface_item()

2015-11-10 Thread Frediano Ziglio
> > On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/display-channel.c | 36 ++ > > server/display-channel.h | 19 ++ > > server/red_worker.c | 50 +--

Re: [Spice-devel] [PATCH] worker: move stream to display channel

2015-11-10 Thread Frediano Ziglio
> Thanks, it maintains the existing behavior now. ACK. > Merged Frediano > > On Tue, 2015-11-10 at 17:11 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/display-channel.c | 44 > > server/display-channel.h | 22 +- > > server/red_worker.c | 563

Re: [Spice-devel] [PATCH 10/16] worker: move drawable to display

2015-11-10 Thread Jonathon Jongsma
I'd like to propose splitting out the changes related to UpgradeItem since they're not really related. I'll post a split patch. On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.h | 24 -- > server/red_worker.c |

Re: [Spice-devel] [PATCH] worker: move stream to display channel

2015-11-10 Thread Jonathon Jongsma
Thanks, it maintains the existing behavior now. ACK. On Tue, 2015-11-10 at 17:11 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 44 > server/display-channel.h | 22 +- > server/red_worker.c | 563 + >

[Spice-devel] [PATCH] worker: move stream to display channel

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.c | 44 server/display-channel.h | 22 +- server/red_worker.c | 563 +-- server/stream.c | 4 +- server/stream.h | 10 + 5 files changed, 323 insertions(+), 320 deletio

[Spice-devel] [PATCH spice-gtk 0/2] Allow to change the preferred compression on the fly

2015-11-10 Thread Pavel Grunt
Hi, this series adds new public function for changing the preferred image compression. The new function is used in spicy under Option -> Preferred Image compression Pavel Grunt (2): channel-display: Add spice_display_change_preferred_compression spicy: Add support for changing compression

[Spice-devel] [PATCH spice-gtk 2/2] spicy: Add support for changing compression

2015-11-10 Thread Pavel Grunt
--- src/spicy.c | 63 + 1 file changed, 63 insertions(+) diff --git a/src/spicy.c b/src/spicy.c index 4de56d9..67873ed 100644 --- a/src/spicy.c +++ b/src/spicy.c @@ -633,6 +633,9 @@ static const GtkActionEntry entries[] = { .nam

[Spice-devel] [PATCH spice-gtk 1/2] channel-display: Add spice_display_change_preferred_compression

2015-11-10 Thread Pavel Grunt
--- doc/reference/spice-gtk-sections.txt | 1 + src/channel-display.c| 41 ++-- src/channel-display.h| 1 + src/map-file | 1 + src/spice-glib-sym-file | 1 + 5 files changed, 38 insertions(+),

Re: [Spice-devel] [PATCH 09/16] worker: move current to display

2015-11-10 Thread Jonathon Jongsma
ACK On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.h | 3 +++ > server/red_worker.c | 29 + > 2 files changed, 20 insertions(+), 12 deletions(-) > > diff --git a/server/display-channel.h b/s

Re: [Spice-devel] [PATCH 08/16] worker: move red_destroy_surface_item()

2015-11-10 Thread Jonathon Jongsma
On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 36 ++ > server/display-channel.h | 19 ++ > server/red_worker.c | 50 +- > --

Re: [Spice-devel] [PATCH 05/16] worker: rename function that handle DisplayChannelClient

2015-11-10 Thread Frediano Ziglio
> > s/function/functions in the commit message > > On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Signed-off-by: Frediano Ziglio > > --- > > server/red_worker.c | 36 ++-- > > 1

Re: [Spice-devel] [PATCH 03/16] worker: move stream definitions to a new stream.h file

2015-11-10 Thread Frediano Ziglio
> > On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Signed-off-by: Frediano Ziglio > > --- > > server/Makefile.am | 1 + > > server/display-channel.h | 60 + > > server/red_worker.c

Re: [Spice-devel] [PATCH 04/16] worker: move stream functions to a new stream.c file

2015-11-10 Thread Frediano Ziglio
> > On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Signed-off-by: Frediano Ziglio > > --- > > server/Makefile.am | 1 + > > server/red_worker.c | 52 ++--- > > server/stream

Re: [Spice-devel] [PATCH 01/16] remove server/stream.h file added by mistake in previous commit

2015-11-10 Thread Frediano Ziglio
> > Ack. > Pavel Merged Frediano > On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > >  server/stream.h | 139 > >  - > > --- > >  1 file changed, 139 deletions(-) > >  delete mode 100644 s

Re: [Spice-devel] [PATCH 02/16] worker: fix RED_STREAM_TIMOUT macro spelling

2015-11-10 Thread Frediano Ziglio
> > On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Frediano Ziglio > > --- > > server/red_worker.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > inde

Re: [Spice-devel] [PATCH 00/16] Backported some patches from refactory branches (10th Nov)

2015-11-10 Thread Frediano Ziglio
> > This patchset supersedes last patchset. > > Changes: > - rebased on new master; > - split "worker: move stream to display channel"; > - added a patch to rollback one commit mistake; > - removed merged patches. > > Christophe Fergeau (1): > worker: simplify RedCompressBuf > > Frediano Zigl

Re: [Spice-devel] [PATCH 07/16] worker: move stream to display channel

2015-11-10 Thread Jonathon Jongsma
Still has the same logic issue mentioned in the previous review and a couple of comments that refer to the old function name. comments inline. On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 44 > server/display-cha

Re: [Spice-devel] [PATCH 05/16] worker: rename function that handle DisplayChannelClient

2015-11-10 Thread Fabiano Fidêncio
s/function/functions in the commit message On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- > server/red_worker.c | 36 ++-- > 1 file changed, 18 insert

Re: [Spice-devel] [PATCH 06/16] worker: move DisplayChannel/DisplayChannelClient functions together

2015-11-10 Thread Jonathon Jongsma
ACK On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- > server/red_worker.c | 327 ++ > -- > 1 file changed, 164 insertions(+), 163 del

Re: [Spice-devel] [PATCH 04/16] worker: move stream functions to a new stream.c file

2015-11-10 Thread Fabiano Fidêncio
On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- > server/Makefile.am | 1 + > server/red_worker.c | 52 ++--- > server/stream.c | 66 > ++

Re: [Spice-devel] [PATCH 04/16] worker: move stream functions to a new stream.c file

2015-11-10 Thread Jonathon Jongsma
ACK On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- > server/Makefile.am | 1 + > server/red_worker.c | 52 ++--- > server/stream.c | 66 >

Re: [Spice-devel] [PATCH 05/16] worker: rename function that handle DisplayChannelClient

2015-11-10 Thread Jonathon Jongsma
ACK On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- > server/red_worker.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) > > diff -

Re: [Spice-devel] [PATCH 03/16] worker: move stream definitions to a new stream.h file

2015-11-10 Thread Fabiano Fidêncio
On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- > server/Makefile.am | 1 + > server/display-channel.h | 60 + > server/red_worker.c | 45 +--

Re: [Spice-devel] [PATCH 02/16] worker: fix RED_STREAM_TIMOUT macro spelling

2015-11-10 Thread Fabiano Fidêncio
On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Frediano Ziglio > --- > server/red_worker.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index 6138781..d73d616 1006

Re: [Spice-devel] [PATCH 01/16] remove server/stream.h file added by mistake in previous commit

2015-11-10 Thread Pavel Grunt
Ack. Pavel On Tue, 2015-11-10 at 14:16 +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/stream.h | 139 - > --- >  1 file changed, 139 deletions(-) >  delete mode 100644 server/stream.h > > diff --git a/server/stream

Re: [Spice-devel] [PATCH spice-server] worker: remove compression parameters

2015-11-10 Thread Pavel Grunt
Hi Frediano, On Tue, 2015-11-10 at 09:28 -0500, Frediano Ziglio wrote: > > > > --- > >  server/red_worker.c | 20 > >  1 file changed, 8 insertions(+), 12 deletions(-) > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > index 111f8ba..85e0ebd 100644 > > --- a/s

Re: [Spice-devel] [ovirt-users] console viewing failure after moving engine from CO6 to CO7

2015-11-10 Thread David Jaša
Hi, On Pá, 2015-11-06 at 19:53 +, Weber, Charles (NIH/NIA/IRP) [E] wrote: > Hi everyone, > I have been moving production Ovirt cluster 4 host+1 engine+FC storage > from CentOS 6 to CentOS 7. > I created new cluster with CO7 nodes and did the usual transition > without any major issues. > This

Re: [Spice-devel] [PATCH spice-gtk 1/4] gtk: add spice_main_request_mouse_mode()

2015-11-10 Thread Victor Toso
Hi, On Tue, Nov 10, 2015 at 02:05:23PM +0100, Marc-André Lureau wrote: > Hi > > On Tue, Nov 10, 2015 at 11:05 AM, Victor Toso wrote: > > Hi, > > > > On Mon, Nov 09, 2015 at 03:02:07PM +0100, Marc-André Lureau wrote: > >> Send a SpiceMsgcMainMouseModeRequest message to request a mouse mode. > >> >

Re: [Spice-devel] [PATCH 15/16] worker: simplify RedCompressBuf

2015-11-10 Thread Frediano Ziglio
> > Hi > > On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > > From: Christophe Fergeau > > > > Make sure an allocated buffer is correctly referenced by the marshaller, > > and can't be free and reused by mistake. Simplify the code by using > > GSlice > > Please wait until Christophe c

Re: [Spice-devel] [PATCH 15/16] worker: simplify RedCompressBuf

2015-11-10 Thread Marc-André Lureau
Hi On Tue, Nov 10, 2015 at 3:16 PM, Frediano Ziglio wrote: > From: Christophe Fergeau > > Make sure an allocated buffer is correctly referenced by the marshaller, > and can't be free and reused by mistake. Simplify the code by using > GSlice Please wait until Christophe confirm he wrote this pa

Re: [Spice-devel] [PATCH spice-server] worker: remove compression parameters

2015-11-10 Thread Frediano Ziglio
> > --- > server/red_worker.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index 111f8ba..85e0ebd 100644 > --- a/server/red_worker.c > +++ b/server/red_worker.c > @@ -323,10 +323,6 @@ typedef struct Red

[Spice-devel] [PATCH 02/16] worker: fix RED_STREAM_TIMOUT macro spelling

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/red_worker.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 6138781..d73d616 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -82,7 +82,7 @@

[Spice-devel] [PATCH 08/16] worker: move red_destroy_surface_item()

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.c | 36 ++ server/display-channel.h | 19 ++ server/red_worker.c | 50 +--- 3 files changed, 56 insertions(+), 49 deletions(-) diff --git a/server/

[Spice-devel] [PATCH 15/16] worker: simplify RedCompressBuf

2015-11-10 Thread Frediano Ziglio
From: Christophe Fergeau Make sure an allocated buffer is correctly referenced by the marshaller, and can't be free and reused by mistake. Simplify the code by using GSlice --- server/display-channel.h | 3 -- server/red_worker.c | 117 --- 2 fi

[Spice-devel] [PATCH 14/16] worker: don't use weird RedCompressedBuf nbytes shifting

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.h | 3 +-- server/red_worker.c | 18 +- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/server/display-channel.h b/server/display-channel.h index 7c62a62..f1f4e3a 100644 --- a/server/display-channel.h +++ b

[Spice-devel] [PATCH 13/16] worker: move compression parameters to dcc

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.c | 9 - server/display-channel.h | 8 +++- server/red_worker.c | 31 +++ 3 files changed, 30 insertions(+), 18 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 5

[Spice-devel] [PATCH 06/16] worker: move DisplayChannel/DisplayChannelClient functions together

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/red_worker.c | 327 ++-- 1 file changed, 164 insertions(+), 163 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 816938c.

[Spice-devel] [PATCH 10/16] worker: move drawable to display

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.h | 24 -- server/red_worker.c | 118 ++- 2 files changed, 74 insertions(+), 68 deletions(-) diff --git a/server/display-channel.h b/server/display-channel.h index 898ff01..1566c21 10064

[Spice-devel] [PATCH 01/16] remove server/stream.h file added by mistake in previous commit

2015-11-10 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/stream.h | 139 1 file changed, 139 deletions(-) delete mode 100644 server/stream.h diff --git a/server/stream.h b/server/stream.h deleted file mode 100644 index 5500414..000 --- a/server/stre

[Spice-devel] [PATCH 04/16] worker: move stream functions to a new stream.c file

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/Makefile.am | 1 + server/red_worker.c | 52 ++--- server/stream.c | 66 + server/stream.h | 5 +

[Spice-devel] [PATCH 16/16] worker: move encoders to dcc-encoders

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau Author:Marc-André Lureau --- server/Makefile.am | 2 + server/dcc-encoders.c| 402 ++ server/dcc-encoders.h| 145 + server/display-channel.c | 6 +- server/display-channel.h | 66 ++ server/red_worker

[Spice-devel] [PATCH 07/16] worker: move stream to display channel

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.c | 44 server/display-channel.h | 22 +- server/red_worker.c | 557 +-- server/stream.c | 4 +- 4 files changed, 315 insertions(+), 312 deletions(-) diff --git a/server/display

[Spice-devel] [PATCH 03/16] worker: move stream definitions to a new stream.h file

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/Makefile.am | 1 + server/display-channel.h | 60 + server/red_worker.c | 45 +--- server/stream.h | 132 ++

[Spice-devel] [PATCH 09/16] worker: move current to display

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau --- server/display-channel.h | 3 +++ server/red_worker.c | 29 + 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/server/display-channel.h b/server/display-channel.h index 76e4d11..898ff01 100644 --- a/server/display-chan

[Spice-devel] [PATCH 05/16] worker: rename function that handle DisplayChannelClient

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/red_worker.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index f855765..816938c 100644 ---

[Spice-devel] [PATCH 00/16] Backported some patches from refactory branches (10th Nov)

2015-11-10 Thread Frediano Ziglio
This patchset supersedes last patchset. Changes: - rebased on new master; - split "worker: move stream to display channel"; - added a patch to rollback one commit mistake; - removed merged patches. Christophe Fergeau (1): worker: simplify RedCompressBuf Frediano Ziglio (1): remove server/str

[Spice-devel] [PATCH 12/16] worker: remove cursor channel asserts

2015-11-10 Thread Frediano Ziglio
From: Marc-André Lureau --- server/cursor-channel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index aafc807..794dcf3 100644 --- a/server/cursor-channel.c +++ b/server/cursor-channel.c @@ -223,7 +223,7 @@ static voi

Re: [Spice-devel] [PATCH 03/15] worker: move image cache to display

2015-11-10 Thread Uri Lublin
On 11/10/2015 12:58 PM, Frediano Ziglio wrote: I didn't understand what I did wrong but looks like when I pushed this patch it contained a new server/stream.h file from another patch... Hi Frediano, I was looking into that patch too. I think it has to come after the first patch "[PATCH 01/15

Re: [Spice-devel] [PATCH spice-gtk 1/4] gtk: add spice_main_request_mouse_mode()

2015-11-10 Thread Marc-André Lureau
Hi On Tue, Nov 10, 2015 at 11:05 AM, Victor Toso wrote: > Hi, > > On Mon, Nov 09, 2015 at 03:02:07PM +0100, Marc-André Lureau wrote: >> Send a SpiceMsgcMainMouseModeRequest message to request a mouse mode. >> >> This allows to switch between client/absolute and server/relative mouse >> modes. >>

Re: [Spice-devel] [PATCH spice-gtk] do not export symbol of non-existent function

2015-11-10 Thread Eduardo Lima (Etrunko)
On 11/10/2015 10:32 AM, Pavel Grunt wrote: > --- > src/map-file| 1 - > src/spice-glib-sym-file | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/map-file b/src/map-file > index 92a9883..786bbbf 100644 > --- a/src/map-file > +++ b/src/map-file > @@ -35,7 +35,6 @@ spice_dis

Re: [Spice-devel] [PATCH spice-gtk] do not export symbol of non-existent function

2015-11-10 Thread Fabiano Fidêncio
On Tue, Nov 10, 2015 at 1:32 PM, Pavel Grunt wrote: > --- > src/map-file| 1 - > src/spice-glib-sym-file | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/src/map-file b/src/map-file > index 92a9883..786bbbf 100644 > --- a/src/map-file > +++ b/src/map-file > @@ -35,7 +35,6 @@

[Spice-devel] [PATCH spice-gtk] do not export symbol of non-existent function

2015-11-10 Thread Pavel Grunt
--- src/map-file| 1 - src/spice-glib-sym-file | 1 - 2 files changed, 2 deletions(-) diff --git a/src/map-file b/src/map-file index 92a9883..786bbbf 100644 --- a/src/map-file +++ b/src/map-file @@ -35,7 +35,6 @@ spice_display_send_keys; spice_display_set_grab_keys; spice_file_trans

Re: [Spice-devel] [PATCH spice-gtk 2/4] main: do not always request client mouse mode

2015-11-10 Thread Marc-André Lureau
On Mon, Nov 9, 2015 at 3:02 PM, Marc-André Lureau wrote: > out = spice_msg_out_new(SPICE_CHANNEL(channel), > SPICE_MSGC_MAIN_MOUSE_MODE_REQUEST); > out->marshallers->msgc_main_mouse_mode_request(out->marshaller, &req); > spice_msg_out_send(out); > @@ -1648,20 +1654,11 @@ static voi

Re: [Spice-devel] [PATCH 03/10] worker: move stream to display channel

2015-11-10 Thread Frediano Ziglio
> NACK > > There's a lot of stuff going on in this patch, but I think it would > be hard to split out (other than a few minor include changes I noted > below). So I'm OK with that part. But there seems to be one behavior > change that I've noted below. > > Agree that code change (if stream one)

Re: [Spice-devel] [PATCH 03/15] worker: move image cache to display

2015-11-10 Thread Frediano Ziglio
I didn't understand what I did wrong but looks like when I pushed this patch it contained a new server/stream.h file from another patch... Should I revert this file change (with a new commit) and merge again on proper patch? Frediano > > > > From: Marc-André Lureau > > > > --- > > server/d

Re: [Spice-devel] [client 04/11] build-sys: Remove some dead configure.ac DBus code

2015-11-10 Thread Frediano Ziglio
> > On Tue, 3 Nov 2015, Francois Gouget wrote: > > > Signed-off-by: Francois Gouget > > --- > > configure.ac | 4 > > 1 file changed, 4 deletions(-) > > > > This patch does not depend on any other patch in this series. > > Anything blocking this? > (there must be a curse...) > Was alre

Re: [Spice-devel] [PATCH spice-gtk 4/4] build-sys: remove xrandr

2015-11-10 Thread Victor Toso
Hi, On Mon, Nov 09, 2015 at 03:02:10PM +0100, Marc-André Lureau wrote: > Not needed anymore (probably since gnome-rr was removed in 30986505b) > > Signed-off-by: Marc-André Lureau Thanks for the commit reference. Looks good, ack. > --- > configure.ac| 5 - > src/Makefile.am | 3 --- >

Re: [Spice-devel] [PATCH spice-gtk 1/4] gtk: add spice_main_request_mouse_mode()

2015-11-10 Thread Victor Toso
Hi, On Mon, Nov 09, 2015 at 03:02:07PM +0100, Marc-André Lureau wrote: > Send a SpiceMsgcMainMouseModeRequest message to request a mouse mode. > > This allows to switch between client/absolute and server/relative mouse > modes. > > This is necessary for some applications that require pointer > re-

Re: [Spice-devel] [PATCH 03/15] worker: move image cache to display

2015-11-10 Thread Frediano Ziglio
> > From: Marc-André Lureau > > --- > server/display-channel.h | 2 + > server/red_worker.c| 119 > + > server/spice_image_cache.c | 60 +++ > server/spice_image_cache.h | 19 ++-- > server/stream.h|

Re: [Spice-devel] [PATCH 10/15] worker s/surfaces_dest/surface_deps

2015-11-10 Thread Frediano Ziglio
> > On Mon, 2015-11-09 at 10:36 -0500, Frediano Ziglio wrote: > > > > > > From: Marc-André Lureau > > > > > > --- > > > server/display-channel.h | 2 +- > > > server/red_parse_qxl.c | 10 +- > > > server/red_parse_qxl.h | 2 +- > > > server/red_worker.c | 32

Re: [Spice-devel] [client 04/11] build-sys: Remove some dead configure.ac DBus code

2015-11-10 Thread Francois Gouget
On Tue, 3 Nov 2015, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > configure.ac | 4 > 1 file changed, 4 deletions(-) > > This patch does not depend on any other patch in this series. Anything blocking this? (there must be a curse...) > diff --git a/configure.ac b/confi

Re: [Spice-devel] [common 01/11] build-sys: Add the SPICE_WARNING() and SPICE_PRINT_MESSAGES m4 macros

2015-11-10 Thread Francois Gouget
On Tue, 3 Nov 2015, Francois Gouget wrote: > A call to SPICE_WARNING() anywhere in the configure file results in the > warning being printed at the end of the configure run where it will be > be visible. This makes it possible to keep the SPICE_WARNING() calls > together with the related feature c

Re: [Spice-devel] [common 03/11] build-sys: Add SPICE_CHECK_GSTREAMER_ELEMENTS()

2015-11-10 Thread Francois Gouget
On Wed, 4 Nov 2015, Christophe Fergeau wrote: [...] > > +AC_DEFUN([SPICE_CHECK_GSTREAMER_ELEMENTS], [ > > +AS_IF([test "x$1" != x], > > + [missing="" > > + for element in $3 > > + do > > + AS_VAR_PUSHDEF([cache_var],[spice_cv_prog_${1}_${element}])dnl > > + AC_C

Re: [Spice-devel] [spice 10/11] build-sys: Use AC_MSG_NOTICE()

2015-11-10 Thread Francois Gouget
On Tue, 3 Nov 2015, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > configure.ac | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) > > This patch is independent from all other patches in this series. Is anything blocking this patch? > diff --git a/confi

[Spice-devel] [PATCH spice-server] worker: remove compression parameters

2015-11-10 Thread Pavel Grunt
--- server/red_worker.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 111f8ba..85e0ebd 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -323,10 +323,6 @@ typedef struct RedWorker { RedMe