Hi,
On Mon, Nov 09, 2015 at 03:25:16PM -0500, Marc-André Lureau wrote:
> - Original Message -
> > On Mon, Nov 09, 2015 at 01:34:50PM -0600, Jonathon Jongsma wrote:
> > > On Mon, 2015-11-09 at 12:25 -0500, Marc-André Lureau wrote:
> > > >
> > > > - Original Message -
> > > > > >
>
- Original Message -
> On Mon, Nov 09, 2015 at 01:34:50PM -0600, Jonathon Jongsma wrote:
> > On Mon, 2015-11-09 at 12:25 -0500, Marc-André Lureau wrote:
> > >
> > > - Original Message -
> > > > >
> > > > > From: Marc-André Lureau
> > > > >
> > > > > ---
> > > > > server/curso
On Mon, Nov 09, 2015 at 01:34:50PM -0600, Jonathon Jongsma wrote:
> On Mon, 2015-11-09 at 12:25 -0500, Marc-André Lureau wrote:
> >
> > - Original Message -
> > > >
> > > > From: Marc-André Lureau
> > > >
> > > > ---
> > > > server/cursor-channel.c | 6 +++---
> > > > server/red_worker
On Mon, 2015-11-09 at 12:25 -0500, Marc-André Lureau wrote:
>
> - Original Message -
> > >
> > > From: Marc-André Lureau
> > >
> > > ---
> > > server/cursor-channel.c | 6 +++---
> > > server/red_worker.c | 2 --
> > > 2 files changed, 3 insertions(+), 5 deletions(-)
> > >
> > > d
On Mon, 2015-11-09 at 10:36 -0500, Frediano Ziglio wrote:
> >
> > From: Marc-André Lureau
> >
> > ---
> > server/display-channel.h | 2 +-
> > server/red_parse_qxl.c | 10 +-
> > server/red_parse_qxl.h | 2 +-
> > server/red_worker.c | 32
> >
On Mon, 2015-11-09 at 15:10 -0200, Eduardo Lima (Etrunko) wrote:
> On 11/06/2015 12:14 PM, Pavel Grunt wrote:
> > Hi,
> >
> > make syntax-check was failing, I am sending fixes.
> >
> > Thanks,
> >
> > Pavel Grunt (2):
> > red_dispatcher: Remove unused signal.h include
> > syntax-check: Add m
On Mon, 2015-11-09 at 11:01 -0600, Jonathon Jongsma wrote:
> On Fri, 2015-11-06 at 15:14 +0100, Pavel Grunt wrote:
> > Hi,
> >
> > make syntax-check was failing, I am sending fixes.
> >
> > Thanks,
> >
> > Pavel Grunt (2):
> > red_dispatcher: Remove unused signal.h include
> > syntax-check:
On Mon, 2015-11-09 at 13:15 +, Frediano Ziglio wrote:
> This patchset supersed last patchset.
>
> Changes:
> - rebased on new master;
> - dropper "server/red_worker: red_draw_qxl_drawable: protect from
> NULL dereference in case of buggy driver (or recording)" patch;
> - updated "worker: mov
- Original Message -
> >
> > From: Marc-André Lureau
> >
> > ---
> > server/display-channel.h | 3 +--
> > server/red_worker.c | 18 +-
> > 2 files changed, 10 insertions(+), 11 deletions(-)
> >
> > diff --git a/server/display-channel.h b/server/display-channel.
- Original Message -
> >
> > From: Marc-André Lureau
> >
> > ---
> > server/cursor-channel.c | 6 +++---
> > server/red_worker.c | 2 --
> > 2 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> > index 6d648b1..
On 11/06/2015 12:14 PM, Pavel Grunt wrote:
> Hi,
>
> make syntax-check was failing, I am sending fixes.
>
> Thanks,
>
> Pavel Grunt (2):
> red_dispatcher: Remove unused signal.h include
> syntax-check: Add missing #include
>
> server/cache_item.tmpl.c | 4
> server/cursor-chann
On 11/05/2015 07:37 PM, Jonathon Jongsma wrote:
>>> g_file_read_async(files[i],
>>>G_PRIORITY_DEFAULT,
>>>cancellable,
>>>file_xfer_read_async_cb,
>>> - task);
>>> +
On Fri, 2015-11-06 at 15:14 +0100, Pavel Grunt wrote:
> Hi,
>
> make syntax-check was failing, I am sending fixes.
>
> Thanks,
>
> Pavel Grunt (2):
> red_dispatcher: Remove unused signal.h include
> syntax-check: Add missing #include
>
> server/cache_item.tmpl.c | 4
> server/c
We will put auto session related items in that directory.
Signed-off-by: Jeremy White
---
scripts/Xspice | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 7414721..5941f4f 100755
--- a/scripts/Xspice
+++ b/scripts/Xspic
Signed-off-by: Jeremy White
---
Changes since v1:
- Use a temporary directory, not merely extending the name of
a single temporary file.
---
scripts/Xspice | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 59
>
> From: Marc-André Lureau
>
> ---
> server/cursor-channel.c | 6 +++---
> server/red_worker.c | 2 --
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> index 6d648b1..fc3a057 100644
> --- a/server/cursor-channel.c
> ++
>
> From: Marc-André Lureau
>
> ---
> server/display-channel.h | 2 +-
> server/red_parse_qxl.c | 10 +-
> server/red_parse_qxl.h | 2 +-
> server/red_worker.c | 32
> 4 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/server
>
> From: Marc-André Lureau
>
> ---
> server/display-channel.h | 3 +--
> server/red_worker.c | 18 +-
> 2 files changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/server/display-channel.h b/server/display-channel.h
> index 7c62a62..f1f4e3a 100644
> --- a/server/
>
> On Mon, 2015-11-09 at 09:14 -0500, Frediano Ziglio wrote:
> > >
> > > Looks good, but I would split it to:
> > > worker: make more functions static
> > > worker: remove unused function
> > >
> > > Pavel
> > >
> >
> > Giving that the warning from unused should be an error due to -Werror and
>
> On Mon, 2015-11-09 at 13:16 +, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 18 +-
> > 1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index 6becc56..640dff5 1
> This patchset supersed last patchset.
>
> Changes:
> - rebased on new master;
> - dropper "server/red_worker: red_draw_qxl_drawable: protect from
> NULL dereference in case of buggy driver (or recording)" patch;
> - updated "worker: move red_destroy_surface_item()" checking
> for dcc NULL be
On Mon, 2015-11-09 at 09:14 -0500, Frediano Ziglio wrote:
> >
> > Looks good, but I would split it to:
> > worker: make more functions static
> > worker: remove unused function
> >
> > Pavel
> >
>
> Giving that the warning from unused should be an error due to -Werror and
> the commit should no
Hi
- Original Message -
> >
> > On Mon, Nov 9, 2015 at 3:03 PM, Frediano Ziglio wrote:
> > > No, it's from Chiristophe
> >
> > ah?
> >
> > http://cgit.freedesktop.org/~alon/spice/commit/?h=wip/replay&id=1531f5935dfdc6e54b6fc8c99676869c1c0f808d
> >
>
> That's weird
>
> http://cgit.fr
>
> Looks good, but I would split it to:
> worker: make more functions static
> worker: remove unused function
>
> Pavel
>
Giving that the warning from unused should be an error due to -Werror and
the commit should not compile probably the order of the patch should be
worker: remove unused fun
Hi,
it is keeping the compression parameters in the RedWorker structure.
I think they should be removed from the structure and only used from dcc.
Pavel
On Mon, 2015-11-09 at 13:16 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/display-channel.c | 9 -
> serv
>
> On Mon, Nov 9, 2015 at 3:03 PM, Frediano Ziglio wrote:
> > No, it's from Chiristophe
>
> ah?
>
> http://cgit.freedesktop.org/~alon/spice/commit/?h=wip/replay&id=1531f5935dfdc6e54b6fc8c99676869c1c0f808d
>
That's weird
http://cgit.freedesktop.org/~fziglio/spice-server/commit/?h=refactory&i
On Mon, Nov 9, 2015 at 3:03 PM, Frediano Ziglio wrote:
> No, it's from Chiristophe
ah?
http://cgit.freedesktop.org/~alon/spice/commit/?h=wip/replay&id=1531f5935dfdc6e54b6fc8c99676869c1c0f808d
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-de
>
> hi
>
> Although I don't remember writing this, it seems git history attributes this
> to me. I guess a "based on initial patch from" could be useful some day.
>
No, it's from Chiristophe
Frediano
>
> - Original Message -
> > From: Christophe Fergeau
> >
> > Make sure an allocat
Whenever the mouse mode changed on the server, spice-gtk was requesting
client mode. Instead keep the last requested mode and request it
whenever it's possible.
Signed-off-by: Marc-André Lureau
---
src/channel-main.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
This is just for testing, the UI could be different in better clients.
Signed-off-by: Marc-André Lureau
---
src/spicy.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/spicy.c b/src/spicy.c
index 4de56d9..a5e974b 100644
--- a/src/spicy.c
+++ b/src/spicy.c
@@ -356,
Send a SpiceMsgcMainMouseModeRequest message to request a mouse mode.
This allows to switch between client/absolute and server/relative mouse
modes.
This is necessary for some applications that require pointer
re-positioning, which we can't provide through a remote protocol easily
with client poi
Not needed anymore (probably since gnome-rr was removed in 30986505b)
Signed-off-by: Marc-André Lureau
---
configure.ac| 5 -
src/Makefile.am | 3 ---
2 files changed, 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index 5790a37..2e23c90 100644
--- a/configure.ac
+++ b/configur
hi
Although I don't remember writing this, it seems git history attributes this to
me. I guess a "based on initial patch from" could be useful some day.
- Original Message -
> From: Christophe Fergeau
>
> Make sure an allocated buffer is correctly referenced by the marshaller,
> and c
Looks good, but I would split it to:
worker: make more functions static
worker: remove unused function
Pavel
On Mon, 2015-11-09 at 13:16 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 71 --
> ---
> 1 file
On Mon, 2015-11-09 at 13:16 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 6becc56..640dff5 100644
> --- a/server/
From: Marc-André Lureau
---
server/red_worker.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 0c1a1b1..f70ee9b 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -8701,24 +8701
From: Marc-André Lureau
---
server/display-channel.h | 2 +
server/red_worker.c| 119 +
server/spice_image_cache.c | 60 +++
server/spice_image_cache.h | 19 ++--
server/stream.h| 6 +--
5 files chang
From: Marc-André Lureau
---
server/display-channel.h | 3 +--
server/red_worker.c | 18 +-
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/server/display-channel.h b/server/display-channel.h
index 7c62a62..f1f4e3a 100644
--- a/server/display-channel.h
+++ b
From: Marc-André Lureau
---
server/cursor-channel.c | 6 +++---
server/red_worker.c | 2 --
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/server/cursor-channel.c b/server/cursor-channel.c
index 6d648b1..fc3a057 100644
--- a/server/cursor-channel.c
+++ b/server/cursor-channel
From: Marc-André Lureau
---
server/red_worker.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 6becc56..640dff5 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -745,15 +745,15 @@ static inline v
From: Marc-André Lureau
---
server/display-channel.c | 9 -
server/display-channel.h | 8 +++-
server/red_worker.c | 31 +++
3 files changed, 30 insertions(+), 18 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 3
From: Marc-André Lureau
---
server/red_worker.c | 71 -
1 file changed, 32 insertions(+), 39 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 8f6ef95..0c1a1b1 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
From: Marc-André Lureau
---
server/display-channel.c | 36 ++
server/display-channel.h | 19 ++
server/red_worker.c | 50 +---
3 files changed, 56 insertions(+), 49 deletions(-)
diff --git a/server/
From: Marc-André Lureau
---
server/Makefile.am | 2 +
server/display-channel.c | 44 +++
server/display-channel.h | 82 ++---
server/red_worker.c | 917 ---
server/red_worker.h | 1 +
server/stream.c | 66
server/st
From: Marc-André Lureau
---
server/display-channel.h | 3 +++
server/red_worker.c | 29 +
2 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/server/display-channel.h b/server/display-channel.h
index 53c5ddc..1871cb0 100644
--- a/server/display-chan
From: Marc-André Lureau
---
server/display-channel.h | 2 +-
server/red_parse_qxl.c | 10 +-
server/red_parse_qxl.h | 2 +-
server/red_worker.c | 32
4 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/server/display-channel.h b/se
From: Christophe Fergeau
Make sure an allocated buffer is correctly referenced by the marshaller,
and can't be free and reused by mistake. Simplify the code by using
GSlice
---
server/display-channel.h | 3 --
server/red_worker.c | 117 ---
2 fi
This patchset supersed last patchset.
Changes:
- rebased on new master;
- dropper "server/red_worker: red_draw_qxl_drawable: protect from
NULL dereference in case of buggy driver (or recording)" patch;
- updated "worker: move red_destroy_surface_item()" checking
for dcc NULL before using it;
-
From: Marc-André Lureau
---
server/display-channel.h | 24 --
server/red_worker.c | 117 ++-
2 files changed, 74 insertions(+), 67 deletions(-)
diff --git a/server/display-channel.h b/server/display-channel.h
index 1871cb0..f981d27 10064
From: Marc-André Lureau
Author:Marc-André Lureau
---
server/Makefile.am | 2 +
server/dcc-encoders.c| 402 ++
server/dcc-encoders.h| 145 +
server/display-channel.c | 6 +-
server/display-channel.h | 66 ++
server/red_worker
On Mon, Nov 09, 2015 at 01:30:15PM +0100, Jose Carlos Norte Fernandez wrote:
> Thanks for your comments Daniel!
>
> It wasn’t our intention to add the badgeware paragraph in the first place,
> it was there because we recovered our header license text from our past
> open source components (from 4
The current logic for generating the url is for our web sockets proxy
implementation.
We need to add a new parameter to override this part and just pass a full url.
Regards,
joca.
> On 09 Nov 2015, at 09:07, Vasiliy Tolstov wrote:
>
> 2015-11-06 20:05 GMT+03:00 Gianni Pirozzi :
>> Hello,
>> I'
Thanks for your comments Daniel!
It wasn’t our intention to add the badgeware paragraph in the first place, it
was there because we recovered our header license text from our past open
source components (from 4 years ago), that were in fact badgeware.
Since this is not our intention with spice-
>
> From: Marc-André Lureau
>
> ---
> server/display-channel.h | 2 +
> server/red_worker.c| 119
> +
> server/spice_image_cache.c | 60 +++
> server/spice_image_cache.h | 19 ++--
> server/stream.h|
>
> From: Marc-André Lureau
>
> ---
> server/display-channel.c | 29
> server/display-channel.h | 19 ++
> server/red_worker.c | 50
> +---
> 3 files changed, 49 insertions(+), 49 deletions(-)
>
> di
>
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 53
> +++--
> 1 file changed, 27 insertions(+), 26 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 7a4822a..93e0efb 100644
> --- a/server/red_worker.c
>
> >
> > This patchset supersed last patchset.
> >
> > Changes:
> > - removed merged patches;
> > - squashed "worker: use RED_CHANNEL_CLIENT for dcc"
> > - added some patches to the set.
> >
> > Alon's patch is removed from patchset, there is no reason to keep
> > sending it all the time as alrea
>
> ACK
>
Merged
Frediano
> On Fri, 2015-11-06 at 14:23 +, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > Use read_safe/write_safe instead which do the same stuff
> > ---
> > server/dispatcher.c | 6 +++---
> > server/red_dispatcher.h | 32 --
>
> The commit log is a bit terse and difficult to parse, but the patch
> looks OK. It's clearly an intermediate step in a refactoring, but
> that's OK.
>
> Possible suggestion for commit log:
>
> "Create display and cursor channels in RedWorker constructor
>
> Instead of requiring the dispatc
>
> ACK both
>
Merged
> On Fri, 2015-11-06 at 13:58 +, Frediano Ziglio wrote:
> > Remove space and inline changes, remove unused parameter
> > instead of changing type and name.
> >
> > Frediano Ziglio (1):
> > worker: remove unused parameter from remove_shadow
> >
> > Marc-André Lurea
2015-11-06 20:05 GMT+03:00 Gianni Pirozzi :
> Hello,
> I'm in the process of understanding if spice-web-client would be a suitable
> replacement for spice-html5 in our company web application.
> The first obstacle I'm encountering is that I can't easily control the
> complete websocket URL.
>
> O
61 matches
Mail list logo
