On Wed, 4 Nov 2015, Christophe Fergeau wrote:
> Can you explain in the commit log why this is a good thing/why you need
> to do that?
Not sure how to explain it in the commit log.
It's essentially like the video decoder support: we don't force the
developer to choose between the builtin MJPEG d
On 11/04/2015 11:37 AM, Gianni Pirozzi wrote:
> Hello,
> thanks for open sourcing spice web client, I just tried it and it solves most
> of our problems :)
>
> In my tests there is always a rectangular area at the top-left of the screen
> (866x78px), inside of which the pointer has a "text selec
> > > > >
> > > > > This patchset supersed last patchset.
> > > > >
> > > > > Changes:
> > > > > - removed merged patches;
> > > > > - updated patch from Jonathon for "Fix warning due to unexpected pipe
> > > > > item type";
> > > > > - merged later minor changes to "server: move bitmap related
>
> ---
>
> Changes since v2:
> - changes spice_return_if_fail() to spice_warn_if_fail() to avoid leaking
>additional memory
>
>
> server/red_worker.c | 46 --
> 1 file changed, 24 insertions(+), 22 deletions(-)
>
> diff --git a/server/red_work
Hello,
thanks for open sourcing spice web client, I just tried it and it solves most
of our problems :)
In my tests there is always a rectangular area at the top-left of the screen
(866x78px), inside of which the pointer has a "text selection" shape and
doesn't work (clicks and hovering have no
---
Changes since v2:
- changes spice_return_if_fail() to spice_warn_if_fail() to avoid leaking
additional memory
server/red_worker.c | 46 --
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.
>
> On 11/04/2015 05:48 PM, Frediano Ziglio wrote:
> > This patch does the same of former one.
>
> Hi,
>
> Does this patch just throws away the draw command ?
>
> Why is that good ?
>
> Regards,
> Uri.
>
The idea of the patch is basically "if you cannot handle the draw discard it
and
On 11/04/2015 05:48 PM, Frediano Ziglio wrote:
This patch does the same of former one.
Hi,
Does this patch just throws away the draw command ?
Why is that good ?
Regards,
Uri.
[PATCH] worker: don't process drawable if it can't be allocated
---
server/red_worker.c | 10 ++
This patch does the same of former one.
[PATCH] worker: don't process drawable if it can't be allocated
---
server/red_worker.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 5b1ece8..5005e7c 100644
--- a/server/re
We do this by auto detecting the inbound http(s) 'GET' and probing
for a well formulated WebSocket binary connection, such as used
by the spice-html5 client. If detected, we implement a set of
cover functions that abstract the read/write/writev functions,
in a fashion similar to the SASL implement
Hi
So I tested 16bpp with multiple image compressions.
Most work, but there are a couple of issues.
LZ doesn't work at all, Spicy crashes with that one on 16bpp, all others
work.
Color order is correct on all compressions.
When using 16bpp there is an artefact with icons, as in video [1]
When usi
Gah, missed a potential problem.
> +int websocket_write(void *opaque, const guchar *buf, int len, guint64
> *remainder,
> + websocket_write_cb_t write_cb)
> +{
> +guint8 header[WEBSOCKET_MAX_HEADER_SIZE];
> +int rc;
> +int header_len;
> +
> +memset(header, 0, sizeof(header
>
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 136
>
> 1 file changed, 73 insertions(+), 63 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 9697532..5f1bbaf 100644
> --- a/server/red_worker.c
>
From: Marc-André Lureau
---
server/red_worker.c | 136
1 file changed, 73 insertions(+), 63 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 9697532..5f1bbaf 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
Self NACK
Wrong order of LE/BE macros
Should be the other way around:
#ifdef WORDS_BIGENDIAN
#define x8r8g8b8_ALPHA 0x00ffu
#else
#define x8r8g8b8_ALPHA 0xff00u
#endif
Will fix in next version, still some changes left.
On Thu, Oct 22, 2015 at 5:02 PM, Lukas Venhoda wrote:
> W
>
> ---
> server/red_worker.c | 46 --
> 1 file changed, 24 insertions(+), 22 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 9738e98..e23c460 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -991,11 +
>
> ---
> server/pixmap-cache.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/server/pixmap-cache.h b/server/pixmap-cache.h
> index 336c9ae..a4f6fea 100644
> --- a/server/pixmap-cache.h
> +++ b/server/pixmap-cache.h
> @@ -28,8 +28,6 @@
> #define BITS_CACHE_HASH_MASK (BITS_CACHE_HASH
>
> From: Marc-André Lureau
>
> This commit moves some DrawablePipeItem declarations to
> display-channel.h, though the function implementations remain in
> red_worker.c until they can be disentangled some more.
> ---
> server/display-channel.h | 74 ++
> server/red_wor
>
> On Tue, Nov 3, 2015 at 6:00 PM, Christophe Fergeau
> wrote:
> > On Mon, Nov 02, 2015 at 05:11:04PM +0100, Fabiano Fidêncio wrote:
> >> On Mon, Nov 2, 2015 at 5:00 PM, Frediano Ziglio
> >> wrote:
> >> >>
> >> >> On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio
> >> >> wrote:
> >> >> Just a
Updated proposed patch
[PATCH] worker: move shadow_new() and container_new()
---
server/red_worker.c | 49 +++--
server/tree.c | 39 +++
server/tree.h | 9 +
3 files changed, 55 insertions(+), 4
Proposed update
[PATCH] worker: move delta computation
Move delta computation from red_add_drawable to red_current_add_with_shadow.
---
server/red_worker.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 1b04
>
> On Tue, Nov 3, 2015 at 6:08 PM, Fabiano Fidêncio wrote:
> > On Tue, Nov 3, 2015 at 5:28 PM, Frediano Ziglio wrote:
> >>>
> >>> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio
> >>> wrote:
> >>> > From: Marc-André Lureau
> >>> >
> >>> > ---
> >>> > server/red_worker.c | 42 ++
On Tue, Nov 3, 2015 at 6:08 PM, Fabiano Fidêncio wrote:
> On Tue, Nov 3, 2015 at 5:28 PM, Frediano Ziglio wrote:
>>>
>>> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
>>> > From: Marc-André Lureau
>>> >
>>> > ---
>>> > server/red_worker.c | 42 +++-
>
> On Wed, Nov 4, 2015 at 11:54 AM, Frediano Ziglio wrote:
> >>
> >> It's a regression introduced by commit e601e920bd5. The logic error was
> >> introduced when trying to achieve the following code[0]. but rewritten
> >> to prefer an early return.
> >>
> >> [0]:
> >> if (cursor_is_connected(wor
It's a regression introduced by commit e601e920bd5. The logic error was
introduced when trying to achieve the following code[0]. but rewritten
to prefer an early return, which was wrogly negated.
[0]:
if (cursor_is_connected(worker)
&& !COMMON_CHANNEL(worker->cursor_channel)->during_target_mig
On Wed, Nov 4, 2015 at 11:54 AM, Frediano Ziglio wrote:
>>
>> It's a regression introduced by commit e601e920bd5. The logic error was
>> introduced when trying to achieve the following code[0]. but rewritten
>> to prefer an early return.
>>
>> [0]:
>> if (cursor_is_connected(worker)
>> && !COM
> > > >
> > > > This patchset supersed last patchset.
> > > >
> > > > Changes:
> > > > - removed merged patches;
> > > > - updated patch from Jonathon for "Fix warning due to unexpected pipe
> > > > item type";
> > > > - merged later minor changes to "server: move bitmap related to
> > > > r
>
> In order to invalidate a single palette cache item, we were using
> spice_marshall_msg_cursor_inval_one(), which is the marshal function
> used to send an invalidation message for the Cursor channel's cache.
> This didn't cause any problems because SPICE_MSG_CURSOR_INVAL_ONE and
> SPICE_MSG_DI
On Wed, Nov 04, 2015 at 12:04:57PM +0100, Christophe Fergeau wrote:
> Hey,
>
> On Fri, Oct 30, 2015 at 12:17:30PM +0100, Francois Gouget wrote:
> > *data must always be set to NULL on error.
>
> Looks good, ACK.
I've pushed this.
Christophe
signature.asc
Description: PGP signature
___
Hey,
On Fri, Oct 30, 2015 at 12:17:30PM +0100, Francois Gouget wrote:
> *data must always be set to NULL on error.
Looks good, ACK.
Christophe
>
> Signed-off-by: Francois Gouget
> ---
> src/channel-display.c | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff
>
> It's a regression introduced by commit e601e920bd5. The logic error was
> introduced when trying to achieve the following code[0]. but rewritten
> to prefer an early return.
>
> [0]:
> if (cursor_is_connected(worker)
> && !COMMON_CHANNEL(worker->cursor_channel)->during_target_migrate) {
>
Series looks good, thanks! Just curious about the purpose of
"build-sys: Allow simultaneous support for Pulse and GStreamer"
Christophe
On Tue, Nov 03, 2015 at 01:05:28PM +0100, Francois Gouget wrote:
> A call to SPICE_WARNING() anywhere in the configure file results in the
> warning being printe
Can you explain in the commit log why this is a good thing/why you need
to do that?
Thanks,
Christophe
On Tue, Nov 03, 2015 at 01:06:10PM +0100, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
> configure.ac | 63
> +--
>
Hey,
On Tue, Nov 03, 2015 at 01:05:49PM +0100, Francois Gouget wrote:
> This makes it possible to warn the developer that the GStreamer elements
> needed at runtime are missing and give him a hint on how to fix the
> issue.
>
> Signed-off-by: Francois Gouget
> ---
> m4/spice-deps.m4 | 32 ++
> >
> > >
> > > This patchset supersed last patchset.
> > >
> > > Changes:
> > > - removed merged patches;
> > > - updated patch from Jonathon for "Fix warning due to unexpected pipe
> > > item type";
> > > - merged later minor changes to "server: move bitmap related to
> > > red_bitmap_util
>
> From: Marc-André Lureau
>
> Various changes in RedWorker and CursorChannel related to error and
> warning messages.
>
> Signed-off-by: Jonathon Jongsma
> ---
> server/cursor-channel.c | 28
> server/red_worker.c | 17 +++--
> server/red_worker
On Tue, Nov 03, 2015 at 01:05:28PM +0100, Francois Gouget wrote:
> A call to SPICE_WARNING() anywhere in the configure file results in the
> warning being printed at the end of the configure run where it will be
> be visible. This makes it possible to keep the SPICE_WARNING() calls
> together with
It's a regression introduced by commit e601e920bd5. The logic error was
introduced when trying to achieve the following code[0]. but rewritten
to prefer an early return.
[0]:
if (cursor_is_connected(worker)
&& !COMMON_CHANNEL(worker->cursor_channel)->during_target_migrate) {
red_channe
>
> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/display-channel.c | 45
> > server/display-channel.h | 16 ++
> > server/red_worker.c | 130
> > +--
> > 3 file
>
> >
> > This patchset supersed last patchset.
> >
> > Changes:
> > - removed merged patches;
> > - updated patch from Jonathon for "Fix warning due to unexpected pipe
> > item type";
> > - merged later minor changes to "server: move bitmap related to
> > red_bitmap_utils" (license header a
>
> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index d50d4dd..1849cc8 100644
> > --- a
On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote:
> Personal considerations:
> - although is sometimes useful to have errors reported to detect problems
> we should consider we should consider that too logging can cause DoS
> due to disk consumption, slow down (there are some che
On Tue, Nov 03, 2015 at 12:08:33PM -0500, Frediano Ziglio wrote:
>
> >
> > On Mon, Nov 02, 2015 at 07:43:49AM -0500, Frediano Ziglio wrote:
> > >
> > > Acked and pushed.
> > > (no comments beside this in more than a week).
> >
> > Ah, wanted to mention s/seperate/separate/ in the commit log :(
>
> This patch causes my v0.30-9-g17a6b8a vintage spice-gtk client stop
> having a cursor in an Xspice session.
>
> The spice-html5 client cursor continues to work fine.
>
> I've bisected it, but not really explored further; if there are
> easy/obvious things for me to check, let me know.
>
>
44 matches
Mail list logo
