On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 131
> +++-
> 1 file changed, 69 insertions(+), 62 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 45
We do this by auto detecting the inbound http(s) 'GET' and probing
for a well formulated WebSocket binary connection, such as used
by the spice-html5 client. If detected, we implement a set of
cover functions that abstract the read/write/writev functions,
in a fashion similar to the SASL implement
This patch causes my v0.30-9-g17a6b8a vintage spice-gtk client stop
having a cursor in an Xspice session.
The spice-html5 client cursor continues to work fine.
I've bisected it, but not really explored further; if there are
easy/obvious things for me to check, let me know.
Cheers,
Jeremy
On 11
On Tue, Nov 3, 2015 at 9:35 PM, Jonathon Jongsma wrote:
> This is a split version of the following patch:
> [PATCH 14/15] worker: tried to move dpi functions to display channel, fail
>
> Personally, I'd ACK all of these commits, but would appreciate opinions from
> others.
>
> Jonathon Jongsma (2)
---
server/pixmap-cache.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/server/pixmap-cache.h b/server/pixmap-cache.h
index 336c9ae..a4f6fea 100644
--- a/server/pixmap-cache.h
+++ b/server/pixmap-cache.h
@@ -28,8 +28,6 @@
#define BITS_CACHE_HASH_MASK (BITS_CACHE_HASH_SIZE - 1)
#define BIT
---
server/red_worker.c | 46 --
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 9738e98..e23c460 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -991,11 +991,12 @@ static void
This is a split version of the following patch:
[PATCH 14/15] worker: tried to move dpi functions to display channel, fail
Personally, I'd ACK all of these commits, but would appreciate opinions from
others.
Jonathon Jongsma (2):
Remove unnecessary typedef from pixmap-cache.h
style: prefer e
From: Marc-André Lureau
This commit moves some DrawablePipeItem declarations to
display-channel.h, though the function implementations remain in
red_worker.c until they can be disentangled some more.
---
server/display-channel.h | 74 ++
server/red_worker.c | 134 ++
On Tue, 2015-11-03 at 17:54 +0100, Fabiano Fidêncio wrote:
> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio
> wrote:
> > From: Marc-André Lureau
>
> Why did it fail? What's the main issue? Was it achieved in some other
> patch during the rebase?
> I didn't go through the code because I didn'
In order to invalidate a single palette cache item, we were using
spice_marshall_msg_cursor_inval_one(), which is the marshal function
used to send an invalidation message for the Cursor channel's cache.
This didn't cause any problems because SPICE_MSG_CURSOR_INVAL_ONE and
SPICE_MSG_DISPLAY_INVAL_P
On Tue, 2015-11-03 at 19:30 +0100, Fabiano Fidêncio wrote:
> On Tue, Nov 3, 2015 at 7:10 PM, Jonathon Jongsma > wrote:
> > On Tue, 2015-11-03 at 12:16 -0500, Frediano Ziglio wrote:
> > > >
> > > > From: Jonathon Jongsma
> > > >
> > > > In order to invalidate a single palette cache item, we were
On Tue, Nov 3, 2015 at 7:10 PM, Jonathon Jongsma wrote:
> On Tue, 2015-11-03 at 12:16 -0500, Frediano Ziglio wrote:
>> >
>> > From: Jonathon Jongsma
>> >
>> > In order to invalidate a single palette cache item, we were using
>> > spice_marshall_msg_cursor_inval_one(), which is the marshal
>> > fu
On Tue, 2015-11-03 at 12:16 -0500, Frediano Ziglio wrote:
> >
> > From: Jonathon Jongsma
> >
> > In order to invalidate a single palette cache item, we were using
> > spice_marshall_msg_cursor_inval_one(), which is the marshal
> > function
> > used to send an invalidation message for the Cursor
>
>
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 31 +++
> > 1 file changed, 15 insertions(+), 16 deletions(-)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
> > index bad8e47..491e55e 100644
> > --- a/server/red_worker.c
> > +
On Thu, 22 Oct 2015, Christophe Fergeau wrote:
[...]
> > +AC_ARG_ENABLE(gstreamer,
> > + AS_HELP_STRING([--enable-gstreamer=@<:@auto/yes/no@:>@],
> > + [Enable GStreamer 1.0 support]),
> > + [],
> > + [enable_gstreamer="auto"])
> >
>
> From: Jonathon Jongsma
>
> In order to invalidate a single palette cache item, we were using
> spice_marshall_msg_cursor_inval_one(), which is the marshal function
> used to send an invalidation message for the Cursor channel's cache.
> This didn't cause any problems because SPICE_MSG_CURSO
On Tue, Nov 3, 2015 at 5:49 PM, Christophe Fergeau wrote:
> Hey,
>
> Looks good to me, ACK.
Thanks, pushed as: 086ececd5f7f6bd8668f11d8811bf8badb9d8c5d
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
htt
On 11/03/2015 06:27 PM, Fabiano Fidêncio wrote:
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
From: Marc-André Lureau
This patch does "move and modify"
---
server/red_worker.c | 61 -
server/tree.c | 39 +++
On Mon, Nov 02, 2015 at 09:56:03AM +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/cursor-channel.c | 24 +++-
> server/cursor-channel.h | 18 ++---
> server/red_channel.c| 12 ++
> server/red_channel.h| 6 +++
> server/red_worker.c | 98
> +
On Tue, Nov 3, 2015 at 5:28 PM, Frediano Ziglio wrote:
>>
>> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
>> > From: Marc-André Lureau
>> >
>> > ---
>> > server/red_worker.c | 42 +++---
>> > server/tree.h | 1 +
>> > 2 files changed, 24 ins
>
> On Mon, Nov 02, 2015 at 07:43:49AM -0500, Frediano Ziglio wrote:
> >
> > Acked and pushed.
> > (no comments beside this in more than a week).
>
> Ah, wanted to mention s/seperate/separate/ in the commit log :(
>
> Christophe
>
Got this change :)
Frediano
On Tue, Nov 3, 2015 at 6:00 PM, Christophe Fergeau wrote:
> On Mon, Nov 02, 2015 at 05:11:04PM +0100, Fabiano Fidêncio wrote:
>> On Mon, Nov 2, 2015 at 5:00 PM, Frediano Ziglio wrote:
>> >>
>> >> On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio
>> >> wrote:
>> >> Just a nitpick, I would prefer
On Mon, Nov 02, 2015 at 05:11:04PM +0100, Fabiano Fidêncio wrote:
> On Mon, Nov 2, 2015 at 5:00 PM, Frediano Ziglio wrote:
> >>
> >> On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio
> >> wrote:
> >> Just a nitpick, I would prefer to have a explicit comparison here: if
> >> (--items->refs > 0) ..
On Tue, 2015-11-03 at 17:54 +0100, Fabiano Fidêncio wrote:
> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio
> wrote:
> > From: Marc-André Lureau
>
> Why did it fail? What's the main issue? Was it achieved in some other
> patch during the rebase?
> I didn't go through the code because I didn't
On Tue, 3 Nov 2015, Christophe Fergeau wrote:
[...]
> > > We'll need to readd the AS_VAR_APPEND fallback which was removed in
> > > f7ec855af3d , otherwise looks fine
> >
> > Ok. I'll resubmit.
>
> I can easily add this myself before pushing.
Well, I resubmitted a few hours ago with the trailing
On Tue, Nov 03, 2015 at 01:31:33PM +0100, Fabiano Fidêncio wrote:
> On Tue, Nov 3, 2015 at 11:01 AM, Frediano Ziglio wrote:
> > Merged
>
> And it got merged without both mine and yours suggestion :-\
Yes, would have been nice to address the pending issues before
pushing...
Christophe
signatur
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/display-channel.c | 45
> server/display-channel.h | 16 ++
> server/red_worker.c | 130
> +--
> 3 files changed, 95 inserti
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
Why did it fail? What's the main issue? Was it achieved in some other
patch during the rebase?
I didn't go through the code because I didn't even understand the main
point of this patch.
>
> ---
> server/display-
On Tue, Nov 03, 2015 at 10:39:33AM -0600, Jeremy White wrote:
> As of commit f73ca7e4cc090772652611a4e2b8b95ae64319bc, you can now
> disable the regular port by specifying 0. This change to the Xspice
> script permits us to take advantage of that change.
Ah thanks for the explanation, makes much
On Mon, Nov 02, 2015 at 07:43:49AM -0500, Frediano Ziglio wrote:
>
> Acked and pushed.
> (no comments beside this in more than a week).
Ah, wanted to mention s/seperate/separate/ in the commit log :(
Christophe
signature.asc
Description: PGP signature
__
Hey,
Looks good to me, ACK.
Christophe
On Tue, Nov 03, 2015 at 11:10:55AM +0100, Fabiano Fidêncio wrote:
> Use "PRIu64" macro for printf-ing uint64_t variables, avoiding warnings
> like:
> usbredirhost.c: In function 'usbredirhost_can_write_iso_package':
> usbredirhost.c:1023:19: warning: format
>
> On Tue, 2015-11-03 at 11:25 -0500, Frediano Ziglio wrote:
> > >
> > > On Tue, 2015-11-03 at 10:20 +, Frediano Ziglio wrote:
> > > > From: Marc-André Lureau
> > > >
> > > > ---
> > > > server/Makefile.am | 2 +
> > > > server/red_common.h | 13
> > > > server/r
>
> On Tue, Nov 03, 2015 at 11:13:05AM -0500, Frediano Ziglio wrote:
> > >
> > > On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio
> > > wrote:
> > > > From: Marc-André Lureau
> > > >
> > > > Not really necessary, but probably better than FALSE anyway.
> > > > ---
> > > > server/red_worker.c |
As of commit f73ca7e4cc090772652611a4e2b8b95ae64319bc, you can now
disable the regular port by specifying 0. This change to the Xspice
script permits us to take advantage of that change.
Signed-off-by: Jeremy White
---
Since v1: Commit message expanded to explain why this is useful.
---
scripts
On Mon, Nov 02, 2015 at 08:55:50PM +0100, Francois Gouget wrote:
> On Fri, 30 Oct 2015, Christophe Fergeau wrote:
>
> > Hey,
> >
> > This looks good, but I was wondering whether this is being copied/pasted
> > from some other configure.ac/m4 file, or if this is the initial
> > implementation?
>
Why do you want to allow that? (can you add this to the commit log?)
Christophe
On Mon, Nov 02, 2015 at 04:14:16PM -0600, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> scripts/Xspice | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Xspice b/scripts/X
On Tue, 2015-11-03 at 11:25 -0500, Frediano Ziglio wrote:
> >
> > On Tue, 2015-11-03 at 10:20 +, Frediano Ziglio wrote:
> > > From: Marc-André Lureau
> > >
> > > ---
> > > server/Makefile.am | 2 +
> > > server/red_common.h | 13
> > > server/red_parse_qxl.c |
>
> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 42 +++---
> > server/tree.h | 1 +
> > 2 files changed, 24 insertions(+), 19 deletions(-)
> >
> > diff --git a/server/red_wor
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 61
> -
> server/tree.c | 39 ++
> server/tree.h | 9
> 3 files changed, 61
>
> On Tue, 2015-11-03 at 10:20 +, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > ---
> > server/Makefile.am | 2 +
> > server/red_common.h | 13
> > server/red_parse_qxl.c | 1 +
> > server/red_worker.c | 158 -
This way the video encoder can actually count on a real estimate when
it is initializing.
Signed-off-by: Francois Gouget
---
server/red_worker.c | 19 +++
server/tree.h | 1 +
2 files changed, 16 insertions(+), 4 deletions(-)
I sent this patch back in June but I did not g
On Tue, Nov 03, 2015 at 10:20:16AM +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/dispatcher.c | 6 ++--
> server/red_dispatcher.c | 74
> ++---
> server/red_dispatcher.h | 36 ++
> server/red
On Tue, Nov 03, 2015 at 11:13:05AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> > > From: Marc-André Lureau
> > >
> > > Not really necessary, but probably better than FALSE anyway.
> > > ---
> > > server/red_worker.c | 1 +
> > > 1 file changed
On Tue, Nov 3, 2015 at 5:13 PM, Frediano Ziglio wrote:
>>
>> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
>> > From: Marc-André Lureau
>> >
>> > Not really necessary, but probably better than FALSE anyway.
>> > ---
>> > server/red_worker.c | 1 +
>> > 1 file changed, 1 insertion(+)
>
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 23 ---
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 9f42f87..f40cd30 100644
> --- a/ser
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 42 +++---
> server/tree.h | 1 +
> 2 files changed, 24 insertions(+), 19 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_wo
03.11.2015, 18:43, "Christophe Fergeau" :
> On Tue, Oct 27, 2015 at 08:42:03PM +0300, Anton D. Kachalov wrote:
>> Hello,
>>
>
> If I understand correctly, the encoding/decoding is all done in
> hardware?
Encoding & compressing is done in hardware while decompressing have to be done
by the client
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index d50d4dd..1849cc8 100644
> --- a/server/red_worker.c
> +
>
> On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > Not really necessary, but probably better than FALSE anyway.
> > ---
> > server/red_worker.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/server/red_worker.c b/server/red_worker.c
>
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/dispatcher.c | 6 ++--
> server/red_dispatcher.c | 74
> ++---
> server/red_dispatcher.h | 36 ++
> server/red_worker.c
On 11/03/2015 04:32 AM, Daniel P. Berrange wrote:
> On Fri, Oct 30, 2015 at 03:52:56PM -0500, Jeremy White wrote:
>> We do this by auto detecting the inbound http(s) 'GET' and probing
>> for a well formulated WebSocket binary connection, such as used
>> by the spice-html5 client. If detected, we i
On Tue, Nov 3, 2015 at 11:20 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Not really necessary, but probably better than FALSE anyway.
> ---
> server/red_worker.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index fbcab6d..9057c
On Tue, 27 Oct 2015, Anton D. Kachalov wrote:
[...]
> I've started with Francois Gouget's https://github.com/fgouget/spice
> repo with GStreamer support. It were my first steps with Spice. I've
> added one more encoder: "aspeed" and one more image type: "AST" and
> tries to pass fake image updat
Hell, Christophe.
I've found a missed mutex unlock in my code added to the red_worker/fill_bits.
Git version looks stable for me now.
03.11.2015, 18:24, "Christophe Fergeau" :
> Hey,
>
> On Thu, Oct 29, 2015 at 08:54:12PM +0300, Anton D. Kachalov wrote:
>> Hi.
>>
>> I often get stucked on clie
On Tue, Oct 27, 2015 at 08:42:03PM +0300, Anton D. Kachalov wrote:
> Hello,
>
> sorry for the previous HTML-only message.
>
> I'm trying to add support for Aspeed SoC (AST2150/2300/2400) raw video
> streaming to Spice (this SoC might be found in the most server's BMC).
> It is a kind of a compres
Hey,
On Thu, Oct 29, 2015 at 08:54:12PM +0300, Anton D. Kachalov wrote:
> Hi.
>
> I often get stucked on client disconnect on blocking read (recent git
> checkout):
git master is moving quite a lot currently, I'd recommend sticking to
the 0.12.6 tag for now. If you want to stay up to date on la
Hey,
On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote:
> Style:
> - why use spice_printerr if all errors basically go to standard error?
> - from a first time readers spice_return_if_fail and spice_return_val_if_fail
> do not suggest function is doing some logging.
> Also they
Hi
- Original Message -
> On Tue, Nov 03, 2015 at 09:17:29AM -0500, Marc-André Lureau wrote:
> > > - from a first time readers spice_return_if_fail and
> > > spice_return_val_if_fail
> > > do not suggest function is doing some logging. Also they use critical
> > > level which by defaul
- Original Message -
> Hi
>
> - Original Message -
> > On Tue, Nov 03, 2015 at 09:17:29AM -0500, Marc-André Lureau wrote:
> > > > - from a first time readers spice_return_if_fail and
> > > > spice_return_val_if_fail
> > > > do not suggest function is doing some logging. Also th
On Tue, 2015-11-03 at 10:20 +, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/Makefile.am | 2 +
> server/red_common.h | 13
> server/red_parse_qxl.c | 1 +
> server/red_worker.c | 158 --
> --
On Tue, Nov 03, 2015 at 09:17:29AM -0500, Marc-André Lureau wrote:
> > - from a first time readers spice_return_if_fail and
> > spice_return_val_if_fail
> > do not suggest function is doing some logging. Also they use critical
> > level which by default cause program abortion.
>
> they follow
Hi,
On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote:
> Hi,
> looking at refactory branch and spice-server code looks like logging
> facilities are used all around the code for different purposes however
> don't looks like there are some specific style or direction to handle
> the
Hi
- Original Message -
> Hi,
> looking at refactory branch and spice-server code looks like logging
> facilities are used all around the code for different purposes however
> don't looks like there are some specific style or direction to handle
> these stuff.
> At http://cgit.freedeskto
>
> This patchset supersed last patchset.
>
> Changes:
> - removed merged patches;
> - updated patch from Jonathon for "Fix warning due to unexpected pipe
> item type";
> - merged later minor changes to "server: move bitmap related to
> red_bitmap_utils" (license header and name);
> - added s
On Tue, Nov 3, 2015 at 1:38 PM, Frediano Ziglio wrote:
>>
>> On Tue, Nov 3, 2015 at 11:01 AM, Frediano Ziglio wrote:
>> > Merged
>>
>> And it got merged without both mine and yours suggestion :-\
>>
>> Best Regards,
>> --
>> Fabiano Fidêncio
>>
>
> Mea culpa... yes.
>
> I decided to post a mail o
>
> On Tue, 2015-11-03 at 05:24 -0500, Frediano Ziglio wrote:
> > I would change the comment to
> >
> > "worker: remove unused worker parameter"
> >
> Yes, it is more accurate
>
> > >
> > > From: Marc-André Lureau
> > >
> > > ---
> > > server/red_worker.c | 16 +---
> > > 1 file
On Tue, 2015-11-03 at 05:24 -0500, Frediano Ziglio wrote:
> I would change the comment to
>
> "worker: remove unused worker parameter"
>
Yes, it is more accurate
> >
> > From: Marc-André Lureau
> >
> > ---
> > server/red_worker.c | 16 +---
> > 1 file changed, 9 insertions(+), 7
Hi,
looking at refactory branch and spice-server code looks like logging
facilities are used all around the code for different purposes however
don't looks like there are some specific style or direction to handle
these stuff.
At http://cgit.freedesktop.org/spice/spice/tree/docs there is a
Spice_
From: Marc-André Lureau
Various changes in RedWorker and CursorChannel related to error and
warning messages.
Signed-off-by: Jonathon Jongsma
---
server/cursor-channel.c | 28
server/red_worker.c | 17 +++--
server/red_worker.h | 1 -
3 files c
On Tue, Nov 3, 2015 at 11:05 AM, Frediano Ziglio wrote:
>>
>> On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
>> > From: Marc-André Lureau
>> >
>> > Various changes in RedWorker and CursorChannel related to error and
>> > warning messages.
>> >
>> > Signed-off-by: Jonathon Jongsma
>> >
>
> On Tue, Nov 3, 2015 at 11:01 AM, Frediano Ziglio wrote:
> > Merged
>
> And it got merged without both mine and yours suggestion :-\
>
> Best Regards,
> --
> Fabiano Fidêncio
>
Mea culpa... yes.
I decided to post a mail on logging and style and not stop the merging.
Could you post a chang
On Tue, Nov 3, 2015 at 11:01 AM, Frediano Ziglio wrote:
> Merged
And it got merged without both mine and yours suggestion :-\
Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/
Does this patch need changes?
On Fri, 30 Oct 2015, Francois Gouget wrote:
> *data must always be set to NULL on error.
>
> Signed-off-by: Francois Gouget
> ---
> src/channel-display.c | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/src/channel-disp
Signed-off-by: Francois Gouget
---
configure.ac | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
This patch depends on [client 07/11] and [common 02/11].
diff --git a/configure.ac b/configure.ac
index ddaab2a..3a19c03 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31
Note that spice-deps.m4 now provides the AS_VAR_APPEND() fallback.
Signed-off-by: Francois Gouget
---
configure.ac | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
This patch only depends on [spice 10/11] and [common 01/11].
diff --git a/configure.ac b/configure.ac
index ad
This lets us avoid naming conflicts when using GStreamer for other
purposes.
Signed-off-by: Francois Gouget
---
configure.ac| 18 +-
src/Makefile.am | 4 ++--
2 files changed, 11 insertions(+), 11 deletions(-)
This patch does not depend on any other patch in this series.
d
Signed-off-by: Francois Gouget
---
configure.ac | 63 +--
src/Makefile.am | 4 ++--
src/spice-audio.c | 11 +-
3 files changed, 37 insertions(+), 41 deletions(-)
This patch only depends on [client 07/11].
diff --git a/configure
Signed-off-by: Francois Gouget
---
configure.ac | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
This patch is independent from all other patches in this series.
diff --git a/configure.ac b/configure.ac
index dfb967b..ad76467 100644
--- a/configure.ac
+++ b/configure.ac
@
Their absence should not be reported as an error since they are not
needed for the build, but the developer will need them to test the code
so it's appropriate to warn him.
Signed-off-by: Francois Gouget
---
configure.ac | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
This patch depe
This makes it possible to warn the developer that the GStreamer elements
needed at runtime are missing and give him a hint on how to fix the
issue.
Signed-off-by: Francois Gouget
---
m4/spice-deps.m4 | 32
1 file changed, 32 insertions(+)
diff --git a/m4/spice-d
This simplifies checking for GStreamer modules by setting all the
variables we normally need.
Signed-off-by: Francois Gouget
---
m4/spice-deps.m4 | 20
1 file changed, 20 insertions(+)
diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
index 57d5b78..bb58d0f 100644
--- a/m4/s
Signed-off-by: Francois Gouget
---
configure.ac | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
This patch only depends on [common 01/11].
diff --git a/configure.ac b/configure.ac
index 7033cbb..db2891f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -671,6 +671,8 @@ have_dbus=no
i
Signed-off-by: Francois Gouget
---
configure.ac | 4
1 file changed, 4 deletions(-)
This patch does not depend on any other patch in this series.
diff --git a/configure.ac b/configure.ac
index 5790a37..7033cbb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -671,10 +671,6 @@ have_dbus=no
A call to SPICE_WARNING() anywhere in the configure file results in the
warning being printed at the end of the configure run where it will be
be visible. This makes it possible to keep the SPICE_WARNING() calls
together with the related feature checks instead of having to put a
separate AC_MSG_WAR
On Tue, Nov 3, 2015 at 11:05 AM, Frediano Ziglio wrote:
>>
>> On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
>> > From: Alon Levy
>> >
>> > ---
>> > server/red_worker.c | 5 +
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/server/red_worker.c b/server/red_worker.c
>> >
On Fri, Oct 30, 2015 at 03:52:56PM -0500, Jeremy White wrote:
> We do this by auto detecting the inbound http(s) 'GET' and probing
> for a well formulated WebSocket binary connection, such as used
> by the spice-html5 client. If detected, we implement a set of
> cover functions that abstract the r
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 31 +++
> 1 file changed, 15 insertions(+), 16 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index bad8e47..491e55e 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
>
Hi Jeremy,
On Mon, 2015-11-02 at 15:20 -0600, Jeremy White wrote:
> Hi Pavel,
>
> Thanks for the review.
>
> > >
> > > +static void reds_handle_new_link(RedLinkInfo *link);
> > > static void reds_handle_read_header_done(void *opaque)
> > > {
> > > RedLinkInfo *link = (RedLinkInfo *)opaqu
I would change the comment to
"worker: remove unused worker parameter"
>
> From: Marc-André Lureau
>
> ---
> server/red_worker.c | 16 +---
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 491e55e..fbcab6d 100644
From: Marc-André Lureau
---
server/display-channel.c | 45
server/display-channel.h | 16 ++
server/red_worker.c | 130 +--
3 files changed, 95 insertions(+), 96 deletions(-)
diff --git a/server/display-channel.c b/server/d
From: Marc-André Lureau
---
server/Makefile.am | 2 +
server/red_common.h | 13
server/red_parse_qxl.c | 1 +
server/red_worker.c | 158
server/spice-bitmap-utils.c | 119 +
serve
From: Marc-André Lureau
---
server/red_worker.c | 42 +++---
server/tree.h | 1 +
2 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 1849cc8..9f42f87 100644
--- a/server/red_worker.c
+++ b/se
From: Marc-André Lureau
---
server/red_worker.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 491e55e..fbcab6d 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -1506,16 +1506,18 @@ static inline S
From: Marc-André Lureau
---
server/red_worker.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 9f42f87..f40cd30 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -3032,9 +3032,15 @@ static
From: Marc-André Lureau
Not really necessary, but probably better than FALSE anyway.
---
server/red_worker.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/red_worker.c b/server/red_worker.c
index fbcab6d..9057cf5 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -10598,6
From: Marc-André Lureau
---
server/red_worker.c | 131 +++-
1 file changed, 69 insertions(+), 62 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 45750f9..d50d4dd 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
From: Jonathon Jongsma
In order to invalidate a single palette cache item, we were using
spice_marshall_msg_cursor_inval_one(), which is the marshal function
used to send an invalidation message for the Cursor channel's cache.
This didn't cause any problems because SPICE_MSG_CURSOR_INVAL_ONE and
From: Marc-André Lureau
---
server/red_worker.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index bad8e47..491e55e 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -376,6 +376,10 @@ R
From: Marc-André Lureau
---
server/display-channel.h | 74
server/pixmap-cache.h| 2 -
server/red_worker.c | 178 +++
server/tree.h| 34 -
4 files changed, 147 insertions(+), 141 deletions(-)
diff
From: Marc-André Lureau
---
server/dispatcher.c | 6 ++--
server/red_dispatcher.c | 74 ++---
server/red_dispatcher.h | 36 ++
server/red_worker.c | 68 ++---
server/red_worke
1 - 100 of 113 matches
Mail list logo
