Hi,
On Tue, Nov 03, 2015 at 07:18:33AM +0100, Victor Toso wrote:
> On Tue, Nov 03, 2015 at 01:51:41AM +0100, Fabiano Fidêncio wrote:
> > Cast uint64_t to long unsigned on printfs in order to avoid warnings
> > like:
> > usbredirhost.c: In function 'usbredirhost_can_write_iso_package':
> > usbredir
Hi,
On Tue, Nov 03, 2015 at 01:51:41AM +0100, Fabiano Fidêncio wrote:
> Cast uint64_t to long unsigned on printfs in order to avoid warnings
> like:
> usbredirhost.c: In function 'usbredirhost_can_write_iso_package':
> usbredirhost.c:1023:19: warning: format '%lu' expects argument of type 'long
>
Hi,
On Tue, Nov 03, 2015 at 01:51:41AM +0100, Fabiano Fidêncio wrote:
> Cast uint64_t to long unsigned on printfs in order to avoid warnings
> like:
> usbredirhost.c: In function 'usbredirhost_can_write_iso_package':
> usbredirhost.c:1023:19: warning: format '%lu' expects argument of type 'long
>
On Tue, Nov 3, 2015 at 1:51 AM, Fabiano Fidêncio wrote:
> Cast uint64_t to long unsigned on printfs in order to avoid warnings
> like:
> usbredirhost.c: In function 'usbredirhost_can_write_iso_package':
> usbredirhost.c:1023:19: warning: format '%lu' expects argument of type 'long
> unsigned int'
Cast uint64_t to long unsigned on printfs in order to avoid warnings
like:
usbredirhost.c: In function 'usbredirhost_can_write_iso_package':
usbredirhost.c:1023:19: warning: format '%lu' expects argument of type 'long
unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}'
Signed-off-by: Jeremy White
---
scripts/Xspice | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Xspice b/scripts/Xspice
index 52b1b16..46c5c1e 100755
--- a/scripts/Xspice
+++ b/scripts/Xspice
@@ -256,7 +256,7 @@ var_args = ['port', 'tls_port', 'disable_ticketing',
Hi Pavel,
Thanks for the review.
>>
>> +static void reds_handle_new_link(RedLinkInfo *link);
>> static void reds_handle_read_header_done(void *opaque)
>> {
>> RedLinkInfo *link = (RedLinkInfo *)opaque;
>> @@ -2182,6 +2183,11 @@ static void reds_handle_read_header_done(void *opaque)
>>
On Mon, 2015-11-02 at 11:00 -0500, Frediano Ziglio wrote:
> >
> > On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio <
> > fzig...@redhat.com> wrote:
> > > From: Marc-André Lureau
> > >
> > > Doing so allows us to remove the extra QXLInstance parameter from
> > > cursor_item_unref() and makes the
In order to invalidate a single palette cache item, we were using
spice_marshall_msg_cursor_inval_one(), which is the marshal function
used to send an invalidation message for the Cursor channel's cache.
This didn't cause any problems because SPICE_MSG_CURSOR_INVAL_ONE and
SPICE_MSG_DISPLAY_INVAL_P
On Fri, 30 Oct 2015, Christophe Fergeau wrote:
> Hey,
>
> This looks good, but I was wondering whether this is being copied/pasted
> from some other configure.ac/m4 file, or if this is the initial
> implementation?
It comes from Wine which is also LGPL:
https://source.winehq.org/git/wine.git/blo
On Mon, Nov 2, 2015 at 6:46 PM, Jonathon Jongsma wrote:
> On Mon, 2015-11-02 at 10:55 -0500, Frediano Ziglio wrote:
>> >
>> > On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio <
>> > fzig...@redhat.com> wrote:
>> > > From: Marc-André Lureau
>> > >
>> > > The specific item type that was not being h
On Mon, 2015-11-02 at 10:55 -0500, Frediano Ziglio wrote:
> >
> > On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio <
> > fzig...@redhat.com> wrote:
> > > From: Marc-André Lureau
> > >
> > > The specific item type that was not being handled was
> > > PIPE_ITEM_TYPE_INVAL_ONE (#102). This item typ
On Fri, Oct 30, 2015 at 10:05:23PM +0900, Daniel P. Berrange wrote:
> On Fri, Oct 30, 2015 at 01:24:36PM +0100, j...@eyeos.com wrote:
> >
> > > I note the attribution clause in your license. As it stands now, I
> > > don't think that would cause any trouble (because of the 'however' of 5
> > > (d
On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/Makefile.am| 2 +
> server/red_bitmap_utils.c | 99 +
> server/red_bitmap_utils.h | 91 ++
> server/red_common.h | 13
>
Hi Jeremy,
I really like how it works, that you can use the same port value for html5 and
gtk clients.
Not everything was clear to me, so I put some comments inline.
On Fri, 2015-10-30 at 15:52 -0500, Jeremy White wrote:
> We do this by auto detecting the inbound http(s) 'GET' and probing
> for a
On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/cursor-channel.c | 79
> +++--
> server/cursor-channel.h | 51 +++
> server/red_channel.h| 2 ++
> server/red_worker.c
On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> ---
> server/cursor-channel.c | 24 +++-
> server/cursor-channel.h | 18 ++---
> server/red_channel.c| 12 ++
> server/red_channel.h| 6 +++
> server/red_worker.c | 98
> ++
On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
> From: Alon Levy
>
> ---
> server/red_worker.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 339b353..868de94 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
On 11/01/2015 09:55 AM, Uri Lublin wrote:
> On 10/30/2015 05:45 PM, Jeremy White wrote:
>> This fixes a bug where Xspice had to listen on two ports, even in an
>> SSL only configuration.
>>
>> Signed-off-by: Jeremy White
>
> Ack.
Thanks. Pushed, with typo s/diabled/disabled/.
Cheers,
Jeremy
_
On Mon, Nov 2, 2015 at 5:00 PM, Frediano Ziglio wrote:
>>
>> On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio wrote:
>> > From: Marc-André Lureau
>> >
>> > Doing so allows us to remove the extra QXLInstance parameter from
>> > cursor_item_unref() and makes the code a bit cleaner.
>> >
>> > Also
>
> On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > Move the cursor-specific pipe item types to cursor-channel.h, and the
> > display-specific types to red_worker.c. Only leave the common
> > definitions in red_worker.h. This prepares for splitting the
> >
> > >
> > > This patchset supersed last patchset.
> > >
> > > Changes:
> > > - rebased on upstream master;
> > > - removed merged patches;
> > > - added patches from Jonathon cursor split ones;
> > > - added some patches to the set.
> > >
> > > I think if we won't receive any comment on Alo
On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Various changes in RedWorker and CursorChannel related to error and
> warning messages.
>
> Signed-off-by: Jonathon Jongsma
> ---
> server/cursor-channel.c | 28
> server/red_worke
>
> On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > Doing so allows us to remove the extra QXLInstance parameter from
> > cursor_item_unref() and makes the code a bit cleaner.
> >
> > Also add cursor_item_ref().
> >
> > Signed-off-by: Jonathon Jongsma
On Mon, Nov 2, 2015 at 10:56 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Move the cursor-specific pipe item types to cursor-channel.h, and the
> display-specific types to red_worker.c. Only leave the common
> definitions in red_worker.h. This prepares for splitting the display
> chan
>
> On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio wrote:
> > From: Marc-André Lureau
> >
> > The specific item type that was not being handled was
> > PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor
> > channel, but the analogous item for the display channel is
> > PIPE_
On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> The specific item type that was not being handled was
> PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor
> channel, but the analogous item for the display channel is
> PIPE_ITEM_TYPE_INVAL_P
On Mon, Nov 2, 2015 at 10:55 AM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Doing so allows us to remove the extra QXLInstance parameter from
> cursor_item_unref() and makes the code a bit cleaner.
>
> Also add cursor_item_ref().
>
> Signed-off-by: Jonathon Jongsma
> ---
> server/curs
>
> On Mon, Oct 26, 2015 at 06:48:38AM -0400, Frediano Ziglio wrote:
> >
> > >
> > > On Fri, Oct 23, 2015 at 10:29:04AM -0400, Frediano Ziglio wrote:
> > > > It would be much better to define a public structure like
> > > >
> > > > struct CursorChannel {
> > > >CommonChannel common;
> > > >
On Mon, Nov 2, 2015 at 2:50 PM, Fabiano Fidêncio wrote:
> On Mon, Nov 2, 2015 at 11:02 AM, Frediano Ziglio wrote:
>>
>>>
>>> From: Marc-André Lureau
>>>
>>> Move function from server/red_worker.c to new server/display-channel.c.
>>> ---
>>> server/Makefile.am | 1 +
>>> server/display-ch
>
> >
> > This patchset supersed last patchset.
> >
> > Changes:
> > - rebased on upstream master;
> > - removed merged patches;
> > - added patches from Jonathon cursor split ones;
> > - added some patches to the set.
> >
> > I think if we won't receive any comment on Alon Levy's patch
> > in
On Mon, Nov 2, 2015 at 3:14 PM, Fabiano Fidêncio wrote:
> On Mon, Nov 2, 2015 at 2:50 PM, Fabiano Fidêncio wrote:
>> On Mon, Nov 2, 2015 at 11:02 AM, Frediano Ziglio wrote:
>>>
From: Marc-André Lureau
Move function from server/red_worker.c to new server/display-channel.c.
>>
>
> On Mon, Nov 2, 2015 at 11:02 AM, Frediano Ziglio wrote:
> >
> >>
> >> From: Marc-André Lureau
> >>
> >> Move function from server/red_worker.c to new server/display-channel.c.
> >> ---
> >> server/Makefile.am | 1 +
> >> server/display-channel.c | 38 +++
> >>
On Mon, Nov 2, 2015 at 11:02 AM, Frediano Ziglio wrote:
>
>>
>> From: Marc-André Lureau
>>
>> Move function from server/red_worker.c to new server/display-channel.c.
>> ---
>> server/Makefile.am | 1 +
>> server/display-channel.c | 38 +++
>> server/display-channel
Hi,
> > Higher chance is with video playback. lip sync issues might show up,
> > although you probably still have to watch carefully to actually notice.
>
> Regarding the video playback workload: video playback is not a
> low-latency audio use case. That's why you won't notice any difference
On Fri, Oct 30, 2015 at 11:59:29AM +0100, Gerd Hoffmann wrote:
> > > What bothers me is that you have no qualms about making latency on
> > > everyone's system worse.
> >
> > How do you know it makes sound on other people's systems worse? If you have
> > actually done any testing, I would like to
>
> This patchset supersed last patchset.
>
> Changes:
> - rebased on upstream master;
> - removed merged patches;
> - added patches from Jonathon cursor split ones;
> - added some patches to the set.
>
> I think if we won't receive any comment on Alon Levy's patch
> in a week or so I'll remove
>
> From: Marc-André Lureau
>
> ---
> server/Makefile.am | 2 +
> server/red_worker.c | 266
> +++-
> server/tree.c | 182 +++
> server/tree.h | 111 ++
> 4 files changed, 306 ins
Hi,
On Mon, Nov 02, 2015 at 06:34:39AM -0500, Frediano Ziglio wrote:
>
> >
> > Hi,
> >
> > As in a mailing list it is a bit hard to track of the status of each
> > PATCH (acked/reviewed/pushed) and we still have tons of batch of
> > patches to apply/test/review I would like to suggest the followin
On Fri, Oct 30, 2015 at 12:01:20PM -0500, Jonathon Jongsma wrote:
> ACK
Thanks, pushed.
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/sp
>
> Hi,
>
> As in a mailing list it is a bit hard to track of the status of each
> PATCH (acked/reviewed/pushed) and we still have tons of batch of
> patches to apply/test/review I would like to suggest the following:
>
> 1-) When a batch is pushed, send an email in-reply-to 00/00 mail saying
>
>
> On Fri, 2015-10-30 at 03:24 -0400, Frediano Ziglio wrote:
> > >
> > > From: Marc-André Lureau
> > >
> > > Doing so allows us to remove the extra QXLInstance parameter from
> > > cursor_item_unref() and makes the code a bit cleaner.
> > >
> > > Also add cursor_item_ref().
> > >
> > > Sign
Hi,
As in a mailing list it is a bit hard to track of the status of each
PATCH (acked/reviewed/pushed) and we still have tons of batch of
patches to apply/test/review I would like to suggest the following:
1-) When a batch is pushed, send an email in-reply-to 00/00 mail saying
that patches were p
>
> From: Marc-André Lureau
>
> Move function from server/red_worker.c to new server/display-channel.c.
> ---
> server/Makefile.am | 1 +
> server/display-channel.c | 38 +++
> server/display-channel.h | 50 ---
> server/red_worker
From: Marc-André Lureau
---
server/cursor-channel.c | 79 +++--
server/cursor-channel.h | 51 +++
server/red_channel.h| 2 ++
server/red_worker.c | 22 +-
server/red_worker.h | 1 +
5 files changed,
From: Marc-André Lureau
---
server/cursor-channel.c | 24 +++-
server/cursor-channel.h | 18 ++---
server/red_channel.c| 12 ++
server/red_channel.h| 6 +++
server/red_worker.c | 98 ++---
server/red_worker.h | 5 +++
This patchset supersed last patchset.
Changes:
- rebased on upstream master;
- removed merged patches;
- added patches from Jonathon cursor split ones;
- added some patches to the set.
I think if we won't receive any comment on Alon Levy's patch
in a week or so I'll remove entirely.
The "server:
From: Marc-André Lureau
Various changes in RedWorker and CursorChannel related to error and
warning messages.
Signed-off-by: Jonathon Jongsma
---
server/cursor-channel.c | 28
server/red_worker.c | 22 ++
server/red_worker.h | 1 -
3 fi
From: Marc-André Lureau
The specific item type that was not being handled was
PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the cursor
channel, but the analogous item for the display channel is
PIPE_ITEM_TYPE_INVAL_PALETTE_CACHE. Use this value instead.
The exact warning follows:
From: Marc-André Lureau
---
server/Makefile.am| 2 +
server/red_bitmap_utils.c | 99 +
server/red_bitmap_utils.h | 91 ++
server/red_common.h | 13
server/red_parse_qxl.c| 1 +
server/red_worker.c | 158 -
From: Alon Levy
---
server/red_worker.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/server/red_worker.c b/server/red_worker.c
index 339b353..868de94 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -3838,6 +3838,11 @@ static void red_draw_qxl_drawable(RedWorker *worker,
From: Marc-André Lureau
Move function from server/red_worker.c to new server/display-channel.c.
---
server/Makefile.am | 1 +
server/display-channel.c | 38 +++
server/display-channel.h | 50 ---
server/red_worker.c | 68 +++
From: Marc-André Lureau
Doing so allows us to remove the extra QXLInstance parameter from
cursor_item_unref() and makes the code a bit cleaner.
Also add cursor_item_ref().
Signed-off-by: Jonathon Jongsma
---
server/cursor-channel.c | 70 +++--
serve
From: Marc-André Lureau
Move the cursor-specific pipe item types to cursor-channel.h, and the
display-specific types to red_worker.c. Only leave the common
definitions in red_worker.h. This prepares for splitting the display
channel into a separate file.
Signed-off-by: Jonathon Jongsma
---
ser
From: Marc-André Lureau
---
server/Makefile.am | 2 +
server/red_worker.c | 266 +++-
server/tree.c | 182 +++
server/tree.h | 111 ++
4 files changed, 306 insertions(+), 255 deleti
Hi all,
If no one objects, I'll be doing the 0.7.1 release shortly
* Changelogs for the release (acked by Hans)
usbredir-0.7.1 29 Oct 2015
-usbredirfilter
-force check to device which had all interfaces skipped. This fix a bug
which allow a KVM device to be redi
56 matches
Mail list logo
