On Wed, Oct 21, 2015 at 7:58 PM, Christophe Fergeau wrote:
> On Tue, Oct 20, 2015 at 02:34:40PM +0300, Yedidyah Bar David wrote:
>> Hi all,
>>
>> Changes since [1]:
>>
>> - Attended (I hope) Christophe's comments from previous set
>>
>> - Added Makefile/spec and jenkins automation scripts
>>
>> -
On Wed, Oct 21, 2015 at 7:55 PM, Christophe Fergeau wrote:
> On Tue, Oct 20, 2015 at 02:35:23PM +0300, Yedidyah Bar David wrote:
>> From: Christophe Fergeau
>>
>> Now that we are able to generate different installers for SPICE and
>> oVirt, we can install the oVirt agent when building an oVirt in
On Wed, Oct 21, 2015 at 7:43 PM, Christophe Fergeau wrote:
> On Wed, Oct 21, 2015 at 05:47:12PM +0300, Yedidyah Bar David wrote:
>> Allow 'make dist'.
>>
>> Allow building the spice installer and building/installing the ovirt
>> installer.
>>
>> VERSION moved from the nsis file to the Makefile and
On Wed, Oct 21, 2015 at 7:52 PM, Christophe Fergeau wrote:
> I suspect these scripts are no longer needed? I don't see them being
> used after applying your automation patch.
Again, just used your ovirt branch.
As far as I can tell, we don't need anything in tools/ .
I don't mind removing it an
On Wed, Oct 21, 2015 at 7:50 PM, Christophe Fergeau wrote:
> Sorry if I missed it/forgot the answer
You didn't :-)
You already asked and I replied asking Lev.
> , but why do we need/want this
> change?
I guess it's mainly to pay tribute to that project.
Lev?
You already merged it to your own
On Wed, Oct 21, 2015 at 10:52 PM, Jonathon Jongsma wrote:
> In order to avoid reference cycles, you're supposed to release
> references in dispose, especially to those objects that can hold
> references to yourself. This probably wasn't causing any leaks, since
> the file transfer tasks generally
On Wed, 2015-10-21 at 13:00 +0100, Frediano Ziglio wrote:
> These patches are extracted from a branch intended to refactory
> spice-server.
>
> This patchset supersed last patchset and apply to updated master.
Can you provide a little bit of explanation for why this new set
supersedes the last s
In certain circumstances we were printing an error message even though
the file transfer had completed successfully. It didn't cause any
problems, but it pointed out an issue in the handling of outgoing agent
messages.
The described behavior was generally only encountered when there were multiple
This isn't terribly useful for general debugging and makes the log
pretty noisy when transferring large files.
---
src/channel-main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index 01a3f89..8c0d28c 100644
--- a/src/channel-main.c
+++ b/src/channel-
In order to avoid reference cycles, you're supposed to release
references in dispose, especially to those objects that can hold
references to yourself. This probably wasn't causing any leaks, since
the file transfer tasks generally are not alive when the main channel is
destroyed, but it's more pro
On Wed, Oct 21, 2015 at 2:15 PM, Frediano Ziglio wrote:
>
>>
>> From: Alon Levy
>>
>> ---
>> server/red_worker.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/server/red_worker.c b/server/red_worker.c
>> index ef529f1..225c272 100644
>> --- a/server/red_worker.c
>> +++ b/serve
On Wed, Oct 21, 2015 at 2:00 PM, Frediano Ziglio wrote:
> From: Marc-André Lureau
>
> Clean up, more extensible.
>
Not exactly sure what it means.
> Avoid server hanging when no client are connected.
How does this patch avoid server hanging when no client is connected?
Is it a side-effect of u
On Wed, Oct 21, 2015 at 3:53 PM, Frediano Ziglio wrote:
>>
>> On Wed, Oct 21, 2015 at 08:37:25AM -0400, Frediano Ziglio wrote:
>> >
>> > >
>> > > From: Marc-André Lureau
>> > >
>> > > ---
>> > > server/red_dispatcher.c | 6 --
>> > > server/red_dispatcher.h | 2 +-
>> > > server/reds.c
On Wed, Oct 21, 2015 at 2:26 PM, Frediano Ziglio wrote:
>
>>
>> From: Marc-André Lureau
>>
>> Group enums with their respective struct location.
>> ---
>> server/red_dispatcher.h | 97
>> -
>> server/red_worker.h | 93 +
On Tue, Oct 20, 2015 at 02:34:40PM +0300, Yedidyah Bar David wrote:
> Hi all,
>
> Changes since [1]:
>
> - Attended (I hope) Christophe's comments from previous set
>
> - Added Makefile/spec and jenkins automation scripts
>
> - Some other minor changes.
>
> Current patchset starts at [2] (see
On Tue, Oct 20, 2015 at 02:35:23PM +0300, Yedidyah Bar David wrote:
> From: Christophe Fergeau
>
> Now that we are able to generate different installers for SPICE and
> oVirt, we can install the oVirt agent when building an oVirt installer.
>
> Change-Id: I63e071262f8dd807cc1dd362e17fc814460c525
I suspect these scripts are no longer needed? I don't see them being
used after applying your automation patch.
Christophe
On Tue, Oct 20, 2015 at 02:35:27PM +0300, Yedidyah Bar David wrote:
> From: Christophe Fergeau
>
> Change-Id: I6bf84620dd18361274a0d9bb1d2a98011c2bc1d4
> Signed-off-by: Chr
Sorry if I missed it/forgot the answer, but why do we need/want this
change?
Christophe
On Tue, Oct 20, 2015 at 02:35:24PM +0300, Yedidyah Bar David wrote:
> From: Lev Veyde
>
> Change-Id: I8692e636d42f127f953f578d86c7cbe8f2bcc06a
> Signed-off-by: Lev Veyde
> ---
> win-guest-tools.nsis | 2 +-
On Wed, Oct 21, 2015 at 05:47:12PM +0300, Yedidyah Bar David wrote:
> Allow 'make dist'.
>
> Allow building the spice installer and building/installing the ovirt
> installer.
>
> VERSION moved from the nsis file to the Makefile and will be maintained
> there.
>
> Some Makefile variables (format:
Allow 'make dist'.
Allow building the spice installer and building/installing the ovirt
installer.
VERSION moved from the nsis file to the Makefile and will be maintained
there.
Some Makefile variables (format: PARAM (valid values) [default]):
MODE (SPICE,OVIRT) [SPICE] - its value is passed as
On Tue, Oct 20, 2015 at 2:34 PM, Yedidyah Bar David wrote:
> Hi all,
>
> Changes since [1]:
>
> - Attended (I hope) Christophe's comments from previous set
>
> - Added Makefile/spec and jenkins automation scripts
>
> - Some other minor changes.
>
> Current patchset starts at [2] (see the list unde
By the way, this could be more explicit in the long log about what this
commit is doing (adding a VideoEncoder base class/interface which wraps
mjpeg encoder public API in vfuncs which can be reimplemented by other
encoders, + rename members/enums here and there from *mjpeg* to
*video*).
Christoph
>
> On Wed, Oct 21, 2015 at 08:37:25AM -0400, Frediano Ziglio wrote:
> >
> > >
> > > From: Marc-André Lureau
> > >
> > > ---
> > > server/red_dispatcher.c | 6 --
> > > server/red_dispatcher.h | 2 +-
> > > server/reds.c | 2 +-
> > > 3 files changed, 6 insertions(+), 4 deletion
On Wed, Oct 21, 2015 at 08:37:25AM -0400, Frediano Ziglio wrote:
>
> >
> > From: Marc-André Lureau
> >
> > ---
> > server/red_dispatcher.c | 6 --
> > server/red_dispatcher.h | 2 +-
> > server/reds.c | 2 +-
> > 3 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --gi
On Wed, Oct 21, 2015 at 03:27:02PM +0200, Francois Gouget wrote:
> On Wed, 21 Oct 2015, Christophe Fergeau wrote:
>
> > ACK.
> >
> > Since the changes up to now are useful cleanups regardless of the
> > addition of gstreamer, I suggest we land the patches up to this one
> > right now, hopefully t
On Wed, Oct 14, 2015 at 05:31:38PM +0200, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
> server/Makefile.am | 2 +-
> server/mjpeg_encoder.c | 85 +++---
> server/red_worker.c| 86 +-
> server/video_encoder.h | 162
> ++
On Wed, 21 Oct 2015, Christophe Fergeau wrote:
> ACK.
>
> Since the changes up to now are useful cleanups regardless of the
> addition of gstreamer, I suggest we land the patches up to this one
> right now, hopefully this will save some rebasing pain (haven't looked
> at rest of the patches yet,
>
> From: Marc-André Lureau
>
> Now that worker is created before running, and run() returns success,
> there is no point in using MESSAGE_READY.
> ---
> server/red_dispatcher.h | 10 --
> server/red_worker.c | 8 +---
> 2 files changed, 5 insertions(+), 13 deletions(-)
>
> di
ACK.
Since the changes up to now are useful cleanups regardless of the
addition of gstreamer, I suggest we land the patches up to this one
right now, hopefully this will save some rebasing pain (haven't looked
at rest of the patches yet, I'll do that now).
Christophe
On Wed, Oct 14, 2015 at 05:3
ACK.
On Wed, Oct 14, 2015 at 05:30:35PM +0200, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
> server/red_worker.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index babb597..616be72 100644
> --- a/server/
On Wed, Oct 14, 2015 at 05:30:52PM +0200, Francois Gouget wrote:
> This also allows getting rid of a couple of forward definitions.
>
> Signed-off-by: Francois Gouget
> ---
> server/mjpeg_encoder.c | 74
> +++---
> 1 file changed, 34 insertions(+), 40
ACK.
On Wed, Oct 14, 2015 at 05:31:01PM +0200, Francois Gouget wrote:
> Note that this requires some adjustments to the encode_frame()
> parameters to avoid red_worker-specific types.
>
> Signed-off-by: Francois Gouget
> ---
> server/mjpeg_encoder.c | 74
> +
>
> From: Marc-André Lureau
>
> ---
> server/red_dispatcher.c | 6 --
> server/red_dispatcher.h | 2 +-
> server/reds.c | 2 +-
> 3 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
> index 0bc853d..c43da7d 100644
>
>
> From: Marc-André Lureau
>
> The stat functions in worker are not generic enough to deserve to be
> "non-worker", so just pass the worker instance.
> ---
> server/red_worker.c | 59
> +++--
> 1 file changed, 30 insertions(+), 29 deletions(-)
>
> From: Marc-André Lureau
>
> Group enums with their respective struct location.
> ---
> server/red_dispatcher.h | 97
> -
> server/red_worker.h | 93 +--
> 2 files changed, 96 insertions(+), 94
>
> From: Marc-André Lureau
>
> ---
> server/dispatcher.c | 13 +
> server/dispatcher.h | 2 ++
> server/red_dispatcher.c | 21 +++--
> server/red_dispatcher.h | 6 +-
> server/red_worker.c | 33 ++---
> server/red_worke
>
> From: Alon Levy
>
> ---
> server/red_worker.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index ef529f1..225c272 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -4203,6 +4203,11 @@ static void red_draw_qxl_d
Hi,
On 21-10-15 13:54, Victor Toso wrote:
Hi,
On Wed, Oct 21, 2015 at 01:40:01PM +0200, Hans de Goede wrote:
Hi,
On 21-10-15 12:38, Victor Toso wrote:
For streaming devices it might be necessary from application to drop
data for different reasons. This patch provides a new callback that it
i
From: Marc-André Lureau
Move code around to declare and place it where it fits better.
---
server/red_dispatcher.c | 106 +---
server/red_dispatcher.h | 7
server/red_worker.c | 56 +
server/red_worker.h | 35 +-
From: Marc-André Lureau
This fixes the following scary racy corruption after glib loop switch:
==28173==
==28173== Debugger has detached. Valgrind regains control. We
continue.
==28173== Invalid read of size 8
==28173==at 0x4C7871E: reds_stream_read (reds.c:4521)
==28173==by 0x4C2F9D7:
From: Marc-André Lureau
The stat functions in worker are not generic enough to deserve to be
"non-worker", so just pass the worker instance.
---
server/red_worker.c | 59 +++--
1 file changed, 30 insertions(+), 29 deletions(-)
diff --git a/server/
From: Marc-André Lureau
Clean up, more extensible.
Avoid server hanging when no client are connected.
---
server/Makefile.am | 2 -
server/red_worker.c| 438 +
server/spice_timer_queue.c | 273
server/spi
These patches are extracted from a branch intended to refactory
spice-server.
This patchset supersed last patchset and apply to updated master.
Alon Levy (1):
server/red_worker: red_draw_qxl_drawable: protect from NULL
dereference in case of buggy driver (or recording)
Marc-André Lureau (8
From: Alon Levy
---
server/red_worker.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/server/red_worker.c b/server/red_worker.c
index ef529f1..225c272 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -4203,6 +4203,11 @@ static void red_draw_qxl_drawable(RedWorker *worker,
From: Marc-André Lureau
Now that worker is created before running, and run() returns success,
there is no point in using MESSAGE_READY.
---
server/red_dispatcher.h | 10 --
server/red_worker.c | 8 +---
2 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/server/red_d
From: Marc-André Lureau
---
server/red_dispatcher.c | 6 --
server/red_dispatcher.h | 2 +-
server/reds.c | 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
index 0bc853d..c43da7d 100644
--- a/server/red_dispatch
From: Marc-André Lureau
---
server/dispatcher.c | 13 +
server/dispatcher.h | 2 ++
server/red_dispatcher.c | 21 +++--
server/red_dispatcher.h | 6 +-
server/red_worker.c | 33 ++---
server/red_worker.h | 5 -
6
From: Marc-André Lureau
Group enums with their respective struct location.
---
server/red_dispatcher.h | 97 -
server/red_worker.h | 93 +--
2 files changed, 96 insertions(+), 94 deletions(-)
diff --
Hi,
On Wed, Oct 21, 2015 at 01:40:01PM +0200, Hans de Goede wrote:
> Hi,
>
> On 21-10-15 12:38, Victor Toso wrote:
> >For streaming devices it might be necessary from application to drop
> >data for different reasons. This patch provides a new callback that it
> >is called before queueing the mos
Hi,
On 21-10-15 12:38, Victor Toso wrote:
For streaming devices it might be necessary from application to drop
data for different reasons. This patch provides a new callback that it
is called before queueing the most recent iso packages.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1264
(CC David as per his request)
On Wed, Oct 21, 2015 at 12:38:10PM +0200, Victor Toso wrote:
> Addressing some of Hans comments but not all of them yet.
>
> This versions sets a higher and lower threshold so usbredir can drop
> *some* packages when we are above lower threshold and drop *all*
> pack
Addressing some of Hans comments but not all of them yet.
This versions sets a higher and lower threshold so usbredir can drop
*some* packages when we are above lower threshold and drop *all*
packages when we are above the higher threshold.
Hans, I'm failing to have the rate measurement for the i
For streaming devices it might be necessary from application to drop
data for different reasons. This patch provides a new callback that it
is called before queueing the most recent iso packages.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1264156
---
usbredirhost/usbredirhost.c | 70 +++
When channel wants to send much more data then the wire can handle, the
queue grows fast. This patch does not limit the queue growth but
introduces an internal API to check if queue size is too big.
This internal API is used with usbredirhost_can_write_iso callback from
usbredir. This way, we gara
54 matches
Mail list logo
