Hey,
On Mon, Oct 12, 2015 at 04:38:22PM +0200, Christophe Fergeau wrote:
> Otherwise it will be leaked.
Actually, it was leaking before:
valgrind --leak-check=full --show-leak-kinds=definite ./session
==27687== 64 bytes in 4 blocks are definitely lost in loss record 250 of
435
==27687==at
Hi,
On Tue, Oct 13, 2015 at 11:29:25AM +0200, Christophe Fergeau wrote:
> These macros were automatically appending the needed CFLAGS/LIBS to
> variables passed as arguments. This is how spice-common uses them, but
> now how spice-gtk/spice want to use them, and is making the macros more
> complic
Hi
On Mon, Oct 12, 2015 at 8:07 PM, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> git.mk | 3 +++
> 1 file changed, 3 insertions(+)
git.mk do not need to be modified, it uses a number of customizable
Makefile variables instead. (see top comments in file)
> diff --git a/git.mk b/gi
On Tue, Oct 13, 2015 at 11:39:17AM +0200, Victor Toso wrote:
> Hey,
>
> On Tue, Oct 13, 2015 at 10:56:00AM +0200, Christophe Fergeau wrote:
> > The binaries in tests/ need a static build of spice-gtk libraries in
> > order to be built, but by default, we disable static libraries at
> > LT_INIT() t
Hey,
On Tue, Oct 13, 2015 at 10:56:00AM +0200, Christophe Fergeau wrote:
> The binaries in tests/ need a static build of spice-gtk libraries in
> order to be built, but by default, we disable static libraries at
> LT_INIT() time.
> As the compile failure can be quite cryptic when someone
> tries t
These macros were automatically appending the needed CFLAGS/LIBS to
variables passed as arguments. This is how spice-common uses them, but
now how spice-gtk/spice want to use them, and is making the macros more
complicated than they could (in particular this makes them use
AS_VAR_APPEND).
This is
On Fri, Oct 09, 2015 at 07:32:33PM +0300, Michael Tokarev wrote:
> Well, not exactly. Why don't you keep the variables in the final
> SPICE_COMMON_{CFLAGS,LIBS} line my first patch does, instead of
> expanding the values at configure time? This way it will be possible
> to override the components
Hey,
On Tue, Oct 13, 2015 at 10:08:32AM +0200, Christophe Fergeau wrote:
> On Tue, Oct 13, 2015 at 09:37:48AM +0200, Victor Toso wrote:
> > It is common to remote-viewer/spicy attach empty tls argument and IIRC
> > that was buggy at some point.
>
> Ah indeed, you added support for this in
> 2ff11e
On Tue, Oct 13, 2015 at 10:56 AM, Christophe Fergeau
wrote:
> The binaries in tests/ need a static build of spice-gtk libraries in
> order to be built, but by default, we disable static libraries at
> LT_INIT() time.
> As the compile failure can be quite cryptic when someone
> tries to manually ru
The binaries in tests/ need a static build of spice-gtk libraries in
order to be built, but by default, we disable static libraries at
LT_INIT() time.
As the compile failure can be quite cryptic when someone
tries to manually run 'make -C tests', this commit adds an explicit
error message when tryi
On Tue, Oct 13, 2015 at 09:37:48AM +0200, Victor Toso wrote:
> Hi,
>
> On Tue, Oct 13, 2015 at 09:31:11AM +0200, Christophe Fergeau wrote:
> > Ah ok, good that we are seeing the same behaviour :) Fwiw, the warnings
> > are avoided with:
> >
> > diff --git a/tests/session.c b/tests/session.c
> > in
> On October 12, 2015 at 6:19 PM Christophe Fergeau wrote:
> Hey,
>
> So we have both spice_uri_parse() and spice_parse_uri(), the former used
> for parsing proxy URIs, the latter for parsing spice:// URIs.
> spice_parse_uri() supports [] notation, but also knows how to unescape
> URI components
Hi,
On Tue, Oct 13, 2015 at 09:31:11AM +0200, Christophe Fergeau wrote:
> Ah ok, good that we are seeing the same behaviour :) Fwiw, the warnings
> are avoided with:
>
> diff --git a/tests/session.c b/tests/session.c
> index 0b57e7e..aecc009 100644
> --- a/tests/session.c
> +++ b/tests/session.c
>
> On October 12, 2015 at 6:16 PM Christophe Fergeau wrote:
>
> Looks good, though detecting the presence of ":" feels a bit magic :)
Surely it's a future proof strategy because who uses colons for anything
meaningful anyway? ;-)
At least s->host is supposed to only contain the host and no other
On Tue, Oct 13, 2015 at 09:21:23AM +0200, Wolfgang Bumiller wrote:
> Hi
>
> > On October 12, 2015 at 6:08 PM Christophe Fergeau
> > wrote:
> > On Mon, Oct 05, 2015 at 04:16:43PM +0200, Wolfgang Bumiller wrote:
> > >
> > > diff --git a/tests/session.c b/tests/session.c
> > > (...)
> >
> > Was t
On Tue, Oct 13, 2015 at 09:21:23AM +0200, Wolfgang Bumiller wrote:
> Hi
>
> > On October 12, 2015 at 6:08 PM Christophe Fergeau
> > wrote:
> > On Mon, Oct 05, 2015 at 04:16:43PM +0200, Wolfgang Bumiller wrote:
> > >
> > > diff --git a/tests/session.c b/tests/session.c
> > > (...)
> >
> > Was this
Hi
> On October 12, 2015 at 6:08 PM Christophe Fergeau wrote:
> On Mon, Oct 05, 2015 at 04:16:43PM +0200, Wolfgang Bumiller wrote:
> >
> > diff --git a/tests/session.c b/tests/session.c
> > (...)
>
> Was this test working fine for you ? most of the tests in tests/ were
> not building for me, I
Hey,
Thanks for all the details!
On Tue, Oct 13, 2015 at 01:12:40AM +0200, Francois Gouget wrote:
> On Mon, 21 Sep 2015, Christophe Fergeau wrote:
> [...]
> > > +src_caps = "typefind=true"; /* Misidentifies VP8 */
> >
> > What does VP8 gets identified as when using this? Has this been re
ACK.
On Mon, Oct 12, 2015 at 12:53:25PM -0500, Jeremy White wrote:
> Fixes 'make check' on Debian.
>
> Signed-off-by: Jeremy White
> ---
> Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 605e96e..fb1c00b 100644
> --- a/Make
19 matches
Mail list logo
