Re: [Spice-devel] libcacard: linking with too many libs

2015-10-12 Thread Robert Relyea
On 10/09/2015 03:18 AM, Michael Tokarev wrote: Hello. I tried to package libcacard, and come across a small thing. The library is uselessly linked with too many libs from the nss family, namely, the following libs are not needed: libplds4.so libplc4.so libssl3.so libsmime3.so libnssutil3.so li

Re: [Spice-devel] [PATCH v5 20/20] spice-gtk: Use typefind and decodebin as fallbacks to set up the GStreamer pipeline.

2015-10-12 Thread Francois Gouget
On Mon, 21 Sep 2015, Christophe Fergeau wrote: [...] > > +src_caps = "typefind=true"; /* Misidentifies VP8 */ > > What does VP8 gets identified as when using this? Has this been reported > to gstreamer developers? With GStreamer 1.6.0 typefind does not identify it at all (with GStreamer

[Spice-devel] [PATCH libcacard] Add a few additional m4 files to .gitignore.

2015-10-12 Thread Jeremy White
Signed-off-by: Jeremy White --- git.mk | 3 +++ 1 file changed, 3 insertions(+) diff --git a/git.mk b/git.mk index 9d4bf25..1b2edbd 100644 --- a/git.mk +++ b/git.mk @@ -118,6 +118,9 @@ GITIGNORE_MAINTAINERCLEANFILES_M4_LIBTOOL = \ ltsugar.m4 \ ltve

[Spice-devel] [PATCH v4 spice-gtk] Provide support for using the passthru smartcard mode in libcacard.

2015-10-12 Thread Jeremy White
Add an optional args parameter to the --spice-smartcard which will be passed to vcard_emul_options. This allows us to deprecate the --smartcard-db and --smartcard-certificates options as well. Signed-off-by: Jeremy White --- Changes since v3: * Retested with new libcacard * Updated version

Re: [Spice-devel] [PATCH libcacard] Add gthread libraries to link flags for the test.

2015-10-12 Thread Marc-André Lureau
ack, thanks - Original Message - > Fixes 'make check' on Debian. > > Signed-off-by: Jeremy White > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 605e96e..fb1c00b 100644 > --- a/Makefile.am > +++ b/Makefile.a

[Spice-devel] [PATCH libcacard] Add gthread libraries to link flags for the test.

2015-10-12 Thread Jeremy White
Fixes 'make check' on Debian. Signed-off-by: Jeremy White --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 605e96e..fb1c00b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -65,7 +65,7 @@ endif include $(srcdir)/build-aux/glib-tap.

Re: [Spice-devel] [PATCH v2 1/3] proxy: support ipv6 addresses in brackets

2015-10-12 Thread Christophe Fergeau
Hey, So we have both spice_uri_parse() and spice_parse_uri(), the former used for parsing proxy URIs, the latter for parsing spice:// URIs. spice_parse_uri() supports [] notation, but also knows how to unescape URI components (eg @ encoded as %40 in usernames), which spice_uri_parse() does not see

Re: [Spice-devel] [PATCH v2 2/3] session: spice_uri_create put brackets around ipv6 addresses

2015-10-12 Thread Christophe Fergeau
On Mon, Oct 05, 2015 at 04:16:42PM +0200, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > src/spice-session.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/spice-session.c b/src/spice-session.c > index e1d9997..86c339f 100644 > --- a

Re: [Spice-devel] [PATCH v2 3/3] tests/session: test ipv6 uri and proxy

2015-10-12 Thread Christophe Fergeau
Hey, On Mon, Oct 05, 2015 at 04:16:43PM +0200, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > tests/session.c | 45 +++-- > 1 file changed, 39 insertions(+), 6 deletions(-) > > diff --git a/tests/session.c b/tests/session.c > index fe

Re: [Spice-devel] [PATCH v2 0/2] Dependency locks fixes for QXL driver

2015-10-12 Thread Christophe Fergeau
Hey David, What is the best way of handling QXL kernel patches? Is it easier for you if they get reviewed first on spice-devel@? Or should we just ping you when patches have been pending for a bit too long? Thanks, Christophe On Thu, Sep 24, 2015 at 02:25:13PM +0100, Frediano Ziglio wrote: > Th

[Spice-devel] [spice-gtk 1/2] Rename display_cache::cache_unref to cache_free

2015-10-12 Thread Christophe Fergeau
display_cache is no longer refcounted since commit c9d4773, but this is not an issue as even before, the fact that it was refcounted was not used as there was no corresponding cache_ref() call (and g_hash_table_ref() was not called directly either). As the next commit will free memory from cache_un

[Spice-devel] [spice-gtk 2/2] Free display_cache in cache_free()

2015-10-12 Thread Christophe Fergeau
Otherwise it will be leaked. --- src/spice-channel-cache.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/spice-channel-cache.h b/src/spice-channel-cache.h index 238ceb7..e609a67 100644 --- a/src/spice-channel-cache.h +++ b/src/spice-channel-cache.h @@ -131,6 +131,7 @@ static inline void

[Spice-devel] [RFC PATCH 0/2] Try to smartly allocate memory on the two BARs

2015-10-12 Thread Frediano Ziglio
Currently a single type of surface is allocated in a specific BAR. This also changes from userspace driver to the kernel one. This way it could happen that allocation are failing even if there are plenty of space in the other BAR. For instance this can happen trying to change resolution as the old

[Spice-devel] [PATCH 2/2] Allocate objects in both video rams

2015-10-12 Thread Frediano Ziglio
If memory is not enough in the default BAR for a type try other BAR this allow better memory usage and avoid memory allocation failure if a BAR is quite small and other is quite unused. --- qxl/qxl_object.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/qxl/qxl_obj

[Spice-devel] [PATCH 1/2] Change the way slot is detected

2015-10-12 Thread Frediano Ziglio
Instead of relaying on surface type use the actual placement. This allow to have different placement for a single type of surface. --- qxl/qxl_cmd.c | 2 +- qxl/qxl_drv.h | 9 - 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/qxl/qxl_cmd.c b/qxl/qxl_cmd.c index fdc1833..3a1b

Re: [Spice-devel] [cacard] build-sys: Add git-version-gen to EXTRA_DIST

2015-10-12 Thread Christophe Fergeau
On Fri, Oct 09, 2015 at 02:59:49PM -0500, Jonathon Jongsma wrote: > ACK Thanks, pushed. Christophe signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/sp

Re: [Spice-devel] [PATCH libcacard] Remove link_test.c

2015-10-12 Thread Christophe Fergeau
ACK. On Mon, Oct 12, 2015 at 11:15:15AM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This test was not automated and is now redundant with make check tests > > Signed-off-by: Marc-André Lureau > --- > docs/libcacard.txt | 1 - > src/link_test.c| 22 ---

Re: [Spice-devel] [NSIS 8/8] packaging: add Makefile

2015-10-12 Thread Christophe Fergeau
Hey, On Mon, Oct 12, 2015 at 11:59:32AM +0300, Yedidyah Bar David wrote: > On Mon, Sep 14, 2015 at 4:24 PM, Christophe Fergeau > wrote: > > On Sun, Sep 13, 2015 at 08:50:22AM +0300, Yedidyah Bar David wrote: > >> > same content as what would be generated by git archive, just working also > >> >

[Spice-devel] [PATCH libcacard] Remove link_test.c

2015-10-12 Thread marcandre . lureau
From: Marc-André Lureau This test was not automated and is now redundant with make check tests Signed-off-by: Marc-André Lureau --- docs/libcacard.txt | 1 - src/link_test.c| 22 -- 2 files changed, 23 deletions(-) delete mode 100644 src/link_test.c diff --git a/docs

Re: [Spice-devel] libcacard: src/link_test.c in the git tree

2015-10-12 Thread Marc-André Lureau
Hi - Original Message - > Hi. > > I noticed an extra file in the git tree in libcacard > source directory, src/link_test.c, which is not present > in the source tarball. Is it really needed there? > I never noticed it: $ git grep link_test docs/libcacard.txt:link_test.c - static test

Re: [Spice-devel] [NSIS 8/8] packaging: add Makefile

2015-10-12 Thread Yedidyah Bar David
On Mon, Sep 14, 2015 at 4:24 PM, Christophe Fergeau wrote: > On Sun, Sep 13, 2015 at 08:50:22AM +0300, Yedidyah Bar David wrote: >> > same content as what would be generated by git archive, just working also >> > without the .git. >> >> Not sure it should be part of 'make dist', but I think it wil

Re: [Spice-devel] [spice-gtk PATCH v2] spice-channel: check message queue length

2015-10-12 Thread Victor Toso
CC hans about this one as well. Btw, this was tested on windows client (related to rhbz#1201387) and it seems to improve well. https://bugzilla.redhat.com/show_bug.cgi?id=1201387 Thanks for any input, On Fri, Oct 09, 2015 at 02:59:05PM +0200, Victor Toso wrote: > When channel wants to send much