Thanks, pushed
Jonathon
On Fri, 2015-10-09 at 17:48 +0200, Pavel Grunt wrote:
> Hi Jonathon,
>
> I tested the series, it behaves much more reasonable.
> One comment below.
>
> Thanks and ack from me.
>
> On Tue, 2015-10-06 at 14:05 -0500, Jonathon Jongsma wrote:
> > There were several shortco
ACK
On Fri, 2015-10-09 at 19:31 +0200, Christophe Fergeau wrote:
> Without it, running autoreconf -fi from a tarball is going to spew a lot
> of warnings about this missing file, and afterwards, ./configure will
> generate version-less .pc files.
> ---
> Makefile.am | 6 +-
> 1 file changed,
Without it, running autoreconf -fi from a tarball is going to spew a lot
of warnings about this missing file, and afterwards, ./configure will
generate version-less .pc files.
---
Makefile.am | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index b
On Fri, Oct 9, 2015 at 6:30 PM, Christophe Fergeau wrote:
> ACK from me.
thanks, pushed
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
- Original Message -
> On Fri, Oct 09, 2015 at 06:16:00PM +0200, marcandre.lur...@redhat.com wrote:
> > From: Jeremy White
> >
> > That option can be achieved using -e "use_hw=yes hw_type=passthru"
>
> Any idea why this is called "broken" by the way? Might be worth to
> expand a bit
On Tue, Oct 06, 2015 at 11:18:56AM +0200, Pavel Grunt wrote:
> On Mon, 2015-10-05 at 18:39 +0200, Christophe Fergeau wrote:
> > On Thu, Oct 01, 2015 at 05:19:23PM +0200, Pavel Grunt wrote:
> > > Resolves:
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1061942
> > > ---
> > > server/red_worker.c
On Wed, Oct 07, 2015 at 12:25:40PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds_stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/reds_stream.c b/server/reds_stream.c
> index 1a595b2..6dc41ca 100644
> --- a/server/reds_
On Thu, Oct 08, 2015 at 04:46:56PM +0300, Yedidyah Bar David wrote:
> On Thu, Sep 10, 2015 at 4:20 PM, Christophe Fergeau
> wrote:
> > On Thu, Sep 10, 2015 at 03:14:14PM +0300, Yedidyah Bar David wrote:
> >> for ovirt use ovirt-guest-tools-setup
> >>
> >
> > This rename can probably be squashed i
09.10.2015 16:36, Christophe Fergeau wrote:
>> --- a/spice-common/m4/spice-deps.m4
>> +++ b/spice-common/m4/spice-deps.m4
>> @@ -58,7 +58,8 @@ AC_DEFUN([SPICE_CHECK_SMARTCARD], [
>>fi
>> fi
>> AS_VAR_APPEND([$1_CFLAGS], [' $(SMARTCARD_CFLAGS)'])
>> -AS_VAR_APPEND([$1_LIBS], ['
looks like this reply didn't get tied up with original thread here ===>
http://lists.freedesktop.org/archives/spice-devel/2015-September/021836.html
On 09/10/15 15:37, Graeme V wrote:
OK, I created an Xorg.conf , by doing:
Xorg -configure
I edited the file and placed it in /etc/X11/xorg.conf
ACK from me.
Christophe
On Fri, Oct 09, 2015 at 06:15:53PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> A series of pending patches for libcacard, adapted from previous
> patches for qemu. Most of this patches have already been reviewed by
> me, other adapted, or adde
On Fri, Oct 09, 2015 at 06:16:00PM +0200, marcandre.lur...@redhat.com wrote:
> From: Jeremy White
>
> That option can be achieved using -e "use_hw=yes hw_type=passthru"
Any idea why this is called "broken" by the way? Might be worth to
expand a bit on the exact meaning of 'broken' ? (crash, not
On Fri, Oct 09, 2015 at 06:15:58PM +0200, marcandre.lur...@redhat.com wrote:
> diff --git a/src/vcard_emul_type.c b/src/vcard_emul_type.c
> index 04e8d99..0c2fbb7 100644
> --- a/src/vcard_emul_type.c
> +++ b/src/vcard_emul_type.c
> @@ -7,7 +7,6 @@
> * This work is licensed under the terms of the
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
NEWS | 11 +++
1 file changed, 11 insertions(+)
diff --git a/NEWS b/NEWS
index 8e55e71..b2778f3 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,14 @@
+v2.5.1
+==
+
+- fix mingw cross-compilation
+- add error checking to vcard_emu
From: Marc-André Lureau
A top-level header file is often easier to deal with for programs
Signed-off-by: Marc-André Lureau
---
Makefile.am | 1 +
src/libcacard.h | 21 +
2 files changed, 22 insertions(+)
create mode 100644 src/libcacard.h
diff --git a/Makefile.am b/M
From: Marc-André Lureau
So the whole project use the same log domain.
Signed-off-by: Marc-André Lureau
---
Makefile.am | 1 +
src/vreader.c | 5 -
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 0d9cc6a..c332c99 100644
--- a/Makefile.am
+++ b
From: Jeremy White
That option can be achieved using -e "use_hw=yes hw_type=passthru"
Signed-off-by: Jeremy White
Reviewed-by: Marc-André Lureau
---
src/vscclient.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/src/vscclient.c b/src/vscclient.c
index e9
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
Makefile.am | 31 ++-
build-aux/glib-tap.mk | 150 +++
build-aux/tap-driver.sh | 652
build-aux/tap-test | 5 +
configure.ac| 4 +-
m4/glibte
From: Marc-André Lureau
A series of pending patches for libcacard, adapted from previous
patches for qemu. Most of this patches have already been reviewed by
me, other adapted, or added. A second look is worth it:
- add error checking to vcard_emul_options()
- add VCARD_DIRECT implementation to
From: Jeremy White
As far as I can tell, the vreader_remove_reader function is not presently in
use anywhere; I have an upcoming patch set that uses it.
Signed-off-by: Jeremy White
Reviewed-by: Marc-André Lureau
---
src/vreader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
From: Jeremy White
Also add an alias of 'nssemul' for the default card
of hw=yes hw_type=cac.
This allows the spice-gtk client to take a more human
friendly set of arguments and relay them through to this code.
Signed-off-by: Jeremy White
Reviewed-by: Marc-André Lureau
---
src/vcard_emul_nss
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
configure.ac | 27 +++
1 file changed, 27 insertions(+)
diff --git a/configure.ac b/configure.ac
index b841ec1..2bc5c73 100644
--- a/configure.ac
+++ b/configure.ac
@@ -36,9 +36,36 @@ AX_CODE_COVERAGE()
PKG_C
From: Marc-André Lureau
It was not in the exported symbols, so it shouldn't hurt to remove it now.
Signed-off-by: Marc-André Lureau
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 7951ec4..03c86e7 100644
--- a/Makefile.am
+++
From: Marc-André Lureau
(alternatively, we could simply require this to be installed, but it's
very recent and the autofoo error is unfriendly)
Signed-off-by: Marc-André Lureau
---
m4/ax_append_flag.m4| 4 ++--
m4/ax_compiler_flags.m4 | 4 ++--
m4/ax_compiler_flags_cflags
From: Thomas Huth
'smatch' complains about two bugs and one style issue in card_7816.c:
libcacard/card_7816.c:273 vcard_apdu_set_length() warn: should this be a
bitwise op?
libcacard/card_7816.c:295 vcard_apdu_set_length() warn: should this be a
bitwise op?
libcacard/card_7816.c:661 vcard7816_
From: Jeremy White
Enable support for passthru (e.g. direct to pcsc) smart cards in the
emul_options entry point in libcacard.
Signed-off-by: Jeremy White
Reviewed-by: Marc-André Lureau
---
src/vcard_emul_nss.c | 28 +++-
src/vcard_emul_type.c | 4 +++-
2 files chang
From: Jeremy White
This uses libpcsclite to provide direct communication with a smartcard.
Signed-off-by: Jeremy White
Reviewed-by: Marc-André Lureau
---
Makefile.am | 9 +-
src/capcsc.c | 501 ++
src/capcsc.h | 18
On Thu, Oct 08, 2015 at 04:32:58PM +0200, Lukas Venhoda wrote:
> Spice debug message printed only IPv4 addresses using inet_ntoa.
> Changed to inet_pton for IPv6 support.
>
> Can't use getnameinfo, because IP address in certificate is already in
> struct in(6)_addr format used by inet_ntop functio
On Thu, Oct 08, 2015 at 04:32:57PM +0200, Lukas Venhoda wrote:
> Changed old inet_aton function for modern getaddrinfo.
>
> inet_aton only supported IPv4 addresses, and wasn't available on windows
> machines. getaddrinfo supports both IPv4 and IPv6 natively.
> ---
> Changes since v1:
> - Changed
On Thu, Oct 08, 2015 at 04:32:56PM +0200, Lukas Venhoda wrote:
> Print IP address instead of DNS, when using IP adress connection.
ACK, maybe copy and paste bug.
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-de
Hey,
On Thu, Oct 08, 2015 at 04:32:55PM +0200, Lukas Venhoda wrote:
> Only check for address lenght, when connecting trough IP address.
> It is not used, when connecting trough DNS hostname.
> ---
> Changes since v1:
> - New patch
> - Wasn't moved in v1
> ---
> common/ssl_verify.c | 11 +
Hi Jonathon,
I tested the series, it behaves much more reasonable.
One comment below.
Thanks and ack from me.
On Tue, 2015-10-06 at 14:05 -0500, Jonathon Jongsma wrote:
> There were several shortcomings to the existing file transfer API,
> particularly in terms of monitoring ongoing file transfe
thanks, added
- Original Message -
> The .db files are missing from EXTRA_DIST causing make distcheck failure
>
> diff --git a/Makefile.am b/Makefile.am
> index b29f56b..afa7d7a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -87,6 +87,9 @@ EXTRA_DIST +=
The .db files are missing from EXTRA_DIST causing make distcheck failure
diff --git a/Makefile.am b/Makefile.am
index b29f56b..afa7d7a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -87,6 +87,9 @@ EXTRA_DIST += \
build-aux/tap-driver.sh \
On Tue, 2015-10-06 at 23:12 +0200, Pavel Grunt wrote:
> On Tue, 2015-10-06 at 15:23 -0500, Jonathon Jongsma wrote:
> > On Fri, 2015-09-25 at 08:53 -0500, Jonathon Jongsma wrote:
> > > On Fri, 2015-09-25 at 10:51 +0200, Christophe Fergeau wrote:
> > > > On Thu, Sep 24, 2015 at 05:20:25PM -0500, Jona
- Original Message -
> On Thu, Oct 08, 2015 at 05:40:40PM +0200, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > So the whole project use the same log domain.
>
> Any idea why G_LOG_DOMAIN traditionally does not go in
> configure.ac/config.h instead of being adde
On Fri, Oct 09, 2015 at 10:25:45AM -0400, Marc-André Lureau wrote:
>
> Hi
>
> - Original Message -
> > On Thu, Oct 08, 2015 at 05:40:32PM +0200, marcandre.lur...@redhat.com wrote:
> > > From: Jeremy White
> > >
> > > Also add an alias of 'nssemul' for the default card
> > > of hw=yes hw
On Fri, Oct 09, 2015 at 04:43:37PM +0200, Marc-André Lureau wrote:
> Keeping the author of the patch in CC
>
> On Fri, Oct 9, 2015 at 4:34 PM, Christophe Fergeau
> wrote:
> > On Thu, Oct 08, 2015 at 05:40:33PM +0200, marcandre.lur...@redhat.com wrote:
> >> From: Jeremy White
> >>
> >> This uses
On Thu, Oct 08, 2015 at 05:40:40PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> So the whole project use the same log domain.
Any idea why G_LOG_DOMAIN traditionally does not go in
configure.ac/config.h instead of being added to CFLAGS?
ACK patch.
Christophe
>
> Si
OK, I created an Xorg.conf , by doing:
Xorg -configure
I edited the file and placed it in /etc/X11/xorg.conf. The edited
section was:
Section "Device"
### Available Driver options are:-
### Values: : integer, : float, : "True"/"False",
### : "String", : " Hz/kHz/MHz"
Keeping the author of the patch in CC
On Fri, Oct 9, 2015 at 4:34 PM, Christophe Fergeau wrote:
> On Thu, Oct 08, 2015 at 05:40:33PM +0200, marcandre.lur...@redhat.com wrote:
>> From: Jeremy White
>>
>> This uses libpcsclite to provide direct communication with a smartcard.
>>
>> Signed-off-by:
Nit: I'd add a "vscclient:" prefix to the log.
On Thu, Oct 08, 2015 at 05:40:35PM +0200, marcandre.lur...@redhat.com wrote:
> From: Jeremy White
>
> That option can be achieved using -e "use_hw=yes hw_type=passthru"
Would the new "-e passthru" alias work here too?
Christophe
>
> Signed-off-b
On Thu, Oct 08, 2015 at 05:40:33PM +0200, marcandre.lur...@redhat.com wrote:
> From: Jeremy White
>
> This uses libpcsclite to provide direct communication with a smartcard.
>
> Signed-off-by: Jeremy White
> Reviewed-by: Marc-André Lureau
> ---
> Makefile.am | 9 +-
> configure.ac
On Thu, Oct 08, 2015 at 05:40:32PM +0200, marcandre.lur...@redhat.com wrote:
> From: Jeremy White
>
> Also add an alias of 'nssemul' for the default card
> of hw=yes hw_type=cac, and an alias of 'passthru' for
> the new card type of hw=yes hw_type=passthru.
The 'passthru' alias is added in the n
On Thu, Oct 08, 2015 at 05:40:31PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> configure.ac | 26 ++
> 1 file changed, 26 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index b841ec1..b87
- Original Message -
> On Thu, Oct 08, 2015 at 05:40:31PM +0200, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > configure.ac | 26 ++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a
Hi
- Original Message -
> On Thu, Oct 08, 2015 at 05:40:32PM +0200, marcandre.lur...@redhat.com wrote:
> > From: Jeremy White
> >
> > Also add an alias of 'nssemul' for the default card
> > of hw=yes hw_type=cac, and an alias of 'passthru' for
> > the new card type of hw=yes hw_type=pas
Hi,
Thanks for the 2 patches!
On Fri, Oct 09, 2015 at 01:04:12AM +0300, Michael Tokarev wrote:
> None of the libcacard symbols are actually used by the library,
> only the header files, so there's no need to link with libcacard.
>
> Signed-off-by: Michael Tokarev
> ---
> spice-common/m4/spice-
Hi,
On Fri, Oct 09, 2015 at 02:59:05PM +0200, Victor Toso wrote:
> When channel wants to send much more data then the wire can handle, the
> queue grows fast. This patch does not limit the queue growth but
> introduces an internal API to check if queue size is too big.
>
> In the case of usbredir,
When channel wants to send much more data then the wire can handle, the
queue grows fast. This patch does not limit the queue growth but
introduces an internal API to check if queue size is too big.
In the case of usbredir, video devices on high latency can easily
trigger this situation.
An easy
On Fri, Oct 9, 2015 at 1:14 PM, wrote:
> From: Marc-André Lureau
>
> Reported by Michael Tokarev.
>
> Signed-off-by: Marc-André Lureau
> ---
> Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 1cef1ee..b29f56b 100644
> --- a/
From: Marc-André Lureau
Reported by Michael Tokarev.
Signed-off-by: Marc-André Lureau
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 1cef1ee..b29f56b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -55,7 +55,7 @@ pkgconfig_DATA
Hi
- Original Message -
> Hello.
>
> I tried to package libcacard, and come across a small thing.
btw, there is a bug for
> The library is uselessly linked with too many libs
> from the nss family, namely, the following libs are
> not needed:
>
> libplds4.so libplc4.so libssl3.so libsmi
Hello.
I tried to package libcacard, and come across a small thing.
The library is uselessly linked with too many libs
from the nss family, namely, the following libs are
not needed:
libplds4.so libplc4.so libssl3.so libsmime3.so libnssutil3.so
(only libnss3.so is actually needed, it seems, may
54 matches
Mail list logo
