Re: [Spice-devel] syntax-check fixes

Hi! On Wed, Oct 07, 2015 at 06:45:07PM +0200, Christophe Fergeau wrote: > Hey, > > spice has a 'make syntax-check' rule which runs various consistency checks on > the codebase. It hadn't been run in a while, and was not passing successfully. > This series fixes that. > > Christophe Building with

Re: [Spice-devel] [PATCH 05/10] syntax-check: Don't use tabs for indentation

Hi, On Wed, Oct 07, 2015 at 06:45:12PM +0200, Christophe Fergeau wrote: > --- > server/red_worker.c | 2 +- > server/reds_stream.c | 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index babb597..011c688 100644 > --

Re: [Spice-devel] [PATCH 04/10] syntax-check: Don't cast free() arguments

Hi, On Wed, Oct 07, 2015 at 06:45:11PM +0200, Christophe Fergeau wrote: > --- > server/red_replay_qxl.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/server/red_replay_qxl.c b/server/red_replay_qxl.c > index ad1a8fd..7dcfc16 100644 > --- a/server/red_repla

[Spice-devel] [PATCH 03/10] syntax-check: Ignore .png files in sc_trailing_blank test

--- maint.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/maint.mk b/maint.mk index fa2fe74..1eb5217 100644 --- a/maint.mk +++ b/maint.mk @@ -696,7 +696,7 @@ sc_require_test_exit_idiom: exit 1; } || :; \ fi -e

[Spice-devel] [PATCH 10/10] Add missing license headers

--- server/char_device.h| 17 + server/dispatcher.h | 17 + server/main_dispatcher.c| 17 + server/main_dispatcher.h| 17 + server

[Spice-devel] [PATCH 02/10] syntax-check: manual: Remove duplicate word

--- docs/manual/manual.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt index edbb48f..8d06aa2 100644 --- a/docs/manual/manual.txt +++ b/docs/manual/manual.txt @@ -169,7 +169,7 @@ Client mouse:: Not captured and is used as the

[Spice-devel] [PATCH 04/10] syntax-check: Don't cast free() arguments

--- server/red_replay_qxl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/server/red_replay_qxl.c b/server/red_replay_qxl.c index ad1a8fd..7dcfc16 100644 --- a/server/red_replay_qxl.c +++ b/server/red_replay_qxl.c @@ -439,9 +439,9 @@ static void red_replay_image_

[Spice-devel] [PATCH 01/10] syntax-check: Add missing AUTHORS

--- .mailmap | 8 ++-- AUTHORS | 26 +- 2 files changed, 27 insertions(+), 7 deletions(-) diff --git a/.mailmap b/.mailmap index 4daed49..4a68752 100644 --- a/.mailmap +++ b/.mailmap @@ -1,5 +1,9 @@ - - + + + + + + diff --git a/AUTHORS b/AUTHORS inde

[Spice-devel] [PATCH 09/10] syntax-check: Exclude png files from sc_prohibit_empty_lines_at_EOF

--- cfg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cfg.mk b/cfg.mk index 00ef691..1bf60c9 100644 --- a/cfg.mk +++ b/cfg.mk @@ -134,7 +134,7 @@ exclude_file_name_regexp--sc_bindtextdomain = ^server/tests|common/region.c|tool exclude_file_name_regexp--sc_preprocessor_

[Spice-devel] [PATCH 06/10] syntax-check: Add missing #include

--- server/spice_bitmap_utils.c | 3 +++ server/spice_image_cache.c | 3 +++ server/tests/replay.c | 4 3 files changed, 10 insertions(+) diff --git a/server/spice_bitmap_utils.c b/server/spice_bitmap_utils.c index aa7d71b..ddbd2a9 100644 --- a/server/spice_bitmap_utils.c +++ b/server

[Spice-devel] [PATCH 07/10] syntax-check: Remove unused #include

--- server/tests/replay.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/tests/replay.c b/server/tests/replay.c index 220bfe7..d08e92c 100644 --- a/server/tests/replay.c +++ b/server/tests/replay.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #inclu

[Spice-devel] [PATCH 05/10] syntax-check: Don't use tabs for indentation

--- server/red_worker.c | 2 +- server/reds_stream.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index babb597..011c688 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -12117,7 +12117,7 @@ static void red

[Spice-devel] [PATCH 08/10] syntax-check: Clean-up exception rules

Some files no longer exists, some exceptions are no longer needed, ... --- cfg.mk | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/cfg.mk b/cfg.mk index 7cf1d58..00ef691 100644 --- a/cfg.mk +++ b/cfg.mk @@ -130,22 +130,15 @@ sc_check_author_list: # XXX some o

[Spice-devel] syntax-check fixes

Hey, spice has a 'make syntax-check' rule which runs various consistency checks on the codebase. It hadn't been run in a while, and was not passing successfully. This series fixes that. Christophe ___ Spice-devel mailing list Spice-devel@lists.freedesk

Re: [Spice-devel] [PATCH 1/2] cfg.mk: Remove obsolete references to client files

On Wed, Oct 07, 2015 at 04:55:12PM +0200, Fabiano Fidêncio wrote: > On Wed, Oct 7, 2015 at 4:24 PM, Christophe Fergeau > wrote: > > The client/ directory was removed a while ago, but cfg.mk still has > > mentions of files in client/. > > --- > > cfg.mk | 6 +++--- > > 1 file changed, 3 insertion

Re: [Spice-devel] [PATCH 2/2] build-sys: Remove client check from configure.ac

On Wed, Oct 07, 2015 at 10:57:38AM -0400, Frediano Ziglio wrote: > > > > configure.ac is checking for pyparsing availability if > > client/generated_marshallers.c is missing. The client/ code is gone, and > > the python modules checks are done in spice-common/configure.ac > > nowadays, so we can g

Re: [Spice-devel] [spice-common] build-sys: Use ${PKG_CONFIG} rather than pkg-config

On Wed, Oct 07, 2015 at 10:34:11AM -0500, Jonathon Jongsma wrote: > ACK Thanks, pushed. Christophe signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/sp

Re: [Spice-devel] [spice-common] build-sys: Use ${PKG_CONFIG} rather than pkg-config

ACK On Wed, 2015-10-07 at 16:27 +0200, Christophe Fergeau wrote: > In mingw builds, this will be set to mingw-pkg-config rather than the > host system one. This is fixing a build failure on mingw when > spice-protocol is only installed in the mingw prefix and not > system-wide. > --- > configure

Re: [Spice-devel] [PATCH 2/2] build-sys: Remove client check from configure.ac

> > configure.ac is checking for pyparsing availability if > client/generated_marshallers.c is missing. The client/ code is gone, and > the python modules checks are done in spice-common/configure.ac > nowadays, so we can get rid of this check. I would also add that the code is checking for a .cp

Re: [Spice-devel] [PATCH 4/4] mingw: include and link to ws2_32

On Wed, Oct 7, 2015 at 3:14 PM, Frediano Ziglio wrote: >> >> Otherwise the following errors can be faced: >> src/vscclient-vscclient.o: In function `send_msg': >> /home/ffidenci/src/upstream/libcacard/src/vscclient.c:122: undefined >> reference to `_imp__htonl@4' >> /home/ffidenci/src/upstream/lib

Re: [Spice-devel] [PATCH 1/2] cfg.mk: Remove obsolete references to client files

On Wed, Oct 7, 2015 at 4:24 PM, Christophe Fergeau wrote: > The client/ directory was removed a while ago, but cfg.mk still has > mentions of files in client/. > --- > cfg.mk | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cfg.mk b/cfg.mk > index 7cf1d58..3d49775 10

[Spice-devel] [spice-common] build-sys: Use ${PKG_CONFIG} rather than pkg-config

In mingw builds, this will be set to mingw-pkg-config rather than the host system one. This is fixing a build failure on mingw when spice-protocol is only installed in the mingw prefix and not system-wide. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configu

[Spice-devel] [PATCH 1/2] cfg.mk: Remove obsolete references to client files

The client/ directory was removed a while ago, but cfg.mk still has mentions of files in client/. --- cfg.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 7cf1d58..3d49775 100644 --- a/cfg.mk +++ b/cfg.mk @@ -136,14 +136,14 @@ exclude_file_name_reg

[Spice-devel] [PATCH 2/2] build-sys: Remove client check from configure.ac

configure.ac is checking for pyparsing availability if client/generated_marshallers.c is missing. The client/ code is gone, and the python modules checks are done in spice-common/configure.ac nowadays, so we can get rid of this check. --- configure.ac | 10 -- 1 file changed, 10 deletions(

Re: [Spice-devel] [PATCH 4/4] mingw: include and link to ws2_32

> > Otherwise the following errors can be faced: > src/vscclient-vscclient.o: In function `send_msg': > /home/ffidenci/src/upstream/libcacard/src/vscclient.c:122: undefined > reference to `_imp__htonl@4' > /home/ffidenci/src/upstream/libcacard/src/vscclient.c:124: undefined > reference to `_imp__h

Re: [Spice-devel] [ovirt-devel] ovirt-guest-agent behavior on disconnect

On 10/07/2015 02:52 PM, David Mansfield wrote: On 10/01/2015 02:47 AM, Vinzenz Feenstra wrote: On 09/30/2015 10:03 PM, Barak Azulay wrote: Barak On Sep 30, 2015, at 10:04, Michal Skrivanek <michal.skriva...@redhat.com> wrote: On Sep 25, 2015, at 19:

[Spice-devel] [PATCH 2/4] mingw: avoid problems for using %zd (C99)

Otherwise the following problem can be faced: src/vscclient.c: In function 'connect_to_qemu': src/vscclient.c:642:16: error: unknown conversion type character 'z' in format [-Werror=format=] printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader)); ^ src/v

[Spice-devel] [PATCH 4/4] mingw: include and link to ws2_32

Otherwise the following errors can be faced: src/vscclient-vscclient.o: In function `send_msg': /home/ffidenci/src/upstream/libcacard/src/vscclient.c:122: undefined reference to `_imp__htonl@4' /home/ffidenci/src/upstream/libcacard/src/vscclient.c:124: undefined reference to `_imp__htonl@4' src/vsc

[Spice-devel] [PATCH 0/4] libcacard: a few fixed that allows the library to be crosscompiled (using mingw)

Howdy! I've been able to build latest nspr and nss using mingw (on Fedora22) and the next obvious step was to buid libcacard. I faced a few problems that could be solved with these 4 simple patches. Fabiano Fidêncio (4): mingw: remove cac_is_cac_card from libcacard.syms mingw: avoid problems

[Spice-devel] [PATCH 1/4] mingw: remove cac_is_cac_card from libcacard.syms

Without removing cac_is_cac_card the following error can be faced: Cannot export cac_is_cac_card: symbol not defined collect2: error: ld returned 1 exit status Found a not so old QEMU thread about this: https://www.mail-archive.com/qemu-devel%40nongnu.org/msg291698.html --- src/libcacard.syms |

[Spice-devel] [PATCH 3/4] mingw: include ws2tcpip header

This header has the definition of getaddrinfo, according to: https://msdn.microsoft.com/en-us/library/windows/desktop/ms738520(v=vs.85).aspx --- src/vscclient.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vscclient.c b/src/vscclient.c index fad8db9..24015ef 100644 --- a/src/vscclient.c

[Spice-devel] [PATCH] Simplify pointer computation

Signed-off-by: Frediano Ziglio --- server/reds_stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds_stream.c b/server/reds_stream.c index 1a595b2..6dc41ca 100644 --- a/server/reds_stream.c +++ b/server/reds_stream.c @@ -326,7 +326,7 @@ RedsStream *reds_stream_n

Re: [Spice-devel] Announcing spice 0.12.6

Hi, I've uploaded the manual corresponding to that release to http://www.spice-space.org/docs/manual/ http://www.spice-space.org/docs/manual/manual.chunked/ Christophe On Tue, Oct 06, 2015 at 05:44:05PM +0200, Christophe Fergeau wrote: > Hey everyone, > > At long last, I've rolled out a new spi