[Spice-devel] [PATCH spice-gtk v2 1/2] Fix progress monitoring in spice_main_file_copy_async

2015-10-05 Thread Jonathon Jongsma
spice_main_file_copy_async() allows you to pass a NULL-terminated array of files to transfer to the guest. It also allows you to pass a progress_callback function to monitor the progress of the transfer, but this progress callback is called separately for each file that is transferred, and there ar

[Spice-devel] [PATCH spice-gtk v2 2/2] New file transfer API

2015-10-05 Thread Jonathon Jongsma
There were several shortcomings to the existing file transfer API, particularly in terms of monitoring ongoing file transfers. The major issue is that spice_main_file_copy_async() allows you to pass an array of files, but the progress callback does not provide a way to identify which file the callb

Re: [Spice-devel] Question about Spice with Wayland

2015-10-05 Thread Yury Shvedov
Hi, Fabio! Thank you for your interest to this project! But unfortunately this project now is in proof-of-concept state and usable only via loopback network. And as you notice it did not evolve by me for years. The problem is I changed my scientific theme by accident at this point and could n

Re: [Spice-devel] [PATCH spice-server] red_worker: Do not sent empty monitor config message

2015-10-05 Thread Christophe Fergeau
On Thu, Oct 01, 2015 at 05:19:23PM +0200, Pavel Grunt wrote: > Resolves: > https://bugzilla.redhat.com/show_bug.cgi?id=1061942 > --- > server/red_worker.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index e2feb23.

Re: [Spice-devel] [spice-gtk PATCH v1] spice-channel: check message queue length

2015-10-05 Thread Marc-André Lureau
(adding Hans in CC) - Original Message - > When channel wants to send much more data then the wire can handle, the > queue grows fast. This patch does not limit the queue growth but > introduces an internal API to check if queue length is too big. > > In the case of usbredir, video devic

[Spice-devel] [spice-gtk PATCH v1] spice-channel: check message queue length

2015-10-05 Thread Victor Toso
When channel wants to send much more data then the wire can handle, the queue grows fast. This patch does not limit the queue growth but introduces an internal API to check if queue length is too big. In the case of usbredir, video devices on high latency can easily trigger this situation. An eas

[Spice-devel] [spice-gtk PATCH v1] spice-channel limiting queue (usbredir memory leak)

2015-10-05 Thread Victor Toso
Follow up of email [0]. Trying to implement option 4 - Reading less from device. (yes, not listed in the email). [0] http://lists.freedesktop.org/archives/spice-devel/2015-September/022003.html This is a _basic_ attempt to address rhbz#1264156 [1] which is client side queue growing too fast due p

[Spice-devel] [PATCH v2 1/3] proxy: support ipv6 addresses in brackets

2015-10-05 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- src/spice-uri.c | 36 +--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/src/spice-uri.c b/src/spice-uri.c index 82aefdb..c0d2d9c 100644 --- a/src/spice-uri.c +++ b/src/spice-uri.c @@ -114,11 +114,24 @@ gboolean

Re: [Spice-devel] [PATCH] proxy: support ipv6 addresses in brackets

2015-10-05 Thread Victor Toso
Hi, On Mon, Oct 05, 2015 at 04:06:20PM +0200, Wolfgang Bumiller wrote: > > > > On October 5, 2015 at 2:53 PM Victor Toso wrote: > > > Could you please also add some tests in tests/session.c ? > > We are lacking tests and this seems a good oportunity ;) > > Sure, apparently spice_uri_create in

[Spice-devel] [PATCH v2 2/3] session: spice_uri_create put brackets around ipv6 addresses

2015-10-05 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- src/spice-session.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/spice-session.c b/src/spice-session.c index e1d9997..86c339f 100644 --- a/src/spice-session.c +++ b/src/spice-session.c @@ -399,8 +399,15 @@ static gchar* s

[Spice-devel] [PATCH v2 0/3] more ipv6 support

2015-10-05 Thread Wolfgang Bumiller
Changes: - patch 1 * strstr -> strchr for efficiency * updated spice_uri_to_string to include brackts around ipv6 hosts Two new patches: - patch 2: same bracket change for spice_uri_create - patch 3: tests Added a 'host' member to the structure since the second loop never set it, so

[Spice-devel] [PATCH v2 3/3] tests/session: test ipv6 uri and proxy

2015-10-05 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- tests/session.c | 45 +++-- 1 file changed, 39 insertions(+), 6 deletions(-) diff --git a/tests/session.c b/tests/session.c index feee3db..c9f6bca 100644 --- a/tests/session.c +++ b/tests/session.c @@ -8,24 +8,28 @@ sta

Re: [Spice-devel] [PATCH] proxy: support ipv6 addresses in brackets

2015-10-05 Thread Wolfgang Bumiller
> On October 5, 2015 at 2:53 PM Victor Toso wrote: > Could you please also add some tests in tests/session.c ? > We are lacking tests and this seems a good oportunity ;) Sure, apparently spice_uri_create in spice-session.c fails to add brackets when needed, and I didn't see spice_uri_to_string

Re: [Spice-devel] [PATCH 2/2] Add patch fixing performance issue

2015-10-05 Thread Christophe Fergeau
On Wed, Aug 05, 2015 at 05:40:36PM +0300, Kirill Moizik wrote: > From: Kirill Moizik > > --- > cairo-quartz-surface-performance-patch.patch | 61 > > 1 file changed, 61 insertions(+) > create mode 100644 cairo-quartz-surface-performance-patch.patch > > diff --git

Re: [Spice-devel] [PATCH] proxy: support ipv6 addresses in brackets

2015-10-05 Thread Victor Toso
Hi, On Mon, Oct 05, 2015 at 02:38:51PM +0200, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > src/spice-uri.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/src/spice-uri.c b/src/spice-uri.c > index 82aefdb..2415857 100644 > ---

[Spice-devel] [PATCH] proxy: support ipv6 addresses in brackets

2015-10-05 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- src/spice-uri.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/spice-uri.c b/src/spice-uri.c index 82aefdb..2415857 100644 --- a/src/spice-uri.c +++ b/src/spice-uri.c @@ -114,11 +114,24 @@ gboolean spice_uri_parse(

Re: [Spice-devel] [spice-protocol] build-sys: Use $datadir for .proto files/codegen scripts

2015-10-05 Thread Fabiano FidĂȘncio
On Mon, Oct 5, 2015 at 12:07 PM, Christophe Fergeau wrote: > They are not arch-specific, so installing them in $libdir is not needed. ACK! > --- > Makefile.am| 2 +- > python_modules/Makefile.am | 2 +- > spice-protocol.pc.in | 4 ++-- > 3 files changed, 4 insertions(+), 4

[Spice-devel] [spice-protocol] build-sys: Use $datadir for .proto files/codegen scripts

2015-10-05 Thread Christophe Fergeau
They are not arch-specific, so installing them in $libdir is not needed. --- Makefile.am| 2 +- python_modules/Makefile.am | 2 +- spice-protocol.pc.in | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index 53e87be..4af20db 10