This is a second approach suggested by Marc-Andre to fix up some of the issues
with circular includes in the public headers. It will break the build of
applications using spice-gtk, but is very easy to fix since we print out an
explicit compiler error in that case. If accepted, I intend to push thi
spice-client.h is a public "super"-header, which includes all of the
other public headers. Including this header from other public headers
can result in cyclical dependencies. For consistency, I've removed all
includes of this header from spice-gtk files except where absolutely
necessary.
---
src
This header is the single include needed for all gtk-related
functionality, similar to spice-client.h. Generate a compiler error if a
different header is included.
---
src/Makefile.am | 1 +
src/spice-client-gtk.h | 32
src/spice-grabsequence.h | 4 +++
Only the local declarations should be declared extern "C", otherwise it
can result in unexpected errors such as this (encountered while re-ordering
some include statements for a different patch):
CC channel-inputs.lo
In file included from /usr/include/glib-2.0/glib/gmacros.h:38:0,
Generate a compiler error if an application attempts to include a
different header.
---
doc/reference/Makefile.am | 2 +-
src/Makefile.am | 1 +
src/channel-cursor.c | 2 +-
src/channel-cursor.h | 4
src/channel-display.c | 2 +-
src/channel-display.h | 4
src
On 09/24/2015 12:46 PM, Victor Toso wrote:
Hey,
On Wed, Sep 23, 2015 at 10:05:40AM -0400, David Mansfield wrote:
Hi,
The attached is a very simple patch, which is working but possibly not
suitable for inclusion at this point, that locks the x11 session when the
client disconnects.
Locking i
ACK series, thanks!
On Thu, 2015-09-24 at 18:33 +0200, Pavel Grunt wrote:
> Hi all,
> I noticed that we have a lot of not properly documented symbols in spice-gtk.
> My intention was to improve this area before the spice-gtk release. So I am
> sending patches. They are mostly about adding missing
Hey,
On Wed, Sep 23, 2015 at 10:05:40AM -0400, David Mansfield wrote:
> Hi,
>
> The attached is a very simple patch, which is working but possibly not
> suitable for inclusion at this point, that locks the x11 session when the
> client disconnects.
>
> Locking is performed using "xdg-screensaver l
---
v2: new patch - taken from PATCH 7/8
---
src/spice-widget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 34bc128..fdaf6d6 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2537,10 +2537,10 @@ static void channe
---
v2: no change
---
doc/reference/spice-gtk-docs.xml | 1 +
doc/reference/spice-gtk-sections.txt | 12
src/spice-version.h.in | 2 ++
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/doc/reference/spice-gtk-docs.xml b/doc/reference/spice-gtk-docs.x
---
v2: no change
---
doc/reference/spice-gtk-sections.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/reference/spice-gtk-sections.txt
b/doc/reference/spice-gtk-sections.txt
index d8b835e..fe24f9f 100644
--- a/doc/reference/spice-gtk-sections.txt
+++ b/doc/reference/s
---
v2: no change
---
doc/reference/spice-gtk-sections.txt | 10 ++
1 file changed, 10 insertions(+)
diff --git a/doc/reference/spice-gtk-sections.txt
b/doc/reference/spice-gtk-sections.txt
index 2f3e09e..a12183a 100644
--- a/doc/reference/spice-gtk-sections.txt
+++ b/doc/reference/spice
---
v2:
- addresses more typos
---
src/channel-inputs.c | 4 ++--
src/channel-main.c | 4 ++--
src/channel-port.c | 4 ++--
src/spice-grabsequence.c | 2 +-
src/spice-session.c | 2 +-
src/usb-device-manager.c | 2 +-
6 files changed, 9 insertions(+), 9 deletions(-)
diff --g
---
v2:
- "clipboard selection data" instead of "selection data"
- parameter renaming is in the separate patch
- "key click (press and release)" instead of "key click"
- "redirect" instead of "redirected"
---
src/channel-inputs.h | 8
src/channel-main.c | 2 ++
src/channel
---
v2: no change
---
src/channel-main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index b1c19c0..85e01e4 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -724,10 +724,10 @@ static void
spice_main_channel_class_i
Hi all,
I noticed that we have a lot of not properly documented symbols in spice-gtk.
My intention was to improve this area before the spice-gtk release. So I am
sending patches. They are mostly about adding missing descriptions of
parameters,
fields and symbols. I also added a new section - Versi
---
v2: no change
---
src/channel-display.c| 6 +++---
src/channel-inputs.c | 16
src/channel-main.c | 26 ++
src/channel-playback.c | 5 +
src/channel-record.c | 2 +-
src/smartcard-manager.c | 3 +--
src/spice-channel.c |
---
v2: no change
---
src/channel-record.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/channel-record.c b/src/channel-record.c
index d07d84e..e581aed 100644
--- a/src/channel-record.c
+++ b/src/channel-record.c
@@ -200,8 +200,8 @@ static void
spice_record_channel_c
---
NEWS | 16
1 file changed, 16 insertions(+)
diff --git a/NEWS b/NEWS
index 1a6f7a3..86f2a8c 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,19 @@
+v0.30
+=
+- spice-protocol is no longer bundled with spice-gtk. Requires
+ spice-protocol >= 0.12.10
+- Handle single headed monitor
Since these messages are only used for terminal debug output, let's not
waste time translating them.
---
po/POTFILES.in | 1 -
po/POTFILES.skip | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index ef1a2ee..ad12609 100644
--- a/po/POTFILES.in
+
Hey all,
I've just released version 0.12.10 of spice-protocol. The major change
is the inclusion of the code generation scripts that previously were in
the spice-common repository. More details at the end of this email. It
can be downloaded from the following location:
http://www.spice-space.org/
On 09/23/2015 10:56 AM, Michal Suchanek wrote:
Hello,
On Wed, Sep 23, 2015 at 10:05:40AM -0400, David Mansfield wrote:
Hi,
The attached is a very simple patch, which is working but possibly not
suitable for inclusion at this point, that locks the x11 session when the
client disconnects.
Loc
On Thu, 2015-09-24 at 09:47 -0500, Jonathon Jongsma wrote:
> Nice. ACK with a few minor changes on patch 7 and 8.
>
Thanks, I will send a v2
Pavel
> On Thu, 2015-09-24 at 15:10 +0200, Pavel Grunt wrote:
> > Hi all,
> > I noticed that we have a lot of not properly documented symbols in spice-
>
Nice. ACK with a few minor changes on patch 7 and 8.
On Thu, 2015-09-24 at 15:10 +0200, Pavel Grunt wrote:
> Hi all,
> I noticed that we have a lot of not properly documented symbols in spice-gtk.
> My intention was to improve this area before the spice-gtk release. So I am
> sending patches. They
On Thu, 2015-09-24 at 15:10 +0200, Pavel Grunt wrote:
> ---
> src/channel-inputs.c | 2 +-
> src/channel-main.c | 4 ++--
> src/channel-port.c | 4 ++--
> src/spice-session.c | 2 +-
> src/usb-device-manager.c | 2 +-
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> dif
A few suggestions below
On Thu, 2015-09-24 at 15:10 +0200, Pavel Grunt wrote:
> ---
> src/channel-inputs.h | 8
> src/channel-main.c | 2 ++
> src/channel-playback.c | 2 ++
> src/smartcard-manager.h | 21
> src/spice-channel.c | 8
> s
On Thu, 2015-09-24 at 16:21 +0200, Christophe Fergeau wrote:
> On Thu, Sep 24, 2015 at 09:09:36AM -0500, Jonathon Jongsma wrote:
> > On Thu, 2015-09-24 at 09:28 +0200, Christophe Fergeau wrote:
> > > On Wed, Sep 23, 2015 at 10:35:26AM -0500, Jonathon Jongsma wrote:
> > > > Some translatable strings
On Thu, Sep 24, 2015 at 09:09:36AM -0500, Jonathon Jongsma wrote:
> On Thu, 2015-09-24 at 09:28 +0200, Christophe Fergeau wrote:
> > On Wed, Sep 23, 2015 at 10:35:26AM -0500, Jonathon Jongsma wrote:
> > > Some translatable strings were added in commit 8c37a340.
> > > ---
> > > po/POTFILES.in | 1 +
On Thu, 2015-09-24 at 09:28 +0200, Christophe Fergeau wrote:
> On Wed, Sep 23, 2015 at 10:35:26AM -0500, Jonathon Jongsma wrote:
> > Some translatable strings were added in commit 8c37a340.
> > ---
> > po/POTFILES.in | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/po/POTFILES.in b/
qxl_bo_unref calls drm_gem_object_unreference_unlocked which
locks dev->struct_mutex. However this lock could be already
locked if the call came from qxl_gem_object_free.
As we don't need to call qxl_bo_ref/qxl_bo_unref cause
qxl_release_list_add will hold a reference by itself avoid
to call them a
These two patches fixes two lock dependencies issues.
Changes from v1: Sent a wrong patch.
Frediano Ziglio (2):
drm/qxl: avoid buffer reservation in qxl_crtc_page_flip
drm/qxl: avoid dependency lock
drivers/gpu/drm/qxl/qxl_display.c | 10 +-
drivers/gpu/drm/qxl/qxl_release.c | 4 +-
This avoid a dependency lock error.
According to https://lwn.net/Articles/548909/ users of WW mutex API
should avoid using different context.
When a buffer is reserved with qxl_bo_reserve a ww_mutex_lock without
context is used. However during qxl_draw_dirty_fb different locks
with specific context
qxl_bo_unref calls drm_gem_object_unreference_unlocked which
locks dev->struct_mutex. However this lock could be already
locked if the call came from qxl_gem_object_free.
As we don't need to call qxl_bo_ref/qxl_bo_unref cause
qxl_release_list_add will hold a reference by itself avoid
to call them a
Instead of using container_of directly use to_qxl_bo macro.
Signed-off-by: Frediano Ziglio
---
drivers/gpu/drm/qxl/qxl_object.c | 2 +-
drivers/gpu/drm/qxl/qxl_ttm.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl
Instead of using container_of directly use to_qxl_bo macro.
Signed-off-by: Frediano Ziglio
---
drivers/gpu/drm/qxl/qxl_object.c | 2 +-
drivers/gpu/drm/qxl/qxl_ttm.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl
These two patches fixes two lock dependencies issues.
Frediano Ziglio (2):
drm/qxl: use to_qxl_bo macro
drm/qxl: avoid dependency lock
drivers/gpu/drm/qxl/qxl_object.c | 2 +-
drivers/gpu/drm/qxl/qxl_release.c | 4 +---
drivers/gpu/drm/qxl/qxl_ttm.c | 4 ++--
3 files changed, 4 insertio
---
src/channel-inputs.c | 2 +-
src/channel-main.c | 4 ++--
src/channel-port.c | 4 ++--
src/spice-session.c | 2 +-
src/usb-device-manager.c | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/channel-inputs.c b/src/channel-inputs.c
index 1a6457d..edd
---
src/channel-main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index b1c19c0..85e01e4 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -724,10 +724,10 @@ static void
spice_main_channel_class_init(SpiceMainChann
---
src/channel-inputs.h | 8
src/channel-main.c | 2 ++
src/channel-playback.c | 2 ++
src/smartcard-manager.h | 21
src/spice-channel.c | 8
src/spice-channel.h | 13
src/spice-client.c | 7 +++
src/spice-c
---
doc/reference/spice-gtk-docs.xml | 1 +
doc/reference/spice-gtk-sections.txt | 12
src/spice-version.h.in | 2 ++
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/doc/reference/spice-gtk-docs.xml b/doc/reference/spice-gtk-docs.xml
index 5faea74..
Hi all,
I noticed that we have a lot of not properly documented symbols in spice-gtk.
My intention was to improve this area before the spice-gtk release. So I am
sending patches. They are mostly about adding missing descriptions of
parameters,
fields and symbols. I also added a new section - Versi
---
src/channel-record.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/channel-record.c b/src/channel-record.c
index d07d84e..e581aed 100644
--- a/src/channel-record.c
+++ b/src/channel-record.c
@@ -200,8 +200,8 @@ static void
spice_record_channel_class_init(SpiceRec
---
src/channel-display.c| 6 +++---
src/channel-inputs.c | 16
src/channel-main.c | 26 ++
src/channel-playback.c | 5 +
src/channel-record.c | 2 +-
src/smartcard-manager.c | 3 +--
src/spice-channel.c | 20 ++
---
doc/reference/spice-gtk-sections.txt | 10 ++
1 file changed, 10 insertions(+)
diff --git a/doc/reference/spice-gtk-sections.txt
b/doc/reference/spice-gtk-sections.txt
index 2f3e09e..a12183a 100644
--- a/doc/reference/spice-gtk-sections.txt
+++ b/doc/reference/spice-gtk-sections.txt
---
doc/reference/spice-gtk-sections.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/reference/spice-gtk-sections.txt
b/doc/reference/spice-gtk-sections.txt
index d8b835e..fe24f9f 100644
--- a/doc/reference/spice-gtk-sections.txt
+++ b/doc/reference/spice-gtk-sections.
Hi Victor,
> On Sep 23, 2015, at 17:27 PM, Victor Toso wrote:
>
> Hey,
>
> I was taking a look at rhbz#1264156 [1] which leads to a great amount
> of memory being used in the client when sharing webcam with usbredir
> when the connection is slow enough (not necessary slow but slower then
> the
On Wed, Sep 23, 2015 at 10:35:26AM -0500, Jonathon Jongsma wrote:
> Some translatable strings were added in commit 8c37a340.
> ---
> po/POTFILES.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/po/POTFILES.in b/po/POTFILES.in
> index ad12609..ef1a2ee 100644
> --- a/po/POTFILES.in
> +++
On Wed, Sep 23, 2015 at 04:37:03PM -0500, Jonathon Jongsma wrote:
> ---
>
> I'd like to get a new release of spice-gtk out soon. I don't plan to include
> the header changes that I've recently posted to the mailing list. Those would
> go into the next release.
>
> NEWS | 13 +
> 1 fi
48 matches
Mail list logo
