[Spice-devel] [win32-qxl]Do not allow duplicate IDs in video mode info buffer.

2015-09-16 Thread Sandy Stutsman
Modes are returned in a buffer from qemu with IDs in increasing but not necessarily consecutive order. (Some modes may be omitted if they don't fit into the framebuffer.) Two custom modes are appended to the local buffer to support arbitrary resolutions. The first custom id must be set to +1 of th

Re: [Spice-devel] File Transfer API

2015-09-16 Thread Jonathon Jongsma
On Wed, 2015-09-16 at 12:33 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > So, spice-gtk has supported file transfers from client to guest for > > quite a while. But there's a longstanding issue that the user has no > > feedback about whether the file is actually being t

[Spice-devel] [win32-qxl] Remove redundant macro definitions.

2015-09-16 Thread Sandy Stutsman
A change to spice-procotol adds spice/macros.h to the qxl build. This causes a few macros to be redefined, resulting in warnings that break the build. Explicitly including the spice/macros.h file in place of the redundant macros fixes the warnings. --- xddm/display/quic.c | 2 -- xddm/display/

Re: [Spice-devel] File Transfer API

2015-09-16 Thread Marc-André Lureau
Hi - Original Message - > So, spice-gtk has supported file transfers from client to guest for > quite a while. But there's a longstanding issue that the user has no > feedback about whether the file is actually being transferred, or how > long it will take. The only real feedback that a u

[Spice-devel] File Transfer API

2015-09-16 Thread Jonathon Jongsma
So, spice-gtk has supported file transfers from client to guest for quite a while. But there's a longstanding issue that the user has no feedback about whether the file is actually being transferred, or how long it will take. The only real feedback that a user gets is after the file transfer is com

[Spice-devel] [spice-gtk] Add "monitors config position" capability.

2015-09-16 Thread Sandy Stutsman
This will allow Windows guests to determine if the client supports a monitors_config message from a multi-monitor guest that is not multi-headed, i.e., that has one monitor per driver. It keeps commit:8b0cd321d5a4d08ccba5845c5f2206e6f8032c1d from breaking if an updated win-qxl driver is paired wi

Re: [Spice-devel] [win32-qxl]Undefine commonly named macros to avoid 'macro redefinition' warning.

2015-09-16 Thread Christophe Fergeau
On Wed, Sep 16, 2015 at 09:45:49AM -0400, Sandy Stutsman wrote: > > A change to spice-protocol adds spice/macros.h to the QXL driver build, > causing some macros to be redefined. The resulting compiler warnings > break the build. Adding undef statements before the actual macro > definitions fixes

Re: [Spice-devel] [spice-gtk]Add "monitors config position" capability.

2015-09-16 Thread Jonathon Jongsma
I think we usually call that "multi-head". On Wed, 2015-09-16 at 09:06 -0400, Sandy Stutsman wrote: > The distinction is between multi-hat where a single instance of the graphics > driver handles multiple monitors and, say, the windows driver where there is > a separate driver instance for each

[Spice-devel] [spice-html5] About SASL support

2015-09-16 Thread Alvaro Simon Garcia
Dear Spice developers We are playing around with sasl auth+libvirt/spice in our cloud cluster (http://www.freeipa.org/page/Libvirt_with_VNC_Consoles), we are able to use sasl auth with the remote-viewer client and our spice server, but if we use the html5 client + websockify we get this error: >

Re: [Spice-devel] [win32-qxl]Undefine commonly named macros to avoid 'macro redefinition' warning.

2015-09-16 Thread Sandy Stutsman
Only one or two of the macro's are causing the warnings right but if spice/macros.h should add/remove macros, this would break the build again. - Original Message - > From: "Marc-André Lureau" > To: "Sandy Stutsman" > Cc: spice-devel@lists.freedesktop.org > Sent: Wednesday, September 16

Re: [Spice-devel] [win32-qxl]Undefine commonly named macros to avoid 'macro redefinition' warning.

2015-09-16 Thread Marc-André Lureau
Hi - Original Message - > > A change to spice-protocol adds spice/macros.h to the QXL driver build, > causing some macros to be redefined. The resulting compiler warnings > break the build. Adding undef statements before the actual macro > definitions fixes the warnings. > --- Why not j

[Spice-devel] [win32-qxl]Undefine commonly named macros to avoid 'macro redefinition' warning.

2015-09-16 Thread Sandy Stutsman
A change to spice-protocol adds spice/macros.h to the QXL driver build, causing some macros to be redefined. The resulting compiler warnings break the build. Adding undef statements before the actual macro definitions fixes the warnings. --- xddm/display/quic.c | 1 + xddm/display/utils.h | 9 +

Re: [Spice-devel] [spice-gtk]Add "monitors config position" capability.

2015-09-16 Thread Sandy Stutsman
The distinction is between multi-hat where a single instance of the graphics driver handles multiple monitors and, say, the windows driver where there is a separate driver instance for each monitor. - Original Message - > From: "Marc-André Lureau" > To: "Sandy Stutsman" > Cc: spice-dev

Re: [Spice-devel] [PATCH v2] display: Advertise preferred compression cap

2015-09-16 Thread Pavel Grunt
Ack On Wed, 2015-09-16 at 12:18 +0200, Christophe Fergeau wrote: > The patches adding a way for the client to set its preferred compression > method added a new capability so that the server can indicate support > for this feature. However, spice-server was not setting this capability > on its dis

[Spice-devel] [PATCH v2] display: Advertise preferred compression cap

2015-09-16 Thread Christophe Fergeau
The patches adding a way for the client to set its preferred compression method added a new capability so that the server can indicate support for this feature. However, spice-server was not setting this capability on its display channel, which means clients are not going to try to send 'preferred-

Re: [Spice-devel] [PATCH] display: Advertise preferrred compression cap

2015-09-16 Thread Christophe Fergeau
On Wed, Sep 16, 2015 at 07:19:51AM +0200, Pavel Grunt wrote: > Hi Christophe, > > On Tue, 2015-09-15 at 18:08 +0200, Christophe Fergeau wrote: > > The patches adding a way for the client to set its preferred compression > > method added a new capability so that the server can indicate support > >