Re: [Spice-devel] [PATCH spice-gtk 2/2] Don't include super-header from channel-main.h

2015-09-11 Thread Marc-André Lureau
Hi - Original Message - > spice-client.h is a super-header that includes all of the other public > headers (including channel-main.h). By including this from > channel-main.h, it creates a circular dependency. This was causing some > build problems with spice-audio.h: > > In file included

[Spice-devel] [PATCH spice-gtk 2/2] Don't include super-header from channel-main.h

2015-09-11 Thread Jonathon Jongsma
spice-client.h is a super-header that includes all of the other public headers (including channel-main.h). By including this from channel-main.h, it creates a circular dependency. This was causing some build problems with spice-audio.h: In file included from ../../src/spice-client.h:50:0,

[Spice-devel] [PATCH spice-gtk 1/2] MainChannel: include main channel header

2015-09-11 Thread Jonathon Jongsma
channel-main.h was presumably being included indirectly into channel-main.c, but it'd be better to include it explicitly. --- src/channel-main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/channel-main.c b/src/channel-main.c index 03e407e..ea55545 100644 --- a/src/channel-main.c +++ b/

Re: [Spice-devel] [NSIS 8/8] packaging: add Makefile

2015-09-11 Thread Christophe Fergeau
On Fri, Sep 11, 2015 at 01:46:43PM +0200, Sandro Bonazzola wrote: > > > > > ovirt-dist is because of the ovirt version involved in tarball name. Not > > > sure that out of ovirt such version make sense. > > > > Actually, this really depends on what you expect to get in the > > tarball... .nsis scri

Re: [Spice-devel] [NSIS 8/8] packaging: add Makefile

2015-09-11 Thread Sandro Bonazzola
On Thu, Sep 10, 2015 at 5:05 PM, Christophe Fergeau wrote: > On Thu, Sep 10, 2015 at 04:32:46PM +0200, Sandro Bonazzola wrote: > > On Thu, Sep 10, 2015 at 3:25 PM, Christophe Fergeau > > > wrote: > > > > > On Thu, Sep 10, 2015 at 03:14:15PM +0300, Yedidyah Bar David wrote: > > > > From: Sandro B

Re: [Spice-devel] [spice-gtk] build-sys: Fix spice-protocol requirements in .pc file

2015-09-11 Thread Pavel Grunt
On Tue, 2015-09-08 at 14:31 +0200, Christophe Fergeau wrote: > Commit d0ae58a8 added spice-protocol >= 0.12.10 to the Requires.private > field in spice-client-glib.pc. However it's already present in the > Requires field without a version check. Once spice-gtk is built and > installed, building a p