Re: [Spice-devel] [NSIS 8/8] packaging: add Makefile

2015-09-10 Thread Christophe Fergeau
On Thu, Sep 10, 2015 at 04:32:46PM +0200, Sandro Bonazzola wrote: > On Thu, Sep 10, 2015 at 3:25 PM, Christophe Fergeau > wrote: > > > On Thu, Sep 10, 2015 at 03:14:15PM +0300, Yedidyah Bar David wrote: > > > From: Sandro Bonazzola > > > > > > Allow to generate the tar.gz by just calling > > > "

Re: [Spice-devel] [NSIS 8/8] packaging: add Makefile

2015-09-10 Thread Sandro Bonazzola
On Thu, Sep 10, 2015 at 3:25 PM, Christophe Fergeau wrote: > On Thu, Sep 10, 2015 at 03:14:15PM +0300, Yedidyah Bar David wrote: > > From: Sandro Bonazzola > > > > Allow to generate the tar.gz by just calling > > "make ovirt-dist" > > > > Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22 > >

Re: [Spice-devel] [NSIS 8/8] packaging: add Makefile

2015-09-10 Thread Christophe Fergeau
On Thu, Sep 10, 2015 at 03:14:15PM +0300, Yedidyah Bar David wrote: > From: Sandro Bonazzola > > Allow to generate the tar.gz by just calling > "make ovirt-dist" > > Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22 > Signed-off-by: Sandro Bonazzola > Signed-off-by: Yedidyah Bar David > ---

Re: [Spice-devel] [NSIS 7/8] Change installer filename

2015-09-10 Thread Christophe Fergeau
On Thu, Sep 10, 2015 at 03:14:14PM +0300, Yedidyah Bar David wrote: > for ovirt use ovirt-guest-tools-setup > This rename can probably be squashed in 1/8 ? > Allow passing a custom DISPLAYED_VERSION and EXE_VERSION Can you make this a separate commit, and explain the intent of these 2 version

Re: [Spice-devel] [NSIS 4/8] packaging: Update installer to include new oVirt GA .ini files

2015-09-10 Thread Christophe Fergeau
On Thu, Sep 10, 2015 at 03:14:11PM +0300, Yedidyah Bar David wrote: > From: Lev Veyde > > Recent version of oVirt Guest Agent added 2 new .ini conf files. > This patch modifies the installer, so these files are installed > as well. I would squash this in 2/8, unless you want to preserve authorsh

Re: [Spice-devel] [NSIS 3/8] packaging: Re-enable NSIS branding

2015-09-10 Thread Christophe Fergeau
Do you know why we want it to be enabled? I don't really care either way, just curious.. Christophe On Thu, Sep 10, 2015 at 03:14:10PM +0300, Yedidyah Bar David wrote: > From: Lev Veyde > > Change-Id: I8692e636d42f127f953f578d86c7cbe8f2bcc06a > Signed-off-by: Lev Veyde > --- > win-guest-tools

[Spice-devel] [NSIS 5/8] packaging: Add VC redistributable

2015-09-10 Thread Yedidyah Bar David
From: Lev Veyde Change-Id: I0e2444925335027feb01eab7b543156a4493ab23 Signed-off-by: Lev Veyde --- win-guest-tools.nsis | 3 +++ 1 file changed, 3 insertions(+) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index a32b979..91295a9 100644 --- a/win-guest-tools.nsis +++ b/win-guest-tool

[Spice-devel] [NSIS 6/8] Add ovirt-related scripts

2015-09-10 Thread Yedidyah Bar David
From: Christophe Fergeau Change-Id: I6bf84620dd18361274a0d9bb1d2a98011c2bc1d4 Signed-off-by: Christophe Fergeau --- tools/config | 4 tools/get-qxl.sh | 29 + tools/get-spice-agent.sh | 35 +++ 3 files changed

[Spice-devel] [NSIS 1/8] nsis: Add support for building an oVirt installer

2015-09-10 Thread Yedidyah Bar David
From: Christophe Fergeau oVirt wants to reuse the SPICE Guest Tools code as a basis for building an installer for the oVirt Guest Tools. This commit renames the install script to win-guest-tools.nsis and add conditionals to build either an installer for SPICE Guest Tools or oVirt Guest Tools. Ch

[Spice-devel] [NSIS 8/8] packaging: add Makefile

2015-09-10 Thread Yedidyah Bar David
From: Sandro Bonazzola Allow to generate the tar.gz by just calling "make ovirt-dist" Change-Id: I0d651065697d962d4e351ffc1b7274c8eb37cb22 Signed-off-by: Sandro Bonazzola Signed-off-by: Yedidyah Bar David --- Makefile | 5 + 1 file changed, 5 insertions(+) create mode 100644 Makefile di

[Spice-devel] [NSIS 7/8] Change installer filename

2015-09-10 Thread Yedidyah Bar David
for ovirt use ovirt-guest-tools-setup Allow passing a custom DISPLAYED_VERSION and EXE_VERSION Change-Id: Id60a990aea8e9148c0cd47dd685f9681395ac624 Signed-off-by: Yedidyah Bar David --- win-guest-tools.nsis | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/win-

[Spice-devel] [NSIS 2/8] nsis: Install oVirt guest agent

2015-09-10 Thread Yedidyah Bar David
From: Christophe Fergeau Now that we are able to generate different installers for SPICE and oVirt, we can install the oVirt agent when building an oVirt installer. Change-Id: I63e071262f8dd807cc1dd362e17fc814460c5254 Signed-off-by: Christophe Fergeau --- win-guest-tools.nsis | 26

[Spice-devel] [NSIS 4/8] packaging: Update installer to include new oVirt GA .ini files

2015-09-10 Thread Yedidyah Bar David
From: Lev Veyde Recent version of oVirt Guest Agent added 2 new .ini conf files. This patch modifies the installer, so these files are installed as well. Change-Id: I105ce0475d612a5b70ef354df07dbb59b76d1399 Signed-off-by: Lev Veyde --- win-guest-tools.nsis | 2 ++ 1 file changed, 2 insertions(

[Spice-devel] [NSIS 3/8] packaging: Re-enable NSIS branding

2015-09-10 Thread Yedidyah Bar David
From: Lev Veyde Change-Id: I8692e636d42f127f953f578d86c7cbe8f2bcc06a Signed-off-by: Lev Veyde --- win-guest-tools.nsis | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index 8369dfe..d2f8483 100644 --- a/win-guest-tools.nsis +++ b/w

[Spice-devel] ovirt-wgt introduction

2015-09-10 Thread Yedidyah Bar David
Hi all, As some of you might know, the ovirt project [1] started, some time ago, to use the code of spice-nsis [2], as a basis for an installer for its own windows guest tools [3]. Recently Christophe and I had some discussions about how to keep the code bases identical, as much as possible. Chr